Re: [Freeipa-devel] [PATCH] 1002 make revocation_reason required

2012-04-05 Thread Martin Kosek
On Wed, 2012-04-04 at 15:05 -0400, Rob Crittenden wrote: When revoking a certificate passing in an empty revocation reason caused an Internal Error. It already sets a default so making it required prevents empty values and it still operates the same way. rob Pushed to master, ipa-2-2.

Re: [Freeipa-devel] [PATCH 71] improve handling of ds instances during uninstall

2012-04-05 Thread John Dennis
On 04/05/2012 01:26 AM, Alexander Bokovoy wrote: On Wed, 04 Apr 2012, John Dennis wrote: +# Strip off prefix +instance = basename[len(instance_prefix):] +# Must be non-empty +if instance: +

Re: [Freeipa-devel] [PATCH 69] Use indexed format specifiers in i18n strings

2012-04-05 Thread John Dennis
On 04/04/2012 09:01 AM, Petr Viktorin wrote: On 04/02/2012 03:15 PM, Rob Crittenden wrote: John Dennis wrote: Translators need to reorder messages to suit the needs of the target language. The conventional positional format specifiers (e.g. %s %d) do not permit reordering because their order

Re: [Freeipa-devel] [PATCH] 73 Check whether the default user group is POSIX when adding new user with --noprivate

2012-04-05 Thread Martin Kosek
On Wed, 2012-04-04 at 18:50 +0200, Jan Cholasta wrote: On 3.4.2012 13:04, Martin Kosek wrote: On Tue, 2012-04-03 at 13:02 +0200, Martin Kosek wrote: On Tue, 2012-04-03 at 11:58 +0200, Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/2572 Honza NACK. This creates a

Re: [Freeipa-devel] [PATCH] 115 Reworked netgroup Web UI to allow setting user/host category

2012-04-05 Thread Endi Sukma Dewata
On 3/29/2012 7:46 AM, Petr Vobornik wrote: This patch is changing netgroup web ui to look more like hbac or sudo rule UI. This change allows to define and display user category, host category and external host. The core of the change is changing member attributes (user, group, host, hostgroup)

Re: [Freeipa-devel] [PATCH] 116 Fixed: permission attrs table didn't update its available options on load

2012-04-05 Thread Endi Sukma Dewata
On 4/4/2012 2:18 AM, Petr Vobornik wrote: It could lead to state where attributes from other object type were displayed instead of the correct ones. https://fedorahosted.org/freeipa/ticket/2590 ACK. -- Endi S. Dewata ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 117 Added attrs field to permission for target=subtree

2012-04-05 Thread Endi Sukma Dewata
On 4/4/2012 2:19 AM, Petr Vobornik wrote: Permission form was missing attrs field for target=subtree. All other target types have it. It uses multivalued text widget, same as filter, because we can't predict the target type. https://fedorahosted.org/freeipa/ticket/2592 ACK. -- Endi S.

Re: [Freeipa-devel] [PATCH] 118-119 DNS forward policy: checkboxes changed to radio buttons

2012-04-05 Thread Endi Sukma Dewata
On 4/4/2012 5:36 AM, Petr Vobornik wrote: DNS forward policy fields were using mutually exclusive checkboxes. Such behavior is unusual for users. Checkboxes were changed to radios with new option 'none/default' to set empty value ''. https://fedorahosted.org/freeipa/ticket/2599 Second patch

[Freeipa-devel] [PATCH] 1003 return consistent value in netgroup triple

2012-04-05 Thread Rob Crittenden
When constructing netgroup triples with hostcat or usercat set to all we weren't setting the user/host part of the triple correctly. The first entry would have '' as the host/user value as appropriate but all subsequent entries would have -. They should all be empty. This patch uses a new

Re: [Freeipa-devel] [PATCH 71] improve handling of ds instances during uninstall

2012-04-05 Thread Alexander Bokovoy
On Thu, 05 Apr 2012, John Dennis wrote: On 04/05/2012 01:26 AM, Alexander Bokovoy wrote: On Wed, 04 Apr 2012, John Dennis wrote: +# Strip off prefix +instance = basename[len(instance_prefix):] +# Must be non-empty +if instance: +

[Freeipa-devel] [PATCH] 1004 add missing comma to list of services

2012-04-05 Thread Rob Crittenden
The list of services that cannot be disabled was missing a comma so some services could still be disabled. This is a one-liner, just want a sanity check. rob From 8d2b00fde105107822176f7bd2f6d722444bc9f3 Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Thu, 5 Apr 2012

Re: [Freeipa-devel] [PATCH] 118-119 DNS forward policy: checkboxes changed to radio buttons

2012-04-05 Thread Petr Vobornik
Revised patch 118 attached. I used: * Forward first * Forward only and set 'default_value' to 'first'. So there would be always some value checked, which indicates what is actually used. There is a little issue with undo button if policy is not set '' because default_value !== ''. I did this

Re: [Freeipa-devel] [PATCH] 15 Confusing default user groups

2012-04-05 Thread Ondrej Hamada
On 03/27/2012 12:39 PM, Petr Vobornik wrote: On 03/26/2012 10:27 PM, Rob Crittenden wrote: Ondrej Hamada wrote: On 03/19/2012 05:25 PM, Martin Kosek wrote: On Tue, 2012-03-06 at 19:07 +0100, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2354 There was added '(fallback)'

Re: [Freeipa-devel] [PATCH] 1003 return consistent value in netgroup triple

2012-04-05 Thread Jan Cholasta
On 5.4.2012 17:04, Rob Crittenden wrote: When constructing netgroup triples with hostcat or usercat set to all we weren't setting the user/host part of the triple correctly. The first entry would have '' as the host/user value as appropriate but all subsequent entries would have -. They should

Re: [Freeipa-devel] [PATCH] 1003 return consistent value in netgroup triple

2012-04-05 Thread Rob Crittenden
Jan Cholasta wrote: On 5.4.2012 17:04, Rob Crittenden wrote: When constructing netgroup triples with hostcat or usercat set to all we weren't setting the user/host part of the triple correctly. The first entry would have '' as the host/user value as appropriate but all subsequent entries would

Re: [Freeipa-devel] [PATCH 71] improve handling of ds instances during uninstall

2012-04-05 Thread Rob Crittenden
Alexander Bokovoy wrote: On Thu, 05 Apr 2012, John Dennis wrote: On 04/05/2012 01:26 AM, Alexander Bokovoy wrote: On Wed, 04 Apr 2012, John Dennis wrote: + # Strip off prefix + instance = basename[len(instance_prefix):] + # Must be non-empty + if instance: +

Re: [Freeipa-devel] [PATCH] 1004 add missing comma to list of services

2012-04-05 Thread Martin Kosek
On Thu, 2012-04-05 at 11:30 -0400, Rob Crittenden wrote: The list of services that cannot be disabled was missing a comma so some services could still be disabled. This is a one-liner, just want a sanity check. rob ACK. Unfortunately I did not spot this during review. Pushed to master,

Re: [Freeipa-devel] [PATCH] 998 certmonger restarts services on renewal

2012-04-05 Thread Rob Crittenden
Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2012-04-03 at 10:45 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-04-02 at 15:36 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2012-03-27 at 17:40 -0400, Rob Crittenden

Re: [Freeipa-devel] [PATCH] 15 Confusing default user groups

2012-04-05 Thread Rob Crittenden
Ondrej Hamada wrote: On 03/27/2012 12:39 PM, Petr Vobornik wrote: On 03/26/2012 10:27 PM, Rob Crittenden wrote: Ondrej Hamada wrote: On 03/19/2012 05:25 PM, Martin Kosek wrote: On Tue, 2012-03-06 at 19:07 +0100, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2354 There was

Re: [Freeipa-devel] [PATCH] 74 Check configured maximum user login length on user rename

2012-04-05 Thread Rob Crittenden
Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/2587 Honza This looks ok, it would be nice to have a unit test. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel