Re: [Freeipa-devel] [PATCH] 75 Fix internal error when renaming user with an empty string

2012-04-18 Thread Jan Cholasta
On 12.4.2012 14:12, Martin Kosek wrote: On Thu, 2012-04-12 at 13:34 +0200, Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/2629 Honza ACK. I will wait with push until the ticket is triaged. Martin Push please :-) Honza -- Jan Cholasta

Re: [Freeipa-devel] [PATCH] 75 Fix internal error when renaming user with an empty string

2012-04-18 Thread Martin Kosek
On Wed, 2012-04-18 at 09:00 +0200, Jan Cholasta wrote: On 12.4.2012 14:12, Martin Kosek wrote: On Thu, 2012-04-12 at 13:34 +0200, Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/2629 Honza ACK. I will wait with push until the ticket is triaged. Martin Push please

[Freeipa-devel] [PATCH] 0038 Do not use extra command options in the automount plugin

2012-04-18 Thread Petr Viktorin
Part of the work for https://fedorahosted.org/freeipa/ticket/2509 Validation doesn't complain about extra command options, which means e.g. that misspelling an option's name will cause it to be ignored. This allows errors in custom RPC clients (such as our test suite) to go unnoticed.

Re: [Freeipa-devel] [PATCH 70] validate i18n strings when running make lint

2012-04-18 Thread Petr Viktorin
On 04/16/2012 10:32 PM, John Dennis wrote: On 04/12/2012 09:26 AM, Petr Viktorin wrote: On 03/30/2012 03:45 AM, John Dennis wrote: Translatable strings have certain requirements for proper translation and run time behaviour. We should routinely validate those strings. A recent checkin to

Re: [Freeipa-devel] Generating files from .in template files

2012-04-18 Thread Petr Viktorin
On 04/16/2012 10:38 PM, John Dennis wrote: Traditionally when using autotools it's job of the configure script to generate files from .in template files. The reason it's done this way is because configure has to probe the system it's running on to discover the correct substitutions to be used in

Re: [Freeipa-devel] DNS zone serial number updates [#2554]

2012-04-18 Thread Simo Sorce
On Tue, 2012-04-17 at 18:42 -0400, Dmitri Pal wrote: On 04/17/2012 12:13 PM, Simo Sorce wrote: On Tue, 2012-04-17 at 17:49 +0200, Petr Spacek wrote: Hello, there is IPA ticket #2554 DNS zone serial number is not updated [1], which is required by RFE Support zone transfers in

Re: [Freeipa-devel] DNS zone serial number updates [#2554]

2012-04-18 Thread Dmitri Pal
On 04/18/2012 09:20 AM, Simo Sorce wrote: On Tue, 2012-04-17 at 18:42 -0400, Dmitri Pal wrote: On 04/17/2012 12:13 PM, Simo Sorce wrote: On Tue, 2012-04-17 at 17:49 +0200, Petr Spacek wrote: Hello, there is IPA ticket #2554 DNS zone serial number is not updated [1], which is required by

Re: [Freeipa-devel] DNS zone serial number updates [#2554]

2012-04-18 Thread Petr Spacek
Hello, first of all - snippet moved from the end: I think we need to try to be more consistent than what we are now. There may always be minor races, but the current races are too big to pass on IMHO. I definitely agree. Current state = completely broken zone transfer. Rest is in-line. On

Re: [Freeipa-devel] DNS zone serial number updates [#2554]

2012-04-18 Thread Simo Sorce
On Wed, 2012-04-18 at 09:26 -0400, Dmitri Pal wrote: On 04/18/2012 09:20 AM, Simo Sorce wrote: Are you saying that the update should be moved to the DS replication plugin? Do I get it right? not the DS replication plugin per se. But probably the best way to handle it is 'a' DS plugin.

[Freeipa-devel] IP address check during IPA install

2012-04-18 Thread Petr Spacek
Hello, please, can somebody explain to me, why our installer strictly checks IP addresses? I wonder about it from yesterday's IPA meeting and still can't get it. My naive insight is: It's a network layer problem and application shouldn't care. Of course, there are many protocols with

Re: [Freeipa-devel] DNS zone serial number updates [#2554]

2012-04-18 Thread Simo Sorce
On Wed, 2012-04-18 at 15:29 +0200, Petr Spacek wrote: Hello, first of all - snippet moved from the end: I think we need to try to be more consistent than what we are now. There may always be minor races, but the current races are too big to pass on IMHO. I definitely agree.

Re: [Freeipa-devel] [PATCH] 122 Added permission field to delegation

2012-04-18 Thread Rob Crittenden
Petr Vobornik wrote: Permission field is missing in delegation so it can't be set/modified. It was added to delegation details facet and adder dialog. The field is using checkboxes instead of multivalued textbox because it can have only two effective values: 'read' and 'write'.

Re: [Freeipa-devel] IP address check during IPA install

2012-04-18 Thread Dmitri Pal
On 04/18/2012 09:55 AM, Petr Spacek wrote: Hello, please, can somebody explain to me, why our installer strictly checks IP addresses? I wonder about it from yesterday's IPA meeting and still can't get it. My naive insight is: It's a network layer problem and application shouldn't care.

Re: [Freeipa-devel] DNS zone serial number updates [#2554]

2012-04-18 Thread Simo Sorce
On Wed, 2012-04-18 at 10:04 -0400, Simo Sorce wrote: We can compute maximal modifyTimestamp from all idnsRecord objects during initial query. Any change later in time will add only single attribute to transfer + max(currvalue, newvalue) operation. This way (with psearch) has

Re: [Freeipa-devel] DNS zone serial number updates [#2554]

2012-04-18 Thread Petr Spacek
On 04/18/2012 04:04 PM, Simo Sorce wrote: On Wed, 2012-04-18 at 15:29 +0200, Petr Spacek wrote: Hello, first of all - snippet moved from the end: I think we need to try to be more consistent than what we are now. There may always be minor races, but the current races are too big to

Re: [Freeipa-devel] DNS zone serial number updates [#2554]

2012-04-18 Thread Rich Megginson
On 04/18/2012 09:21 AM, Petr Spacek wrote: On 04/18/2012 04:04 PM, Simo Sorce wrote: On Wed, 2012-04-18 at 15:29 +0200, Petr Spacek wrote: Hello, first of all - snippet moved from the end: I think we need to try to be more consistent than what we are now. There may always be minor races,

Re: [Freeipa-devel] [PATCH] 122 Added permission field to delegation

2012-04-18 Thread Endi Sukma Dewata
On 4/18/2012 10:02 AM, Rob Crittenden wrote: Petr Vobornik wrote: Permission field is missing in delegation so it can't be set/modified. It was added to delegation details facet and adder dialog. The field is using checkboxes instead of multivalued textbox because it can have only two

Re: [Freeipa-devel] DNS zone serial number updates [#2554]

2012-04-18 Thread Simo Sorce
On Wed, 2012-04-18 at 17:21 +0200, Petr Spacek wrote: If this happens, it is possible that on one of the masters the serial will be updated twice even though no other change was performed on the entry-set. That is not a big deal though, at most it will cause a useless zone transfer, but

Re: [Freeipa-devel] DNS zone serial number updates [#2554]

2012-04-18 Thread Dmitri Pal
On 04/18/2012 11:53 AM, Simo Sorce wrote: On Wed, 2012-04-18 at 17:21 +0200, Petr Spacek wrote: If this happens, it is possible that on one of the masters the serial will be updated twice even though no other change was performed on the entry-set. That is not a big deal though, at most it

Re: [Freeipa-devel] DNS zone serial number updates [#2554]

2012-04-18 Thread Simo Sorce
On Wed, 2012-04-18 at 12:34 -0400, Dmitri Pal wrote: And this all complexity for the case when we want to support not IPA based DNS slaves. Is this correct? If so is it really a big use case and something that must be solved? Yes, I think we need to allow zone transfers. they are used not

Re: [Freeipa-devel] More types of replica in FreeIPA

2012-04-18 Thread Rich Megginson
On 04/17/2012 06:42 AM, Simo Sorce wrote: On Tue, 2012-04-17 at 01:13 +0200, Ondrej Hamada wrote: Sorry for inactivity, I was struggling with a lot of school stuff. I've summed up the main goals, do you agree on them or should I add/remove any? GOALS

Re: [Freeipa-devel] [PATCH 70] validate i18n strings when running make lint

2012-04-18 Thread John Dennis
On 04/18/2012 07:33 AM, Petr Viktorin wrote: On 04/16/2012 10:32 PM, John Dennis wrote: On 04/12/2012 09:26 AM, Petr Viktorin wrote: On 03/30/2012 03:45 AM, John Dennis wrote: Translatable strings have certain requirements for proper translation and run time behaviour. We should routinely