[Freeipa-devel] [PATCH] 259 Remove ipa-server-install LDAP update errors

2012-05-10 Thread Martin Kosek
LDAP addEntry method raises an exception when a parent entry of the entry being added does not exist. This may not be an error, for example NIS entries are only added when NIS is enabled and thus the NIS entry container exists. This patch adds an appropriate check so that we rather add a debug

[Freeipa-devel] [PATCH] 136 Correction of nested search facets tab labels

2012-05-10 Thread Petr Vobornik
Nested search facets were using 'search' tab label instead of their nested entity name. This patch is fixing that regression. https://fedorahosted.org/freeipa/ticket/2744 -- Petr Vobornik From d7ad53abc3f70da1408fb3421daa488bcab5dfcc Mon Sep 17 00:00:00 2001 From: Petr Vobornik

[Freeipa-devel] [PATCH] 0047 Do not use extra command options in ACI, permission, selfservice

2012-05-10 Thread Petr Viktorin
This is the second and likely the next-to-last part of disabling extra command options (after this it's just test fixes and turning the checking on). Part of the work for https://fedorahosted.org/freeipa/ticket/2509 -- Petr³ From f504ab30d10e9274ee67da00e4d8171263143db7 Mon Sep 17 00:00:00

Re: [Freeipa-devel] [PATCH] 0044 Validate externalhost (when added by --addattr/--setattr)

2012-05-10 Thread Petr Viktorin
On 05/10/2012 12:05 PM, Ondrej Hamada wrote: On 05/09/2012 04:49 PM, Petr Viktorin wrote: On 05/04/2012 01:25 PM, Ondrej Hamada wrote: On 04/30/2012 02:13 PM, Petr Viktorin wrote: Change the externalhost attribute of hbacrule, netgroup and sudorule into a full-fledged Parameter, and attach a

Re: [Freeipa-devel] [PATCH] 0044 Validate externalhost (when added by --addattr/--setattr)

2012-05-10 Thread Petr Viktorin
On 05/10/2012 12:05 PM, Ondrej Hamada wrote: On 05/09/2012 04:49 PM, Petr Viktorin wrote: On 05/04/2012 01:25 PM, Ondrej Hamada wrote: On 04/30/2012 02:13 PM, Petr Viktorin wrote: Change the externalhost attribute of hbacrule, netgroup and sudorule into a full-fledged Parameter, and attach a

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-10 Thread Petr Vobornik
Updated patch attached. See comments below. On 05/08/2012 04:23 AM, Endi Sukma Dewata wrote: On 5/3/2012 8:26 AM, Petr Vobornik wrote: On 05/03/2012 03:19 PM, Petr Vobornik wrote: I found that limitation of maximum pkey length in facet header is not working well. Attaching patch #134 which

[Freeipa-devel] [PATCH] 0048 Rework the CallbackInterface

2012-05-10 Thread Petr Viktorin
While investigating ticket 2674, I found several problems with our implementation of the CallbackInterface ­— it required complicated calling code, and would subtly break if command classes were instantiated in different ways than they are currently. Here's my fix. See commit message for

Re: [Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-05-10 Thread Petr Viktorin
On 04/10/2012 07:53 PM, Martin Kosek wrote: On Tue, 2012-04-10 at 19:25 +0200, Petr Viktorin wrote: On 04/10/2012 07:07 PM, Martin Kosek wrote: On Tue, 2012-04-10 at 17:03 +0200, Jan Cholasta wrote: On 10.4.2012 16:00, Petr Viktorin wrote: [snip] Like you said above, we should either not

[Freeipa-devel] [PATCH] 1010 Unblock referral mods in libipa_uuid

2012-05-10 Thread Rob Crittenden
The ipa_uuid plugin was blocking mods to referral objects due to the way it was retrieving the LDAP entry. It would retrieve the entry and if the result was non-zero, such as LDAP_REFERRAL, it would raise it as an error, short-circuiting the mod process. Instead check to see if we got a

Re: [Freeipa-devel] [PATCH] 0044 Validate externalhost (when added by --addattr/--setattr)

2012-05-10 Thread Ondrej Hamada
On 05/10/2012 01:40 PM, Petr Viktorin wrote: On 05/10/2012 12:05 PM, Ondrej Hamada wrote: On 05/09/2012 04:49 PM, Petr Viktorin wrote: On 05/04/2012 01:25 PM, Ondrej Hamada wrote: On 04/30/2012 02:13 PM, Petr Viktorin wrote: Change the externalhost attribute of hbacrule, netgroup and

Re: [Freeipa-devel] [PATCH] 1010 Unblock referral mods in libipa_uuid

2012-05-10 Thread Simo Sorce
On Thu, 2012-05-10 at 11:06 -0400, Rob Crittenden wrote: The ipa_uuid plugin was blocking mods to referral objects due to the way it was retrieving the LDAP entry. It would retrieve the entry and if the result was non-zero, such as LDAP_REFERRAL, it would raise it as an error,