Re: [Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

2013-07-10 Thread Lukas Slebodnik
On (04/07/13 15:23), Petr Spacek wrote: Hello, several warnings from autotools popped up after upgrade to Fedora 19. Attached patches should make autotools configuration more modern. -- Petr^2 Spacek From 07caec808e394bfcbd898905e917731cb3778e68 Mon Sep 17 00:00:00 2001 From: Petr Spacek

Re: [Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

2013-07-10 Thread Jakub Hrozek
On Wed, Jul 10, 2013 at 10:29:35AM +0200, Lukas Slebodnik wrote: On (04/07/13 15:23), Petr Spacek wrote: Hello, several warnings from autotools popped up after upgrade to Fedora 19. Attached patches should make autotools configuration more modern. -- Petr^2 Spacek From

Re: [Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

2013-07-10 Thread Lukas Slebodnik
On (10/07/13 10:48), Jakub Hrozek wrote: On Wed, Jul 10, 2013 at 10:29:35AM +0200, Lukas Slebodnik wrote: On (04/07/13 15:23), Petr Spacek wrote: Hello, several warnings from autotools popped up after upgrade to Fedora 19. Attached patches should make autotools configuration more modern.

Re: [Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

2013-07-10 Thread Jakub Hrozek
On Wed, Jul 10, 2013 at 10:59:10AM +0200, Lukas Slebodnik wrote: On (10/07/13 10:48), Jakub Hrozek wrote: On Wed, Jul 10, 2013 at 10:29:35AM +0200, Lukas Slebodnik wrote: On (04/07/13 15:23), Petr Spacek wrote: Hello, several warnings from autotools popped up after upgrade to Fedora 19.

Re: [Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

2013-07-10 Thread Lukas Slebodnik
On (10/07/13 11:14), Jakub Hrozek wrote: On Wed, Jul 10, 2013 at 10:59:10AM +0200, Lukas Slebodnik wrote: On (10/07/13 10:48), Jakub Hrozek wrote: On Wed, Jul 10, 2013 at 10:29:35AM +0200, Lukas Slebodnik wrote: On (04/07/13 15:23), Petr Spacek wrote: Hello, several warnings from

Re: [Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

2013-07-10 Thread Petr Spacek
On 10.7.2013 10:29, Lukas Slebodnik wrote: On (04/07/13 15:23), Petr Spacek wrote: Hello, several warnings from autotools popped up after upgrade to Fedora 19. Attached patches should make autotools configuration more modern. -- Petr^2 Spacek From 07caec808e394bfcbd898905e917731cb3778e68 Mon

Re: [Freeipa-devel] [PATCH] 0029 Make sure replication works after DM password is changed

2013-07-10 Thread Tomas Babej
On Monday 08 of July 2013 16:58:18 Ana Krivokapic wrote: On 06/25/2013 05:28 PM, Ana Krivokapic wrote: On 06/24/2013 02:27 PM, Tomas Babej wrote: On 06/11/2013 04:42 PM, Ade Lee wrote: [snip] Just FYI, we plan to do a new release of pki-core today (pki- core-10.0.3-2) to address this

Re: [Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

2013-07-10 Thread Jakub Hrozek
On Wed, Jul 10, 2013 at 11:59:32AM +0200, Lukas Slebodnik wrote: On (10/07/13 11:14), Jakub Hrozek wrote: On Wed, Jul 10, 2013 at 10:59:10AM +0200, Lukas Slebodnik wrote: On (10/07/13 10:48), Jakub Hrozek wrote: On Wed, Jul 10, 2013 at 10:29:35AM +0200, Lukas Slebodnik wrote: On (04/07/13

Re: [Freeipa-devel] [PATCH] 0029 Make sure replication works after DM password is changed

2013-07-10 Thread Ana Krivokapic
On 07/10/2013 01:33 PM, Tomas Babej wrote: On Monday 08 of July 2013 16:58:18 Ana Krivokapic wrote: On 06/25/2013 05:28 PM, Ana Krivokapic wrote: On 06/24/2013 02:27 PM, Tomas Babej wrote: On 06/11/2013 04:42 PM, Ade Lee wrote: [snip] Just FYI, we plan to do a new release of

Re: [Freeipa-devel] [PATCHES] 0230-0240 Integration testing framework

2013-07-10 Thread Jan Cholasta
On 25.6.2013 14:08, Petr Viktorin wrote: Adding two additional patches for better Beaker integration: Patch 0241 allows e.g. adding ticket numbers for automatic test case management Patch 0242 should bring the BeakerLib logging closer to what traditional Beaker tests output make test seems to

Re: [Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

2013-07-10 Thread Lukas Slebodnik
On (10/07/13 12:27), Petr Spacek wrote: On 10.7.2013 10:29, Lukas Slebodnik wrote: On (04/07/13 15:23), Petr Spacek wrote: Hello, several warnings from autotools popped up after upgrade to Fedora 19. Attached patches should make autotools configuration more modern. -- Petr^2 Spacek From

Re: [Freeipa-devel] [PATCH] 116 Add PAC to master host TGTs

2013-07-10 Thread Simo Sorce
On Tue, 2013-07-09 at 22:39 +0200, Jakub Hrozek wrote: On Tue, Jul 09, 2013 at 02:12:33PM +0300, Alexander Bokovoy wrote: On Tue, 09 Jul 2013, Jakub Hrozek wrote: On Wed, Jul 03, 2013 at 02:53:55PM +0200, Sumit Bose wrote: On Wed, Jul 03, 2013 at 01:00:43PM +0300, Alexander Bokovoy wrote:

Re: [Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

2013-07-10 Thread Tomas Hozza
On 07/10/2013 12:27 PM, Petr Spacek wrote: On 10.7.2013 10:29, Lukas Slebodnik wrote: On (04/07/13 15:23), Petr Spacek wrote: Hello, several warnings from autotools popped up after upgrade to Fedora 19. Attached patches should make autotools configuration more modern. -- Petr^2 Spacek

Re: [Freeipa-devel] [PATCH 0171-0172] Fix potential problems found by Clang static analyzer

2013-07-10 Thread Tomas Hozza
On 07/08/2013 10:51 AM, Petr Spacek wrote: Hello, several warnings from Clang static analyzer popped up after upgrade to Fedora 19. Attached patches should fix all problems found by clang-analyzer-3.3-0.6.rc3.fc19.x86_64. ACK Regards, Tomas Hozza

Re: [Freeipa-devel] [PATCH 0067] Add --use-posix option that forces trusted range type

2013-07-10 Thread Tomas Babej
On Monday 24 of June 2013 16:22:01 Petr Viktorin wrote: On 06/20/2013 12:56 PM, Tomas Babej wrote: On 06/17/2013 02:34 PM, Ana Krivokapic wrote: On 06/06/2013 11:10 AM, Tomas Babej wrote: Hi, Adds --use-posix option to ipa trust-add command. It takes two allowed values: 'yes' : the

Re: [Freeipa-devel] [PATCH] 116 Add PAC to master host TGTs

2013-07-10 Thread Alexander Bokovoy
On Wed, 10 Jul 2013, Simo Sorce wrote: On Tue, 2013-07-09 at 22:39 +0200, Jakub Hrozek wrote: On Tue, Jul 09, 2013 at 02:12:33PM +0300, Alexander Bokovoy wrote: On Tue, 09 Jul 2013, Jakub Hrozek wrote: On Wed, Jul 03, 2013 at 02:53:55PM +0200, Sumit Bose wrote: On Wed, Jul 03, 2013 at

Re: [Freeipa-devel] [PATCH] 140 Check trust chain length in CA-less install

2013-07-10 Thread Rob Crittenden
Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/3707. Honza This patch seems to work ok but I've been unable to test it with an external CA installation because that seems to be broken (unrelated to this patch). I filed

Re: [Freeipa-devel] [PATCH] 117 extdom: replace winbind calls with POSIX/SSSD calls

2013-07-10 Thread Alexander Bokovoy
On Tue, 09 Jul 2013, Jakub Hrozek wrote: On Tue, Jul 09, 2013 at 11:42:00AM +0200, Jakub Hrozek wrote: On Tue, Jul 09, 2013 at 10:33:19AM +0300, Alexander Bokovoy wrote: On Mon, 08 Jul 2013, Jakub Hrozek wrote: On Mon, Jul 08, 2013 at 07:32:41PM +0300, Alexander Bokovoy wrote: On Mon, 08 Jul

Re: [Freeipa-devel] [PATCHES] 0039-0040 systemd ipactl fixes

2013-07-10 Thread Ana Krivokapic
On 07/08/2013 08:32 AM, Alexander Bokovoy wrote: On Thu, 20 Jun 2013, Ana Krivokapic wrote: Hello, Attached patches fix systemd and ipactl related bugs: https://fedorahosted.org/freeipa/ticket/3730 https://fedorahosted.org/freeipa/ticket/3729 NACK. For me upgrade case fails (rpm -Uhv),

Re: [Freeipa-devel] [PATCH] 117 extdom: replace winbind calls with POSIX/SSSD calls

2013-07-10 Thread Simo Sorce
On Wed, 2013-07-10 at 19:15 +0300, Alexander Bokovoy wrote: On Tue, 09 Jul 2013, Jakub Hrozek wrote: On Tue, Jul 09, 2013 at 11:42:00AM +0200, Jakub Hrozek wrote: On Tue, Jul 09, 2013 at 10:33:19AM +0300, Alexander Bokovoy wrote: On Mon, 08 Jul 2013, Jakub Hrozek wrote: On Mon, Jul 08,

Re: [Freeipa-devel] [PATCH] 116 Add PAC to master host TGTs

2013-07-10 Thread Alexander Bokovoy
On Wed, 10 Jul 2013, Alexander Bokovoy wrote: On Wed, 10 Jul 2013, Simo Sorce wrote: On Tue, 2013-07-09 at 22:39 +0200, Jakub Hrozek wrote: On Tue, Jul 09, 2013 at 02:12:33PM +0300, Alexander Bokovoy wrote: On Tue, 09 Jul 2013, Jakub Hrozek wrote: On Wed, Jul 03, 2013 at 02:53:55PM +0200,

Re: [Freeipa-devel] [PATCH] 116 Add PAC to master host TGTs

2013-07-10 Thread Simo Sorce
On Wed, 2013-07-10 at 19:55 +0300, Alexander Bokovoy wrote: The patch looks good to me so I'm giving my +1. I would appreciate other review too before a full ack, though. I've nacked the approach, although the results are as expected. Alexander will send a simplified patch that avoids

[Freeipa-devel] [PATCH] Fix for small syntax error in OTP schema

2013-07-10 Thread Nathaniel McCallum
https://fedorahosted.org/freeipa/ticket/3765 Due to the potentially bad ramifications of a schema syntax error, I tested this in both single server and replica configurations. The worst case in both is a truncated attribute description. The above patch fixes the problem in both cases with a

[Freeipa-devel] [PATCH] Remove unused variable

2013-07-10 Thread Jakub Hrozek
Hi, I was doing quite a few builds of freeipa for testing and patch reviews lately and found a couple of unused variables. The attached patch removed the variables. From f3408502fe3e4392dff4085b58670241cd1956ae Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhro...@redhat.com Date: Tue, 9 Jul 2013