Re: [Freeipa-devel] [PATCH] 1103 Add Camellia ciphers

2013-07-18 Thread Alexander Bokovoy
On Fri, 12 Jul 2013, Rob Crittenden wrote: Rob Crittenden wrote: Add the Camellia ciphers to the supported list in the KDC. Also exclude some attributes from being displayed in LDAP updater logs. rob I've split the Camellia patch out from the updater patch to clarify things. Thanks, pushed

Re: [Freeipa-devel] [PATCH] 0044 Add 'ipa_server_mode' option to SSSD configuration

2013-07-18 Thread Alexander Bokovoy
On Mon, 15 Jul 2013, Ana Krivokapic wrote: Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3652. Could you please rebase it on top of git master? -- / Alexander Bokovoy ___ Freeipa-devel mailing list

[Freeipa-devel] Unused trusted range cannot be deleted

2013-07-18 Thread Tomas Babej
Hi, please have a look at the following ticket: https://fedorahosted.org/freeipa/ticket/3787 Basically the problem here is that we do not allow the deletion of a range that belongs to an active trust. This functionality was added in scope of 3.3 AFAIK. However, the admin is not allowed to

Re: [Freeipa-devel] [PATCH 0174] Fix crash during zone_refresh triggered by connection failure

2013-07-18 Thread Tomas Hozza
On 07/15/2013 03:13 PM, Petr Spacek wrote: Hello, Fix crash during zone_refresh triggered by connection failure. Variable 'iter' was initialized too late. Code in cleanup section of refresh_zones_from_ldap() dereferenced the uninitialized variable. ACK. The crash is fixed. Regards,

Re: [Freeipa-devel] [PATCH 0175-0177] Prepare transition from persistent search to RFC 4533

2013-07-18 Thread Tomas Hozza
On 07/16/2013 10:04 AM, Petr Spacek wrote: Hello, this patch set changes default configuration to 'psearch yes' and changes README and informational messages accordingly. ACK. Regards, Tomas Hozza ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH 0178-0179] Preparation for 3.5 release

2013-07-18 Thread Tomas Hozza
On 07/16/2013 10:13 AM, Petr Spacek wrote: Hello, I plan to release 3.5 as soon as all previous patches are ACKed. ACK. Regards, Tomas Hozza ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] Proposal to have spec changes as a separate patch

2013-07-18 Thread Alexander Bokovoy
On Thu, 18 Jul 2013, Alexander Bokovoy wrote: On Mon, 15 Jul 2013, Ana Krivokapic wrote: Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3652. Could you please rebase it on top of git master? BTW, I was thinking on it and given that majority of rebases like this

Re: [Freeipa-devel] [PATCH 0171-0172] Fix potential problems found by Clang static analyzer

2013-07-18 Thread Petr Spacek
On 10.7.2013 16:45, Tomas Hozza wrote: On 07/08/2013 10:51 AM, Petr Spacek wrote: Hello, several warnings from Clang static analyzer popped up after upgrade to Fedora 19. Attached patches should fix all problems found by clang-analyzer-3.3-0.6.rc3.fc19.x86_64. ACK Pushed to v3:

Re: [Freeipa-devel] [PATCH 0169-0170] Modernize autotools configuration

2013-07-18 Thread Petr Spacek
On 10.7.2013 15:33, Tomas Hozza wrote: On 07/10/2013 12:27 PM, Petr Spacek wrote: On 10.7.2013 10:29, Lukas Slebodnik wrote: On (04/07/13 15:23), Petr Spacek wrote: Hello, several warnings from autotools popped up after upgrade to Fedora 19. Attached patches should make autotools

Re: [Freeipa-devel] [PATCH] 1103 Add Camellia ciphers

2013-07-18 Thread Alexander Bokovoy
On Thu, 18 Jul 2013, Alexander Bokovoy wrote: On Fri, 12 Jul 2013, Rob Crittenden wrote: Rob Crittenden wrote: Add the Camellia ciphers to the supported list in the KDC. Also exclude some attributes from being displayed in LDAP updater logs. rob I've split the Camellia patch out from the

Re: [Freeipa-devel] [PATCH 0173] Improve logging for cases where SOA serial autoincrementation failed

2013-07-18 Thread Petr Spacek
On 12.7.2013 10:18, Tomas Hozza wrote: On 07/11/2013 12:24 PM, Petr Spacek wrote: Hello, Improve logging for cases where SOA serial autoincrementation failed. ACK Pushed to v3: 9ef4eee3c484557efd7c777458c6800f7c61bdaf -- Petr^2 Spacek ___

Re: [Freeipa-devel] [PATCH 0174] Fix crash during zone_refresh triggered by connection failure

2013-07-18 Thread Petr Spacek
On 18.7.2013 10:06, Tomas Hozza wrote: On 07/15/2013 03:13 PM, Petr Spacek wrote: Hello, Fix crash during zone_refresh triggered by connection failure. Variable 'iter' was initialized too late. Code in cleanup section of refresh_zones_from_ldap() dereferenced the uninitialized variable.

Re: [Freeipa-devel] [PATCH 0175-0177] Prepare transition from persistent search to RFC 4533

2013-07-18 Thread Petr Spacek
On 18.7.2013 10:08, Tomas Hozza wrote: On 07/16/2013 10:04 AM, Petr Spacek wrote: Hello, this patch set changes default configuration to 'psearch yes' and changes README and informational messages accordingly. ACK. Pushed to v3: b6eb73072b501a646c90e591c3fb7421ab011bd3

Re: [Freeipa-devel] [PATCH 0178-0179] Preparation for 3.5 release

2013-07-18 Thread Petr Spacek
On 18.7.2013 10:09, Tomas Hozza wrote: On 07/16/2013 10:13 AM, Petr Spacek wrote: Hello, I plan to release 3.5 as soon as all previous patches are ACKed. ACK. Pushed to v3: 1c73120c82ddf52c70b16aabde4cf249ed2ec148 190d13ef0188304c0dc23fc0f182482718ecb580 V3 is stable branch, master branch

Re: [Freeipa-devel] [PATCH] 1103 Add Camellia ciphers

2013-07-18 Thread Martin Kosek
On 07/18/2013 11:10 AM, Alexander Bokovoy wrote: On Thu, 18 Jul 2013, Alexander Bokovoy wrote: On Fri, 12 Jul 2013, Rob Crittenden wrote: Rob Crittenden wrote: Add the Camellia ciphers to the supported list in the KDC. Also exclude some attributes from being displayed in LDAP updater logs.

Re: [Freeipa-devel] Proposal to have spec changes as a separate patch

2013-07-18 Thread Petr Viktorin
On 07/18/2013 10:10 AM, Alexander Bokovoy wrote: On Thu, 18 Jul 2013, Alexander Bokovoy wrote: On Mon, 15 Jul 2013, Ana Krivokapic wrote: Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3652. Could you please rebase it on top of git master? BTW, I was thinking on

Re: [Freeipa-devel] [PATCH] Use libunistring ulc_casecmp() on unicode strings

2013-07-18 Thread Martin Kosek
On 07/17/2013 07:13 PM, Nathaniel McCallum wrote: attached I did not review/test the actual code, but shouldn't we also add libunistring as BuildRequires in spec file so that it is automatically installed before the build? Martin ___ Freeipa-devel

[Freeipa-devel] [PATCH] 428 Hide delete button in multivalued widget if attr is not writable

2013-07-18 Thread Petr Vobornik
Hide delete button in multivalued widget if attr is not writable https://fedorahosted.org/freeipa/ticket/3799 -- Petr Vobornik From 0f133f0aa47f0bd1b6567c3adeb37e58e73df859 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Fri, 28 Jun 2013 16:14:45 +0200 Subject: [PATCH]

[Freeipa-devel] [PATCH] 429 Make ssh_widget not-editable if attr is readonly

2013-07-18 Thread Petr Vobornik
Make ssh_widget not-editable if attr is readonly Depends on patch pvoborni-428. https://fedorahosted.org/freeipa/ticket/3800 -- Petr Vobornik From df1d96dcd9996d6849521f0e36cdd6e04e8d3b14 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Fri, 28 Jun 2013 16:50:52 +0200

[Freeipa-devel] [PATCHES] 0251-0252 Wait for replication to finish in test_simple_replication

2013-07-18 Thread Petr Viktorin
Please apply on top of my patches 0245-0250 (or I can rebase if necessary). These patches are continuing with https://fedorahosted.org/freeipa/ticket/3621, Automated integration testing Before checking if an entry is replicated, we need to wait until replication is complete. One way to do

[Freeipa-devel] Announcing bind-dyndb-ldap version 3.5

2013-07-18 Thread Petr Spacek
The FreeIPA team is proud to announce bind-dyndb-ldap version 3.5. It can be downloaded from https://fedorahosted.org/released/bind-dyndb-ldap/. The new version has also been built for Fedora 19 and and is on its way to updates-testing:

Re: [Freeipa-devel] [PATCH] 0044 Add 'ipa_server_mode' option to SSSD configuration

2013-07-18 Thread Ana Krivokapic
On 07/18/2013 09:57 AM, Alexander Bokovoy wrote: On Mon, 15 Jul 2013, Ana Krivokapic wrote: Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3652. Could you please rebase it on top of git master? Sure, patches are attached. Spec changes have been split to a

[Freeipa-devel] [PATCH] 430 Break long words in notification area

2013-07-18 Thread Petr Vobornik
Long words (ie. service principal) breaks out of notification area. It doesn't look good. Patch adds word-wrap to break them to multiple pieces. Reproduction: modify a service in Web UI -- Petr Vobornik From cc8462c8166c51d3241f1a5efd261d0dc4d6e07b Mon Sep 17 00:00:00 2001 From: Petr Vobornik

Re: [Freeipa-devel] [PATCH] 0046 Properly handle non-existent CA file

2013-07-18 Thread Ana Krivokapic
On 07/18/2013 09:25 AM, Jan Cholasta wrote: On 17.7.2013 19:43, Ana Krivokapic wrote: On 07/17/2013 06:04 PM, Jan Cholasta wrote: On 17.7.2013 17:39, Ana Krivokapic wrote: On 07/17/2013 04:57 PM, Jan Cholasta wrote: Hi, On 17.7.2013 16:38, Ana Krivokapic wrote: Hello, This patch

Re: [Freeipa-devel] [PATCHES] 0251-0252 Wait for replication to finish in test_simple_replication

2013-07-18 Thread Jan Cholasta
On 18.7.2013 12:17, Petr Viktorin wrote: Please apply on top of my patches 0245-0250 (or I can rebase if necessary). These patches are continuing with https://fedorahosted.org/freeipa/ticket/3621, Automated integration testing Before checking if an entry is replicated, we need to wait until

Re: [Freeipa-devel] [PATCH] 0046 Properly handle non-existent CA file

2013-07-18 Thread Jan Cholasta
On 18.7.2013 13:02, Ana Krivokapic wrote: On 07/18/2013 09:25 AM, Jan Cholasta wrote: On 17.7.2013 19:43, Ana Krivokapic wrote: On 07/17/2013 06:04 PM, Jan Cholasta wrote: On 17.7.2013 17:39, Ana Krivokapic wrote: On 07/17/2013 04:57 PM, Jan Cholasta wrote: Hi, On 17.7.2013 16:38, Ana

[Freeipa-devel] [PATCH] 431-434 Web UI integration tests continuation

2013-07-18 Thread Petr Vobornik
[PATCH] 431 Web UI integration tests: Add trust tests [PATCH] 432 Web UI integration tests: Add ui_driver method descriptions [PATCH] 433 Web UI integration tests: Verify data after add and mod [PATCH] 434 Web UI integration tests: Compute range sizes to avoid overlaps Heavily inspired by

Re: [Freeipa-devel] [PATCH] 431-434 Web UI integration tests continuation

2013-07-18 Thread Petr Vobornik
On 07/18/2013 01:34 PM, Petr Vobornik wrote: [PATCH] 431 Web UI integration tests: Add trust tests [PATCH] 432 Web UI integration tests: Add ui_driver method descriptions [PATCH] 433 Web UI integration tests: Verify data after add and mod [PATCH] 434 Web UI integration tests: Compute range

Re: [Freeipa-devel] Proposal to have spec changes as a separate patch

2013-07-18 Thread Alexander Bokovoy
On Thu, 18 Jul 2013, Petr Viktorin wrote: On 07/18/2013 10:10 AM, Alexander Bokovoy wrote: On Thu, 18 Jul 2013, Alexander Bokovoy wrote: On Mon, 15 Jul 2013, Ana Krivokapic wrote: Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3652. Could you please rebase it on

Re: [Freeipa-devel] Proposal to have spec changes as a separate patch

2013-07-18 Thread Martin Kosek
On 07/18/2013 02:01 PM, Alexander Bokovoy wrote: On Thu, 18 Jul 2013, Petr Viktorin wrote: On 07/18/2013 10:10 AM, Alexander Bokovoy wrote: On Thu, 18 Jul 2013, Alexander Bokovoy wrote: On Mon, 15 Jul 2013, Ana Krivokapic wrote: Hello, This patch addresses ticket

Re: [Freeipa-devel] [PATCH] Use libunistring ulc_casecmp() on unicode strings

2013-07-18 Thread Nathaniel McCallum
- Original Message - I did not review/test the actual code, but shouldn't we also add libunistring as BuildRequires in spec file so that it is automatically installed before the build? Good catch. Fixed version attached. Nathaniel From fd68fd234bfcd11b3315e685e8f5192659b4a606 Mon Sep

Re: [Freeipa-devel] [PATCHES] 143-147 Improve performance with large groups

2013-07-18 Thread Martin Kosek
On 07/18/2013 04:53 PM, Jan Cholasta wrote: On 15.7.2013 17:21, Martin Kosek wrote: On 07/15/2013 03:43 PM, Jan Cholasta wrote: On 15.7.2013 15:16, Martin Kosek wrote: On 07/11/2013 12:15 PM, Alexander Bokovoy wrote: On Thu, 11 Jul 2013, Jan Cholasta wrote: We can add WebUI improvements

Re: [Freeipa-devel] [PATCHES] 143-147 Improve performance with large groups

2013-07-18 Thread Jan Cholasta
On 18.7.2013 17:07, Martin Kosek wrote: On 07/18/2013 04:53 PM, Jan Cholasta wrote: Added patch which adds new hidden option no_members to suppress membership processing for commands of all objects that have member attributes. This can be used by the WebUI to prevent member lookups where they

Re: [Freeipa-devel] [PATCHES] 143-147 Improve performance with large groups

2013-07-18 Thread Martin Kosek
On 07/18/2013 05:22 PM, Jan Cholasta wrote: On 18.7.2013 17:07, Martin Kosek wrote: On 07/18/2013 04:53 PM, Jan Cholasta wrote: Added patch which adds new hidden option no_members to suppress membership processing for commands of all objects that have member attributes. This can be used by

Re: [Freeipa-devel] [PATCHES] 143-147 Improve performance with large groups

2013-07-18 Thread Jan Cholasta
On 18.7.2013 17:26, Martin Kosek wrote: On 07/18/2013 05:22 PM, Jan Cholasta wrote: On 18.7.2013 17:07, Martin Kosek wrote: On 07/18/2013 04:53 PM, Jan Cholasta wrote: Added patch which adds new hidden option no_members to suppress membership processing for commands of all objects that have

Re: [Freeipa-devel] [PATCH] Use libunistring ulc_casecmp() on unicode strings

2013-07-18 Thread Alexander Bokovoy
On Thu, 18 Jul 2013, Nathaniel McCallum wrote: - Original Message - I did not review/test the actual code, but shouldn't we also add libunistring as BuildRequires in spec file so that it is automatically installed before the build? Good catch. Fixed version attached. ACK. Works fine.

Re: [Freeipa-devel] [PATCH] 0044 Add 'ipa_server_mode' option to SSSD configuration

2013-07-18 Thread Alexander Bokovoy
On Thu, 18 Jul 2013, Ana Krivokapic wrote: On 07/18/2013 09:57 AM, Alexander Bokovoy wrote: On Mon, 15 Jul 2013, Ana Krivokapic wrote: Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3652. Could you please rebase it on top of git master? Sure, patches are

[Freeipa-devel] [PATCH] 0109-0110 Support querying AD DC when establishing trust as HTTP/ipa.server principal

2013-07-18 Thread Alexander Bokovoy
Hi! Attached patches make possible to use HTTP/ipa.server@REALM to query AD DC over LDAP immediately after trust is established. We need this to get range discovery working prior to creating range for trusted domain. The patch 0109 makes KDC hostname cached on ipadb context to avoid resolving

Re: [Freeipa-devel] [PATCH] 428 Hide delete button in multivalued widget if attr is not writable

2013-07-18 Thread James
On Thu, 2013-07-18 at 12:11 +0200, Petr Vobornik wrote: Hide delete button in multivalued widget if attr is not writable Hey, Maybe it would be a good idea to set the disabled state of the button instead of removing it? That way it's obvious that some attrs can be deleted, and it won't cause

Re: [Freeipa-devel] [PATCH] 0044 Add 'ipa_server_mode' option to SSSD configuration

2013-07-18 Thread Martin Kosek
On 07/18/2013 05:32 PM, Alexander Bokovoy wrote: On Thu, 18 Jul 2013, Ana Krivokapic wrote: On 07/18/2013 09:57 AM, Alexander Bokovoy wrote: On Mon, 15 Jul 2013, Ana Krivokapic wrote: Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3652. Could you please rebase it

Re: [Freeipa-devel] [PATCH] 0108 Add support for compatibility tree for trusted domain users

2013-07-18 Thread Martin Kosek
On 07/18/2013 05:45 PM, Alexander Bokovoy wrote: On Tue, 16 Jul 2013, Jakub Hrozek wrote: +if self.enable_compat: +self.step(Enabling trusted domains support for older clients via Schema Compatibility plugin, Nitpick: all the

Re: [Freeipa-devel] [PATCH] Use libunistring ulc_casecmp() on unicode strings

2013-07-18 Thread Martin Kosek
On 07/18/2013 05:30 PM, Alexander Bokovoy wrote: On Thu, 18 Jul 2013, Nathaniel McCallum wrote: - Original Message - I did not review/test the actual code, but shouldn't we also add libunistring as BuildRequires in spec file so that it is automatically installed before the build?

[Freeipa-devel] [PATCH] 0049 Use admin@REALM when testing if SSSD is ready

2013-07-18 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3771. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From 65c900d790adfabdd045069b3be0bd1c87306af9 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic akriv...@redhat.com Date: Thu, 18 Jul