Re: [Freeipa-devel] [PATCH] 0317 Improve LDAPEntry.__repr__ for freshly created entries

2013-11-25 Thread Jan Cholasta
On 6.11.2013 13:28, Petr Viktorin wrote: Hello Honza, This is a simple enough patch, but I'd like you to check if it's consistent with your vision of the framework. I used self._raw here deliberately, so that calling repr() on an LDAPEntry does not change its internal state. I agree that

Re: [Freeipa-devel] [PATCH] 0317 Improve LDAPEntry.__repr__ for freshly created entries

2013-11-25 Thread Petr Viktorin
On 11/25/2013 01:05 PM, Jan Cholasta wrote: On 6.11.2013 13:28, Petr Viktorin wrote: Hello Honza, This is a simple enough patch, but I'd like you to check if it's consistent with your vision of the framework. I used self._raw here deliberately, so that calling repr() on an LDAPEntry does not

Re: [Freeipa-devel] [PATCHES] 198-202 Refactor indirect membership processing

2013-11-25 Thread Jan Cholasta
On 8.11.2013 17:56, Petr Viktorin wrote: Patch 198: Also update ipaldap's find_entries docstring, it no longer uses IPA defaults. Done. While you're touching this part of code, I had some other improvements in mind -- you can consider them: In find_entries, attrs_list = [a.lower()

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

2013-11-25 Thread Ana Krivokapic
On 11/15/2013 02:26 PM, Petr Vobornik wrote: Hello list, this is a first part of RCUE adoption effort. Main themes of this patch set are: - use RCUE navigation https://fedorahosted.org/freeipa/ticket/3902 - new styles for textboxes, textareas, radio/checkbox buttons and buttons- part of