Re: [Freeipa-devel] [PATCH] 0317 Improve LDAPEntry.__repr__ for freshly created entries

2013-11-26 Thread Jan Cholasta
On 25.11.2013 14:41, Petr Viktorin wrote: On 11/25/2013 01:05 PM, Jan Cholasta wrote: On 6.11.2013 13:28, Petr Viktorin wrote: Hello Honza, This is a simple enough patch, but I'd like you to check if it's consistent with your vision of the framework. I used self._raw here deliberately, so

[Freeipa-devel] [PATCH] 203 Remove mod_ssl port workaround

2013-11-26 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4021. Honza -- Jan Cholasta From f880aa215ad268a156e5367e9ee8a915c1e07e35 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 26 Nov 2013 08:53:34 + Subject: [PATCH] Remove mod_ssl port workaround.

Re: [Freeipa-devel] [PATCH] 203 Remove mod_ssl port workaround

2013-11-26 Thread Alexander Bokovoy
On Tue, 26 Nov 2013, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4021. Honza -- Jan Cholasta From f880aa215ad268a156e5367e9ee8a915c1e07e35 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 26 Nov 2013 08:53:34 +

Re: [Freeipa-devel] [PATCH] 203 Remove mod_ssl port workaround

2013-11-26 Thread Petr Viktorin
On 11/26/2013 12:34 PM, Alexander Bokovoy wrote: On Tue, 26 Nov 2013, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4021. Honza -- Jan Cholasta ACK. Pushed to: master: f20577ddc4ab40c2365c8abaa703d96019ec4eef ipa-3-3:

[Freeipa-devel] [PATCH] 0321 Remove changelog from the spec

2013-11-26 Thread Petr Viktorin
The changelog was useless and caused unnecessary rebase conflicts. Let's kill it. -- Petr³ From fe9d847fa39e3683ada3b7d12f3643ae9433bf45 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Tue, 26 Nov 2013 13:06:07 +0100 Subject: [PATCH] Remove changelog from the spec The

Re: [Freeipa-devel] [PATCH] 0317 Improve LDAPEntry.__repr__ for freshly created entries

2013-11-26 Thread Petr Viktorin
On 11/26/2013 09:57 AM, Jan Cholasta wrote: On 25.11.2013 14:41, Petr Viktorin wrote: On 11/25/2013 01:05 PM, Jan Cholasta wrote: On 6.11.2013 13:28, Petr Viktorin wrote: Hello Honza, This is a simple enough patch, but I'd like you to check if it's consistent with your vision of the

Re: [Freeipa-devel] [PATCH] 0321 Remove changelog from the spec

2013-11-26 Thread Alexander Bokovoy
On Tue, 26 Nov 2013, Petr Viktorin wrote: The changelog was useless and caused unnecessary rebase conflicts. Let's kill it. -- Petr³ From fe9d847fa39e3683ada3b7d12f3643ae9433bf45 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Tue, 26 Nov 2013 13:06:07 +0100 Subject:

Re: [Freeipa-devel] [PATCH] 0321 Remove changelog from the spec

2013-11-26 Thread Petr Viktorin
On 11/26/2013 01:27 PM, Alexander Bokovoy wrote: On Tue, 26 Nov 2013, Petr Viktorin wrote: The changelog was useless and caused unnecessary rebase conflicts. Let's kill it. -- Petr³ From fe9d847fa39e3683ada3b7d12f3643ae9433bf45 Mon Sep 17 00:00:00 2001 From: Petr Viktorin

Re: [Freeipa-devel] [PATCH] 0321 Remove changelog from the spec

2013-11-26 Thread Alexander Bokovoy
On Tue, 26 Nov 2013, Petr Viktorin wrote: On 11/26/2013 01:27 PM, Alexander Bokovoy wrote: On Tue, 26 Nov 2013, Petr Viktorin wrote: The changelog was useless and caused unnecessary rebase conflicts. Let's kill it. -- Petr³ From fe9d847fa39e3683ada3b7d12f3643ae9433bf45 Mon Sep 17 00:00:00

Re: [Freeipa-devel] [PATCH] 203 Remove mod_ssl port workaround

2013-11-26 Thread Petr Viktorin
On 11/26/2013 12:17 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4021. Honza I assume a build of httpd = 2.4.6-6 is not planned for Fedora 19, so master is now f20+ only. Is that right? -- Petr³

Re: [Freeipa-devel] [PATCH] 203 Remove mod_ssl port workaround

2013-11-26 Thread Alexander Bokovoy
On Tue, 26 Nov 2013, Petr Viktorin wrote: On 11/26/2013 12:17 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4021. Honza I assume a build of httpd = 2.4.6-6 is not planned for Fedora 19, so master is now f20+ only. Is that right? Is this bad?

Re: [Freeipa-devel] [PATCH] #3901

2013-11-26 Thread Simo Sorce
On Tue, 2013-11-26 at 14:11 +0100, Jan Cholasta wrote: On 17.9.2013 17:26, Jan Cholasta wrote: On 10.9.2013 21:12, Simo Sorce wrote: I think the attached (untested) patch should solve the issue. Is it sufficient or do we want to change framework code somehow ? Simo. I think no

Re: [Freeipa-devel] [PATCH] 203 Remove mod_ssl port workaround

2013-11-26 Thread Petr Viktorin
On 11/26/2013 02:15 PM, Alexander Bokovoy wrote: On Tue, 26 Nov 2013, Petr Viktorin wrote: On 11/26/2013 12:17 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4021. Honza I assume a build of httpd = 2.4.6-6 is not planned for Fedora 19, so

Re: [Freeipa-devel] [PATCH] 203 Remove mod_ssl port workaround

2013-11-26 Thread Jan Cholasta
On 26.11.2013 14:24, Petr Viktorin wrote: On 11/26/2013 02:15 PM, Alexander Bokovoy wrote: On Tue, 26 Nov 2013, Petr Viktorin wrote: On 11/26/2013 12:17 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4021. Honza I assume a build of httpd =

Re: [Freeipa-devel] [PATCH] 203 Remove mod_ssl port workaround

2013-11-26 Thread Alexander Bokovoy
On Tue, 26 Nov 2013, Petr Viktorin wrote: On 11/26/2013 02:15 PM, Alexander Bokovoy wrote: On Tue, 26 Nov 2013, Petr Viktorin wrote: On 11/26/2013 12:17 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4021. Honza I assume a build of httpd =

Re: [Freeipa-devel] [PATCH 0132] [PATCH 132/132] trusts: Always stop and disable smb service on uninstall

2013-11-26 Thread Petr Viktorin
On 11/22/2013 12:01 PM, Alexander Bokovoy wrote: On Thu, 21 Nov 2013, Tomas Babej wrote: https://fedorahosted.org/freeipa/ticket/4042 --- ipaserver/install/adtrustinstance.py | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/ipaserver/install/adtrustinstance.py

[Freeipa-devel] [PATCH 0134] ipa-client-install: Always pass hostname to the ipa-join

2013-11-26 Thread Tomas Babej
Hi, The ipa-client-install script and ipa-join use different methods of resolving the hostname, the former uses gethostbyaddr() call, while the latter reads the uinfo.nodename. This can result ipa-client-install failures in case of broken PTR records.

[Freeipa-devel] [PATCH 0133] ipa-cldap: Cut NetBIOS name after 15 characters

2013-11-26 Thread Tomas Babej
Hi, The CLDAP DS plugin uses the uppercased first segment of the fully qualified hostname as the NetBIOS name. We need to limit its size to 15 characters. https://fedorahosted.org/freeipa/ticket/4028 -- Tomas Babej Associate Software Engeneer | Red Hat | Identity Management RHCE | Brno Site |

Re: [Freeipa-devel] [PATCH] 0321 Remove changelog from the spec

2013-11-26 Thread Petr Viktorin
On 11/26/2013 01:45 PM, Alexander Bokovoy wrote: On Tue, 26 Nov 2013, Petr Viktorin wrote: On 11/26/2013 01:27 PM, Alexander Bokovoy wrote: On Tue, 26 Nov 2013, Petr Viktorin wrote: The changelog was useless and caused unnecessary rebase conflicts. Let's kill it. -- Petr³ From

[Freeipa-devel] [PATCH] 0086 Make Expression field required when adding automember condition

2013-11-26 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/4053. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From 32fe5becfa530e629602433e0942fccb1a06e677 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic akriv...@redhat.com Date: Tue, 26 Nov

Re: [Freeipa-devel] [PATCH] #3901

2013-11-26 Thread Jan Cholasta
On 26.11.2013 14:24, Simo Sorce wrote: On Tue, 2013-11-26 at 14:11 +0100, Jan Cholasta wrote: kadmin.local still returns an error for me with this patch applied: kadmin.local: modprinc +ok_as_delegate host/test.example@example.com modify_principal: Kerberos database internal

Re: [Freeipa-devel] [PATCH 0133] ipa-cldap: Cut NetBIOS name after 15 characters

2013-11-26 Thread Jan Cholasta
On 26.11.2013 15:37, Tomas Babej wrote: Hi, The CLDAP DS plugin uses the uppercased first segment of the fully qualified hostname as the NetBIOS name. We need to limit its size to 15 characters. https://fedorahosted.org/freeipa/ticket/4028 I don't think you need to copy the whole

Re: [Freeipa-devel] [PATCH] #3901

2013-11-26 Thread Jan Cholasta
On 26.11.2013 16:35, Jan Cholasta wrote: On 26.11.2013 14:24, Simo Sorce wrote: On Tue, 2013-11-26 at 14:11 +0100, Jan Cholasta wrote: kadmin.local still returns an error for me with this patch applied: kadmin.local: modprinc +ok_as_delegate host/test.example@example.com

Re: [Freeipa-devel] [PATCH] #3901

2013-11-26 Thread Petr Viktorin
On 11/26/2013 04:42 PM, Jan Cholasta wrote: On 26.11.2013 16:35, Jan Cholasta wrote: On 26.11.2013 14:24, Simo Sorce wrote: On Tue, 2013-11-26 at 14:11 +0100, Jan Cholasta wrote: kadmin.local still returns an error for me with this patch applied: kadmin.local: modprinc +ok_as_delegate

Re: [Freeipa-devel] [PATCH 0133] ipa-cldap: Cut NetBIOS name after 15 characters

2013-11-26 Thread Simo Sorce
On Tue, 2013-11-26 at 16:38 +0100, Jan Cholasta wrote: On 26.11.2013 15:37, Tomas Babej wrote: Hi, The CLDAP DS plugin uses the uppercased first segment of the fully qualified hostname as the NetBIOS name. We need to limit its size to 15 characters.

Re: [Freeipa-devel] [PATCH 0133] ipa-cldap: Cut NetBIOS name after 15 characters

2013-11-26 Thread Jan Cholasta
On 26.11.2013 16:43, Simo Sorce wrote: On Tue, 2013-11-26 at 16:38 +0100, Jan Cholasta wrote: -pdc_name = talloc_asprintf(nlr, %s, fq_hostname); +snprintf(pdc_name, 16, %s, fq_hostname); +pdc_name[15] = '\0'; It's simpler to use length qualifiers in talloc_asprintf:

Re: [Freeipa-devel] [PATCH 0133] ipa-cldap: Cut NetBIOS name after 15 characters

2013-11-26 Thread Alexander Bokovoy
On Tue, 26 Nov 2013, Jan Cholasta wrote: On 26.11.2013 16:43, Simo Sorce wrote: On Tue, 2013-11-26 at 16:38 +0100, Jan Cholasta wrote: -pdc_name = talloc_asprintf(nlr, %s, fq_hostname); +snprintf(pdc_name, 16, %s, fq_hostname); +pdc_name[15] = '\0'; It's simpler to use

Re: [Freeipa-devel] [PATCH 0133] ipa-cldap: Cut NetBIOS name after 15 characters

2013-11-26 Thread Alexander Bokovoy
On Tue, 26 Nov 2013, Tomas Babej wrote: Hi, The CLDAP DS plugin uses the uppercased first segment of the fully qualified hostname as the NetBIOS name. We need to limit its size to 15 characters. https://fedorahosted.org/freeipa/ticket/4028 -- Tomas Babej Associate Software Engeneer | Red Hat

Re: [Freeipa-devel] [PATCH] 0119 Switch client to JSON-RPC

2013-11-26 Thread Petr Viktorin
On 11/26/2013 03:06 PM, Jan Cholasta wrote: On 18.10.2013 12:26, Petr Viktorin wrote: On 10/17/2013 06:08 PM, Jan Cholasta wrote: Hi, On 7.10.2013 18:16, Petr Viktorin wrote: On 08/12/2013 10:17 AM, Petr Viktorin wrote: On 08/02/2013 11:13 AM, Petr Viktorin wrote: On 05/10/2013 04:54 PM,

Re: [Freeipa-devel] [PATCH 0133] ipa-cldap: Cut NetBIOS name after 15 characters

2013-11-26 Thread Tomas Babej
On 11/26/2013 04:56 PM, Alexander Bokovoy wrote: On Tue, 26 Nov 2013, Tomas Babej wrote: Hi, The CLDAP DS plugin uses the uppercased first segment of the fully qualified hostname as the NetBIOS name. We need to limit its size to 15 characters. https://fedorahosted.org/freeipa/ticket/4028 --

Re: [Freeipa-devel] [PATCH 0133] ipa-cldap: Cut NetBIOS name after 15 characters

2013-11-26 Thread Alexander Bokovoy
On Wed, 27 Nov 2013, Tomas Babej wrote: daemons/ipa-slapi-plugins/ipa-cldap/ipa_cldap_netlogon.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/daemons/ipa-slapi-plugins/ipa-cldap/ipa_cldap_netlogon.c b/daemons/ipa-slapi-plugins/ipa-cldap/ipa_cldap_netlogon.c index

Re: [Freeipa-devel] [PATCH 0133] ipa-cldap: Cut NetBIOS name after 15 characters

2013-11-26 Thread Tomas Babej
On 11/27/2013 08:25 AM, Alexander Bokovoy wrote: On Wed, 27 Nov 2013, Tomas Babej wrote: daemons/ipa-slapi-plugins/ipa-cldap/ipa_cldap_netlogon.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/daemons/ipa-slapi-plugins/ipa-cldap/ipa_cldap_netlogon.c