Re: [Freeipa-devel] [PATCH] 910 add permission: System: Manage User Certificates

2015-08-14 Thread Martin Basti
On 08/13/2015 03:46 PM, Fraser Tweedale wrote: On Thu, Aug 13, 2015 at 12:30:10PM +0300, Alexander Bokovoy wrote: On Thu, 13 Aug 2015, Fraser Tweedale wrote: On Thu, Aug 13, 2015 at 11:04:42AM +0200, Petr Vobornik wrote: On 08/13/2015 05:28 AM, Fraser Tweedale wrote: On Wed, Aug 12, 2015

Re: [Freeipa-devel] [PATCH] Added try/except for error handling ipautil

2015-08-14 Thread Martin Basti
On 08/14/2015 06:57 AM, Abhijeet Kasurde wrote: On 08/13/2015 07:08 PM, Martin Basti wrote: On 08/10/2015 01:47 PM, Abhijeet Kasurde wrote: Hi All, This patch fixes bug - https://fedorahosted.org/freeipa/ticket/3406 Thanks, Abhijeet Kasurde Hello, thank you for the patch 1) -

Re: [Freeipa-devel] Topology Plugin design questions

2015-08-14 Thread Petr Vobornik
On 08/14/2015 08:26 AM, Oleg Fayans wrote: The problem of current implementation of topologysegment-add is that it does not support '--connectivity' commandline option: $ ipa help topologysegment-add Usage: ipa [global-options] topologysegment-add TOPOLOGYSUFFIX NAME [options] Add a new

Re: [Freeipa-devel] Topology Plugin design questions

2015-08-14 Thread Oleg Fayans
The problem of current implementation of topologysegment-add is that it does not support '--connectivity' commandline option: $ ipa help topologysegment-add Usage: ipa [global-options] topologysegment-add TOPOLOGYSUFFIX NAME [options] Add a new segment. Options: -h, --helpshow

Re: [Freeipa-devel] [PATCH 0001] ipa-client-install: warn if IP address is used with --server option

2015-08-14 Thread Martin Basti
On 08/11/2015 10:35 AM, Stanislav Laznicka wrote: Hi, Attached is the patch that adds warning when an IP is passed to --server in ipa-client-install (https://fedorahosted.org/freeipa/ticket/4932). Standa ACK Pushed to: master: 592e437fc79e778cc96603a0f414c3456fcc9455 ipa-4-2:

Re: [Freeipa-devel] [PATCH] First part of integration tests for Topology Plugin

2015-08-14 Thread Oleg Fayans
Hi Martin, Already noticed that. Implemented the named groups as Tomas advised. Added the third test for

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-14 Thread Lenka Doudova
NACK syntax error, missing ')' -from ipatests.util import assert_equal, assert_not_equal, raises +from ipatests.util import ( +assert_equal, assert_not_equal, raises, assert_deepequal I cannot apply this patch, please check it Sorry for the error, corrected patch attached. I also added

Re: [Freeipa-devel] Replace stageuser-add --from-delete with user-undel --to-staged

2015-08-14 Thread Martin Basti
On 08/12/2015 05:21 PM, Martin Basti wrote: On 08/12/2015 02:47 PM, Tomas Capek wrote: On 12/08/15 14:22, Martin Basti wrote: On 08/12/2015 02:08 PM, Tomas Capek wrote: On 12/08/15 13:15, David Kupka wrote: On 12/08/15 12:45, thierry bordaz wrote: On 08/12/2015 12:35 PM, Martin Basti

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-14 Thread Martin Basti
On 08/14/2015 11:04 AM, Lenka Doudova wrote: NACK syntax error, missing ')' -from ipatests.util import assert_equal, assert_not_equal, raises +from ipatests.util import ( +assert_equal, assert_not_equal, raises, assert_deepequal I cannot apply this patch, please check it Sorry for the

Re: [Freeipa-devel] [PATCH 0060] user-undel: Fix error messages.

2015-08-14 Thread Martin Basti
On 08/13/2015 08:17 AM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/5207 Requires patch freeipa-jcholast-471.1. NACK This patch causes internal server error ipa user-del user --preserve [Fri Aug 14 17:16:13.691565 2015] [wsgi:error] [pid 3210] ipa: ERROR: non-public:

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-14 Thread Lenka Doudova
Yes, that is correct - it's malfunctioning behavior of the plugin - command 'stageuser-add --from-delete', which is discussed in another thread. I left this test case for so long as it's not fixed/changed. If the command remains and is fixed, the test case will be valid, if it's changed I'll

Re: [Freeipa-devel] [PATCH 0059] dbus: Create empty dbus.Array with specified signature

2015-08-14 Thread Martin Basti
On 08/10/2015 04:14 PM, David Kupka wrote: I was installing freeipa-server earlier today and it failed with Unable to guess signature from empty list. I was unable to reproduce it but there is now harm in explicitly specifying the signature of the empty list to prevent this issue. ACK

Re: [Freeipa-devel] Topology Plugin design questions

2015-08-14 Thread Oleg Fayans
Hi Petr, Ludwig, On 08/14/2015 09:25 AM, Petr Vobornik wrote: On 08/14/2015 08:26 AM, Oleg Fayans wrote: The problem of current implementation of topologysegment-add is that it does not support '--connectivity' commandline option: $ ipa help topologysegment-add Usage: ipa [global-options]

Re: [Freeipa-devel] [PATCH] 0030 Add permission for bypassing CA ACL enforcement

2015-08-14 Thread Martin Basti
On 08/13/2015 03:48 PM, Martin Babinsky wrote: On 08/13/2015 05:46 AM, Fraser Tweedale wrote: On Tue, Aug 04, 2015 at 03:21:29PM +1000, Fraser Tweedale wrote: The attached patch fixes https://fedorahosted.org/freeipa/ticket/5099. Thanks, Fraser Ping; this patch needs review. ACK