Re: [Freeipa-devel] [PATCH 0093] perform connectivity checks for all topology suffixes during node deletion

2015-11-13 Thread Martin Babinsky
On 11/12/2015 04:24 PM, Martin Babinsky wrote: On 11/12/2015 02:04 PM, Petr Vobornik wrote: On 11/10/2015 05:43 PM, Martin Babinsky wrote: On 11/04/2015 06:50 PM, Petr Vobornik wrote: On 11/04/2015 01:30 PM, Martin Babinsky wrote: On 10/30/2015 05:06 PM, Martin Babinsky wrote: On 10/30/2015

[Freeipa-devel] [PATCH] BUILD: provide check target in custom Makefiles

2015-11-13 Thread Lukas Slebodnik
ehlo, The automake generated makefiles have already a target check. We need to provide this target also to non-generated Makefiles so we can recursively call make check from top level Makefile. LS >From ba0e01bb8dd754b24580615decf54b718ba07b2e Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik

[Freeipa-devel] [PATCH] ipa_kdb_tests: Fix test with default krb5.conf

2015-11-13 Thread Lukas Slebodnik
ehlo, ipa_kdb_tests test failed for me on minimal f23. LS >From ba5ecf13cac1b4822651987ba5db9ed16214cb8f Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Thu, 12 Nov 2015 19:22:56 + Subject: [PATCH 1/8] ipa_kdb_tests: Fix test with default krb5.conf Default

[Freeipa-devel] [PATCHES] Fix few gcc warnings

2015-11-13 Thread Lukas Slebodnik
ehlo, Few simple patches are attached. LS >From e7320a93df1f20e6f29e0a067187e70b41c10ef8 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Thu, 12 Nov 2015 19:25:15 + Subject: [PATCH 2/8] ipa_kdb_tests: Remove unused variables ---

[Freeipa-devel] [PATCH] cmocka_tests: Do not use deprecated cmocka interface

2015-11-13 Thread Lukas Slebodnik
ehlo, The cmocka-1.0 introduced new interface for tests which is not compatible with the old one. And the old interface is deprecated which caused compiled warnings. LS >From 15c7610984f8561bceca2a729fc4cc7e81a1d2b1 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Thu,

[Freeipa-devel] [PATCH 0345 - 0346] Fix DNS test on fedora 23

2015-11-13 Thread Martin Basti
Patches attached. From 982954b2d4b4105d7fafb9b57aa8f5f974679785 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Thu, 12 Nov 2015 17:06:34 +0100 Subject: [PATCH 1/2] Tests: DNS replace 192.0.2.0/24 with 198.18.0.0/15 range 192.0.2.0/24 is IANA reserved address that should

Re: [Freeipa-devel] [PATCH 0338] Drop configure.jar file

2015-11-13 Thread Petr Vobornik
On 11/12/2015 03:31 PM, Martin Basti wrote: 1. following first line should be removed as well: preferences_filename = paths.PREFERENCES_HTML -if ipautil.file_exists(preferences_filename): Which also means that PREFERENCES_HTML won't be used and can be removed. Aaa sorry my

[Freeipa-devel] [PATCH] SPEC: Run cmocka based uni test in %check phase

2015-11-13 Thread Lukas Slebodnik
ehlo, this patch depends on freeipa-lslebodn-0007-BUILD-provide-check-target-in-custom-Makefile.patch LS >From 507b57b4a166b0490d4217a9603a67577bb36036 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 13 Nov 2015 07:11:38 + Subject: [PATCH 8/8] SPEC: Run cmocka

Re: [Freeipa-devel] [PATCH 0093] perform connectivity checks for all topology suffixes during node deletion

2015-11-13 Thread Martin Basti
On 13.11.2015 14:33, Petr Vobornik wrote: On 11/13/2015 10:46 AM, Martin Babinsky wrote: Otherwise it looks OK (not tested yet). I didn't realize that. I have modified the patch accordingly. Attaching updated patch with changed docstring of 'check_last_link_managed()' ACK Pushed

Re: [Freeipa-devel] [Update]Time-Based Account Policies

2015-11-13 Thread Martin Basti
On 13.11.2015 14:41, Simo Sorce wrote: On 11/11/15 09:30, Martin Basti wrote: On 11.11.2015 14:52, Martin Basti wrote: Comments inline Martin^2 On 11.11.2015 09:24, Stanislav Laznicka wrote: On 11/05/2015 06:17 PM, Petr Spacek wrote: On 4.11.2015 15:20, Martin Basti wrote: Hello, we

Re: [Freeipa-devel] [Update]Time-Based Account Policies

2015-11-13 Thread Martin Basti
On 13.11.2015 16:40, Simo Sorce wrote: On 13/11/15 10:17, Martin Basti wrote: On 13.11.2015 14:41, Simo Sorce wrote: On 11/11/15 09:30, Martin Basti wrote: On 11.11.2015 14:52, Martin Basti wrote: Comments inline Martin^2 On 11.11.2015 09:24, Stanislav Laznicka wrote: On 11/05/2015

Re: [Freeipa-devel] [Update]Time-Based Account Policies

2015-11-13 Thread Simo Sorce
On 13/11/15 10:17, Martin Basti wrote: On 13.11.2015 14:41, Simo Sorce wrote: On 11/11/15 09:30, Martin Basti wrote: On 11.11.2015 14:52, Martin Basti wrote: Comments inline Martin^2 On 11.11.2015 09:24, Stanislav Laznicka wrote: On 11/05/2015 06:17 PM, Petr Spacek wrote: On 4.11.2015

Re: [Freeipa-devel] [Update]Time-Based Account Policies

2015-11-13 Thread Simo Sorce
On 13/11/15 11:51, Martin Basti wrote: On 13.11.2015 16:40, Simo Sorce wrote: On 13/11/15 10:17, Martin Basti wrote: On 13.11.2015 14:41, Simo Sorce wrote: On 11/11/15 09:30, Martin Basti wrote: On 11.11.2015 14:52, Martin Basti wrote: Comments inline Martin^2 On 11.11.2015 09:24,

Re: [Freeipa-devel] [PATCHES] Fix few gcc warnings

2015-11-13 Thread Martin Basti
On 13.11.2015 09:32, Lukas Slebodnik wrote: ehlo, Few simple patches are attached. LS ACK Pushed to master: be6ecac220a8182ace0c8b8444cc2ec23bcff214 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to

Re: [Freeipa-devel] [Update]Time-Based Account Policies

2015-11-13 Thread Jakub Hrozek
On Fri, Nov 13, 2015 at 10:40:27AM -0500, Simo Sorce wrote: > On 13/11/15 10:17, Martin Basti wrote: > > > > > >On 13.11.2015 14:41, Simo Sorce wrote: > >>On 11/11/15 09:30, Martin Basti wrote: > >>> > >>> > >>>On 11.11.2015 14:52, Martin Basti wrote: > Comments inline > Martin^2 > >

[Freeipa-devel] [PATCH 0347] Fix CI tests domain_level ENV config

2015-11-13 Thread Martin Basti
Patch attached. Following test should pass: ipa-run-tests test_integration/test_testconfig.py --verbose From 60357332fc24c90e61bfad7b8d05bd8411d37fe3 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Fri, 13 Nov 2015 19:04:41 +0100 Subject: [PATCH] Fix CI tests domain_level

Re: [Freeipa-devel] [PATCH] SPEC: Run cmocka based uni test in %check phase

2015-11-13 Thread Lukas Slebodnik
On (13/11/15 09:37), Lukas Slebodnik wrote: >ehlo, > >this patch depends on >freeipa-lslebodn-0007-BUILD-provide-check-target-in-custom-Makefile.patch > >LS >>From 507b57b4a166b0490d4217a9603a67577bb36036 Mon Sep 17 00:00:00 2001 >From: Lukas Slebodnik >Date: Fri, 13 Nov

Re: [Freeipa-devel] [PATCH 0345 - 0346] Fix DNS test on fedora 23

2015-11-13 Thread Petr Spacek
On 13.11.2015 10:05, Martin Basti wrote: > Patches attached. ACK, test_xmlrpc/test_dns_plugin.py passed when I managed to get though test process and all failures in other modules. -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0345 - 0346] Fix DNS test on fedora 23

2015-11-13 Thread Martin Basti
On 13.11.2015 13:21, Petr Spacek wrote: On 13.11.2015 10:05, Martin Basti wrote: Patches attached. ACK, test_xmlrpc/test_dns_plugin.py passed when I managed to get though test process and all failures in other modules. Pushed to master: b0faf30eac6b75267923fac59ef0728d763d29fe -- Manage

Re: [Freeipa-devel] [PATCH 0338] Drop configure.jar file

2015-11-13 Thread Martin Basti
On 13.11.2015 10:17, Petr Vobornik wrote: On 11/12/2015 03:31 PM, Martin Basti wrote: 1. following first line should be removed as well: preferences_filename = paths.PREFERENCES_HTML -if ipautil.file_exists(preferences_filename): Which also means that PREFERENCES_HTML

Re: [Freeipa-devel] [Update]Time-Based Account Policies

2015-11-13 Thread Simo Sorce
On 11/11/15 09:30, Martin Basti wrote: On 11.11.2015 14:52, Martin Basti wrote: Comments inline Martin^2 On 11.11.2015 09:24, Stanislav Laznicka wrote: On 11/05/2015 06:17 PM, Petr Spacek wrote: On 4.11.2015 15:20, Martin Basti wrote: Hello, we (Standa and I) had offline discussion and

Re: [Freeipa-devel] [PATCH 0093] perform connectivity checks for all topology suffixes during node deletion

2015-11-13 Thread Petr Vobornik
On 11/13/2015 10:46 AM, Martin Babinsky wrote: Otherwise it looks OK (not tested yet). I didn't realize that. I have modified the patch accordingly. Attaching updated patch with changed docstring of 'check_last_link_managed()' ACK -- Petr Vobornik -- Manage your subscription for the