Re: [Freeipa-devel] [PATCH 0022-23] Coverity patches

Reworded the commit messages so that they mention Coverity. On 02/22/2016 07:18 AM, Jan Cholasta wrote: On 2.2.2016 13:36, Stanislav Laznicka wrote: On 02/01/2016 02:24 PM, Jan Cholasta wrote: On 1.2.2016 12:11, Petr Spacek wrote: On 1.2.2016 09:03, Jan Cholasta wrote: Hi, On 29.1.2016

Re: [Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output

On 02/18/2016 03:52 PM, Milan Kubík wrote: On 02/15/2016 04:59 PM, Milan Kubík wrote: Patch attached. Applies on ipa-4-3 as well. Updated version of patch fixes test_old_permission_plugin as well. -- Milan Kubik Review bump. -- Milan Kubik -- Manage your subscription for the

Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology

On 23/02/16 17:54, Martin Basti wrote: On 23.02.2016 17:33, Martin Basti wrote: On 23.02.2016 17:30, Martin Basti wrote: On 18.02.2016 10:14, David Kupka wrote: On 12/02/16 16:52, Martin Basti wrote: On 12.02.2016 13:03, Milan Kubík wrote: On 02/12/2016 10:59 AM, David Kupka wrote:

Re: [Freeipa-devel] [PATCH 0011] Move freeipa certmonger helpers to libexecdir.

On 23/02/16 16:41, Rob Crittenden wrote: David Kupka wrote: On 23/02/16 10:14, Martin Kosek wrote: On 02/23/2016 09:47 AM, David Kupka wrote: On 22/02/16 16:15, Martin Kosek wrote: On 02/22/2016 04:04 PM, Jan Cholasta wrote: On 22.2.2016 15:56, David Kupka wrote: On 22/02/16 07:28, Jan

Re: [Freeipa-devel] [PATCH 0420] Set BuildRequires to pylint 1.4

Lukas Slebodnik wrote: > On (23/02/16 17:09), Martin Basti wrote: >> We cannot guarantee that versions older than 1.4 will work with freeipa code. >> >> Patch attached. > >>From a59e72a0b87231c0f2e0d737057550dd532feed7 Mon Sep 17 00:00:00 2001 >> From: Martin Basti >> Date:

Re: [Freeipa-devel] Locations design v2: LDAP schema & user interface

On 23.2.2016 18:14, Simo Sorce wrote: >> > Petr Vobornik mentioned an important question: >> > Should we care about non-IPA services? >> > >> > IMHO it is a valid point. It complicates things a lot as soon as we start >> > introducing 'locations per service'. It is certainly doable but I would

Re: [Freeipa-devel] [PATCH] 0008 Refactor test_sudocmdgroup_plugin, create SudoCmdGroupTracker

NACK. [root@master2 test_xmlrpc]# pep8 test_sudocmdgroup_plugin.py test_sudocmdgroup_plugin.py:26:80: E501 line too long (80 > 79 characters) test_sudocmdgroup_plugin.py:70:80: E501 line too long (80 > 79 characters) test_sudocmdgroup_plugin.py:76:80: E501 line too long (80 > 79 characters)

Re: [Freeipa-devel] [PATCH 0416-0419] fix broken configuration of sidgen and extdom plugins

On 23.02.2016 17:31, Tomas Babej wrote: On 02/23/2016 01:25 PM, Martin Basti wrote: On 23.02.2016 13:02, Alexander Bokovoy wrote: On Tue, 23 Feb 2016, Martin Basti wrote: From f2ae1bd129a1741500d2f3dcb86a0da553604d15 Mon Sep 17 00:00:00 2001 From: Martin Basti Date:

Re: [Freeipa-devel] Locations design v2: LDAP schema & user interface

On Tue, 2016-02-23 at 18:04 +0100, Petr Spacek wrote: > On 23.2.2016 15:19, Simo Sorce wrote: > > On Tue, 2016-02-23 at 12:43 +0100, Petr Spacek wrote: > >> On 23.2.2016 11:00, Jan Cholasta wrote: > >>> Hi, > >>> > >>> On 19.2.2016 16:31, Simo Sorce wrote: > On Fri, 2016-02-19 at 08:58 +0100,

Re: [Freeipa-devel] Locations design v2: LDAP schema & user interface

On 23.2.2016 15:19, Simo Sorce wrote: > On Tue, 2016-02-23 at 12:43 +0100, Petr Spacek wrote: >> On 23.2.2016 11:00, Jan Cholasta wrote: >>> Hi, >>> >>> On 19.2.2016 16:31, Simo Sorce wrote: On Fri, 2016-02-19 at 08:58 +0100, Petr Spacek wrote: > On 4.2.2016 18:21, Petr Spacek wrote:

Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology

On 23.02.2016 17:33, Martin Basti wrote: On 23.02.2016 17:30, Martin Basti wrote: On 18.02.2016 10:14, David Kupka wrote: On 12/02/16 16:52, Martin Basti wrote: On 12.02.2016 13:03, Milan Kubík wrote: On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This

Re: [Freeipa-devel] [PATCH 0420] Set BuildRequires to pylint 1.4

On (23/02/16 17:09), Martin Basti wrote: >We cannot guarantee that versions older than 1.4 will work with freeipa code. > >Patch attached. >From a59e72a0b87231c0f2e0d737057550dd532feed7 Mon Sep 17 00:00:00 2001 >From: Martin Basti >Date: Tue, 23 Feb 2016 16:58:07 +0100

Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology

On 23.02.2016 17:30, Martin Basti wrote: On 18.02.2016 10:14, David Kupka wrote: On 12/02/16 16:52, Martin Basti wrote: On 12.02.2016 13:03, Milan Kubík wrote: On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This one creates a M groups consisting N (N>=2)

Re: [Freeipa-devel] [PATCH 0416-0419] fix broken configuration of sidgen and extdom plugins

On 02/23/2016 01:25 PM, Martin Basti wrote: > > > On 23.02.2016 13:02, Alexander Bokovoy wrote: >> On Tue, 23 Feb 2016, Martin Basti wrote: >>> From f2ae1bd129a1741500d2f3dcb86a0da553604d15 Mon Sep 17 00:00:00 2001 >>> From: Martin Basti >>> Date: Tue, 23 Feb 2016 10:37:47

Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology

On 18.02.2016 10:14, David Kupka wrote: On 12/02/16 16:52, Martin Basti wrote: On 12.02.2016 13:03, Milan Kubík wrote: On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This one creates a M groups consisting N (N>=2) servers. First two servers in each group are

Re: [Freeipa-devel] [PATCH 0413] fix permission: Read Replication Agreements

On 22.02.2016 09:00, Jan Cholasta wrote: Hi, On 17.2.2016 14:49, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5631 Patch attached (for master, 4.3, 4.2) 1) All the replication agreement permission ACIs should be located in the same entry. Currently "Read Replication

Re: [Freeipa-devel] [PATCH 0414] py3: remove usage of iteritems

On 23.02.2016 17:13, Martin Babinsky wrote: On 02/17/2016 04:54 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5623 Patch attached. ACK Pushed to: master: 697072cac9d94ebd006d6a0f595d7956d38d58b9 ipa-4-3: 93582ac57533b2c2bb3079da2ebc48b67b2c1655 -- Manage your

Re: [Freeipa-devel] [PATCH 0414] py3: remove usage of iteritems

On 02/17/2016 04:54 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5623 Patch attached. ACK -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH 0415] Pylint: disable new pylint checks

On 19.02.2016 13:00, David Kupka wrote: On 17/02/16 18:02, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5615 Disable unwanted or false positive checks. New checks cannot be disabled inline because pylint < 1.5 will report them as errors, thus must be disable globally until we

Re: [Freeipa-devel] [PATCH 0135] upgrade: unconditional import of certificate profiles into LDAP

On 23.2.2016 09:55, Martin Babinsky wrote: On 02/23/2016 07:43 AM, Fraser Tweedale wrote: On Tue, Feb 23, 2016 at 07:32:31AM +0100, Jan Cholasta wrote: On 23.2.2016 06:40, Fraser Tweedale wrote: On Mon, Feb 22, 2016 at 02:03:49PM +0100, Martin Babinsky wrote:

Re: [Freeipa-devel] [PATCH 0011] Move freeipa certmonger helpers to libexecdir.

David Kupka wrote: > On 23/02/16 10:14, Martin Kosek wrote: >> On 02/23/2016 09:47 AM, David Kupka wrote: >>> On 22/02/16 16:15, Martin Kosek wrote: On 02/22/2016 04:04 PM, Jan Cholasta wrote: > On 22.2.2016 15:56, David Kupka wrote: >> On 22/02/16 07:28, Jan Cholasta wrote: >>>

Re: [Freeipa-devel] Locations design v2: LDAP schema & user interface

On 02/19/2016 04:31 PM, Simo Sorce wrote: On Fri, 2016-02-19 at 08:58 +0100, Petr Spacek wrote: On 4.2.2016 18:21, Petr Spacek wrote: On 3.2.2016 18:41, Petr Spacek wrote: Hello, I've updated the design page http://www.freeipa.org/page/V4/DNS_Location_Mechanism Namely it now contains

Re: [Freeipa-devel] [PATCH 0012] Use HTTPD_USER in dogtaginstance.py

On 19.01.2016 13:48, David Kupka wrote: I've converted the diff attached to #5587 by Timo Aaltonen. Works for me, ACK. https://fedorahosted.org/freeipa/ticket/5587 Patch has been pushed to master, original email is probably lost. 67c367d0db194d9afa56ecda34dafb46758d99b5 Use HTTPD_USER in

Re: [Freeipa-devel] [PATCH 0006] Refactor test_hostgroup_plugin

On 22.12.2015 11:57, Filip Skola wrote: And also sending refactored hostgroup plugin test. F bump for review -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH] 811 performance: faster DN implementation

On 22.12.2015 16:59, Petr Spacek wrote: On 14.4.2015 19:32, Petr Vobornik wrote: Pushed to master: 11bd9d96f191066f7ba760549f00179c128a9787 Please be so kind and fix naming. AFAIK the patch refers to 'openldap' DN format but in fact it is python-ldap-ishm. It will surely confuse next

Re: [Freeipa-devel] [PATCH] 0048 Decode HTTP reason phrase as iso-8859-1

On 13.1.2016 08:12, Jan Cholasta wrote: On 8.1.2016 11:56, Fraser Tweedale wrote: On Thu, Jan 07, 2016 at 08:00:51PM +1000, Fraser Tweedale wrote: On Thu, Jan 07, 2016 at 07:56:15AM +0100, Jan Cholasta wrote: Hi, On 6.1.2016 05:26, Fraser Tweedale wrote: Happy new year, all. The attached

[Freeipa-devel] [TESTS][PATCH 0010] WebUI tests - ID views

Hi, attached is patch providing missing test coverage for ID views in webUI. Lenka From 5940a3e7f63b7b6360a28fd52ba6c7df65e4ea98 Mon Sep 17 00:00:00 2001 From: Lenka Doudova Date: Fri, 19 Feb 2016 14:59:19 +0100 Subject: [PATCH] WebUI test: ID views Provides missing test

Re: [Freeipa-devel] Locations design v2: LDAP schema & user interface

On Tue, 2016-02-23 at 12:43 +0100, Petr Spacek wrote: > On 23.2.2016 11:00, Jan Cholasta wrote: > > Hi, > > > > On 19.2.2016 16:31, Simo Sorce wrote: > >> On Fri, 2016-02-19 at 08:58 +0100, Petr Spacek wrote: > >>> On 4.2.2016 18:21, Petr Spacek wrote: > On 3.2.2016 18:41, Petr Spacek wrote:

Re: [Freeipa-devel] [PATCH] 0007 Refactor test_sudocmd_plugin

NACK. Some little changes still required: * fixing the pep8 errors * fixing the wrong comment [root@master2 freeipa]# pep8 ipatests/test_xmlrpc/test_sudocmd_plugin.py ipatests/test_xmlrpc/test_sudocmd_plugin.py:94:80: E501 line too long (87 > 79 characters)

Re: [Freeipa-devel] [PATCH 0011] Move freeipa certmonger helpers to libexecdir.

On 23/02/16 10:14, Martin Kosek wrote: On 02/23/2016 09:47 AM, David Kupka wrote: On 22/02/16 16:15, Martin Kosek wrote: On 02/22/2016 04:04 PM, Jan Cholasta wrote: On 22.2.2016 15:56, David Kupka wrote: On 22/02/16 07:28, Jan Cholasta wrote: On 18.2.2016 10:10, David Kupka wrote: On

Re: [Freeipa-devel] [PATCH 0416-0419] fix broken configuration of sidgen and extdom plugins

On 23.02.2016 13:02, Alexander Bokovoy wrote: On Tue, 23 Feb 2016, Martin Basti wrote: From f2ae1bd129a1741500d2f3dcb86a0da553604d15 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Tue, 23 Feb 2016 10:37:47 +0100 Subject: [PATCH 4/4] fix upgrade: wait for proper DS

Re: [Freeipa-devel] [PATCH 0416-0419] fix broken configuration of sidgen and extdom plugins

On Tue, 23 Feb 2016, Martin Basti wrote: From f2ae1bd129a1741500d2f3dcb86a0da553604d15 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Tue, 23 Feb 2016 10:37:47 +0100 Subject: [PATCH 4/4] fix upgrade: wait for proper DS socket after DS restart Restarting DS executed by

Re: [Freeipa-devel] [PATCH 0416-0419] fix broken configuration of sidgen and extdom plugins

On 22.02.2016 20:11, Martin Basti wrote: On 22.02.2016 19:15, Martin Basti wrote: On 22.02.2016 17:05, Martin Basti wrote: On 19.02.2016 15:02, Alexander Bokovoy wrote: On Fri, 19 Feb 2016, Petr Vobornik wrote: On 02/19/2016 11:12 AM, Alexander Bokovoy wrote: On Fri, 19 Feb 2016,

Re: [Freeipa-devel] Locations design v2: LDAP schema & user interface

On 23.2.2016 11:00, Jan Cholasta wrote: > Hi, > > On 19.2.2016 16:31, Simo Sorce wrote: >> On Fri, 2016-02-19 at 08:58 +0100, Petr Spacek wrote: >>> On 4.2.2016 18:21, Petr Spacek wrote: On 3.2.2016 18:41, Petr Spacek wrote: > Hello, > > I've updated the design page >

Re: [Freeipa-devel] Locations design v2: LDAP schema & user interface

Hi, On 19.2.2016 16:31, Simo Sorce wrote: On Fri, 2016-02-19 at 08:58 +0100, Petr Spacek wrote: On 4.2.2016 18:21, Petr Spacek wrote: On 3.2.2016 18:41, Petr Spacek wrote: Hello, I've updated the design page http://www.freeipa.org/page/V4/DNS_Location_Mechanism Namely it now contains

Re: [Freeipa-devel] [PATCH] 946 webui: fixed showing of success message after password change on login

On 02/18/2016 03:58 PM, Pavel Vomacka wrote: On 02/18/2016 03:56 PM, Petr Vobornik wrote: On 01/20/2016 06:42 PM, Petr Vobornik wrote: similar issue and cause as in https://fedorahosted.org/freeipa/ticket/5567 root cause is that binding triggers validation which clears messages in

Re: [Freeipa-devel] [PATCH] 947 webui: use API call ca_is_enabled instead of enable_ra env variable.

On 02/18/2016 03:59 PM, Pavel Vomacka wrote: On 02/18/2016 03:56 PM, Petr Vobornik wrote: On 01/20/2016 07:02 PM, Petr Vobornik wrote: To be consistent with backend code. https://fedorahosted.org/freeipa/ticket/5622 bump for review Ack. Pushed to: master:

Re: [Freeipa-devel] [PATCH 0011] Move freeipa certmonger helpers to libexecdir.

On 02/23/2016 09:47 AM, David Kupka wrote: > On 22/02/16 16:15, Martin Kosek wrote: >> On 02/22/2016 04:04 PM, Jan Cholasta wrote: >>> On 22.2.2016 15:56, David Kupka wrote: On 22/02/16 07:28, Jan Cholasta wrote: > On 18.2.2016 10:10, David Kupka wrote: >> On 19/01/16 16:10, David

Re: [Freeipa-devel] [TESTS][PATCH 0009] WebUI tests fix

On 02/19/2016 02:53 PM, Lenka Doudova wrote: On 02/19/2016 10:51 AM, Petr Vobornik wrote: On 02/16/2016 10:10 AM, Lenka Doudova wrote: On 02/11/2016 11:13 AM, Lenka Doudova wrote: Hi all, most of webUI tests fail with AssertionError: Can't click on checkbox label: table.table Message:

Re: [Freeipa-devel] [PATCH 0135] upgrade: unconditional import of certificate profiles into LDAP

On 02/23/2016 07:43 AM, Fraser Tweedale wrote: On Tue, Feb 23, 2016 at 07:32:31AM +0100, Jan Cholasta wrote: On 23.2.2016 06:40, Fraser Tweedale wrote: On Mon, Feb 22, 2016 at 02:03:49PM +0100, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5682 -- Martin^3 Babinsky Thanks

Re: [Freeipa-devel] [PATCH 0011] Move freeipa certmonger helpers to libexecdir.

On 22/02/16 16:15, Martin Kosek wrote: On 02/22/2016 04:04 PM, Jan Cholasta wrote: On 22.2.2016 15:56, David Kupka wrote: On 22/02/16 07:28, Jan Cholasta wrote: On 18.2.2016 10:10, David Kupka wrote: On 19/01/16 16:10, David Kupka wrote: On 19/01/16 14:38, Jan Cholasta wrote: On 19.1.2016