Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-01 Thread Oleg Fayans
Hi Martin, On 03/01/2016 07:04 PM, Martin Basti wrote: > > > On 01.03.2016 14:56, Martin Basti wrote: >> >> >> >> On 01.03.2016 12:37, Martin Basti wrote: >>> >>> >>> On 01.03.2016 12:32, Martin Basti wrote: On 29.02.2016 13:16, Oleg Fayans wrote: > Hi all, > >

Re: [Freeipa-devel] [PATCH 0428] SPEC: do not execute upgrade when ipa server is not installed

2016-03-01 Thread Rob Crittenden
Martin Basti wrote: > > > On 01.03.2016 20:13, Rob Crittenden wrote: >> Martin Basti wrote: >>> https://fedorahosted.org/freeipa/ticket/5704 >>> >>> Patch attached. >>> >>> >> Would it be safer to integrate this into ipa-upgrade itself? You'd just >> need to return 0 for the case where IPA isn't

Re: [Freeipa-devel] [PATCH 0428] SPEC: do not execute upgrade when ipa server is not installed

2016-03-01 Thread Rob Crittenden
Martin Basti wrote: > https://fedorahosted.org/freeipa/ticket/5704 > > Patch attached. > > Would it be safer to integrate this into ipa-upgrade itself? You'd just need to return 0 for the case where IPA isn't installed. rob -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [PATCH 0428] SPEC: do not execute upgrade when ipa server is not installed

2016-03-01 Thread Martin Basti
https://fedorahosted.org/freeipa/ticket/5704 Patch attached. From 416ce2c0ab50f80d5d976dfa6a2b9a12975e15fb Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Tue, 1 Mar 2016 18:56:28 +0100 Subject: [PATCH] SPEC: do not run upgrade when ipa server is not installed Running

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-01 Thread Martin Basti
On 01.03.2016 14:56, Martin Basti wrote: On 01.03.2016 12:37, Martin Basti wrote: On 01.03.2016 12:32, Martin Basti wrote: On 29.02.2016 13:16, Oleg Fayans wrote: Hi all, Finally the tests pass. The patch 0024 applies on top of patch 0022 (please, consider reviewing it also).

Re: [Freeipa-devel] [PATCH 0427] fix broken configuration of sidgen and extdom plugins

2016-03-01 Thread Martin Basti
On 01.03.2016 17:14, Martin Basti wrote: On 01.03.2016 17:13, Petr Vobornik wrote: On 03/01/2016 05:02 PM, Martin Basti wrote: On 01.03.2016 16:39, Petr Vobornik wrote: On 02/23/2016 06:15 PM, Martin Basti wrote: On 23.02.2016 17:31, Tomas Babej wrote: On 02/23/2016 01:25 PM,

Re: [Freeipa-devel] [PATCH 0425] pylint: suppress false positive no-member errors

2016-03-01 Thread Martin Basti
On 25.02.2016 17:50, Martin Basti wrote: On 25.02.2016 15:48, Martin Basti wrote: The last pylint 1.5 patch, \o/ https://fedorahosted.org/freeipa/ticket/5615 self-NACK too broad disables Updated patches attached. From 3e99288583f02661ed4875e90a10491948f42564 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH 0416-0419] fix broken configuration of sidgen and extdom plugins

2016-03-01 Thread Petr Vobornik
On 03/01/2016 05:02 PM, Martin Basti wrote: On 01.03.2016 16:39, Petr Vobornik wrote: On 02/23/2016 06:15 PM, Martin Basti wrote: On 23.02.2016 17:31, Tomas Babej wrote: On 02/23/2016 01:25 PM, Martin Basti wrote: On 23.02.2016 13:02, Alexander Bokovoy wrote: On Tue, 23 Feb 2016,

Re: [Freeipa-devel] [python-pytest-multihost] Request to add support to specify username/password for each host

2016-03-01 Thread Petr Viktorin
On 02/29/2016 05:57 PM, Niranjan wrote: > Greetings, > > Attached wrong patch in my last mail. Request to review the patch > attached to this email > Hello, I've generalized the patch a bit to make it use existing host attributes, and I added tests. Could you check if it still works for you?

Re: [Freeipa-devel] [PATCH 0416-0419] fix broken configuration of sidgen and extdom plugins

2016-03-01 Thread Martin Basti
On 01.03.2016 16:39, Petr Vobornik wrote: On 02/23/2016 06:15 PM, Martin Basti wrote: On 23.02.2016 17:31, Tomas Babej wrote: On 02/23/2016 01:25 PM, Martin Basti wrote: On 23.02.2016 13:02, Alexander Bokovoy wrote: On Tue, 23 Feb 2016, Martin Basti wrote: From

Re: [Freeipa-devel] [PATCH 0416-0419] fix broken configuration of sidgen and extdom plugins

2016-03-01 Thread Petr Vobornik
On 02/23/2016 06:15 PM, Martin Basti wrote: On 23.02.2016 17:31, Tomas Babej wrote: On 02/23/2016 01:25 PM, Martin Basti wrote: On 23.02.2016 13:02, Alexander Bokovoy wrote: On Tue, 23 Feb 2016, Martin Basti wrote: From f2ae1bd129a1741500d2f3dcb86a0da553604d15 Mon Sep 17 00:00:00 2001

[Freeipa-devel] [PATCH 0087] Pylint: enable parallelism

2016-03-01 Thread Petr Spacek
Hello, Pylint: enable parallelism The config file specifies 8 cores but Pylint very quickly ends up with 3 cores so do not worry about overwhelming your system. -- Petr^2 Spacek From cf0994b03016ca25ad1774f2b49266eb9abd5acb Mon Sep 17 00:00:00 2001 From: Petr Spacek Date:

Re: [Freeipa-devel] [PATCH 0086] Fix URL for reporting bugs in string

2016-03-01 Thread Tomas Babej
On 03/01/2016 03:23 PM, Petr Spacek wrote: > Hello, > > Fix URL for reporting bugs in strings. > ACK, good catch. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH 0086] Fix URL for reporting bugs in string

2016-03-01 Thread Tomas Babej
On 03/01/2016 03:25 PM, Tomas Babej wrote: > > > On 03/01/2016 03:23 PM, Petr Spacek wrote: >> Hello, >> >> Fix URL for reporting bugs in strings. >> > > ACK, good catch. > Pushed to master: e9922c36b15476f99426d0e85fde857887fb5c7d -- Manage your subscription for the Freeipa-devel mailing

[Freeipa-devel] [PATCH 0086] Fix URL for reporting bugs in string

2016-03-01 Thread Petr Spacek
Hello, Fix URL for reporting bugs in strings. -- Petr^2 Spacek From e3eea4e08be25e92ba07fbe647e6d938a7c416f9 Mon Sep 17 00:00:00 2001 From: Petr Spacek Date: Tue, 1 Mar 2016 15:09:01 +0100 Subject: [PATCH] Fix URL for reporting bugs in strings --- install/po/Makefile.in |

Re: [Freeipa-devel] [TEST][Patch 0022] small refactoring in integration tests due to BZ 1303095

2016-03-01 Thread Milan Kubík
On 02/19/2016 02:11 PM, Oleg Fayans wrote: Hi Milan, On 02/12/2016 04:03 PM, Milan Kubík wrote: Agreed. The latest patch gets rid of all resolv.conf related manipulations. The tests work (where not affected by https://fedorahosted.org/bind-dyndb-ldap/ticket/160) -- Milan Kubik Works for

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-01 Thread Martin Basti
On 01.03.2016 12:37, Martin Basti wrote: On 01.03.2016 12:32, Martin Basti wrote: On 29.02.2016 13:16, Oleg Fayans wrote: Hi all, Finally the tests pass. The patch 0024 applies on top of patch 0022 (please, consider reviewing it also). Besides, the whole functionality depends on

Re: [Freeipa-devel] [PATCH] 0017 configure DNA shared config entry to allow connection with GSSAPI

2016-03-01 Thread Martin Babinsky
On 02/29/2016 05:37 PM, thierry bordaz wrote: On 02/26/2016 05:48 PM, Martin Babinsky wrote: On 02/26/2016 04:24 PM, thierry bordaz wrote: On 02/25/2016 07:17 PM, thierry bordaz wrote: On 02/25/2016 12:03 PM, Martin Babinsky wrote: On 02/24/2016 04:30 PM, thierry bordaz wrote: On 01/21/2016

[Freeipa-devel] [PATCH 0391-0392] Add missing return value checks to pthread operations & replace strcmp(var, "") with strlen(var) to workaround Clang bug 20144

2016-03-01 Thread Petr Spacek
Hello, Add missing return value checks to pthread operations. Detected by clang 3.8 -O2 -Wunused-value. Replace strcmp(var, "") with strlen(var) to workaround Clang bug 20144. https://llvm.org/bugs/show_bug.cgi?id=20144 -- Petr^2 Spacek From ccfcc54d15eee928ac9005f902bc5c79da8360e5 Mon Sep 17

Re: [Freeipa-devel] [PATCH 0390] Fix build with GCC 4.9+

2016-03-01 Thread Petr Spacek
On 1.3.2016 12:06, Lukas Slebodnik wrote: > On (25/02/16 15:57), Petr Spacek wrote: >> On 19.2.2016 13:55, Petr Spacek wrote: >>> Hello, >>> >>> Fix build with GCC 4.9+. >>> >>> GCC 4.9+ is too aggressive when optimizing functions with nonnull >>> attributes. This removes most of asserts() in the

Re: [Freeipa-devel] [PATCH] 952 cookie parser: do not fail on cookie with empty value

2016-03-01 Thread Martin Basti
On 01.03.2016 10:32, Petr Vobornik wrote: Forgot to attach ticket number. https://fedorahosted.org/freeipa/ticket/5709 ACK -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH] 0007 Refactor test_sudocmd_plugin

2016-03-01 Thread Tomas Babej
On 03/01/2016 01:27 PM, Aleš Mareček wrote: > ACK. > Thank you! > - alich - > > - Original Message - >> From: "Filip Skola" >> To: "Aleš Mareček" >> Cc: freeipa-devel@redhat.com, "Milan Kubík" >> Sent: Wednesday, February

Re: [Freeipa-devel] [PATCH] 0008 Refactor test_sudocmdgroup_plugin, create SudoCmdGroupTracker

2016-03-01 Thread Tomas Babej
On 03/01/2016 01:29 PM, Aleš Mareček wrote: > ACK. > Thank you! > > Master push: Make sure it will go *after or together with* the previous patch > from Filip, #0007, thanks! > > - alich - > > - Original Message - >> From: "Filip Skola" >> To: "Aleš Mareček"

Re: [Freeipa-devel] [PATCH 00136] use LDAPS during standalone CA/KRA subsystem deployment

2016-03-01 Thread Tomas Babej
On 02/26/2016 06:03 PM, Martin Babinsky wrote: > This patch fixes https://fedorahosted.org/freeipa/ticket/5570 and also > enables CA installation on CA-less master with hardened dirsrv > configuration. > > When testing I ran into the issue with Dogtag restart during KRA > installation [1] which

[Freeipa-devel] [PATCH] 0007 webui: Add a field for GID in the user add dialog

2016-03-01 Thread Pavel Vomacka
Hi, The patch adds new field in user add dialog. This combo box lists GIDs of posix groups so user can choose one. It is also possible to fill a GID number which is not in the list. Link to the ticket: https://fedorahosted.org/freeipa/ticket/5505 -- Pavel^3 Vomacka >From

Re: [Freeipa-devel] [PATCH] 0008 Refactor test_sudocmdgroup_plugin, create SudoCmdGroupTracker

2016-03-01 Thread Aleš Mareček
ACK. Thank you! Master push: Make sure it will go *after or together with* the previous patch from Filip, #0007, thanks! - alich - - Original Message - > From: "Filip Skola" > To: "Aleš Mareček" > Cc: freeipa-devel@redhat.com, "Milan Kubík"

Re: [Freeipa-devel] [PATCH] 0007 Refactor test_sudocmd_plugin

2016-03-01 Thread Aleš Mareček
ACK. Thank you! - alich - - Original Message - > From: "Filip Skola" > To: "Aleš Mareček" > Cc: freeipa-devel@redhat.com, "Milan Kubík" > Sent: Wednesday, February 24, 2016 8:07:55 PM > Subject: Re: [Freeipa-devel] [PATCH]

Re: [Freeipa-devel] [REVIEW] Intial stab towards Authentication Indicators

2016-03-01 Thread Martin Kosek
On 02/29/2016 11:35 PM, Nathaniel McCallum wrote: On Fri, 2016-02-26 at 09:00 +0100, Martin Kosek wrote: On 02/25/2016 10:51 PM, Simo Sorce wrote: On Thu, 2016-02-25 at 16:13 -0500, Nathaniel McCallum wrote: On Thu, 2016-02-25 at 12:19 -0500, Nathaniel McCallum wrote: On Thu, 2016-02-25

Re: [Freeipa-devel] [PATCH] 953 advise: configure TLS in redhat_nss_pam_ldapd and redhat_nss_ldap plugins

2016-03-01 Thread Tomas Babej
On 03/01/2016 10:36 AM, Petr Vobornik wrote: > On 02/26/2016 03:29 PM, Petr Spacek wrote: >> On 25.2.2016 18:01, Petr Vobornik wrote: >>> I did not add --enableldapstarttls to config_redhat_nss_ldap because >>> I'm not >>> sure if it is present on el5 (IMO it is not). >>> >>> authconfig in: >>>

Re: [Freeipa-devel] [PATCH 200] slapi-nis: update configuration to allow external members

2016-03-01 Thread Tomas Babej
On 02/29/2016 01:07 PM, Tomas Babej wrote: > > > On 02/29/2016 07:19 AM, Jan Cholasta wrote: >> On 26.2.2016 21:38, Lukas Slebodnik wrote: >>> On (26/02/16 12:37), Tomas Babej wrote: On 02/26/2016 07:30 AM, Jan Cholasta wrote: > On 22.2.2016 19:56, Tomas Babej wrote: >>

Re: [Freeipa-devel] [PATCH 016 - 017] First part of the replica promotion tests + testplan

2016-03-01 Thread Martin Basti
On 01.03.2016 12:32, Martin Basti wrote: On 29.02.2016 13:16, Oleg Fayans wrote: Hi all, Finally the tests pass. The patch 0024 applies on top of patch 0022 (please, consider reviewing it also). Besides, the whole functionality depends on Martin's patch N 0421 All patches pass pylint.

Re: [Freeipa-devel] [PATCH 016 - 017] First part of the replica promotion tests + testplan

2016-03-01 Thread Martin Basti
On 29.02.2016 13:16, Oleg Fayans wrote: Hi all, Finally the tests pass. The patch 0024 applies on top of patch 0022 (please, consider reviewing it also). Besides, the whole functionality depends on Martin's patch N 0421 All patches pass pylint. hello, I cannot apply patches on master

Re: [Freeipa-devel] Design: Automatic Empty Zone handling in bind-dyndb-ldap

2016-03-01 Thread Martin Basti
On 19.02.2016 09:11, Petr Spacek wrote: On 12.1.2016 15:10, Martin Basti wrote: On 12.01.2016 15:06, Petr Spacek wrote: On 8.1.2016 18:14, Martin Basti wrote: On 08.01.2016 16:57, Petr Spacek wrote: Hello, recent improvements in FreeIPA 4.3.0 (finally) prevent FreeIPA installer from

Re: [Freeipa-devel] [PATCH 0390] Fix build with GCC 4.9+

2016-03-01 Thread Lukas Slebodnik
On (25/02/16 15:57), Petr Spacek wrote: >On 19.2.2016 13:55, Petr Spacek wrote: >> Hello, >> >> Fix build with GCC 4.9+. >> >> GCC 4.9+ is too aggressive when optimizing functions with nonnull >> attributes. This removes most of asserts() in the plugin. >> GCC 6 adds warnings for these cases. >>

Re: [Freeipa-devel] [PATCH] 953 advise: configure TLS in redhat_nss_pam_ldapd and redhat_nss_ldap plugins

2016-03-01 Thread Petr Vobornik
On 02/26/2016 03:29 PM, Petr Spacek wrote: On 25.2.2016 18:01, Petr Vobornik wrote: I did not add --enableldapstarttls to config_redhat_nss_ldap because I'm not sure if it is present on el5 (IMO it is not). authconfig in: * config_redhat_nss_ldap got * --enableldaptls *

Re: [Freeipa-devel] [PATCH] 952 cookie parser: do not fail on cookie with empty value

2016-03-01 Thread Petr Vobornik
Forgot to attach ticket number. https://fedorahosted.org/freeipa/ticket/5709 -- Petr Vobornik From fc053d348a9414716af7794baa4300209548a4e3 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Tue, 2 Feb 2016 17:04:47 +0100 Subject: [PATCH] cookie parser: do not fail on

[Freeipa-devel] [PATCH] 952 cookie parser: do not fail on cookie with empty value

2016-03-01 Thread Petr Vobornik
-- Petr Vobornik From 39735d51bcf5a35462e7c6b6c67cca02c6ea42ae Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Tue, 2 Feb 2016 17:04:47 +0100 Subject: [PATCH] cookie parser: do not fail on cookie with empty value --- ipapython/cookie.py| 3 ++-