Re: [Freeipa-devel] [PATCHES 0146-0152] Server Roles v2

2016-06-12 Thread Jan Cholasta
On 12.6.2016 17:29, Martin Babinsky wrote: On 06/10/2016 05:42 PM, Martin Babinsky wrote: On 06/10/2016 02:22 PM, Jan Cholasta wrote: On 9.6.2016 17:06, Martin Babinsky wrote: On 06/09/2016 03:54 PM, Petr Vobornik wrote: On 06/09/2016 01:02 PM, Martin Babinsky wrote: On 06/07/2016 07:01 PM,

Re: [Freeipa-devel] [PATCH] 0045-47: webui: Sub-CAs

2016-06-12 Thread Fraser Tweedale
On Fri, Jun 10, 2016 at 04:34:33PM +0200, Pavel Vomacka wrote: > Hello, > > please review these new patches which add WebUI for Sub-CAs. > > https://fedorahosted.org/freeipa/ticket/5939 > Hi Pavel, I have reviewed the functionality of the patches. Functionality is good - a few minor comments

Re: [Freeipa-devel] [Testplan review] Sub CAs

2016-06-12 Thread Fraser Tweedale
On Fri, Jun 10, 2016 at 05:58:02PM +0200, Milan KubĂ­k wrote: > Hi Fraser and list, > > I've wrote a (minimal) draft [1] of the test plan for the Sub CAs feature > and I also have several questions. > > Could you please take a look at it? > > Questions: > > As described in the last (currently)

[Freeipa-devel] [PATCH 0159-0160] emancipate IPA NTP service into role

2016-06-12 Thread Martin Babinsky
These two patches turn oft-neglected ntp service into a full fledged role whose status can be queried centrally. They should also enable generation of location-specific _ntp._udp records. Please note that NTP is LDAP-enabled by additional call after DS instance is configured. I was not

Re: [Freeipa-devel] [PATCH 0153-0158] move ipa-replica-manage del functionality into server-del

2016-06-12 Thread Martin Babinsky
On 06/09/2016 08:12 PM, Martin Babinsky wrote: These patches expand `server_del` to a full fledged IPA master killer in domain level 1. Due to 'server uninstallation removed master from topology' use case, the individual steps are not in the same order as in the original code to facilitate

Re: [Freeipa-devel] [PATCHES 0146-0152] Server Roles v2

2016-06-12 Thread Martin Babinsky
On 06/10/2016 05:42 PM, Martin Babinsky wrote: On 06/10/2016 02:22 PM, Jan Cholasta wrote: On 9.6.2016 17:06, Martin Babinsky wrote: On 06/09/2016 03:54 PM, Petr Vobornik wrote: On 06/09/2016 01:02 PM, Martin Babinsky wrote: On 06/07/2016 07:01 PM, Pavel Vomacka wrote: On 06/07/2016 12:07