Re: [Freeipa-devel] [PATCH 0018] Minor fix in ipa-replica-manage MAN page

2016-07-26 Thread Abhijeet Kasurde
Ping. On 07/13/2016 09:24 AM, Abhijeet Kasurde wrote: Hi All, Please review patch. Fixes: https://fedorahosted.org/freeipa/ticket/6058 -- Thanks, Abhijeet Kasurde IRC: akasurde http://akasurde.github.io -- Thanks, Abhijeet Kasurde IRC: akasurde http://akasurde.github.io -- Manage

Re: [Freeipa-devel] [Test][patch-0053] Forced-client-reenrollment test fixed.

2016-07-26 Thread Martin Babinsky
On 07/26/2016 03:34 PM, Oleg Fayans wrote: Hi Martin, The patch was updated according to your suggestions. A separate patch removing outdated tests is attached. On 07/08/2016 02:10 PM, Martin Basti wrote: On 07.07.2016 08:09, Oleg Fayans wrote: Updated version of the patch is attached with

Re: [Freeipa-devel] [PATCH 0196] baseldap: Fix MidairCollision instantiation during entry modification

2016-07-26 Thread Alexander Bokovoy
On Tue, 26 Jul 2016, Alexander Bokovoy wrote: On Tue, 26 Jul 2016, Martin Babinsky wrote: > Fix for https://fedorahosted.org/freeipa/ticket/6097 > > Since this issue was found during investigation of other ticket[1], you > can test it by performing steps to reproduce #6041, but instead of >

Re: [Freeipa-devel] [PATCH 0196] baseldap: Fix MidairCollision instantiation during entry modification

2016-07-26 Thread Alexander Bokovoy
On Tue, 26 Jul 2016, Martin Babinsky wrote: Fix for https://fedorahosted.org/freeipa/ticket/6097 Since this issue was found during investigation of other ticket[1], you can test it by performing steps to reproduce #6041, but instead of internal error you should see the MidairCollision raised

[Freeipa-devel] [PATCH] 0002 Add client install option to set ipa_backup_server

2016-07-26 Thread Ariel Barria
Hello everyone. I send patch for review. Regards, From 3a27ef5bf3001f5f5ad2e71a4fc76a7a5c104e88 Mon Sep 17 00:00:00 2001 From: "Ariel O. Barria" Date: Tue, 26 Jul 2016 09:32:26 -0500 Subject: [PATCH] freeipa arielb 0002 Add client install option to set

[Freeipa-devel] [PATCH 0196] baseldap: Fix MidairCollision instantiation during entry modification

2016-07-26 Thread Martin Babinsky
Fix for https://fedorahosted.org/freeipa/ticket/6097 Since this issue was found during investigation of other ticket[1], you can test it by performing steps to reproduce #6041, but instead of internal error you should see the MidairCollision raised as public error with the right error

Re: [Freeipa-devel] [PATCH] 0001 six.u function instead of the decode

2016-07-26 Thread Petr Spacek
On 26.7.2016 16:28, Jan Cholasta wrote: > Hi, > > On 26.7.2016 16:09, Martin Basti wrote: >> >> >> On 22.07.2016 00:14, Ariel Barria wrote: >>> Hello everyone. >>> >>> I send patch for review. > > NACK, six.u() is supposed to be used on string literals *only* [1]. > > A proper fix would be

Re: [Freeipa-devel] [PATCH] 0001 six.u function instead of the decode

2016-07-26 Thread Jan Cholasta
Hi, On 26.7.2016 16:09, Martin Basti wrote: On 22.07.2016 00:14, Ariel Barria wrote: Hello everyone. I send patch for review. NACK, six.u() is supposed to be used on string literals *only* [1]. A proper fix would be something like: value = self.to_text() if not isinstance(value,

Re: [Freeipa-devel] [PATCH] 0001 six.u function instead of the decode

2016-07-26 Thread Martin Basti
On 22.07.2016 00:14, Ariel Barria wrote: Hello everyone. I send patch for review. Regards, Thank you, I will look on this, for some reason we received your e-mail just today (2016-07-26) Martin -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [Test][patch-0053] Forced-client-reenrollment test fixed.

2016-07-26 Thread Oleg Fayans
Here is the test output: https://paste.fedoraproject.org/395706/69538081/ On 07/26/2016 03:34 PM, Oleg Fayans wrote: Hi Martin, The patch was updated according to your suggestions. A separate patch removing outdated tests is attached. On 07/08/2016 02:10 PM, Martin Basti wrote: On

Re: [Freeipa-devel] [Test][patch-0053] Forced-client-reenrollment test fixed.

2016-07-26 Thread Oleg Fayans
Hi Martin, The patch was updated according to your suggestions. A separate patch removing outdated tests is attached. On 07/08/2016 02:10 PM, Martin Basti wrote: On 07.07.2016 08:09, Oleg Fayans wrote: Updated version of the patch is attached with the failing tests marked as xfailed

Re: [Freeipa-devel] [PATCH 0553] CI tests: improve log collecting in tests

2016-07-26 Thread Martin Babinsky
On 07/25/2016 06:24 PM, Martin Basti wrote: On 25.07.2016 18:02, Martin Babinsky wrote: On 07/22/2016 06:13 PM, Martin Basti wrote: On 20.07.2016 17:41, Martin Basti wrote: On 19.07.2016 17:05, Martin Basti wrote: On 19.07.2016 16:18, Martin Basti wrote: Patch attached.

[Freeipa-devel] [PATCH] 0001 six.u function instead of the decode

2016-07-26 Thread Ariel Barria
Hello everyone. I send patch for review. Regards, From 7aaf440617963facf7bd156f1e7295562391a3f2 Mon Sep 17 00:00:00 2001 From: "Ariel O. Barria" Date: Thu, 21 Jul 2016 17:06:05 -0500 Subject: [PATCH] freeipa arielb 0001 six.u function instead of the decode function

Re: [Freeipa-devel] [PATCH 0022][Tests] Prevent trust test failures cause by adding duplicate DNS forward zone

2016-07-26 Thread Martin Basti
On 26.07.2016 12:17, Lenka Doudova wrote: On 06/30/2016 01:14 PM, Martin Basti wrote: On 30.06.2016 12:58, Lenka Doudova wrote: On 06/30/2016 12:51 PM, Petr Spacek wrote: On 30.6.2016 12:32, Lenka Doudova wrote: On 06/29/2016 07:49 PM, Petr Spacek wrote: On 29.6.2016 18:52, Lenka

Re: [Freeipa-devel] [PATCH] restrict setkeytab operation

2016-07-26 Thread Simo Sorce
On Mon, 2016-07-25 at 11:26 -0400, Simo Sorce wrote: > On Mon, 2016-07-25 at 11:10 -0400, Rob Crittenden wrote: > > Simo Sorce wrote: > > > On Mon, 2016-07-25 at 10:55 -0400, Rob Crittenden wrote: > > >> Simo Sorce wrote: > > >>> As described in #232 start restricting the use of the setkeytab > >

Re: [Freeipa-devel] [PATCH 0194] harden the check for trust namespace overlap in new principals

2016-07-26 Thread Martin Babinsky
On 07/21/2016 12:56 PM, Martin Babinsky wrote: '*-add-principal' would crash with error if the trusted domains did not have any UPN suffixes or NETBIOS name associated with them. This patch fixes that. Big thanks to Milan who found and reported the issue during writing tests for the feature.

Re: [Freeipa-devel] [PATCH 42-47][tests] RFE: Allow users to authenticate with alternative names

2016-07-26 Thread Martin Babinsky
On 07/25/2016 02:05 PM, Milan Kubík wrote: On 07/25/2016 01:53 PM, Milan Kubík wrote: Hi, I'm sending the tests for kerberos principal aliases rfe. The tests are implemented according to test plan [1] sent earlier. Some of the patches implement modifications and extensions to previous code to

Re: [Freeipa-devel] [PATCH 0022][Tests] Prevent trust test failures cause by adding duplicate DNS forward zone

2016-07-26 Thread Lenka Doudova
On 06/30/2016 01:14 PM, Martin Basti wrote: On 30.06.2016 12:58, Lenka Doudova wrote: On 06/30/2016 12:51 PM, Petr Spacek wrote: On 30.6.2016 12:32, Lenka Doudova wrote: On 06/29/2016 07:49 PM, Petr Spacek wrote: On 29.6.2016 18:52, Lenka Doudova wrote: On 06/29/2016 06:51 PM, Petr

Re: [Freeipa-devel] [PATCH 0003] Fix several small typos

2016-07-26 Thread Martin Basti
On 26.07.2016 11:55, Petr Spacek wrote: On 25.7.2016 17:00, Ben Lipton wrote: On 07/18/2016 04:54 PM, Lukas Slebodnik wrote: On (18/07/16 16:38), Petr Spacek wrote: On 14.7.2016 16:11, Ben Lipton wrote: On 07/14/2016 04:09 AM, Alexander Bokovoy wrote: On Wed, 13 Jul 2016, Ben Lipton

Re: [Freeipa-devel] [PATCH 0003] Fix several small typos

2016-07-26 Thread Petr Spacek
On 25.7.2016 17:00, Ben Lipton wrote: > On 07/18/2016 04:54 PM, Lukas Slebodnik wrote: >> On (18/07/16 16:38), Petr Spacek wrote: >>> On 14.7.2016 16:11, Ben Lipton wrote: On 07/14/2016 04:09 AM, Alexander Bokovoy wrote: > On Wed, 13 Jul 2016, Ben Lipton wrote: >> Nothing too