Re: [Freeipa-devel] [PATCH] 0108 cert-request: raise error when request fails

2016-09-08 Thread Fraser Tweedale
On Thu, Sep 08, 2016 at 01:15:03PM +0200, Martin Babinsky wrote: > On 09/08/2016 04:00 AM, Fraser Tweedale wrote: > > The attached patch fixes regression in cert-request: > > https://fedorahosted.org/freeipa/ticket/6309 > > > > Thanks, > > Fraser > > > > ACK. Does this patch also fix the

[Freeipa-devel] [freeipa PR#62] Configure Anonymous PKINIT on server install (synchronize)

2016-09-08 Thread simo5
simo5's pull request #62: "Configure Anonymous PKINIT on server install" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/62 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/62/head:pr62 git

[Freeipa-devel] [freeipa PR#69] Fix ipa-replica-install with RHEL 6.8 master (opened)

2016-09-08 Thread flo-renaud
flo-renaud's pull request #69: "Fix ipa-replica-install with RHEL 6.8 master" was opened PR body: """ ipa-replica-prepare creates a gpg file containing realm_info/cacert.p12 with the certificates. When run on a RHEL 6.8 instance, cacert.p12 contains twice the same cert (for caSigningCert

[Freeipa-devel] [freeipa PR#67] advise: Use `name` instead of `__name__` to get plugin names (comment)

2016-09-08 Thread martbab
martbab commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/5b9516753cae324126fac7e17b6918c08e210d59 """ See the full comment at https://github.com/freeipa/freeipa/pull/67#issuecomment-245636195 -- Manage your subscription for the Freeipa-devel

[Freeipa-devel] [freeipa PR#60] Tests: extend DNS cmdline tests with lowercased record type (comment)

2016-09-08 Thread martbab
martbab commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/866e59bdcee74ea9aea4e65f193339ae9cab5ce3 ipa-4-4: https://fedorahosted.org/freeipa/changeset/e302886204fbac3f155bf272debeaf3330c99952 """ See the full comment at

[Freeipa-devel] [freeipa PR#67] advise: Use `name` instead of `__name__` to get plugin names (closed)

2016-09-08 Thread martbab
martbab's pull request #67: "advise: Use `name` instead of `__name__` to get plugin names" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/67 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#60] Tests: extend DNS cmdline tests with lowercased record type (closed)

2016-09-08 Thread martbab
mbasti-rh's pull request #60: "Tests: extend DNS cmdline tests with lowercased record type" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/60 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#67] advise: Use `name` instead of `__name__` to get plugin names (+pushed)

2016-09-08 Thread martbab
martbab's pull request #67: "advise: Use `name` instead of `__name__` to get plugin names" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/67 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#68] netgroup: avoid extraneous LDAP search when retrieving primary key from DN (opened)

2016-09-08 Thread martbab
martbab's pull request #68: "netgroup: avoid extraneous LDAP search when retrieving primary key from DN" was opened PR body: """ Fixes https://fedorahosted.org/freeipa/ticket/5855 Please note that the parent method does not correctly handle cases when the attribute considered as primary ked is

Re: [Freeipa-devel] [PATCH] 0108 cert-request: raise error when request fails

2016-09-08 Thread Martin Babinsky
On 09/08/2016 04:00 AM, Fraser Tweedale wrote: The attached patch fixes regression in cert-request: https://fedorahosted.org/freeipa/ticket/6309 Thanks, Fraser ACK. Does this patch also fix the (reopened) https://fedorahosted.org/freeipa/ticket/3473 ? -- Martin^3 Babinsky -- Manage your

[Freeipa-devel] [freeipa PR#67] advise: Use `name` instead of `__name__` to get plugin names (+ack)

2016-09-08 Thread stlaz
martbab's pull request #67: "advise: Use `name` instead of `__name__` to get plugin names" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/67 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#67] advise: Use `name` instead of `__name__` to get plugin names (comment)

2016-09-08 Thread martbab
martbab commented on a pull request """ This change is intended only for master branch and I think a ticket would be a bit overkill. """ See the full comment at https://github.com/freeipa/freeipa/pull/67#issuecomment-245526674 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#67] advise: Use `name` instead of `__name__` to get plugin names (comment)

2016-09-08 Thread stlaz
stlaz commented on a pull request """ Seems to be doing more or less the same but in cleaner manner => LGTM. Do we need a ticket for this? """ See the full comment at https://github.com/freeipa/freeipa/pull/67#issuecomment-245525153 -- Manage your subscription for the Freeipa-devel mailing

[Freeipa-devel] [freeipa PR#19] WebUI: Add 'Restore' option to action dropdown menu (comment)

2016-09-08 Thread martbab
martbab commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/c3374c6e16a10e8780401c58c04dcf8d95ea1a4d ipa-4-4: https://fedorahosted.org/freeipa/changeset/8ac026a22506188815f66a65f9592fee724a6720 """ See the full comment at

[Freeipa-devel] [freeipa PR#19] WebUI: Add 'Restore' option to action dropdown menu (closed)

2016-09-08 Thread martbab
pvomacka's pull request #19: "WebUI: Add 'Restore' option to action dropdown menu" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/19 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#19] WebUI: Add 'Restore' option to action dropdown menu (+pushed)

2016-09-08 Thread martbab
pvomacka's pull request #19: "WebUI: Add 'Restore' option to action dropdown menu" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/19 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#19] WebUI: Add 'Restore' option to action dropdown menu (comment)

2016-09-08 Thread stlaz
stlaz commented on a pull request """ Works as expected, the code looks fine as well. """ See the full comment at https://github.com/freeipa/freeipa/pull/19#issuecomment-245509559 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#19] WebUI: Add 'Restore' option to action dropdown menu (+ack)

2016-09-08 Thread stlaz
pvomacka's pull request #19: "WebUI: Add 'Restore' option to action dropdown menu" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/19 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#60] Tests: extend DNS cmdline tests with lowercased record type (+ack)

2016-09-08 Thread mirielka
mbasti-rh's pull request #60: "Tests: extend DNS cmdline tests with lowercased record type" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/60 -- Manage your subscription for the Freeipa-devel mailing list: