[Freeipa-devel] [freeipa PR#474][comment] Update man page of ipa-server-install

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/474 Title: #474: Update man page of ipa-server-install martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/08b8bfa9b59b30e1bec1fa8c1cfce992dc80c49f """ See the full comment at

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-16 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ I have one very important question: Without ipatests, how are you going to automatically test client-only builds? """ See the full comment at

[Freeipa-devel] [freeipa PR#474][closed] Update man page of ipa-server-install

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/474 Author: Akasurde Title: #474: Update man page of ipa-server-install Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/474/head:pr474 git checkout pr474 -- Manage

[Freeipa-devel] [freeipa PR#474][+pushed] Update man page of ipa-server-install

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/474 Title: #474: Update man page of ipa-server-install Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#475][comment] Add options to run only ipaclient unittests

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/475 Title: #475: Add options to run only ipaclient unittests martbab commented: """ I was thinking that instead of making up more options to test runner we could reorganize the `ipatests/` directory to actually make sense from the consumer's POV,

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop martbab commented: """ Could we use just keep the post command as "kdestroy -c {apache_ccache_path}"? Or is everything chrooted into name-spaced /tmp and we can not access the ccache file

[Freeipa-devel] [freeipa PR#475][comment] Add options to run only ipaclient unittests

2017-02-16 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/475 Title: #475: Add options to run only ipaclient unittests tiran commented: """ PS: I'm not attached to the new of the option. Please speak up if you can come up with a better name than ```--ipaclient-unittests```. """ See the full comment at

[Freeipa-devel] [freeipa PR#475][opened] Add options to run only ipaclient unittests

2017-02-16 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/475 Author: tiran Title: #475: Add options to run only ipaclient unittests Action: opened PR body: """ A new option for ipa-run-tests makes the test runner ignore subdirectories or skips tests that depend on the ipaserver package or on a running

[Freeipa-devel] [freeipa PR#474][+ack] Update man page of ipa-server-install

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/474 Title: #474: Update man page of ipa-server-install Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#474][opened] Update man page of ipa-server-install

2017-02-16 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/474 Author: Akasurde Title: #474: Update man page of ipa-server-install Action: opened PR body: """ This fix adds information about --ignore-last-of-role in ipa-server-install man page Fixes https://fedorahosted.org/freeipa/ticket/6634

[Freeipa-devel] [freeipa PR#473][+ack] Fix session/cookie related issues introduced with the privilege separation patches

2017-02-16 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/473 Title: #473: Fix session/cookie related issues introduced with the privilege separation patches Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-16 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (16/02/17 02:30), Christian Heimes wrote: >Lukas, you are wasting both my and your precious time with a needless >bike-shedding discussion about semantics. The

[Freeipa-devel] [freeipa PR#473][comment] Fix session/cookie related issues introduced with the privilege separation patches

2017-02-16 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/473 Title: #473: Fix session/cookie related issues introduced with the privilege separation patches abbra commented: """ LGTM """ See the full comment at https://github.com/freeipa/freeipa/pull/473#issuecomment-280428547 -- Manage your

[Freeipa-devel] [freeipa PR#473][synchronized] Fix session/cookie related issues introduced with the privilege separation patches

2017-02-16 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/473 Author: simo5 Title: #473: Fix session/cookie related issues introduced with the privilege separation patches Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#473][opened] Fix session/cookie related issues introduced with the privilege separation patches

2017-02-16 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/473 Author: simo5 Title: #473: Fix session/cookie related issues introduced with the privilege separation patches Action: opened PR body: """ Fixes two bugs opened recently about double cookies being returned and ccache removal """ To pull the

[Freeipa-devel] [freeipa PR#454][synchronized] Move AD trust installation code to a separate module

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/454 Author: martbab Title: #454: Move AD trust installation code to a separate module Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/454/head:pr454 git

[Freeipa-devel] [freeipa PR#465][+ack] Tests: search for disabled users

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/465 Title: #465: Tests: search for disabled users Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-16 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop simo5 commented: """ If you request a new keytab you should clean up the cacche ? If we have a way to run the post exec command as the right user and with the right /tmp (httpd unit file

[Freeipa-devel] [freeipa PR#465][comment] Tests: search for disabled users

2017-02-16 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/465 Title: #465: Tests: search for disabled users MartinBasti commented: """ @stlaz That means the any *-find command may work unexpectedly with non-mandratory attribute. For this case you must get all active users by `user-find --disabled=false` +

[Freeipa-devel] [freeipa PR#465][comment] Tests: search for disabled users

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/465 Title: #465: Tests: search for disabled users stlaz commented: """ Does that mean that `user-find` no longer works? """ See the full comment at https://github.com/freeipa/freeipa/pull/465#issuecomment-280374785 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-16 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop MartinBasti commented: """ how about @martbab comment? https://github.com/freeipa/freeipa/pull/468#issuecomment-280056786 > However the restore use-case is not the only one which can

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-16 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop simo5 commented: """ If this is about backup/restore, add a kdestroy ccache in the restore scripts, making sue it su - apache first """ See the full comment at

[Freeipa-devel] [freeipa PR#465][comment] Tests: search for disabled users

2017-02-16 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/465 Title: #465: Tests: search for disabled users MartinBasti commented: """ No because according @HonzaCholasta this is expected framework behavior """ See the full comment at https://github.com/freeipa/freeipa/pull/465#issuecomment-280366327 --

[Freeipa-devel] [freeipa PR#468][synchronized] Remove non-sensical kdestroy on https stop

2017-02-16 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/468 Author: simo5 Title: #468: Remove non-sensical kdestroy on https stop Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/468/head:pr468 git checkout pr468 From

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-16 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop MartinBasti commented: """ @simo5 any ideas how this should be fixed? We cannot push this patch without additional fix of removing outdated ccache because it will cause permanent fail of

[Freeipa-devel] [freeipa PR#396][synchronized] Explicitly remove support of SSLv2

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/396 Author: stlaz Title: #396: Explicitly remove support of SSLv2 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/396/head:pr396 git checkout pr396 From

[Freeipa-devel] [freeipa PR#454][synchronized] Move AD trust installation code to a separate module

2017-02-16 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/454 Author: martbab Title: #454: Move AD trust installation code to a separate module Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/454/head:pr454 git

[Freeipa-devel] [freeipa PR#464][-ack] Bump required python-cryptography version

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/464 Title: #464: Bump required python-cryptography version Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#464][-pushed] Bump required python-cryptography version

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/464 Title: #464: Bump required python-cryptography version Label: -pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#464][synchronized] Bump required python-cryptography version

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/464 Author: stlaz Title: #464: Bump required python-cryptography version Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/464/head:pr464 git checkout pr464 From

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-16 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop simo5 commented: """ @MartinBasti the unit files are the wrong place to destroy ccaches, especially given they run as a different user (root) and may not have access to destroy stuff when

[Freeipa-devel] [freeipa PR#448][synchronized] Tests: Basic coverage with tree root domain

2017-02-16 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/448 Author: gkaihorodova Title: #448: Tests: Basic coverage with tree root domain Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/448/head:pr448 git checkout

[Freeipa-devel] [freeipa PR#464][reopened] Bump required python-cryptography version

2017-02-16 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/464 Author: stlaz Title: #464: Bump required python-cryptography version Action: reopened To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/464/head:pr464 git checkout pr464 --

[Freeipa-devel] [freeipa PR#472][opened] Packaging: Add placeholder packages

2017-02-16 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/472 Author: tiran Title: #472: Packaging: Add placeholder packages Action: opened PR body: """ The ipa and freeipa packages are placeholders to prevent PyPI squashing attacks and reserve the names for future use. `pip install ipa` installs

[Freeipa-devel] [freeipa PR#471][comment] Fix some privilege separation regressions

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/471 Title: #471: Fix some privilege separation regressions stlaz commented: """ Upgrade still fails when run for the first time during `dnf update`: http://pastebin.com/H4kt6hVb When I run it by hand after this failure, it gets a bit further, but

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-16 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ ACK, I'm fine with pushing this PR. `make install` does install ipatests for client-only build, other server-related packages are omitted. Server build work like

[Freeipa-devel] [freeipa PR#443][+rejected] Stronger check for DM password during server install

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/443 Title: #443: Stronger check for DM password during server install Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#443][comment] Stronger check for DM password during server install

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/443 Title: #443: Stronger check for DM password during server install stlaz commented: """ Closing as REJECTED, this will be sorted out in another way. """ See the full comment at https://github.com/freeipa/freeipa/pull/443#issuecomment-280324266

[Freeipa-devel] [freeipa PR#443][closed] Stronger check for DM password during server install

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/443 Author: stlaz Title: #443: Stronger check for DM password during server install Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/443/head:pr443 git checkout pr443

[Freeipa-devel] [freeipa PR#396][comment] Explicitly remove support of SSLv2

2017-02-16 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/396 Title: #396: Explicitly remove support of SSLv2 tomaskrizek commented: """ Please update the commit title and description to make it clear that it also removes support of SSLv3. """ See the full comment at

[Freeipa-devel] [freeipa PR#471][comment] Fix some privilege separation regressions

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/471 Title: #471: Fix some privilege separation regressions stlaz commented: """ LGTM """ See the full comment at https://github.com/freeipa/freeipa/pull/471#issuecomment-280305500 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-16 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ Lukas, you are wasting both my and your precious time with a needless bike-shedding discussion about semantics. The ```--disable-server``` option skips all parts of the

[Freeipa-devel] [freeipa PR#469][reopened] Ignore unlink error in ipa-otpd.socket

2017-02-16 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/469 Author: tiran Title: #469: Ignore unlink error in ipa-otpd.socket Action: reopened To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/469/head:pr469 git checkout pr469 -- Manage

[Freeipa-devel] [freeipa PR#469][comment] Ignore unlink error in ipa-otpd.socket

2017-02-16 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/469 Title: #469: Ignore unlink error in ipa-otpd.socket HonzaCholasta commented: """ This will ignore all errors, not just file does not exist. Are we OK with that? """ See the full comment at

[Freeipa-devel] [freeipa PR#469][closed] Ignore unlink error in ipa-otpd.socket

2017-02-16 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/469 Author: tiran Title: #469: Ignore unlink error in ipa-otpd.socket Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/469/head:pr469 git checkout pr469 -- Manage

[Freeipa-devel] [freeipa PR#471][opened] Fix some privilege separation regressions

2017-02-16 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/471 Author: HonzaCholasta Title: #471: Fix some privilege separation regressions Action: opened PR body: """ **client install: create /etc/ipa/nssdb with correct mode** The NSS database directory is created with mode 640, which causes the IPA

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-16 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (16/02/17 00:57), Christian Heimes wrote: >You are missing the point. Obviously tests are an important part of building. >I can't test the client bits when ipatests

[Freeipa-devel] [freeipa PR#465][comment] Tests: search for disabled users

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/465 Title: #465: Tests: search for disabled users stlaz commented: """ Is there a ticket for the xfail scenario? """ See the full comment at https://github.com/freeipa/freeipa/pull/465#issuecomment-280275823 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#446][edited] Add password file to certutil calls in ipapython.certdb module

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/446 Author: stlaz Title: #446: Add password file to certutil calls in ipapython.certdb module Action: edited Changed field: body Original value: """ With this patchset, ipa-client-install should not ask for NSS database password. Prerequisite:

[Freeipa-devel] [freeipa PR#367][comment] Remove nsslib from IPA

2017-02-16 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Title: #367: Remove nsslib from IPA stlaz commented: """ In the last update I renamed the proposed config option `ca_certfile` to `cacert_store` and made a requirement for it to be absolute path. This was done with possible future changes to it

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-16 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ You are missing the point. Obviously tests are an important part of building. I can't test the client bits when ipatests is not available. Let's do small, incremental

[Freeipa-devel] [freeipa PR#466][+pushed] pkinit: make sure to have proper dictionary for Kerberos instance on upgrade

2017-02-16 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/466 Title: #466: pkinit: make sure to have proper dictionary for Kerberos instance on upgrade Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to

[Freeipa-devel] [freeipa PR#466][closed] pkinit: make sure to have proper dictionary for Kerberos instance on upgrade

2017-02-16 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/466 Author: abbra Title: #466: pkinit: make sure to have proper dictionary for Kerberos instance on upgrade Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#466][comment] pkinit: make sure to have proper dictionary for Kerberos instance on upgrade

2017-02-16 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/466 Title: #466: pkinit: make sure to have proper dictionary for Kerberos instance on upgrade MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/14d84daf29543978c6383da10f4f2d913346f013 """ See the full