[Freeipa-devel] [freeipa PR#714][comment] fix minor typo in ipa-adtrust-install.1

2017-04-24 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/714 Title: #714: fix minor typo in ipa-adtrust-install.1 stlaz commented: """ Thanks, now this is ready to be pushed :) """ See the full comment at https://github.com/freeipa/freeipa/pull/714#issuecomment-296920348 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#714][+ack] fix minor typo in ipa-adtrust-install.1

2017-04-24 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/714 Title: #714: fix minor typo in ipa-adtrust-install.1 Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#694][comment] RFC: implement local PKINIT deployment in server/replica install

2017-04-24 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/694 Title: #694: RFC: implement local PKINIT deployment in server/replica install HonzaCholasta commented: """ @martbab, this sounds like a typical instance of a we will do it later = we will do it never situation. IMO we should remove the

[Freeipa-devel] [freeipa PR#714][comment] fix minor typo in ipa-adtrust-install.1

2017-04-24 Thread realsobek
URL: https://github.com/freeipa/freeipa/pull/714 Title: #714: fix minor typo in ipa-adtrust-install.1 realsobek commented: """ It was my fault. I knew how to squash two unpushed commits, but squashing two pushed commits was beyond me. Thanks for your comment in #716 I had a look again and I

[Freeipa-devel] [freeipa PR#714][synchronized] fix minor typo in ipa-adtrust-install.1

2017-04-24 Thread realsobek
URL: https://github.com/freeipa/freeipa/pull/714 Author: realsobek Title: #714: fix minor typo in ipa-adtrust-install.1 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/714/head:pr714 git checkout pr714

[Freeipa-devel] [freeipa PR#728][opened] ipa-cacert-manage: add --external-ca-type

2017-04-24 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/728 Author: HonzaCholasta Title: #728: ipa-cacert-manage: add --external-ca-type Action: opened PR body: """ **server upgrade: always fix certmonger tracking request** Fix certmonger tracking requests on every run of ipa-server-upgrade rather than

[Freeipa-devel] [freeipa PR#711][+pushed] Compat-plugin related fixes

2017-04-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/711 Title: #711: Compat-plugin related fixes Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#711][comment] Compat-plugin related fixes

2017-04-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/711 Title: #711: Compat-plugin related fixes MartinBasti commented: """ master: * 0c0af8cf7adf61ef03ba1240ecbdecef7fa15275 compat-manage: behave the same for all users * ddbbb1c58e8a4fec8129e7d1e941c54660af6a69 Move the compat plugin setup at the

[Freeipa-devel] [freeipa PR#711][closed] Compat-plugin related fixes

2017-04-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/711 Author: stlaz Title: #711: Compat-plugin related fixes Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/711/head:pr711 git checkout pr711 -- Manage your

[Freeipa-devel] [freeipa PR#727][closed] Regenerate ASN.1 code with asn1c 0.9.28

2017-04-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/727 Author: tiran Title: #727: Regenerate ASN.1 code with asn1c 0.9.28 Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/727/head:pr727 git checkout pr727 -- Manage

[Freeipa-devel] [freeipa PR#727][+pushed] Regenerate ASN.1 code with asn1c 0.9.28

2017-04-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/727 Title: #727: Regenerate ASN.1 code with asn1c 0.9.28 Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#727][comment] Regenerate ASN.1 code with asn1c 0.9.28

2017-04-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/727 Title: #727: Regenerate ASN.1 code with asn1c 0.9.28 MartinBasti commented: """ master: * ad0843047779b55848425eaba0385034d6893446 Regenerate ASN.1 code with asn1c 0.9.28 * 9b443b908fe6fb9c11f9b76552bf4fef2c3b2be5 Replace _BSD_SOURCE with

[Freeipa-devel] [freeipa PR#727][+ack] Regenerate ASN.1 code with asn1c 0.9.28

2017-04-24 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/727 Title: #727: Regenerate ASN.1 code with asn1c 0.9.28 Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#711][+ack] Compat-plugin related fixes

2017-04-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/711 Title: #711: Compat-plugin related fixes Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#720][+ack] tox: use pylint 1.6.x for now

2017-04-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/720 Title: #720: tox: use pylint 1.6.x for now Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#720][synchronized] tox: use pylint 1.6.x for now

2017-04-24 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/720 Author: tiran Title: #720: tox: use pylint 1.6.x for now Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/720/head:pr720 git checkout pr720 From

[Freeipa-devel] [freeipa PR#720][comment] tox: use pylint 1.6.x for now

2017-04-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/720 Title: #720: tox: use pylint 1.6.x for now MartinBasti commented: """ pylint and pylint3 targets are failing ``` MAKEFLAGS= /tmp/freeipa/.tox/pylint2/bin/python -m pip wheel \ --disable-pip-version-check \ --constraint .wheelconstraints \

[Freeipa-devel] [freeipa PR#724][+pushed] upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is…

2017-04-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/724 Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is… Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#724][closed] upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is…

2017-04-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/724 Author: flo-renaud Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is… Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#724][comment] upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is…

2017-04-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/724 Title: #724: upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is… MartinBasti commented: """ master: * 434d9e539d24fe0110c5d6bf4a4342daf40d15d5 upgrade: adtrust update_tdo_gidnumber plugin must check if adtrust is installed

[Freeipa-devel] [bind-dyndb-ldap PR#17][comment] settings: skip unconfigured values

2017-04-24 Thread MartinBasti
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/17 Title: #17: settings: skip unconfigured values MartinBasti commented: """ LGTM """ See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/17#issuecomment-296617030 -- Manage your subscription for the Freeipa-devel

[Freeipa-devel] [freeipa PR#694][comment] RFC: implement local PKINIT deployment in server/replica install

2017-04-24 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/694 Title: #694: RFC: implement local PKINIT deployment in server/replica install martbab commented: """ I have rewritten the PKINIT state reporting code as agreed with @abbra and also re-factored the installation/upgrade logic. @HonzaCholasta also

[Freeipa-devel] [freeipa PR#694][synchronized] RFC: implement local PKINIT deployment in server/replica install

2017-04-24 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/694 Author: martbab Title: #694: RFC: implement local PKINIT deployment in server/replica install Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/694/head:pr694

[Freeipa-devel] [freeipa PR#712][+ack] WebUI: Coverity fixes

2017-04-24 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/712 Title: #712: WebUI: Coverity fixes Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#727][opened] Regenerate ASN.1 code with asn1c 0.9.28

2017-04-24 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/727 Author: tiran Title: #727: Regenerate ASN.1 code with asn1c 0.9.28 Action: opened PR body: """ Regenerate ASN.1 code with asn1c 0.9.28 https://pagure.io/freeipa/issue/6818 """ To pull the PR as Git branch: git remote add ghfreeipa

[Freeipa-devel] [freeipa PR#726][synchronized] Add check for directory name

2017-04-24 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/726 Author: Akasurde Title: #726: Add check for directory name Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/726/head:pr726 git checkout pr726 From

[Freeipa-devel] [freeipa PR#726][comment] Add check for directory name

2017-04-24 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/726 Title: #726: Add check for directory name Akasurde commented: """ @tiran Do you think we should allow only files here ? """ See the full comment at https://github.com/freeipa/freeipa/pull/726#issuecomment-296579941 -- Manage your subscription

[Freeipa-devel] [freeipa PR#714][comment] fix minor typo in ipa-adtrust-install.1

2017-04-24 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/714 Title: #714: fix minor typo in ipa-adtrust-install.1 stlaz commented: """ Ah, I did not notice you made a second commit for this. Please, squash them. """ See the full comment at

[Freeipa-devel] [freeipa PR#714][-ack] fix minor typo in ipa-adtrust-install.1

2017-04-24 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/714 Title: #714: fix minor typo in ipa-adtrust-install.1 Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#726][comment] Add check for directory name

2017-04-24 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/726 Title: #726: Add check for directory name tiran commented: """ What about other types that might cause trouble, e.g. socket, fifo, device files, dangling symlinks? """ See the full comment at

[Freeipa-devel] [freeipa PR#689][synchronized] Sort SRV records by priority

2017-04-24 Thread alex-zel
URL: https://github.com/freeipa/freeipa/pull/689 Author: alex-zel Title: #689: Sort SRV records by priority Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/689/head:pr689 git checkout pr689 From

[Freeipa-devel] [freeipa PR#716][comment] Fix minor typos

2017-04-24 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/716 Title: #716: Fix minor typos stlaz commented: """ Please, see what `git rebase -i master` will do for you, along with `git commit --amend --author="Author Name "`. """ See the full comment at

[Freeipa-devel] [freeipa PR#716][comment] Fix minor typos

2017-04-24 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/716 Title: #716: Fix minor typos stlaz commented: """ Please, see what `git rebase -i master` will do for you, along with `git commit --amend --author="Author Name "`. **edit:** I see a lot of confusion in your commits in this

[Freeipa-devel] [freeipa PR#716][comment] Fix minor typos

2017-04-24 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/716 Title: #716: Fix minor typos stlaz commented: """ Please, see what `git rebase -i master` will do for you. """ See the full comment at https://github.com/freeipa/freeipa/pull/716#issuecomment-296531382 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#716][comment] Fix minor typos

2017-04-24 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/716 Title: #716: Fix minor typos stlaz commented: """ Please, see what `git rebase -i master` will do for you. """ See the full comment at https://github.com/freeipa/freeipa/pull/716#issuecomment-296531382 -- Manage your subscription for the