Re: [Freeipa-devel] [PATCH] Framework for custom UI

2010-10-28 Thread Adam Young
On 10/27/2010 11:51 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/97/diff/2/ This patch introduces a new framework for implementing custom UI. It consists of the following classes: Main: - IPA: global namespace and object

Re: [Freeipa-devel] [PATCH] Dialog boxes for AJAX, HTTP, and IPA errors.

2010-10-28 Thread Adam Young
On 10/28/2010 11:02 AM, Endi Sukma Dewata wrote: On 10/19/2010 4:28 PM, Endi Sukma Dewata wrote: https://fedorahosted.org/reviewboard/r/95/ The ipa_cmd() has been modified to identity the type of the error it has received and display the error using the right dialog box. The dialog box can be

Re: [Freeipa-devel] [PATCH] 587 get effective rights in *-show

2010-10-28 Thread Adam Young
On 10/25/2010 11:03 PM, Rob Crittenden wrote: Add --rights flag to *-show in baseldap so you can retrieve the effective rights to modify the entry you are viewing. The output is a dict of attributes. Each value is a list of rights. It is pretty nasty looking output so I'm only displaying it

Re: [Freeipa-devel] [PATCH] 587 get effective rights in *-show

2010-10-28 Thread Adam Young
On 10/28/2010 01:39 PM, Adam Young wrote: On 10/25/2010 11:03 PM, Rob Crittenden wrote: Add --rights flag to *-show in baseldap so you can retrieve the effective rights to modify the entry you are viewing. The output is a dict of attributes. Each value is a list of rights. It is pretty nasty

Re: [Freeipa-devel] [PATCH] 591 improve error reporting when adding/removing members

2010-10-28 Thread Adam Young
On 10/28/2010 02:43 PM, Rob Crittenden wrote: Return reason for failure when updating group membership fails. We used to return a list of dns that failed to be added. We now return a list of tuples instead. The tuple looks like (dn, reason) where reason is the exception that was returned.

[Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0070-delete-associations.patch

2010-10-28 Thread Adam Young
delete associations Uses code very similar to the search code for deleting associations Only uses the serial means of deletion. While this works for all deletes, it is slower than bulk. From 8620779c9bbfe7f39653da03aeeb20ae0ff5be45 Mon Sep 17 00:00:00 2001 From: Adam Young ayo

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0070-delete-associations.patch

2010-10-29 Thread Adam Young
On 10/28/2010 05:30 PM, Adam Young wrote: On 10/28/2010 05:22 PM, Adam Young wrote: delete associations Uses code very similar to the search code for deleting associations Only uses the serial means of deletion. While this works for all deletes, it is slower than bulk

Re: [Freeipa-devel] [PATCH] 592 Implement nested netgroups

2010-10-29 Thread Adam Young
On 10/29/2010 11:36 AM, Rob Crittenden wrote: Implement nested netgroups and include summaries for the commands. Replace the existing netgroup test cases with Declarative tests. This triples the number of tests we were doing. ticket 209 rob ___

[Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0071-group_remove_memeber.json.patch

2010-10-29 Thread Adam Young
Metadata for testing From cc76c1216d8c2b633183173209aec41228b94c62 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Fri, 29 Oct 2010 13:42:08 -0400 Subject: [PATCH] group_remove_memeber.json meta data for testing and developmemt --- install/static/test/data

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0072-rights-check.patch

2010-11-01 Thread Adam Young
On 10/29/2010 09:31 PM, Endi Sukma Dewata wrote: On 10/29/2010 2:50 PM, Adam Young wrote: Check effective rights. If the right is not explicitly allowed, show the field as read only. It seems to be working, but I think it has to wait until the attributelevelrights is returned in the JSON

[Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0073-Clear-fields-after-add.patch

2010-11-01 Thread Adam Young
For the 'add and add again' useage. From cd57386340acaaf5d168d48942ee19020bb6f3ee Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Mon, 1 Nov 2010 13:42:28 -0400 Subject: [PATCH] Clear fields after add --- install/static/add.js | 22 +++--- 1 files changed, 11

Re: [Freeipa-devel] [PATCH] 0003 Remove reference to ipa_webgui from ipa-server-install man page

2010-11-02 Thread Adam Young
On 11/02/2010 01:38 PM, Jan Zelený wrote: There was a single reference, so I removed it and rephrased the sentence a little. https://fedorahosted.org/freeipa/ticket/330 Jan ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] 0074 jslint cleanup

2010-11-02 Thread Adam Young
While this doesn't fix all of the jslint complaints for ipa.js, it fixes the worst offenders. From be7c71306b15c50b06fdddc9387c80628629fa99 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Mon, 1 Nov 2010 16:32:07 -0400 Subject: [PATCH 74/75] jslint cleanup --- install/static

[Freeipa-devel] patches needing review

2010-11-02 Thread Adam Young
freeipa-admiyo-freeipa-0070-delete-associations.patch freeipa-admiyo-freeipa-0071-group_remove_memeber.json.patch freeipa-admiyo-freeipa-0072-rights-check.patch freeipa-admiyo-freeipa-0073-Clear-fields-after-add.patch freeipa-admiyo-freeipa-0074-jslint-cleanup.patch

[Freeipa-devel] [PATCH] Bulk

2010-11-02 Thread Adam Young
http://localhost:/ipa/json This needs a test, but that will be a follow on patch. From 55c3fb0b401c068b90a0a30a2db457429c1fc35c Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Fri, 22 Oct 2010 15:08:29 -0400 Subject: [PATCH] bulk Allows the user to send multiple commands

Re: [Freeipa-devel] [PATCH] 0074 jslint cleanup

2010-11-03 Thread Adam Young
On 11/03/2010 08:33 AM, Endi Sukma Dewata wrote: On 11/2/2010 2:33 PM, Adam Young wrote: While this doesn't fix all of the jslint complaints for ipa.js, it fixes the worst offenders. Nearly ACKed... is there such thing? :) The IPA and ipa_cmd are defined twice. +var IPA; +var ipa_cmd; +var

Re: [Freeipa-devel] [PATCH] HBAC test data

2010-11-03 Thread Adam Young
On 11/03/2010 08:31 AM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. It can be installed independently from my patch #25-2 (HBAC Details Page). Thanks! https://fedorahosted.org/reviewboard/r/100/ ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] HBAC Details Page

2010-11-03 Thread Adam Young
On 11/03/2010 08:30 AM, Endi Sukma Dewata wrote: On 11/1/2010 12:35 PM, Adam Young wrote: NACK, based on the templating issues we discussed on the phone. TO lay out the issues for other people reading: we previously had a framework like what Endi is proposing here. We found that importing HTML

Re: [Freeipa-devel] [PATCH] HBAC Details Page

2010-11-03 Thread Adam Young
On 11/03/2010 10:48 AM, Adam Young wrote: On 11/03/2010 08:30 AM, Endi Sukma Dewata wrote: On 11/1/2010 12:35 PM, Adam Young wrote: NACK, based on the templating issues we discussed on the phone. TO lay out the issues for other people reading: we previously had a framework like what Endi

Re: [Freeipa-devel] [PATCH] Bulk

2010-11-03 Thread Adam Young
On 11/03/2010 10:35 AM, Rob Crittenden wrote: Adam Young wrote: Joint effort between me and Rob in getting this to work. I've tested it with the following data: [ayo...@ipa freeipa]$ cat ../bulk_request.json {method:bulk,params:[[ {method:json_metadata,params:[[],{}]}, {method:user_find

Re: [Freeipa-devel] [PATCH] 594 display aci components separately

2010-11-03 Thread Adam Young
On 11/03/2010 01:42 PM, Rob Crittenden wrote: Adam Young wrote: On 11/03/2010 11:32 AM, Rob Crittenden wrote: Break out an ACI into components so it is easier to see what it does. This will be needed for UI support. I also filled more supported types and made the List parameter perform

Re: [Freeipa-devel] [PATCH] 0074 jslint cleanup

2010-11-03 Thread Adam Young
On 11/03/2010 01:15 PM, Endi Sukma Dewata wrote: On 11/3/2010 9:10 AM, Adam Young wrote: The IPA and ipa_cmd are defined twice. +var IPA; +var ipa_cmd; +var IPA = ( function () { function ipa_cmd(name, args, options, win_callback, fail_callback, objname) Fixed The duplicate IPA

Re: [Freeipa-devel] [PATCH] HBAC Details Page

2010-11-03 Thread Adam Young
On 11/03/2010 02:43 PM, Endi Sukma Dewata wrote: On 11/3/2010 10:09 AM, Adam Young wrote: A few questions (and tweaks). Note that I have just given the code a read through, not applied the patch yet. Are you sure we want to implement our own Theme code? I'd rather try to keep theme stuff

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0072-rights-check.patch

2010-11-03 Thread Adam Young
On 11/03/2010 12:55 PM, Endi Sukma Dewata wrote: On 11/3/2010 8:53 AM, Adam Young wrote: Still NACK. I have tested this again. It looks like the UI does not send the --rights parameter which is required to get the attributelevelrights. With this patch even the admin can't edit anything. Ah

Re: [Freeipa-devel] [PATCH] 0074 jslint cleanup

2010-11-03 Thread Adam Young
On 11/03/2010 02:20 PM, Adam Young wrote: On 11/03/2010 01:15 PM, Endi Sukma Dewata wrote: On 11/3/2010 9:10 AM, Adam Young wrote: The IPA and ipa_cmd are defined twice. +var IPA; +var ipa_cmd; +var IPA = ( function () { function ipa_cmd(name, args, options, win_callback, fail_callback

Re: [Freeipa-devel] [PATCH] 594 display aci components separately

2010-11-04 Thread Adam Young
On 11/03/2010 02:18 PM, Adam Young wrote: On 11/03/2010 01:42 PM, Rob Crittenden wrote: Adam Young wrote: On 11/03/2010 11:32 AM, Rob Crittenden wrote: Break out an ACI into components so it is easier to see what it does. This will be needed for UI support. I also filled more supported types

Re: [Freeipa-devel] [PATCH] 597 user-enable/disable improvements

2010-11-04 Thread Adam Young
On 11/03/2010 03:34 PM, Rob Crittenden wrote: Always display the account enable/disable status. Don't ignore the exceptions when a user is already enabled or disabled. Fix the exception error messages to use the right terminology. In baseldap when retrieving all attributes include the default

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-0072-3-rights-check.patch

2010-11-05 Thread Adam Young
On 11/05/2010 02:29 PM, Adam Young wrote: REbased, got the links for add and removed chacked as well, and set defautl to 'rsc' ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel A couple

Re: [Freeipa-devel] [PATCH] 598 add rights to LDAPUpdate base class

2010-11-05 Thread Adam Young
On 11/04/2010 10:47 AM, Rob Crittenden wrote: This makes --rights available to all _mod commands. https://fedorahosted.org/freeipa/ticket/437 rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-0072-3-rights-check.patch

2010-11-05 Thread Adam Young
On 11/05/2010 04:42 PM, Adam Young wrote: On 11/05/2010 03:16 PM, Rob Crittenden wrote: Adam Young wrote: On 11/05/2010 02:29 PM, Adam Young wrote: REbased, got the links for add and removed chacked as well, and set defautl to 'rsc' ___ Freeipa

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0075-Ticket-Expiration.patch

2010-11-05 Thread Adam Young
On 11/02/2010 03:35 PM, Adam Young wrote: Ticket Expiration This patch handles Kerberos ticket expiration in the UI. Additionally it removes the mod_auth_kerb authorization for elements in the static directory, cutting down on the number of round trips

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0073-Clear-fields-after-add.patch

2010-11-08 Thread Adam Young
On 11/05/2010 05:25 PM, Endi Sukma Dewata wrote: On 11/3/2010 12:03 PM, Endi Sukma Dewata wrote: On 11/3/2010 8:55 AM, Adam Young wrote: I suspect then that the service add dialog is wrong. This behaviour has been spec'ed and working for a long time. What does it break? The field.setup

[Freeipa-devel] [PATCH] admiyo-0077-Disable-Enable-user

2010-11-08 Thread Adam Young
From 321c0afc7d0998ce120c9c68bb20e4f3672c0c68 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Mon, 8 Nov 2010 12:57:16 -0500 Subject: [PATCH] Disable Enable user UI updated to use the enable and disable methods, and to correctly report them Implementation has a few

Re: [Freeipa-devel] [PATCH] HBAC Access Time

2010-11-08 Thread Adam Young
On 11/08/2010 05:01 PM, Endi Sukma Dewata wrote: On 11/7/2010 7:13 PM, Adam Young wrote: The Time Dialog needs a format. I couldn't guess a value that it would accept. The retry/cancel message is really confusing, too. Tried 1200, 12:00 and 1200-1300. 1. Put in text showing the format. 2

Re: [Freeipa-devel] [PATCH] admiyo-0077-Disable-Enable-user

2010-11-08 Thread Adam Young
On 11/08/2010 06:44 PM, Endi Sukma Dewata wrote: On 11/8/2010 12:01 PM, Adam Young wrote: The functionality works, but there are some issues: 1. The JSON files contain some trailing whitespaces. 2. The server seems to be using true and False for nsaccountlock value. So it might be safer

Re: [Freeipa-devel] [PATCH] admiyo-0077-Disable-Enable-user

2010-11-08 Thread Adam Young
On 11/08/2010 09:04 PM, Endi Sukma Dewata wrote: On 11/8/2010 5:44 PM, Endi Sukma Dewata wrote: The functionality works, but there are some issues: 1. The JSON files contain some trailing whitespaces. 2. The server seems to be using true and False for nsaccountlock value. So it might be

[Freeipa-devel] [PATCH] admiyo-0080-Label-cleanup

2010-11-09 Thread Adam Young
From 011b2db628a8239bf5a8da9989c6c026b6f017a6 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Tue, 9 Nov 2010 14:13:39 -0500 Subject: [PATCH] Label cleanup Also, addeed in the default shell field. --- install/static/user.js | 26 +- 1 files changed

Re: [Freeipa-devel] [PATCH] Add new version of DNS plugin: complete rework with baseldap + unit tests.

2010-11-09 Thread Adam Young
On 11/08/2010 11:07 PM, Pavel Zůna wrote: Finally, there it is. :) I redesigned the whole thing to fit the baseldap model. Here's some example on how it's used: # create zone 'example.com' # ipa dnszone-add example.com --name=ns.example.com --admin=ad...@example.com # create a resource in

Re: [Freeipa-devel] HBAC Service Service Group test data

2010-11-10 Thread Adam Young
On 11/10/2010 06:23 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. This can be installed independently from my patch #28 (HBAC Services). Thanks! https://fedorahosted.org/reviewboard/r/105/ ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] HBAC Service Groups

2010-11-11 Thread Adam Young
On 11/10/2010 08:46 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. This patch requires my patch #28 (HBAC Services). Thanks! The HBAC Service Groups search, details, and association pages have been added under the HBAC tab. New test data files for HBAC Service Groups

Re: [Freeipa-devel] HBAC Service Service Group test data

2010-11-11 Thread Adam Young
On 11/11/2010 12:22 PM, Endi Sukma Dewata wrote: On 11/10/2010 7:18 PM, Adam Young wrote: Please review the attached patch. This can be installed independently from my patch #28 (HBAC Services). Thanks! https://fedorahosted.org/reviewboard/r/105/ You want to make sure the hbac_show.json

[Freeipa-devel] admiyo-0084-buttons-to-action-panel

2010-11-13 Thread Adam Young
From 646b16b92ed2aa9fadca6fc6b850e81bbea056ed Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Sat, 13 Nov 2010 21:34:31 -0500 Subject: [PATCH] buttons to action panel --- install/static/hbac.js |4 ++-- install/static/hbacsvc.js |4 ++-- install/static

Re: [Freeipa-devel] admiyo-0084-buttons-to-action-panel

2010-11-13 Thread Adam Young
On 11/13/2010 09:35 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel As soon as I posted this, I saw an error. This version fixes the broken 'add' button. From

[Freeipa-devel] [PATCH] association buttons to action panel

2010-11-15 Thread Adam Young
Pushed under the one line rule: From dbd823c8d874fc54a3ad8a7061a784a39cea2488 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Mon, 15 Nov 2010 10:03:27 -0500 Subject: [PATCH] Push associate buttons to the action-panel --- install/static/associate.js |4 ++-- 1 files

Re: [Freeipa-devel] [PATCH] HBAC details page enhancement

2010-11-15 Thread Adam Young
On 11/13/2010 11:14 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/107/ The HBAC details page has been enhanced to support Undo and Reset operations. The functionality is implemented in the base widget class so the behavior

Re: [Freeipa-devel] [PATCH] HBAC details page enhancement

2010-11-15 Thread Adam Young
On 11/15/2010 11:00 AM, Adam Young wrote: On 11/15/2010 10:58 AM, Adam Young wrote: On 11/13/2010 11:14 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/107/ The HBAC details page has been enhanced to support Undo and Reset

[Freeipa-devel] [PATCH] dmiyo-0088-HBAC-css-cleanup.

2010-11-15 Thread Adam Young
From e36f0a47317a3b4c185e78e695c35750a3f218cf Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Mon, 15 Nov 2010 13:43:10 -0500 Subject: [PATCH] HBAC css cleanup The additions to the search widget have to go one level deeper, as 'container' has both the action panel

Re: [Freeipa-devel] [PATCH] admiyo-0088-HBAC-css-cleanup.

2010-11-15 Thread Adam Young
On 11/15/2010 01:44 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Rebased on top of 0877-2 From 16cc1e8a9558a9070e40277a08ad6de3cb1e6569 Mon Sep 17 00:00:00 2001

[Freeipa-devel] [PATCH] admiyo-0091-buttons-to-action-panel

2010-11-15 Thread Adam Young
From a975881d4c326a06317a22bd21217938440c20c3 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Mon, 15 Nov 2010 11:32:28 -0500 Subject: [PATCH] buttons to action panel puts the buttons as the top li in the action panel --- install/static/details.js |4 ++-- install/static

[Freeipa-devel] Moving index page from xhtml to html

2010-11-16 Thread Adam Young
Although we currently don't have an requirement to support IE, it seems that IE has a trouble with xhtml. I guess there is no good reason to stay on xhtml: HTML5 will give us validation, and a file in valid html5 format will render in IR. So, in the not-to-distant future, I'll be moving the

[Freeipa-devel] [PATCH] admiyo-0092-action-select

2010-11-17 Thread Adam Young
From c31e4187d00975ff871f1e32249638f899a3ce8e Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Mon, 15 Nov 2010 16:41:21 -0500 Subject: [PATCH] action select if exactly one entity is selected, it enables the entity-facet links in the action panel, and sets the pkey in bbq

[Freeipa-devel] [PATCH] admiyo-0093-CSS-cleanup

2010-11-17 Thread Adam Young
Depends on 0092. From 58a8b432ff1f921d820a348ff5cdb12fb034c545 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Wed, 17 Nov 2010 14:13:33 -0500 Subject: [PATCH] CSS cleanup post UXD discussion --- install/static/Mainnav-background.png | Bin 225 - 233 bytes install/static

Re: [Freeipa-devel] Proposed changes to the HBAC grammar

2010-11-17 Thread Adam Young
On 11/17/2010 04:31 PM, Simo Sorce wrote: On Wed, 17 Nov 2010 16:07:24 -0500 Stephen Gallaghersgall...@redhat.com wrote: This will require two changes to the HBAC schema. First of all, we plan to drop the week-of-the-month concept entirely and replace it with septet-of-the-month. This is

Re: [Freeipa-devel] [PATCH]admiyo-0094-xhtml-to-html

2010-11-17 Thread Adam Young
On 11/17/2010 05:20 PM, Endi Sukma Dewata wrote: On 11/17/2010 2:06 PM, Adam Young wrote: This patch doesn't apply, the index.html is already created in patch #92. OK. Didn't realize I had done that, though it was in another branch. The index.html file is in the right form, though, so

[Freeipa-devel] Plugin to list plugins?

2010-11-17 Thread Adam Young
Is there a server side plugin I can call to list the plugins, or is this login completely contained on the client side now? ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] admiyo-0096-add-button

2010-11-18 Thread Adam Young
https://fedorahosted.org/freeipa/ticket/471 From 16a64eaabe4041a63ccfb2473b1c75c9dbe0a3e0 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Wed, 17 Nov 2010 21:12:55 -0500 Subject: [PATCH] add button the spec had three add buttons: this one is the basic, 'add and then close

Re: [Freeipa-devel] Proposed changes to the HBAC grammar

2010-11-18 Thread Adam Young
On 11/18/2010 07:09 AM, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/17/2010 04:51 PM, Adam Young wrote: On 11/17/2010 04:31 PM, Simo Sorce wrote: On Wed, 17 Nov 2010 16:07:24 -0500 Stephen Gallaghersgall...@redhat.com wrote

Re: [Freeipa-devel] [PATCH] Service and Host Provisioning

2010-11-18 Thread Adam Young
On 11/16/2010 11:52 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/109/ The service and host details pages have been modified to display Kerberos key provisioning status and to provide a way to unprovision. The host

[Freeipa-devel] WebUI status

2010-11-18 Thread Adam Young
To sum up where we are overall, and the dependencies. We have three Entities not yet implemented: Permissions (ACIs) - Spec'ed, but waiting on Backend implementation. SUDO - Not spec'ed, but we can get started based on the HBAC work. Joint effort between edewata and JR Aquino Automount --

Re: [Freeipa-devel] admiyo-0083-super-to-superior

2010-11-18 Thread Adam Young
On 11/13/2010 09:03 PM, Adam Young wrote: super is a keyword in Javascript. This removeds a syntax error that shows up on some browsers. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] Proposed changes to the HBAC grammar

2010-11-18 Thread Adam Young
On 11/18/2010 04:02 PM, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/18/2010 09:55 AM, Dmitri Pal wrote: Steve can you summarize where we are and what we agreed to, please, and identify the questions that we need to answer. Simo, Adam and I had a

[Freeipa-devel] admiyo-0098-env-init

2010-11-18 Thread Adam Young
Example: to find the cert server used, you would do: IPA.env.ra_plugin From 61aaef3542c5f4db0674ffcd591425902ace7367 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Thu, 18 Nov 2010 16:48:23 -0500 Subject: [PATCH] env init call the json rpc 'env' during ipa init and cache

Re: [Freeipa-devel] [PATCH] admiyo-0092-action-select

2010-11-18 Thread Adam Young
On 11/17/2010 01:37 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACKed and pushed to master by edewata ___ Freeipa

[Freeipa-devel] [PATCH] admiyo-0098-env-init

2010-11-18 Thread Adam Young
From 80b651cdf18270d778c141af1fdcb1d86dccd250 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Thu, 18 Nov 2010 16:48:23 -0500 Subject: [PATCH] env init call the json rpc 'env' during ipa init and cache the result --- install/static/ipa.js |6 ++- install

Re: [Freeipa-devel] Proposed changes to the HBAC grammar

2010-11-18 Thread Adam Young
On 11/18/2010 05:27 PM, Dmitri Pal wrote: Adam Young wrote: On 11/18/2010 04:02 PM, Stephen Gallagher wrote: On 11/18/2010 09:55 AM, Dmitri Pal wrote: Steve can you summarize where we are and what we agreed to, please, and identify the questions that we need

Re: [Freeipa-devel] [PATCH] 608 Fix returning effective rights for password policy

2010-11-18 Thread Adam Young
On 11/18/2010 11:22 AM, Rob Crittenden wrote: Password policy needs to update the class of service priority in another entry. Include the CoS attribute when reporting rights. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 0016 Tune directory server

2010-11-18 Thread Adam Young
On 11/17/2010 04:26 PM, Simo Sorce wrote: On Tue, 16 Nov 2010 14:09:58 -0500 Simo Sorcesso...@redhat.com wrote: This patch bumps up the default number of files allowed by default for directory server. This allows more clients and also reserves a bigger number of FDs (at least according to

Re: [Freeipa-devel] [PATCH] 0018 filter lockout attributes from replication

2010-11-18 Thread Adam Young
On 11/17/2010 04:27 PM, Simo Sorce wrote: Fixes #440 Simo. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK and pushed to master ___

Re: [Freeipa-devel] [PATCH] 607 add managedby to hosts

2010-11-18 Thread Adam Young
On 11/18/2010 05:05 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Tue, 09 Nov 2010 14:00:00 -0500 Rob Crittendenrcrit...@redhat.com wrote: + + Add a host that can manage this host's keytab and certificate: + ipa host-add-host --hosts=test2 test I do not want to

Re: [Freeipa-devel] [PATCH] 608 Fix returning effective rights for password policy

2010-11-19 Thread Adam Young
On 11/18/2010 10:04 PM, Rob Crittenden wrote: Adam Young wrote: On 11/18/2010 11:22 AM, Rob Crittenden wrote: Password policy needs to update the class of service priority in another entry. Include the CoS attribute when reporting rights. rob

Re: [Freeipa-devel] [PATCH] 607 add managedby to hosts

2010-11-19 Thread Adam Young
On 11/18/2010 10:06 PM, Rob Crittenden wrote: Adam Young wrote: On 11/18/2010 05:05 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Tue, 09 Nov 2010 14:00:00 -0500 Rob Crittendenrcrit...@redhat.com wrote: + + Add a host that can manage this host's keytab

Re: [Freeipa-devel] [PATCH] 607 add managedby to hosts

2010-11-19 Thread Adam Young
On 11/18/2010 10:06 PM, Rob Crittenden wrote: Adam Young wrote: On 11/18/2010 05:05 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Tue, 09 Nov 2010 14:00:00 -0500 Rob Crittendenrcrit...@redhat.com wrote: + + Add a host that can manage this host's keytab

Re: [Freeipa-devel] [PATCH] 604 revoke certs when disabling and deleting hosts

2010-11-19 Thread Adam Young
On 11/18/2010 05:04 PM, Rob Crittenden wrote: Simo Sorce wrote: On Fri, 05 Nov 2010 15:20:27 -0400 Rob Crittendenrcrit...@redhat.com wrote: When a host is deleted we revoke its certificate, if any. When a host keytab is disabled we disable all the keytabs and revoke the certificates of its

Re: [Freeipa-devel] [PATCH] SUDO Rule Search and Details Pages

2010-11-19 Thread Adam Young
On 11/18/2010 09:33 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! The search and details pages for SUDO Rule have been added. Codes that are shared with HBAC have been moved to rule.js. The following methods were renamed for consistency: - ipa_details_load() -

[Freeipa-devel] [PATCH] admiyo-0099-tab-width

2010-11-19 Thread Adam Young
From e588474b389e4eab171f750fc850868099d490e0 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Fri, 19 Nov 2010 11:40:44 -0500 Subject: [PATCH] tab width fixes the spacing and width for the top and second row of tabs --- install/static/ipa.css | 13 + 1 files

Re: [Freeipa-devel] [PATCH] Sample data for service provisioning

2010-11-19 Thread Adam Young
On 11/19/2010 12:35 AM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK and pushed to master

Re: [Freeipa-devel] [PATCH] Host Enrollment via OTP

2010-11-19 Thread Adam Young
On 11/18/2010 11:50 PM, Endi Sukma Dewata wrote: Hi, Please revie the attached patch. Thanks! The support for host enrollment via one-time-password has been added. When submitted, the OTP will be used to set the host's userpassword. Previously each IPA command can only have one JSON test data

Re: [Freeipa-devel] [PATCH] Use radio buttons for HBAC rule type

2010-11-19 Thread Adam Young
On 11/19/2010 01:00 AM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! To be consistent with the details page, the rule type in the HBAC add dialog box has been converted into radio buttons. ___ Freeipa-devel mailing list

Re: [Freeipa-devel] Proposed changes to the HBAC grammar

2010-11-19 Thread Adam Young
On 11/19/2010 06:33 AM, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/18/2010 06:16 PM, Dmitri Pal wrote: Adam Young wrote: On 11/18/2010 05:27 PM, Dmitri Pal wrote: Adam Young wrote: On 11/18/2010 04:02 PM, Stephen Gallagher wrote

[Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-19 Thread Adam Young
From 2371a5b82d7f3184445bcbba32ca516747bb9c6e Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Fri, 19 Nov 2010 15:57:40 -0500 Subject: [PATCH] top nav index allows links between differnt top level tabs by calculating the index of the top level tab for the target tab

Re: [Freeipa-devel] [PATCH] Added some fields to user object

2010-11-22 Thread Adam Young
On 11/22/2010 09:25 AM, Jan Zelený wrote: Some fields were missing from user object, this change adds them along with their l10n https://fedorahosted.org/freeipa/ticket/305 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-22 Thread Adam Young
On 11/19/2010 06:53 PM, Endi Sukma Dewata wrote: On 11/19/2010 4:09 PM, Adam Young wrote: This will not work with entities that do not have associated tabs, e.g. hbacsvc, hbacsvcgroups, sudocmd, sudocmdgroups. For these entities the IPA.tab_state() will return undefined, so

Re: [Freeipa-devel] [PATCH] 0001 Ensure that Apache is running in Prefork mode

2010-11-22 Thread Adam Young
On 11/15/2010 05:21 AM, Jan Zelený wrote: Jan Zelenyjzel...@redhat.com wrote: Rob Crittendenrcrit...@redhat.com wrote: Jan Zelený wrote: Rob Crittendenrcrit...@redhat.com wrote: Jan Zelený wrote: I tried one other solution, but this approach was

Re: [Freeipa-devel] [PATCH] 0016 Tune directory server

2010-11-22 Thread Adam Young
On 11/18/2010 08:40 PM, Adam Young wrote: On 11/17/2010 04:26 PM, Simo Sorce wrote: On Tue, 16 Nov 2010 14:09:58 -0500 Simo Sorcesso...@redhat.com wrote: This patch bumps up the default number of files allowed by default for directory server. This allows more clients and also reserves

Re: [Freeipa-devel] [PATCH] 0011 Change DNA configuration to use shared configuration

2010-11-22 Thread Adam Young
On 11/19/2010 03:08 PM, Simo Sorce wrote: On Thu, 11 Nov 2010 19:51:23 -0500 Simo Sorcesso...@redhat.com wrote: With this patch 2 changes are introduced. 1. idranges are unified, the --uidstart and --gistart options are removed and instead --idtsrat and --idmax are provided at install

Re: [Freeipa-devel] [PATCH] SUDO Rule Search and Details Pages

2010-11-22 Thread Adam Young
On 11/19/2010 12:21 PM, Endi Sukma Dewata wrote: On 11/19/2010 11:18 AM, Dmitri Pal wrote: Endi Sukma Dewata wrote: On 11/19/2010 10:22 AM, Adam Young wrote: ACK. However, you will need to rebase, as Rob already made the index.html addition to ipa.spec.in Thanks. Rebased and pushed

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-23 Thread Adam Young
On 11/23/2010 02:15 PM, Endi Sukma Dewata wrote: On 11/22/2010 10:41 AM, Adam Young wrote: Without reordering things now, I propose we allow for a three level structure in the tab_set. Top level will not be an entity. Second level will be an entity. third level will be a nested entity

Re: [Freeipa-devel] [PATCH] Add new version of DNS plugin: complete rework with baseldap + unit tests.

2010-11-23 Thread Adam Young
On 11/23/2010 09:37 AM, Pavel Zuna wrote: Finally managed to rewrite the DNS plugin again. Sorry, it took so long, we had training in the office and I also had a nasty bug in baseldap.py I couldn't find. Anyway, this version has it all: - changes we agreed on meeting, the resource abstraction

Re: [Freeipa-devel] [PATCH] Generate better DuplicateEntry error message in LDAPCreate.

2010-11-23 Thread Adam Young
On 11/23/2010 09:39 AM, Pavel Zuna wrote: DuplicateEntry error messages generated by LDAPCreate are now detailed like this: ipa: ERROR: user with name testuser already exists Solves ticket #530. It works for everything, not just the objects described in this ticket. Pavel

Re: [Freeipa-devel] [PATCH] Rename parent LDAPObject pkeys in child LDAPObject methods.

2010-11-24 Thread Adam Young
On 11/24/2010 03:48 AM, Pavel Zuna wrote: On 11/19/2010 04:23 PM, Jakub Hrozek wrote: On Tue, Nov 09, 2010 at 04:55:50AM +0100, Pavel Zůna wrote: If the parent and child entries have the same attribute as primary key (such as in the DNS schema), we need to rename the parent key to prevent a

Re: [Freeipa-devel] [PATCH] Add new version of DNS plugin: complete rework with baseldap + unit tests.

2010-11-24 Thread Adam Young
On 11/24/2010 03:46 AM, Pavel Zuna wrote: On 11/24/2010 03:26 AM, Adam Young wrote: On 11/23/2010 09:37 AM, Pavel Zuna wrote: Finally managed to rewrite the DNS plugin again. Sorry, it took so long, we had training in the office and I also had a nasty bug in baseldap.py I couldn't find

Re: [Freeipa-devel] [PATCH] Add new version of DNS plugin: complete rework with baseldap + unit tests.

2010-11-24 Thread Adam Young
On 11/24/2010 10:21 AM, Adam Young wrote: On 11/24/2010 03:46 AM, Pavel Zuna wrote: On 11/24/2010 03:26 AM, Adam Young wrote: On 11/23/2010 09:37 AM, Pavel Zuna wrote: Finally managed to rewrite the DNS plugin again. Sorry, it took so long, we had training in the office and I also had a nasty

[Freeipa-devel] [PATCH] admiyo-0102-action-panel-formatting

2010-11-24 Thread Adam Young
From 9bc3cc9897741ac720747ecd4a3b4d4f31de7232 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Tue, 23 Nov 2010 22:24:50 -0500 Subject: [PATCH] action panel formatting Cleans up the indentation of the action panel Puts the sudo and HBAC entries in a consistent order

[Freeipa-devel] [PATCH] admiyo-0103-navigation-format

2010-11-24 Thread Adam Young
From d0dd106cbc247fb451cdb8f6c4c3d454d914dd38 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Tue, 23 Nov 2010 16:32:17 -0500 Subject: [PATCH] navigation format UXD guidance to cleanup navigation. adjusts the tab font --- install/static/Mainnav-background.png | Bin 233

Re: [Freeipa-devel] [PATCH]admiyo-0094-xhtml-to-html

2010-11-24 Thread Adam Young
On 11/17/2010 08:58 PM, Adam Young wrote: On 11/17/2010 05:20 PM, Endi Sukma Dewata wrote: On 11/17/2010 2:06 PM, Adam Young wrote: This patch doesn't apply, the index.html is already created in patch #92. OK. Didn't realize I had done that, though it was in another branch

[Freeipa-devel] PATCH for whoami

2010-11-24 Thread Adam Young
Pushed under the 1 liner rule From 16b935169c556135dcab2908d102a884f803fda4 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Wed, 24 Nov 2010 16:36:36 -0500 Subject: [PATCH] whoami fix recent changes to the scope mechanism weren't propigated to the whoami call --- ipalib

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-25 Thread Adam Young
Updated version that doesn't break SUDO or HBAC. The third level nesting in the tabs set is only used for this kind of navigation now, but should be used for Action panel shortly. From 2371a5b82d7f3184445bcbba32ca516747bb9c6e Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Fri

[Freeipa-devel] [PATCH] admiyo-0105-action-panel-sibling

2010-11-30 Thread Adam Young
team isn't writing tests for SUDO yet that makes use of the Label field. From 0ed90c1174c03db1cbe8301cff1f6ced435e240e Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Mon, 29 Nov 2010 14:26:55 -0500 Subject: [PATCH] action panel sibling added function to get sibling entities from

Re: [Freeipa-devel] [PATCH] 612 re-implimit permissions

2010-12-01 Thread Adam Young
a620d92d5b24d43aad12dddbef0932e9d49f0328 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Wed, 1 Dec 2010 16:44:44 -0500 Subject: [PATCH] admin determination extends the logic for showing the admin or self service ui to admins by checking for membership in the group admins --- install/static/webui.js | 15

Re: [Freeipa-devel] [PATCH] 612 re-implimit permissions

2010-12-01 Thread Adam Young
On 12/01/2010 05:07 PM, Adam Young wrote: The attached patch is required on top of the changes, as the admin user no longer has any rolegroup, and thus would see the self service api. It should be pushed with this patch. posted the wrong version. THis one checks for presence of the group

<    1   2   3   4   5   6   7   8   9   10   >