[Freeipa-devel] [freeipa PR#789][closed] [4.4] ipaclient: fix missing RPM ownership

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/789
Author: MartinBasti
 Title: #789: [4.4] ipaclient: fix missing RPM ownership
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/789/head:pr789
git checkout pr789
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#789][+pushed] [4.4] ipaclient: fix missing RPM ownership

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/789
Title: #789: [4.4] ipaclient: fix missing RPM ownership

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#789][comment] [4.4] ipaclient: fix missing RPM ownership

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/789
Title: #789: [4.4] ipaclient: fix missing RPM ownership

MartinBasti commented:
"""
ipa-4-4:

* 62cf83808d77ea456e608486c5a9bd28edb3350d ipaclient: fix missing RPM ownership


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/789#issuecomment-301735963
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#787][closed] ipasetup: fix dependencies handling based on python version

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/787
Author: MartinBasti
 Title: #787: ipasetup: fix dependencies handling based on python version
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/787/head:pr787
git checkout pr787
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#787][+pushed] ipasetup: fix dependencies handling based on python version

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/787
Title: #787: ipasetup: fix dependencies handling based on python version

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#787][comment] ipasetup: fix dependencies handling based on python version

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/787
Title: #787: ipasetup: fix dependencies handling based on python version

MartinBasti commented:
"""
master:

* bea7236b9c5a82db5d945a88103c0524a793a8a2 ipasetup: fix dependencies handling 
based on python version


ipa-4-5:

* c49e146a69a66cda894687f39f3d77ff3ad9c33b ipasetup: fix dependencies handling 
based on python version


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/787#issuecomment-301733213
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#785][closed] otptoken-add-yubikey: When --digits not provided use default value

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/785
Author: dkupka
 Title: #785: otptoken-add-yubikey: When --digits not provided use default value
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/785/head:pr785
git checkout pr785
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#785][+pushed] otptoken-add-yubikey: When --digits not provided use default value

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/785
Title: #785: otptoken-add-yubikey: When --digits not provided use default value

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#785][comment] otptoken-add-yubikey: When --digits not provided use default value

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/785
Title: #785: otptoken-add-yubikey: When --digits not provided use default value

MartinBasti commented:
"""
ipa-4-5:

* 749fc90d1fde0d012acb05ba64309f4a6ed63124 otptoken-add-yubikey: When --digits 
not provided use default value


master:

* e415da22f350fbda5b8b341bf2dc5f969cecb84a otptoken-add-yubikey: When --digits 
not provided use default value


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/785#issuecomment-301732673
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#789][edited] ipaclient: fix missing RPM ownership

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/789
Author: MartinBasti
 Title: #789: ipaclient: fix missing RPM ownership
Action: edited

 Changed field: title
Original value:
"""
ipaclient: fix missing RPM ownership
"""

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#789][opened] ipaclient: fix missing RPM ownership

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/789
Author: MartinBasti
 Title: #789: ipaclient: fix missing RPM ownership
Action: opened

PR body:
"""
FreeIPA package should own all subdirectories to work properly with
3rd party packages/plugins.

https://pagure.io/freeipa/issue/6927
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/789/head:pr789
git checkout pr789
From baf01a202b5c4d99c8dd441cab0cb9031526884f Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Wed, 10 May 2017 18:39:22 +0200
Subject: [PATCH] ipaclient: fix missing RPM ownership

FreeIPA package should own all subdirectories to work properly with
3rd party packages/plugins.

https://pagure.io/freeipa/issue/6927
---
 freeipa.spec.in | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 021db96..6c9269a 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -1308,9 +1308,10 @@ fi
 %doc README Contributors.txt
 %license COPYING
 %dir %{python_sitelib}/ipaclient
-%dir %{python_sitelib}/ipaclient/plugins
 %{python_sitelib}/ipaclient/*.py*
+%dir %{python_sitelib}/ipaclient/plugins
 %{python_sitelib}/ipaclient/plugins/*.py*
+%dir %{python_sitelib}/ipaclient/remote_plugins
 %{python_sitelib}/ipaclient/remote_plugins/*.py*
 %{python_sitelib}/ipaclient/remote_plugins/2_*/*.py*
 %{python_sitelib}/ipaclient-*.egg-info
@@ -1323,11 +1324,12 @@ fi
 %doc README Contributors.txt
 %license COPYING
 %dir %{python3_sitelib}/ipaclient
-%dir %{python3_sitelib}/ipaclient/plugins
 %{python3_sitelib}/ipaclient/*.py
 %{python3_sitelib}/ipaclient/__pycache__/*.py*
+%dir %{python3_sitelib}/ipaclient/plugins
 %{python3_sitelib}/ipaclient/plugins/*.py
 %{python3_sitelib}/ipaclient/plugins/__pycache__/*.py*
+%dir %{python3_sitelib}/ipaclient/remote_plugins
 %{python3_sitelib}/ipaclient/remote_plugins/*.py
 %{python3_sitelib}/ipaclient/remote_plugins/__pycache__/*.py*
 %{python3_sitelib}/ipaclient/remote_plugins/2_*/*.py
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#778][+pushed] ipaclient: fix missing RPM ownership

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/778
Title: #778: ipaclient: fix missing RPM ownership

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#778][closed] ipaclient: fix missing RPM ownership

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/778
Author: MartinBasti
 Title: #778: ipaclient: fix missing RPM ownership
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/778/head:pr778
git checkout pr778
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#778][comment] ipaclient: fix missing RPM ownership

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/778
Title: #778: ipaclient: fix missing RPM ownership

MartinBasti commented:
"""
master:

* 374a58fa49adc715d50996571631af37ae16bd64 ipaclient: fix missing RPM ownership


ipa-4-5:

* 5d0975319daa34a16d4163669474af89e987457e ipaclient: fix missing RPM ownership


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/778#issuecomment-301727407
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#775][comment] [4.4 backport] Added plugins directory to ipaclient subpackages

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/775
Title: #775: [4.4 backport] Added plugins directory to ipaclient subpackages

MartinBasti commented:
"""
ipa-4-4:

* d22ac59828cc4339d509804ddb3e2e1da9cfaa20 Added plugins directory to ipaclient 
subpackages


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/775#issuecomment-301716584
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#775][closed] [4.4 backport] Added plugins directory to ipaclient subpackages

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/775
Author: MartinBasti
 Title: #775: [4.4 backport] Added plugins directory to ipaclient subpackages
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/775/head:pr775
git checkout pr775
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#775][+pushed] [4.4 backport] Added plugins directory to ipaclient subpackages

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/775
Title: #775: [4.4 backport] Added plugins directory to ipaclient subpackages

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#776][comment] [4.5 backport] Added plugins directory to ipaclient subpackages

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/776
Title: #776: [4.5 backport] Added plugins directory to ipaclient subpackages

MartinBasti commented:
"""
ipa-4-5:

* 3605f8ba9a2545680cd46ff02c282d03f84bb366 Added plugins directory to ipaclient 
subpackages


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/776#issuecomment-301715202
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#776][+pushed] [4.5 backport] Added plugins directory to ipaclient subpackages

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/776
Title: #776: [4.5 backport] Added plugins directory to ipaclient subpackages

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#776][closed] [4.5 backport] Added plugins directory to ipaclient subpackages

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/776
Author: MartinBasti
 Title: #776: [4.5 backport] Added plugins directory to ipaclient subpackages
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/776/head:pr776
git checkout pr776
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#761][closed] Fixing adding authenticator indicators to host

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/761
Author: felipevolpone
 Title: #761: Fixing adding authenticator indicators to host
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/761/head:pr761
git checkout pr761
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#761][comment] Fixing adding authenticator indicators to host

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/761
Title: #761: Fixing adding authenticator indicators to host

MartinBasti commented:
"""
master:

* d51af28bdbef8386b6d3bde683be2fc5f73b904e Fixing adding authenticator 
indicators to host


ipa-4-5:

* 81ae5f4d655bb052c6c0961760dba34e70dcd3c3 Fixing adding authenticator 
indicators to host


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/761#issuecomment-301713644
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#761][+pushed] Fixing adding authenticator indicators to host

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/761
Title: #761: Fixing adding authenticator indicators to host

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#736][+pushed] Fixing the cert-request command comparing whole email address case-sensitively.

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/736
Title: #736: Fixing the cert-request command comparing whole email address 
case-sensitively.

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#736][closed] Fixing the cert-request command comparing whole email address case-sensitively.

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/736
Author: felipevolpone
 Title: #736: Fixing the cert-request command comparing whole email address 
case-sensitively.
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/736/head:pr736
git checkout pr736
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#736][comment] Fixing the cert-request command comparing whole email address case-sensitively.

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/736
Title: #736: Fixing the cert-request command comparing whole email address 
case-sensitively.

MartinBasti commented:
"""
master:

* d973168e89c7fb5e8c36919b3adb685371e1a3ab Fixing the cert-request comparing 
whole email address case-sensitively.


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/736#issuecomment-301709267
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#689][closed] Sort SRV records by priority

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/689
Author: alex-zel
 Title: #689: Sort SRV records by priority
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/689/head:pr689
git checkout pr689
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#689][comment] Sort SRV records by priority

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/689
Title: #689: Sort SRV records by priority

MartinBasti commented:
"""
master:

* 8ec8e24015df29bae97fa58d1a7ae12d28639d25 Sort SRV records by priority


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/689#issuecomment-301702375
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#689][+pushed] Sort SRV records by priority

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/689
Title: #689: Sort SRV records by priority

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#689][+ack] Sort SRV records by priority

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/689
Title: #689: Sort SRV records by priority

Label: +ack
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#787][opened] ipasetup: fix dependencies handling based on python version

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/787
Author: MartinBasti
 Title: #787: ipasetup: fix dependencies handling based on python version
Action: opened

PR body:
"""
On RHEL system ipasetup is failing:
```
ValueError: (":python_version>='3'", ['pyldap'])
```

Our RHEL re-implementation of setuptools logic should ignore python3
packages when python3 is not available.

https://pagure.io/freeipa/issue/6875
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/787/head:pr787
git checkout pr787
From 04c3936319728494d9992a4cbcdd87d3c4db0765 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Mon, 15 May 2017 18:46:43 +0200
Subject: [PATCH] ipasetup: fix dependencies handling based on python version

On RHEL system ipasetup is failing:
```
ValueError: (":python_version>='3'", ['pyldap'])
```

Our RHEL re-implementation of setuptools logic should ignore python3
packages when python3 is not available.

https://pagure.io/freeipa/issue/6875
---
 ipasetup.py.in | 10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/ipasetup.py.in b/ipasetup.py.in
index 2ad57e2..bd23504 100644
--- a/ipasetup.py.in
+++ b/ipasetup.py.in
@@ -147,10 +147,12 @@ def ipasetup(name, doc, **kwargs):
 continue
 values = setup_kwargs['extras_require'].pop(k)
 req = setup_kwargs.setdefault('install_requires', [])
-if k == ":python_version<'3'" and sys.version_info.major == 2:
-req.extend(values)
-elif k == ":python_version>='3'" and sys.version_info.major >= 3:
-req.extend(values)
+if k == ":python_version<'3'":
+if sys.version_info.major == 2:
+req.extend(values)
+elif k == ":python_version>='3'":
+if sys.version_info.major >= 3:
+req.extend(values)
 else:
 raise ValueError(k, values)
 
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#689][comment] Sort SRV records by priority

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/689
Title: #689: Sort SRV records by priority

MartinBasti commented:
"""
I squashed your commits, please check
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/689#issuecomment-301480548
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#689][synchronized] Sort SRV records by priority

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/689
Author: alex-zel
 Title: #689: Sort SRV records by priority
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/689/head:pr689
git checkout pr689
From 3975c169871b7809a3d422e56b41686fa141de96 Mon Sep 17 00:00:00 2001
From: Alex Zeleznikov 
Date: Tue, 4 Apr 2017 09:42:10 +0300
Subject: [PATCH] Sort SRV records by priority

In some cases where multiple SRV records are present, LDAP and Kerberos records were returned in different order, causing replication issues in a multi master enviorment.

Update ipadiscovery.py
---
 ipaclient/install/ipadiscovery.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ipaclient/install/ipadiscovery.py b/ipaclient/install/ipadiscovery.py
index 46e05c9..c929a35 100644
--- a/ipaclient/install/ipadiscovery.py
+++ b/ipaclient/install/ipadiscovery.py
@@ -17,6 +17,7 @@
 # along with this program.  If not, see .
 #
 
+import operator
 import socket
 
 import six
@@ -493,6 +494,7 @@ def ipadns_search_srv(self, domain, srv_record_name, default_port,
 
 try:
 answers = resolver.query(qname, rdatatype.SRV)
+answers = sorted(answers, key=operator.attrgetter('priority'))
 except DNSException as e:
 root_logger.debug("DNS record not found: %s", e.__class__.__name__)
 answers = []
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#777][closed] ipa-kra-install manpage: document domain-level 1

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/777
Author: flo-renaud
 Title: #777: ipa-kra-install manpage: document domain-level 1
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/777/head:pr777
git checkout pr777
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#777][+pushed] ipa-kra-install manpage: document domain-level 1

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/777
Title: #777: ipa-kra-install manpage: document domain-level 1

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#777][comment] ipa-kra-install manpage: document domain-level 1

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/777
Title: #777: ipa-kra-install manpage: document domain-level 1

MartinBasti commented:
"""
master:

* f3e1efdcf5db5da2c3c42d3d58be172943f20bce ipa-kra-install manpage: document 
domain-level 1


ipa-4-5:

* 72d2e9e4c312576e1a62e210b4e5d9696bc70609 ipa-kra-install manpage: document 
domain-level 1


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/777#issuecomment-300818344
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#779][closed] [master, 4.5] Bump version of ipa.conf file

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/779
Author: dkupka
 Title: #779: [master, 4.5] Bump version of ipa.conf file
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/779/head:pr779
git checkout pr779
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#779][+pushed] [master, 4.5] Bump version of ipa.conf file

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/779
Title: #779: [master, 4.5] Bump version of ipa.conf file

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#779][comment] [master, 4.5] Bump version of ipa.conf file

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/779
Title: #779: [master, 4.5] Bump version of ipa.conf file

MartinBasti commented:
"""
master:

* 9d32e61ba548e7e940f165c0ec8df0b4bfd210bd Bump version of ipa.conf file


ipa-4-5:

* 76e5ac59579f36f28bb247bf3173e95e57ee4af4 Bump version of ipa.conf file


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/779#issuecomment-300816972
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#765][+pushed] [4.5 backport] spec file: bump python-netaddr Requires

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/765
Title: #765: [4.5 backport] spec file: bump python-netaddr Requires

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#765][comment] [4.5 backport] spec file: bump python-netaddr Requires

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/765
Title: #765: [4.5 backport] spec file: bump python-netaddr Requires

MartinBasti commented:
"""
ipa-4-5:

* ecccd6cb843c44093449cc45a7d94bb14fa65513 spec file: bump python-netaddr 
Requires


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/765#issuecomment-300815982
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#765][closed] [4.5 backport] spec file: bump python-netaddr Requires

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/765
Author: MartinBasti
 Title: #765: [4.5 backport] spec file: bump python-netaddr Requires
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/765/head:pr765
git checkout pr765
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#779][+ack] [master, 4.5] Bump version of ipa.conf file

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/779
Title: #779: [master, 4.5] Bump version of ipa.conf file

Label: +ack
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#757][comment] ca, kra install: validate DM password

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/757
Title: #757: ca, kra install: validate DM password

MartinBasti commented:
"""
We have to use `sys.exit()` in this case, because I forgot that CA still uses 
old style installer. Without `sys.exit()` ti will always suggest user to 
uninstall server:

```
Your system may be partly configured.
Run /usr/sbin/ipa-server-install --uninstall to clean up.
```

We don't want to uninstall server due typo in password
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/757#issuecomment-300811680
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#745][comment] tests: add missing dependency iptables

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/745
Title: #745: tests: add missing dependency iptables

MartinBasti commented:
"""
AFAIK nobody complains about this issue except me, and I'm fine with master only
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/745#issuecomment-300766961
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#779][comment] [master, 4.5] Bump version of ipa.conf file

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/779
Title: #779: [master, 4.5] Bump version of ipa.conf file

MartinBasti commented:
"""
Please use ticket https://pagure.io/freeipa/issue/6860 in commit message
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/779#issuecomment-300763946
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#778][opened] ipaclient: fix missing RPM ownership

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/778
Author: MartinBasti
 Title: #778: ipaclient: fix missing RPM ownership
Action: opened

PR body:
"""
FreeIPA package should own all subdirectories to work properly with
3rd party packages/plugins.

https://pagure.io/freeipa/issue/6927
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/778/head:pr778
git checkout pr778
From 53e1325dbf755c36e822d0d45eb714beb481fb4a Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Wed, 10 May 2017 18:39:22 +0200
Subject: [PATCH] ipaclient: fix missing RPM ownership

FreeIPA package should own all subdirectories to work properly with
3rd party packages/plugins.

https://pagure.io/freeipa/issue/6927
---
 freeipa.spec.in | 16 ++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 87ac7c3..0f9952d 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -1409,14 +1409,20 @@ fi
 %doc README.md Contributors.txt
 %license COPYING
 %dir %{python_sitelib}/ipaclient
-%dir %{python_sitelib}/ipaclient/plugins
 %{python_sitelib}/ipaclient/*.py*
+%dir %{python_sitelib}/ipaclient/install
 %{python_sitelib}/ipaclient/install/*.py*
+%dir %{python_sitelib}/ipaclient/plugins
 %{python_sitelib}/ipaclient/plugins/*.py*
+%dir %{python_sitelib}/ipaclient/remote_plugins
 %{python_sitelib}/ipaclient/remote_plugins/*.py*
 %{python_sitelib}/ipaclient/remote_plugins/2_*/*.py*
+%dir %{python_sitelib}/ipaclient/csrgen
+%dir %{python_sitelib}/ipaclient/csrgen/profiles
 %{python_sitelib}/ipaclient/csrgen/profiles/*.json
+%dir %{python_sitelib}/ipaclient/csrgen/rules
 %{python_sitelib}/ipaclient/csrgen/rules/*.json
+%dir %{python_sitelib}/ipaclient/csrgen/templates
 %{python_sitelib}/ipaclient/csrgen/templates/*.tmpl
 %{python_sitelib}/ipaclient-*.egg-info
 
@@ -1428,19 +1434,25 @@ fi
 %doc README.md Contributors.txt
 %license COPYING
 %dir %{python3_sitelib}/ipaclient
-%dir %{python3_sitelib}/ipaclient/plugins
 %{python3_sitelib}/ipaclient/*.py
 %{python3_sitelib}/ipaclient/__pycache__/*.py*
+%dir %{python3_sitelib}/ipaclient/install
 %{python3_sitelib}/ipaclient/install/*.py
 %{python3_sitelib}/ipaclient/install/__pycache__/*.py*
+%dir %{python3_sitelib}/ipaclient/plugins
 %{python3_sitelib}/ipaclient/plugins/*.py
 %{python3_sitelib}/ipaclient/plugins/__pycache__/*.py*
+%dir %{python3_sitelib}/ipaclient/remote_plugins
 %{python3_sitelib}/ipaclient/remote_plugins/*.py
 %{python3_sitelib}/ipaclient/remote_plugins/__pycache__/*.py*
 %{python3_sitelib}/ipaclient/remote_plugins/2_*/*.py
 %{python3_sitelib}/ipaclient/remote_plugins/2_*/__pycache__/*.py*
+%dir %{python3_sitelib}/ipaclient/csrgen
+%dir %{python3_sitelib}/ipaclient/csrgen/profiles
 %{python3_sitelib}/ipaclient/csrgen/profiles/*.json
+%dir %{python3_sitelib}/ipaclient/csrgen/rules
 %{python3_sitelib}/ipaclient/csrgen/rules/*.json
+%dir %{python3_sitelib}/ipaclient/csrgen/templates
 %{python3_sitelib}/ipaclient/csrgen/templates/*.tmpl
 %{python3_sitelib}/ipaclient-*.egg-info
 
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#765][synchronized] [4.5 backport] spec file: bump python-netaddr Requires

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/765
Author: MartinBasti
 Title: #765: [4.5 backport] spec file: bump python-netaddr Requires
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/765/head:pr765
git checkout pr765
From 0d3cf21741dc57c1d8370b49778d08b97949b0e2 Mon Sep 17 00:00:00 2001
From: Jan Cholasta <jchol...@redhat.com>
Date: Tue, 25 Apr 2017 12:13:00 +
Subject: [PATCH] spec file: bump python-netaddr Requires

Bump python-netaddr Requires to the version which has correct private and
reserved IPv4 address ranges.

This fixes DNS server install failure when 0.0.0.0 is entered as a
forwarder.

Backport from: 0784e53f7f8a323acafbbff26a9d1c0276a229b0

https://pagure.io/freeipa/issue/6894
---
 freeipa.spec.in | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 1b3ed15..97e67e4 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -38,6 +38,8 @@
 %if 0%{?rhel}
 # 1.15.1-7: certauth (http://krbdev.mit.edu/rt/Ticket/Display.html?id=8561)
 %global krb5_version 1.15.1-4
+# 0.7.16: https://github.com/drkjam/netaddr/issues/71
+%global python_netaddr_version 0.7.5-8
 # Require 4.6.0-4 which brings RC4 for FIPS + trust fixes to priv. separation
 %global samba_version 4.6.0-4
 %global selinux_policy_version 3.12.1-153
@@ -45,6 +47,8 @@
 %else
 # 1.15.1-7: certauth (http://krbdev.mit.edu/rt/Ticket/Display.html?id=8561)
 %global krb5_version 1.15.1-7
+# 0.7.16: https://github.com/drkjam/netaddr/issues/71
+%global python_netaddr_version 0.7.16
 # Require 4.6.0-4 which brings RC4 for FIPS + trust fixes to priv. separation
 %global samba_version 2:4.6.0-4
 %global selinux_policy_version 3.13.1-158.4
@@ -646,7 +650,7 @@ Requires: pyOpenSSL
 Requires: python >= 2.7.9
 Requires: python-nss >= 0.16
 Requires: python-cryptography >= 1.4
-Requires: python-netaddr
+Requires: python-netaddr >= %{python_netaddr_version}
 Requires: python-libipa_hbac
 Requires: python-qrcode-core >= 5.0.0
 Requires: python-pyasn1
@@ -695,7 +699,7 @@ Requires: keyutils
 Requires: python3-pyOpenSSL
 Requires: python3-nss >= 0.16
 Requires: python3-cryptography >= 1.4
-Requires: python3-netaddr
+Requires: python3-netaddr >= %{python_netaddr_version}
 Requires: python3-libipa_hbac
 Requires: python3-qrcode-core >= 5.0.0
 Requires: python3-pyasn1
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#776][opened] [4.5 backport] Added plugins directory to ipaclient subpackages

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/776
Author: MartinBasti
 Title: #776: [4.5 backport] Added plugins directory to ipaclient subpackages
Action: opened

PR body:
"""
https://pagure.io/freeipa/issue/6927
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/776/head:pr776
git checkout pr776
From bdd7283c655b56decd768731782655c23dff4712 Mon Sep 17 00:00:00 2001
From: Oliver Gutierrez <ogutier...@redhat.com>
Date: Fri, 28 Apr 2017 15:21:49 +0100
Subject: [PATCH] Added plugins directory to ipaclient subpackages

https://pagure.io/freeipa/issue/6927
---
 freeipa.spec.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 1b3ed15..3a5a9b4 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -1404,6 +1404,7 @@ fi
 %doc README.md Contributors.txt
 %license COPYING
 %dir %{python_sitelib}/ipaclient
+%dir %{python_sitelib}/ipaclient/plugins
 %{python_sitelib}/ipaclient/*.py*
 %{python_sitelib}/ipaclient/install/*.py*
 %{python_sitelib}/ipaclient/plugins/*.py*
@@ -1422,6 +1423,7 @@ fi
 %doc README.md Contributors.txt
 %license COPYING
 %dir %{python3_sitelib}/ipaclient
+%dir %{python3_sitelib}/ipaclient/plugins
 %{python3_sitelib}/ipaclient/*.py
 %{python3_sitelib}/ipaclient/__pycache__/*.py*
 %{python3_sitelib}/ipaclient/install/*.py
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#775][edited] Added plugins directory to ipaclient subpackages

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/775
Author: MartinBasti
 Title: #775: Added plugins directory to ipaclient subpackages
Action: edited

 Changed field: title
Original value:
"""
Added plugins directory to ipaclient subpackages
"""

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#775][synchronized] [4.4 backport] Added plugins directory to ipaclient subpackages

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/775
Author: MartinBasti
 Title: #775: [4.4 backport] Added plugins directory to ipaclient subpackages
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/775/head:pr775
git checkout pr775
From be6818287204b62ee9df973b60983611100f8270 Mon Sep 17 00:00:00 2001
From: Oliver Gutierrez <ogutier...@redhat.com>
Date: Fri, 28 Apr 2017 15:21:49 +0100
Subject: [PATCH] Added plugins directory to ipaclient subpackages

https://pagure.io/freeipa/issue/6927
---
 freeipa.spec.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 21f2416..021db96 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -1308,6 +1308,7 @@ fi
 %doc README Contributors.txt
 %license COPYING
 %dir %{python_sitelib}/ipaclient
+%dir %{python_sitelib}/ipaclient/plugins
 %{python_sitelib}/ipaclient/*.py*
 %{python_sitelib}/ipaclient/plugins/*.py*
 %{python_sitelib}/ipaclient/remote_plugins/*.py*
@@ -1322,6 +1323,7 @@ fi
 %doc README Contributors.txt
 %license COPYING
 %dir %{python3_sitelib}/ipaclient
+%dir %{python3_sitelib}/ipaclient/plugins
 %{python3_sitelib}/ipaclient/*.py
 %{python3_sitelib}/ipaclient/__pycache__/*.py*
 %{python3_sitelib}/ipaclient/plugins/*.py
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#775][opened] Added plugins directory to ipaclient subpackages

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/775
Author: MartinBasti
 Title: #775: Added plugins directory to ipaclient subpackages
Action: opened

PR body:
"""
https://pagure.io/freeipa/issue/6927
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/775/head:pr775
git checkout pr775
From c314f0874a72f0056642cb28299aa6132350478c Mon Sep 17 00:00:00 2001
From: Oliver Gutierrez <ogutier...@redhat.com>
Date: Fri, 28 Apr 2017 15:21:49 +0100
Subject: [PATCH] Added plugins directory to paclient subpackages

https://pagure.io/freeipa/issue/6927
---
 freeipa.spec.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 21f2416..021db96 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -1308,6 +1308,7 @@ fi
 %doc README Contributors.txt
 %license COPYING
 %dir %{python_sitelib}/ipaclient
+%dir %{python_sitelib}/ipaclient/plugins
 %{python_sitelib}/ipaclient/*.py*
 %{python_sitelib}/ipaclient/plugins/*.py*
 %{python_sitelib}/ipaclient/remote_plugins/*.py*
@@ -1322,6 +1323,7 @@ fi
 %doc README Contributors.txt
 %license COPYING
 %dir %{python3_sitelib}/ipaclient
+%dir %{python3_sitelib}/ipaclient/plugins
 %{python3_sitelib}/ipaclient/*.py
 %{python3_sitelib}/ipaclient/__pycache__/*.py*
 %{python3_sitelib}/ipaclient/plugins/*.py
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#768][comment] Ticket#6854 caless

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/768
Title: #768: Ticket#6854 caless

MartinBasti commented:
"""
This PR is obsoleted by #769 
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/768#issuecomment-300437510
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#671][+pushed] Slim down dependencies

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/671
Title: #671: Slim down dependencies

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#671][comment] Slim down dependencies

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/671
Title: #671: Slim down dependencies

MartinBasti commented:
"""
master:

* bd5a5012d24820b54cdca2955f5405b84de1178c Slim down dependencies


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/671#issuecomment-300198093
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#671][closed] Slim down dependencies

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/671
Author: tiran
 Title: #671: Slim down dependencies
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/671/head:pr671
git checkout pr671
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#671][+ack] Slim down dependencies

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/671
Title: #671: Slim down dependencies

Label: +ack
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#766][closed] ipa-kra-install: fix check_host_keys

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/766
Author: flo-renaud
 Title: #766: ipa-kra-install: fix check_host_keys
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/766/head:pr766
git checkout pr766
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#766][comment] ipa-kra-install: fix check_host_keys

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/766
Title: #766: ipa-kra-install: fix check_host_keys

MartinBasti commented:
"""
master:

* 8983ce53e3fdee98926f81f3012146e33bb92d30 ipa-kra-install: fix check_host_keys


ipa-4-5:

* b90dce88e227174aa33270beee9b3d6ff51cce59 ipa-kra-install: fix check_host_keys


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/766#issuecomment-300148119
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#766][+pushed] ipa-kra-install: fix check_host_keys

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/766
Title: #766: ipa-kra-install: fix check_host_keys

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#766][+ack] ipa-kra-install: fix check_host_keys

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/766
Title: #766: ipa-kra-install: fix check_host_keys

Label: +ack
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#752][comment] upgrade: add missing DN suffix when enabling KDC proxy

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/752
Title: #752: upgrade: add missing DN suffix when enabling KDC proxy

MartinBasti commented:
"""
master:

* 999706fcdfa7fd4206a2399aa578fb00753d9978 python2-ipalib: add missing python 
dependency
* 4b8ab77dd4800bd9c6b822502462ee649c88c663 installer service: fix typo in 
service entry
* ebefb281775d5bd5f32459ac597af78781d7dbf5 upgrade: add missing suffix to http 
instance


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/752#issuecomment-299518616
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#752][closed] upgrade: add missing DN suffix when enabling KDC proxy

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/752
Author: tomaskrizek
 Title: #752: upgrade: add missing DN suffix when enabling KDC proxy
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/752/head:pr752
git checkout pr752
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#752][+pushed] upgrade: add missing DN suffix when enabling KDC proxy

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/752
Title: #752: upgrade: add missing DN suffix when enabling KDC proxy

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#763][+pushed] Dogtag: fail if instance cannot be (re)started

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/763
Title: #763: Dogtag: fail if instance cannot be (re)started

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#763][comment] Dogtag: fail if instance cannot be (re)started

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/763
Title: #763: Dogtag: fail if instance cannot be (re)started

MartinBasti commented:
"""
master:

* 1a7a1f955e327bf1a06faa53c517bdb22eba Make CA/KRA fail when they don't 
start
* aba384ddb535e81f81a518fa468a8ed095250ca1 Fix wrong message on Dogtag 
instances stop


ipa-4-5:

* 81f97cb89e17e63b3dcb8925a373970ac61764c2 Make CA/KRA fail when they don't 
start
* 1b44c4caa1e7a1f90b3b3537de9cc1529f0891e8 Fix wrong message on Dogtag 
instances stop


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/763#issuecomment-299517511
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#763][closed] Dogtag: fail if instance cannot be (re)started

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/763
Author: stlaz
 Title: #763: Dogtag: fail if instance cannot be (re)started
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/763/head:pr763
git checkout pr763
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#752][+ack] upgrade: add missing DN suffix when enabling KDC proxy

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/752
Title: #752: upgrade: add missing DN suffix when enabling KDC proxy

Label: +ack
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#752][comment] upgrade: add missing DN suffix when enabling KDC proxy

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/752
Title: #752: upgrade: add missing DN suffix when enabling KDC proxy

MartinBasti commented:
"""
Works for me 
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/752#issuecomment-299511962
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#765][opened] [4.5 backport] spec file: bump python-netaddr Requires

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/765
Author: MartinBasti
 Title: #765: [4.5 backport] spec file: bump python-netaddr Requires
Action: opened

PR body:
"""
Bump python-netaddr Requires to the version which has correct private and
reserved IPv4 address ranges.

This fixes DNS server install failure when 0.0.0.0 is entered as a
forwarder.

Backport from: 0784e53f7f8a323acafbbff26a9d1c0276a229b0

https://pagure.io/freeipa/issue/6894
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/765/head:pr765
git checkout pr765
From 1abd7689eeb4ebb1685da0dc8a647bc2957ffc43 Mon Sep 17 00:00:00 2001
From: Jan Cholasta <jchol...@redhat.com>
Date: Tue, 25 Apr 2017 12:13:00 +
Subject: [PATCH] spec file: bump python-netaddr Requires

Bump python-netaddr Requires to the version which has correct private and
reserved IPv4 address ranges.

This fixes DNS server install failure when 0.0.0.0 is entered as a
forwarder.

Backport from: 0784e53f7f8a323acafbbff26a9d1c0276a229b0

https://pagure.io/freeipa/issue/6894
---
 freeipa.spec.in | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 3b7410b..1214de7 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -38,6 +38,8 @@
 %if 0%{?rhel}
 # 1.15.1-7: certauth (http://krbdev.mit.edu/rt/Ticket/Display.html?id=8561)
 %global krb5_version 1.15.1-4
+# 0.7.16: https://github.com/drkjam/netaddr/issues/71
+%global python_netaddr_version 0.7.5-8
 # Require 4.6.0-4 which brings RC4 for FIPS + trust fixes to priv. separation
 %global samba_version 4.6.0-4
 %global selinux_policy_version 3.12.1-153
@@ -45,6 +47,8 @@
 %else
 # 1.15.1-7: certauth (http://krbdev.mit.edu/rt/Ticket/Display.html?id=8561)
 %global krb5_version 1.15.1-7
+# 0.7.16: https://github.com/drkjam/netaddr/issues/71
+%global python_netaddr_version 0.7.16
 # Require 4.6.0-4 which brings RC4 for FIPS + trust fixes to priv. separation
 %global samba_version 2:4.6.0-4
 %global selinux_policy_version 3.13.1-158.4
@@ -641,7 +645,7 @@ Requires: keyutils
 Requires: pyOpenSSL
 Requires: python-nss >= 0.16
 Requires: python-cryptography >= 1.4
-Requires: python-netaddr
+Requires: python-netaddr >= %{python_netaddr_version}
 Requires: python-libipa_hbac
 Requires: python-qrcode-core >= 5.0.0
 Requires: python-pyasn1
@@ -690,7 +694,7 @@ Requires: keyutils
 Requires: python3-pyOpenSSL
 Requires: python3-nss >= 0.16
 Requires: python3-cryptography >= 1.4
-Requires: python3-netaddr
+Requires: python3-netaddr >= %{python_netaddr_version}
 Requires: python3-libipa_hbac
 Requires: python3-qrcode-core >= 5.0.0
 Requires: python3-pyasn1
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#763][+ack] Dogtag: fail if instance cannot be (re)started

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/763
Title: #763: Dogtag: fail if instance cannot be (re)started

Label: +ack
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#753][closed] Check CA status: add HTTP timeout

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/753
Author: MartinBasti
 Title: #753: Check CA status: add HTTP timeout
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/753/head:pr753
git checkout pr753
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#753][comment] Check CA status: add HTTP timeout

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/753
Title: #753: Check CA status: add HTTP timeout

MartinBasti commented:
"""
master:

* 20f7689079328aeef42b62a359b303f531db5666 http_request: add timeout option
* 05984f171b0b41681254c95380a0598e4208a201 ca_status: add HTTP timeout 30 
seconds


ipa-4-5:

* 48bb3cb69c000cea3f28bd5b44072d0fe9caa7a2 http_request: add timeout option
* 68ce9aa2addb6048333e723f771132f5da7dd38f ca_status: add HTTP timeout 30 
seconds


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/753#issuecomment-299167248
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#753][+pushed] Check CA status: add HTTP timeout

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/753
Title: #753: Check CA status: add HTTP timeout

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#756][comment] Added plugins directory to paclient subpackages

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/756
Title: #756: Added plugins directory to paclient subpackages

MartinBasti commented:
"""
Opened issue: https://pagure.io/freeipa/issue/6927
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/756#issuecomment-299116620
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#756][+pushed] Added plugins directory to paclient subpackages

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/756
Title: #756: Added plugins directory to paclient subpackages

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#756][closed] Added plugins directory to paclient subpackages

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/756
Author: olivergs
 Title: #756: Added plugins directory to paclient subpackages
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/756/head:pr756
git checkout pr756
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#756][comment] Added plugins directory to paclient subpackages

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/756
Title: #756: Added plugins directory to paclient subpackages

MartinBasti commented:
"""
master:

* 548014f03eeababfd1b49e4bc9ac608633cb9b98 Added plugins directory to paclient 
subpackages


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/756#issuecomment-298950498
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#756][comment] Added plugins directory to paclient subpackages

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/756
Title: #756: Added plugins directory to paclient subpackages

MartinBasti commented:
"""
Thank you! Just for the record, you could use `git push --force` and keep the 
original PR opened :-)
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/756#issuecomment-298950141
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#756][+ack] Added plugins directory to paclient subpackages

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/756
Title: #756: Added plugins directory to paclient subpackages

Label: +ack
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#755][synchronized] Use proper SELinux context with http.keytab

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/755
Author: MartinBasti
 Title: #755: Use proper SELinux context with http.keytab
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/755/head:pr755
git checkout pr755
From c4e2b1e5f1cb4886cfd0824d4b23bbc9042f9158 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Wed, 3 May 2017 13:51:02 +0200
Subject: [PATCH] Use proper SELinux context with http.keytab

During upgrade keytab is moved to a new location using "move" operation.
This commit replaces move operation with "copy" and "remove" that
ensures a proper selinux context.

https://pagure.io/freeipa/issue/6924
---
 ipaserver/install/server/upgrade.py | 10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/ipaserver/install/server/upgrade.py b/ipaserver/install/server/upgrade.py
index 0f27428..4d8fd66 100644
--- a/ipaserver/install/server/upgrade.py
+++ b/ipaserver/install/server/upgrade.py
@@ -1427,7 +1427,15 @@ def update_ipa_httpd_service_conf(http):
 def update_http_keytab(http):
 root_logger.info('[Moving HTTPD service keytab to gssproxy]')
 if os.path.exists(paths.OLD_IPA_KEYTAB):
-shutil.move(paths.OLD_IPA_KEYTAB, http.keytab)
+# ensure proper SELinux context by using copy operation
+shutil.copy(paths.OLD_IPA_KEYTAB, http.keytab)
+try:
+os.remove(paths.OLD_IPA_KEYTAB)
+except OSError as e:
+root_logger.error(
+'Cannot remove file %s (%s). Please remove the file manually.',
+paths.OLD_IPA_KEYTAB, e
+)
 pent = pwd.getpwnam(http.keytab_user)
 os.chown(http.keytab, pent.pw_uid, pent.pw_gid)
 
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#753][synchronized] Check CA status: add HTTP timeout

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/753
Author: MartinBasti
 Title: #753: Check CA status: add HTTP timeout
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/753/head:pr753
git checkout pr753
From 1c0d760de5b882c819d96ef0ce791fe7557208b4 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Tue, 2 May 2017 19:24:16 +0200
Subject: [PATCH 1/2] http_request: add timeout option

httplib.HTTPConnection supports timeout option so _httplib_request can
be updated to allow passing connection keyword arguments to
connection_factory.

We need connection timeout for cases when reply from server is not
received on time to ask again and not to wait for infinity.

https://pagure.io/freeipa/issue/6766
---
 ipapython/dogtag.py | 20 
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/ipapython/dogtag.py b/ipapython/dogtag.py
index 48232a9..21d58a9 100644
--- a/ipapython/dogtag.py
+++ b/ipapython/dogtag.py
@@ -163,9 +163,10 @@ def connection_factory(host, port):
 method=method, headers=headers)
 
 
-def http_request(host, port, url, **kw):
+def http_request(host, port, url, timeout=None, **kw):
 """
 :param url: The path (not complete URL!) to post to.
+:param timeout: Timeout in seconds for waiting for reply.
 :param kw: Keyword arguments to encode into POST body.
 :return:   (http_status, http_headers, http_body)
 as (integer, dict, str)
@@ -173,21 +174,32 @@ def http_request(host, port, url, **kw):
 Perform an HTTP request.
 """
 body = urlencode(kw)
+if timeout is None:
+conn_opt = {}
+else:
+conn_opt = {"timeout": timeout}
+
 return _httplib_request(
-'http', host, port, url, httplib.HTTPConnection, body)
+'http', host, port, url, httplib.HTTPConnection, body,
+connection_options=conn_opt)
 
 
 def _httplib_request(
 protocol, host, port, path, connection_factory, request_body,
-method='POST', headers=None):
+method='POST', headers=None, connection_options=None):
 """
 :param request_body: Request body
 :param connection_factory: Connection class to use. Will be called
 with the host and port arguments.
 :param method: HTTP request method (default: 'POST')
+:param connection_options: a dictionary that will be passed to
+connection_factory as keyword arguments.
 
 Perform a HTTP(s) request.
 """
+if connection_options is None:
+connection_options = {}
+
 uri = u'%s://%s%s' % (protocol, ipautil.format_netloc(host, port), path)
 root_logger.debug('request %s %s', method, uri)
 root_logger.debug('request body %r', request_body)
@@ -200,7 +212,7 @@ def _httplib_request(
 headers['content-type'] = 'application/x-www-form-urlencoded'
 
 try:
-conn = connection_factory(host, port)
+conn = connection_factory(host, port, **connection_options)
 conn.request(method, uri, body=request_body, headers=headers)
 res = conn.getresponse()
 

From cf243bbb518670fd5ee073fcf5dc3f6a161e9ee3 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Tue, 2 May 2017 19:52:13 +0200
Subject: [PATCH 2/2] ca_status: add HTTP timeout 30 seconds

CA sometimes "forgot to answer" so we have to add timeout for http
connection and ask again rather than wait for infinity.

https://pagure.io/freeipa/issue/6766
---
 ipalib/constants.py | 2 ++
 ipapython/dogtag.py | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/ipalib/constants.py b/ipalib/constants.py
index e604bb4..5279b64 100644
--- a/ipalib/constants.py
+++ b/ipalib/constants.py
@@ -140,6 +140,8 @@
 
 # Time to wait for a service to start, in seconds
 ('startup_timeout', 300),
+# How long http connection should wait for reply [seconds].
+('http_timeout', 30),
 
 # Web Application mount points
 ('mount_ipa', '/ipa/'),
diff --git a/ipapython/dogtag.py b/ipapython/dogtag.py
index 21d58a9..28f78b5 100644
--- a/ipapython/dogtag.py
+++ b/ipapython/dogtag.py
@@ -123,7 +123,9 @@ def ca_status(ca_host=None):
 if ca_host is None:
 ca_host = api.env.ca_host
 status, _headers, body = http_request(
-ca_host, 8080, '/ca/admin/ca/getStatus')
+ca_host, 8080, '/ca/admin/ca/getStatus',
+# timeout: CA sometimes forgot to answer, we have to try again
+timeout=api.env.http_timeout)
 if status == 503:
 # Service temporarily unavailable
 return status
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#759][+ack] kra install: update installation failure message

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/759
Title: #759: kra install: update installation failure message

Label: +ack
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#755][synchronized] Use proper SELinux context with http.keytab

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/755
Author: MartinBasti
 Title: #755: Use proper SELinux context with http.keytab
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/755/head:pr755
git checkout pr755
From 32832cfc5452460486f9dddb69f9564c16b5fc87 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Wed, 3 May 2017 13:51:02 +0200
Subject: [PATCH] Use proper SELinux context with http.keytab

During upgrade keytab is moved to a new location using "move" operation.
This commit replaces move operation with "copy" and "remove" that
ensures a proper selinux context.

https://pagure.io/freeipa/issue/6924
---
 ipaserver/install/server/upgrade.py | 10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/ipaserver/install/server/upgrade.py b/ipaserver/install/server/upgrade.py
index 0f27428..7792f23 100644
--- a/ipaserver/install/server/upgrade.py
+++ b/ipaserver/install/server/upgrade.py
@@ -1427,7 +1427,15 @@ def update_ipa_httpd_service_conf(http):
 def update_http_keytab(http):
 root_logger.info('[Moving HTTPD service keytab to gssproxy]')
 if os.path.exists(paths.OLD_IPA_KEYTAB):
-shutil.move(paths.OLD_IPA_KEYTAB, http.keytab)
+# ensure proper SELinux context by using copy operation
+shutil.copy(paths.OLD_IPA_KEYTAB, http.keytab)
+try:
+os.remove(paths.OLD_IPA_KEYTAB)
+except OSError as e:
+root_logger.error(
+'Cannot remove file %s (%s). Please remove file manually.',
+paths.OLD_IPA_KEYTAB, e
+)
 pent = pwd.getpwnam(http.keytab_user)
 os.chown(http.keytab, pent.pw_uid, pent.pw_gid)
 
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#749][comment] Added plugins directory to python2-ipaclient subpackage

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/749
Title: #749: Added plugins directory to python2-ipaclient subpackage

MartinBasti commented:
"""
Thanks, could you please merge into one patch?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/749#issuecomment-298890770
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#755][opened] Use proper SELinux context with http.keytab

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/755
Author: MartinBasti
 Title: #755: Use proper SELinux context with http.keytab
Action: opened

PR body:
"""
During upgrade keytab is moved to a new location using "move" operation.
This commit replaces move operation with "copy" and "remove" that
ensures a proper selinux context.

https://pagure.io/freeipa/issue/6924
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/755/head:pr755
git checkout pr755
From ad8792f3c841ae859c1e0abcc953be96224e55ff Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Wed, 3 May 2017 13:51:02 +0200
Subject: [PATCH] Use proper SELinux context with http.keytab

During upgrade keytab is moved to a new location using "move" operation.
This commit replaces move operation with "copy" and "remove" that
ensures a proper selinux context.

https://pagure.io/freeipa/issue/6924
---
 ipaserver/install/server/upgrade.py | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/ipaserver/install/server/upgrade.py b/ipaserver/install/server/upgrade.py
index 0f27428..21ecb15 100644
--- a/ipaserver/install/server/upgrade.py
+++ b/ipaserver/install/server/upgrade.py
@@ -1427,7 +1427,14 @@ def update_ipa_httpd_service_conf(http):
 def update_http_keytab(http):
 root_logger.info('[Moving HTTPD service keytab to gssproxy]')
 if os.path.exists(paths.OLD_IPA_KEYTAB):
-shutil.move(paths.OLD_IPA_KEYTAB, http.keytab)
+shutil.copy(paths.OLD_IPA_KEYTAB, http.keytab)  # SELINUX
+try:
+os.remove(paths.OLD_IPA_KEYTAB)
+except OSError as e:
+root_logger.error(
+'Cannot remove file %s (%s). Please remove file manually.',
+paths.OLD_IPA_KEYTAB, e
+)
 pent = pwd.getpwnam(http.keytab_user)
 os.chown(http.keytab, pent.pw_uid, pent.pw_gid)
 
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#749][comment] Added plugins directory to python2-ipaclient subpackage

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/749
Title: #749: Added plugins directory to python2-ipaclient subpackage

MartinBasti commented:
"""
Hello, could you please also add it for python3-ipaclient too?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/749#issuecomment-298847918
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#753][opened] Check CA status: add HTTP timeout

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/753
Author: MartinBasti
 Title: #753: Check CA status: add HTTP timeout
Action: opened

PR body:
"""
https://pagure.io/freeipa/issue/6766
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/753/head:pr753
git checkout pr753
From 1c0d760de5b882c819d96ef0ce791fe7557208b4 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Tue, 2 May 2017 19:24:16 +0200
Subject: [PATCH 1/2] http_request: add timeout option

httplib.HTTPConnection supports timeout option so _httplib_request can
be updated to allow passing connection keyword arguments to
connection_factory.

We need connection timeout for cases when reply from server is not
received on time to ask again and not to wait for infinity.

https://pagure.io/freeipa/issue/6766
---
 ipapython/dogtag.py | 20 
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/ipapython/dogtag.py b/ipapython/dogtag.py
index 48232a9..21d58a9 100644
--- a/ipapython/dogtag.py
+++ b/ipapython/dogtag.py
@@ -163,9 +163,10 @@ def connection_factory(host, port):
 method=method, headers=headers)
 
 
-def http_request(host, port, url, **kw):
+def http_request(host, port, url, timeout=None, **kw):
 """
 :param url: The path (not complete URL!) to post to.
+:param timeout: Timeout in seconds for waiting for reply.
 :param kw: Keyword arguments to encode into POST body.
 :return:   (http_status, http_headers, http_body)
 as (integer, dict, str)
@@ -173,21 +174,32 @@ def http_request(host, port, url, **kw):
 Perform an HTTP request.
 """
 body = urlencode(kw)
+if timeout is None:
+conn_opt = {}
+else:
+conn_opt = {"timeout": timeout}
+
 return _httplib_request(
-'http', host, port, url, httplib.HTTPConnection, body)
+'http', host, port, url, httplib.HTTPConnection, body,
+connection_options=conn_opt)
 
 
 def _httplib_request(
 protocol, host, port, path, connection_factory, request_body,
-method='POST', headers=None):
+method='POST', headers=None, connection_options=None):
 """
 :param request_body: Request body
 :param connection_factory: Connection class to use. Will be called
 with the host and port arguments.
 :param method: HTTP request method (default: 'POST')
+:param connection_options: a dictionary that will be passed to
+connection_factory as keyword arguments.
 
 Perform a HTTP(s) request.
 """
+if connection_options is None:
+connection_options = {}
+
 uri = u'%s://%s%s' % (protocol, ipautil.format_netloc(host, port), path)
 root_logger.debug('request %s %s', method, uri)
 root_logger.debug('request body %r', request_body)
@@ -200,7 +212,7 @@ def _httplib_request(
 headers['content-type'] = 'application/x-www-form-urlencoded'
 
 try:
-conn = connection_factory(host, port)
+conn = connection_factory(host, port, **connection_options)
 conn.request(method, uri, body=request_body, headers=headers)
 res = conn.getresponse()
 

From 278e6a1bc39ba1f73bcb238acf4b5030645802ba Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Tue, 2 May 2017 19:52:13 +0200
Subject: [PATCH 2/2] ca_status: add HTTP timeout 30 seconds

CA sometimes "forgot to answer" so we have to add timeout for http
connection and ask again rather than wait for infinity.

https://pagure.io/freeipa/issue/6766
---
 ipalib/constants.py | 3 +++
 ipapython/dogtag.py | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/ipalib/constants.py b/ipalib/constants.py
index e604bb4..e719fa0 100644
--- a/ipalib/constants.py
+++ b/ipalib/constants.py
@@ -171,6 +171,9 @@
 ('ca_install_port', None),
 ('ca_agent_install_port', None),
 ('ca_ee_install_port', None),
+# How long http connection should wait before trying again [seconds].
+# Do not mistake with "startup_timeout"
+('ca_status_http_timeout', 30),
 
 # Topology plugin
 ('recommended_max_agmts', 4),  # Recommended maximum number of replication
diff --git a/ipapython/dogtag.py b/ipapython/dogtag.py
index 21d58a9..0c542d8 100644
--- a/ipapython/dogtag.py
+++ b/ipapython/dogtag.py
@@ -123,7 +123,9 @@ def ca_status(ca_host=None):
 if ca_host is None:
 ca_host = api.env.ca_host
 status, _headers, body = http_request(
-ca_host, 8080, '/ca/admin/ca/getStatus')
+ca_host, 8080, '/ca/admin/ca/getStatus',
+# timeout: CA sometimes forgot to answer, we have to try again
+timeout=api.env.ca_status_http_timeout)
 if status == 503:
 # Service temporarily unavailable
 return status
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#729][comment] Turn on NSSOCSP check in mod_nss conf

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/729
Title: #729: Turn on NSSOCSP check in mod_nss conf

MartinBasti commented:
"""
And you also need to add it in `ipaserver/setup.py` as dependency for our PyPI 
packages
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/729#issuecomment-298691022
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#729][comment] Turn on NSSOCSP check in mod_nss conf

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/729
Title: #729: Turn on NSSOCSP check in mod_nss conf

MartinBasti commented:
"""
And you also need python[3]-augeas as Pylint BuildDependency to pass pylint :), 
sorry I forgot about it.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/729#issuecomment-298690276
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#671][comment] Slim down dependencies

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/671
Title: #671: Slim down dependencies

MartinBasti commented:
"""
Due missing jinja, tox tests failed

```
ERROR:   py27: commands failed
ERROR:   py35: commands failed
ERROR:   py36: commands failed
ERROR:   pylint2: commands failed
ERROR:   pylint3: commands failed
```

Tests
```
ImportError while importing test module 
'/tmp/freeipa/.tox/py36/lib/python3.6/site-packages/ipatests/test_ipaclient/test_csrgen.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test_ipaclient/test_csrgen.py:8: in 
from ipaclient import csrgen
../ipaclient/csrgen.py:23: in 
import jinja2
E   ModuleNotFoundError: No module named 'jinja2'

```

pylint
```
* Module ipaclient.csrgen
lib/python3.5/site-packages/ipaclient/csrgen.py:23: [E0401(import-error), ] 
Unable to import 'jinja2')
lib/python3.5/site-packages/ipaclient/csrgen.py:24: [E0401(import-error), ] 
Unable to import 'jinja2.ext')
lib/python3.5/site-packages/ipaclient/csrgen.py:25: [E0401(import-error), ] 
Unable to import 'jinja2.sandbox')
```
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/671#issuecomment-298675008
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#741][closed] 6.9 -> 7.4 migration fixes

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/741
Author: stlaz
 Title: #741: 6.9 -> 7.4 migration fixes
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/741/head:pr741
git checkout pr741
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#741][+pushed] 6.9 -> 7.4 migration fixes

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/741
Title: #741: 6.9 -> 7.4 migration fixes

Label: +pushed
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#741][comment] 6.9 -> 7.4 migration fixes

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/741
Title: #741: 6.9 -> 7.4 migration fixes

MartinBasti commented:
"""
master:

* 0d406fcb784924bfe685729f3156efb8c902b947 Refresh Dogtag RestClient.ca_host 
property
* 92313c9e9d37733feb79d1b1c825178f48d6c69c Remove the cachedproperty class


ipa-4-5:

* 32981a0f9d0ff699e3d16da8f5a37c112871ba3a Refresh Dogtag RestClient.ca_host 
property
* 9de343987e6d76d2edeba372c73c1060657aef59 Remove the cachedproperty class


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/741#issuecomment-298671871
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#741][+ack] 6.9 -> 7.4 migration fixes

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/741
Title: #741: 6.9 -> 7.4 migration fixes

Label: +ack
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#729][comment] Turn on NSSOCSP check in mod_nss conf

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/729
Title: #729: Turn on NSSOCSP check in mod_nss conf

MartinBasti commented:
"""
augeas should be dependency of python2-ipaserver and python3-ipaserver 
(python3-augeas) packages
```
* Module ipaserver.install.httpinstance
ipaserver/install/httpinstance.py:32: [E0401(import-error), ] Unable to import 
'augeas')
```
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/729#issuecomment-298665396
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#723][comment] Store GSSAPI session key in /var/run/httpd

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/723
Title: #723: Store GSSAPI session key in /var/run/httpd

MartinBasti commented:
"""
The issue will be fixed on the SELinux side
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/723#issuecomment-298627474
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#723][closed] Store GSSAPI session key in /var/run/httpd

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/723
Author: MartinBasti
 Title: #723: Store GSSAPI session key in /var/run/httpd
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/723/head:pr723
git checkout pr723
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#723][+rejected] Store GSSAPI session key in /var/run/httpd

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/723
Title: #723: Store GSSAPI session key in /var/run/httpd

Label: +rejected
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#751][comment] ipa-client-install: remove extra space in pkinit_anchors definition

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/751
Title: #751: ipa-client-install: remove extra space in pkinit_anchors definition

MartinBasti commented:
"""
master:

* 26dbab1fd4384b8f3999b153c2d94220cf541ad2 ipa-client-install: remove extra 
space in pkinit_anchors definition


ipa-4-5:

* a3c4e70650dbcd5dd3f00a7b2fecc051afeebec0 ipa-client-install: remove extra 
space in pkinit_anchors definition


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/751#issuecomment-298613205
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code