[Freeipa-devel] [freeipa PR#513][comment] certdb: Don't restore_context() of new NSSDB

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/513 Title: #513: certdb: Don't restore_context() of new NSSDB MartinBasti commented: """ master: * a163ad77b3d12f2da2b135de29f594c06190b41a certdb: Don't restore_context() of new NSSDB """ See the ful

[Freeipa-devel] [freeipa PR#513][+pushed] certdb: Don't restore_context() of new NSSDB

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/513 Title: #513: certdb: Don't restore_context() of new NSSDB Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Cont

[Freeipa-devel] [freeipa PR#512][closed] test_config: fix fips_mode key in Env

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/512 Author: tomaskrizek Title: #512: test_config: fix fips_mode key in Env Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/512/head:pr512 git checkout pr512 -- Manage

[Freeipa-devel] [freeipa PR#512][comment] test_config: fix fips_mode key in Env

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/512 Title: #512: test_config: fix fips_mode key in Env MartinBasti commented: """ master: * 770d4cda430803f8e020c57971c4dd8e802dc417 Env __setitem__: replace assert with exception * 5055b34cefd6e3f9b707aed076a49ae97b38aa3c t

[Freeipa-devel] [freeipa PR#488][closed] Speed up client schema cache

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/488 Author: tiran Title: #488: Speed up client schema cache Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/488/head:pr488 git checkout pr488 -- Manage your subscript

[Freeipa-devel] [freeipa PR#512][+pushed] test_config: fix fips_mode key in Env

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/512 Title: #512: test_config: fix fips_mode key in Env Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/

[Freeipa-devel] [freeipa PR#412][+pushed] Define template version in certmap.conf

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/412 Title: #412: Define template version in certmap.conf Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribut

[Freeipa-devel] [freeipa PR#412][closed] Define template version in certmap.conf

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/412 Author: flo-renaud Title: #412: Define template version in certmap.conf Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/412/head:pr412 git checkout pr412 -- Manag

[Freeipa-devel] [freeipa PR#509][+pushed] Migrate OTP import script to python-cryptography

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/509 Title: #509: Migrate OTP import script to python-cryptography Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/

[Freeipa-devel] [freeipa PR#509][closed] Migrate OTP import script to python-cryptography

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/509 Author: tiran Title: #509: Migrate OTP import script to python-cryptography Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/509/head:pr509 git checkout pr509 -- M

[Freeipa-devel] [freeipa PR#488][+pushed] Speed up client schema cache

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/488 Title: #488: Speed up client schema cache Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#488][comment] Speed up client schema cache

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/488 Title: #488: Speed up client schema cache MartinBasti commented: """ master: * 332dbab1ff09eb719eb9e0a7a90bbf5b6e69ddc9 Speed up client schema cache * 3be696c92f6948ea0ced9784920600b73703e414 Drop in-memory copy of schema zip fi

[Freeipa-devel] [freeipa PR#509][comment] Migrate OTP import script to python-cryptography

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/509 Title: #509: Migrate OTP import script to python-cryptography MartinBasti commented: """ master: * d00ae870dda2889545c9d93e82e44526bfd4f431 Migrate OTP import script to python-cryptography * 135d0b5dd111d40632e2cd5be8f5315684b45

[Freeipa-devel] [freeipa PR#412][comment] Define template version in certmap.conf

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/412 Title: #412: Define template version in certmap.conf MartinBasti commented: """ master: * c49320435ddc67210c0d95be273e971ea8ffad6d Define template version in certmap.conf """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#501][closed] C compilation fixes and hardening

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/501 Author: tiran Title: #501: C compilation fixes and hardening Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/501/head:pr501 git checkout pr501 -- Manage your subs

[Freeipa-devel] [freeipa PR#501][+pushed] C compilation fixes and hardening

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/501 Title: #501: C compilation fixes and hardening Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#501][comment] C compilation fixes and hardening

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/501 Title: #501: C compilation fixes and hardening MartinBasti commented: """ master: * 2828a2b92b89932d66b640e5047161448d522e2e C compilation fixes and hardening """ See the full comment at https://github.com/freeipa

[Freeipa-devel] [freeipa PR#508][comment] Fix ipa.service unit re. gssproxy

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/508 Title: #508: Fix ipa.service unit re. gssproxy MartinBasti commented: """ master: * 98e3b14a0477232054b02065c857fb1b16ce85a6 Fix ipa.service unit re. gssproxy """ See the full comment at https://github.com/freeipa

[Freeipa-devel] [freeipa PR#508][closed] Fix ipa.service unit re. gssproxy

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/508 Author: flo-renaud Title: #508: Fix ipa.service unit re. gssproxy Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/508/head:pr508 git checkout pr508 -- Manage your

[Freeipa-devel] [freeipa PR#508][+pushed] Fix ipa.service unit re. gssproxy

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/508 Title: #508: Fix ipa.service unit re. gssproxy Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#513][+ack] certdb: Don't restore_context() of new NSSDB

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/513 Title: #513: certdb: Don't restore_context() of new NSSDB Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contrib

[Freeipa-devel] [freeipa PR#513][comment] certdb: Don't restore_context() of new NSSDB

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/513 Title: #513: certdb: Don't restore_context() of new NSSDB MartinBasti commented: """ Ok, I agree """ See the full comment at https://github.com/freeipa/freeipa/pull/513#issuecomment-283285379 -- Manage your

[Freeipa-devel] [freeipa PR#513][comment] certdb: Don't restore_context() of new NSSDB

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/513 Title: #513: certdb: Don't restore_context() of new NSSDB MartinBasti commented: """ This is old code, initially added here 49b36583a50e7f542e0667f3e2432ab1aa63924e But I failed to detect why restorecon call has been add

[Freeipa-devel] [freeipa PR#521][+rejected] Add nsaccountlock to user attributes when a new user is created

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/521 Title: #521: Add nsaccountlock to user attributes when a new user is created Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.

[Freeipa-devel] [freeipa PR#521][closed] Add nsaccountlock to user attributes when a new user is created

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/521 Author: redhatrises Title: #521: Add nsaccountlock to user attributes when a new user is created Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/521/head:pr521 git

[Freeipa-devel] [freeipa PR#521][comment] Add nsaccountlock to user attributes when a new user is created

2017-03-01 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/521 Title: #521: Add nsaccountlock to user attributes when a new user is created MartinBasti commented: """ It looks that my proposal is not the right way, sorry. (See: #444) """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#511][comment] Bump required version of gssproxy to 0.6.2

2017-02-28 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/511 Title: #511: Bump required version of gssproxy to 0.6.2 MartinBasti commented: """ @puiterwijk It shouldn't be an issue with https://pagure.io/fedora-infrastructure/issue/5845 fixed :) but yes since this is not acked yet comm

[Freeipa-devel] [freeipa PR#515][comment] Re-add ipapython.config.config for backwards compatibilty

2017-02-28 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/515 Title: #515: Re-add ipapython.config.config for backwards compatibilty MartinBasti commented: """ IIRC we agreed that there should be warning that this is deprecated and `api.env` should be used instead. """

[Freeipa-devel] [freeipa PR#444][comment] Allow nsaccountlock to be searched in user-find commands

2017-02-28 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/444 Title: #444: Allow nsaccountlock to be searched in user-find commands MartinBasti commented: """ @redhatrises IMO for new users we can always create that attribute in LDAP, that should limit bad behavior. I wouldn't add it

[Freeipa-devel] [freeipa PR#509][comment] Migrate OTP import script to python-cryptography

2017-02-27 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/509 Title: #509: Migrate OTP import script to python-cryptography MartinBasti commented: """ @stlaz Why is this closed? I don't see any push/commit here """ See the full comment at https://github.com/freeipa/free

[Freeipa-devel] [freeipa PR#509][comment] Migrate OTP import script to python-cryptography

2017-02-27 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/509 Title: #509: Migrate OTP import script to python-cryptography MartinBasti commented: """ @stlaz Why is this closed? I don't see any push/commit here """ See the full comment at https://github.com/freeipa/free

[Freeipa-devel] [freeipa PR#479][+ack] Merge AD trust installer into composite ones

2017-02-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/479 Title: #479: Merge AD trust installer into composite ones Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contrib

[Freeipa-devel] [freeipa PR#479][comment] Merge AD trust installer into composite ones

2017-02-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/479 Title: #479: Merge AD trust installer into composite ones MartinBasti commented: """ Works for me, except, ipa-server-install --setup-adtrust works even without freeipa-server-trust-ad package. Please fix this in a new PR in

[Freeipa-devel] [freeipa PR#503][comment] [WIP] Update testcase for cert plugin

2017-02-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/503 Title: #503: [WIP] Update testcase for cert plugin MartinBasti commented: """ @Akasurde what is your opinion about creating a Tracker class for certificate? """ See the full comment at https://github.com/freeipa

[Freeipa-devel] [freeipa PR#504][comment] Add SHA256 fingerprints

2017-02-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/504 Title: #504: Add SHA256 fingerprints MartinBasti commented: """ Do not touch `install/share/copy-schema-to-ca.py` ever (this will be removed soon from master, just waiting for ACKs) """ See the full comment

[Freeipa-devel] [freeipa PR#503][comment] [WIP] Update testcase for cert plugin

2017-02-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/503 Title: #503: [WIP] Update testcase for cert plugin MartinBasti commented: """ I left some inline comments, this improves the test but it still misses several features to be tested. You can finish these improvements and it can be

[Freeipa-devel] [freeipa PR#500][+rejected] Replace sha1 fingerprints with sha256

2017-02-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/500 Title: #500: Replace sha1 fingerprints with sha256 Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribut

[Freeipa-devel] [freeipa PR#500][closed] Replace sha1 fingerprints with sha256

2017-02-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/500 Author: tomaskrizek Title: #500: Replace sha1 fingerprints with sha256 Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/500/head:pr500 git checkout pr500 -- Manage

[Freeipa-devel] [freeipa PR#500][comment] Replace sha1 fingerprints with sha256

2017-02-24 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/500 Title: #500: Replace sha1 fingerprints with sha256 MartinBasti commented: """ https://www.redhat.com/archives/freeipa-devel/2017-February/msg01083.html This was discussed in that thread and resolution is to not remove sha1 @

[Freeipa-devel] [freeipa PR#483][comment] lite-server: validate LDAP connection and cache schema

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/483 Title: #483: lite-server: validate LDAP connection and cache schema MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/dcb618152572ca013a447336e13d24399b5f7960 """

[Freeipa-devel] [freeipa PR#483][closed] lite-server: validate LDAP connection and cache schema

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/483 Author: tiran Title: #483: lite-server: validate LDAP connection and cache schema Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/483/head:pr483 git checkout pr483

[Freeipa-devel] [freeipa PR#483][+pushed] lite-server: validate LDAP connection and cache schema

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/483 Title: #483: lite-server: validate LDAP connection and cache schema Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org

[Freeipa-devel] [freeipa PR#482][+pushed] Remove MD5 certificate fingerprints

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/482 Title: #482: Remove MD5 certificate fingerprints Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Co

[Freeipa-devel] [freeipa PR#482][comment] Remove MD5 certificate fingerprints

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/482 Title: #482: Remove MD5 certificate fingerprints MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/e2d1b21c5049f68d0336dcaf3f8657b214a34e2b """ See the full comment

[Freeipa-devel] [freeipa PR#412][comment] Define template version in certmap.conf

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/412 Title: #412: Define template version in certmap.conf MartinBasti commented: """ needs rebase """ See the full comment at https://github.com/freeipa/freeipa/pull/412#issuecomment-282069402 -- Manage your subs

[Freeipa-devel] [freeipa PR#482][closed] Remove MD5 certificate fingerprints

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/482 Author: stlaz Title: #482: Remove MD5 certificate fingerprints Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/482/head:pr482 git checkout pr482 -- Manage your su

[Freeipa-devel] [freeipa PR#498][+pushed] compat: fix `Any` params in `batch` and `dnsrecord`

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/498 Title: #498: compat: fix `Any` params in `batch` and `dnsrecord` Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/pa

[Freeipa-devel] [freeipa PR#499][closed] added help about default value for --external-ca-type option

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/499 Author: tscherf Title: #499: added help about default value for --external-ca-type option Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/499/head:pr499 git checko

[Freeipa-devel] [freeipa PR#499][comment] added help about default value for --external-ca-type option

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/499 Title: #499: added help about default value for --external-ca-type option MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/573a0f1ffe5035b75fb88ee7752029e34c6b37af """

[Freeipa-devel] [freeipa PR#499][+pushed] added help about default value for --external-ca-type option

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/499 Title: #499: added help about default value for --external-ca-type option Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freei

[Freeipa-devel] [freeipa PR#498][closed] compat: fix `Any` params in `batch` and `dnsrecord`

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/498 Author: HonzaCholasta Title: #498: compat: fix `Any` params in `batch` and `dnsrecord` Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/498/head:pr498 git checkout

[Freeipa-devel] [freeipa PR#498][comment] compat: fix `Any` params in `batch` and `dnsrecord`

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/498 Title: #498: compat: fix `Any` params in `batch` and `dnsrecord` MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/19060db1b8fa9d1d3e8f3ac3fcd1f387e9a39c94 """

[Freeipa-devel] [freeipa PR#498][comment] compat: fix `Any` params in `batch` and `dnsrecord`

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/498 Title: #498: compat: fix `Any` params in `batch` and `dnsrecord` MartinBasti commented: """ Works for me """ See the full comment at https://github.com/freeipa/freeipa/pull/498#issuecomment-282068296 -- Manage you

[Freeipa-devel] [freeipa PR#498][+ack] compat: fix `Any` params in `batch` and `dnsrecord`

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/498 Title: #498: compat: fix `Any` params in `batch` and `dnsrecord` Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/

[Freeipa-devel] [freeipa PR#483][+ack] lite-server: validate LDAP connection and cache schema

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/483 Title: #483: lite-server: validate LDAP connection and cache schema Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/pa

[Freeipa-devel] [freeipa PR#483][comment] lite-server: validate LDAP connection and cache schema

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/483 Title: #483: lite-server: validate LDAP connection and cache schema MartinBasti commented: """ Code looks good to me, as far as this is just code for developers I assume that @tiran tested it enough, so ACK. """

[Freeipa-devel] [freeipa PR#499][comment] added help about default value for --external-ca-type option

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/499 Title: #499: added help about default value for --external-ca-type option MartinBasti commented: """ Thanks! Next time please use `git push --force` to update current pull request instead creating a new one. """

[Freeipa-devel] [freeipa PR#497][+rejected] added more meaningful help for --external-ca-type option

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/497 Title: #497: added more meaningful help for --external-ca-type option Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa

[Freeipa-devel] [freeipa PR#497][comment] added more meaningful help for --external-ca-type option

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/497 Title: #497: added more meaningful help for --external-ca-type option MartinBasti commented: """ Replaced by #499 """ See the full comment at https://github.com/freeipa/freeipa/pull/497#issuecomment-281995516 --

[Freeipa-devel] [freeipa PR#499][+ack] added help about default value for --external-ca-type option

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/499 Title: #499: added help about default value for --external-ca-type option Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.

[Freeipa-devel] [freeipa PR#499][comment] added help about default value for --external-ca-type option

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/499 Title: #499: added help about default value for --external-ca-type option MartinBasti commented: """ Thanks! Next time please use 'git push --force' to update current pull request instead a creating a new one. "&quo

[Freeipa-devel] [freeipa PR#497][comment] added more meaningful help for --external-ca-type option

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/497 Title: #497: added more meaningful help for --external-ca-type option MartinBasti commented: """ This is already fixed in master, however it missed what is the default value ``` --external-ca-type={generic,ms-cs}

[Freeipa-devel] [freeipa PR#497][comment] added more meaningful help for --external-ca-type option

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/497 Title: #497: added more meaningful help for --external-ca-type option MartinBasti commented: """ This is already fixed in master, however it missed what is the default value ``` --external-ca-type={generic,ms-cs}

[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ The old pylint issue is back ``` * Module ipaserver.install.installutils ipaserver/install/installutils.py:1209: [E1101(no-member), store_v

[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ @tiran I thought we agreed on having `with_wheels` in specfile and install dependencies only when you want to build wheel packages, what is not the ca

[Freeipa-devel] [freeipa PR#493][comment] Update Contributors.txt

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/493 Title: #493: Update Contributors.txt MartinBasti commented: """ If script for generating contributors file was published it may be documented in releasing page and it may be part of each release. """ See the full

[Freeipa-devel] [freeipa PR#493][+pushed] Update Contributors.txt

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/493 Title: #493: Update Contributors.txt Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#493][comment] Update Contributors.txt

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/493 Title: #493: Update Contributors.txt MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/b367c3a622c8c8b96777e4ce50334d2a4477bbe7 """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#493][closed] Update Contributors.txt

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/493 Author: mkosek Title: #493: Update Contributors.txt Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/493/head:pr493 git checkout pr493 -- Manage your subscription

[Freeipa-devel] [freeipa PR#495][comment] Fix ipa-server-upgrade

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/495 Title: #495: Fix ipa-server-upgrade MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/32076df10231b381a80c9ef850c2c31d7a25feb8 """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#496][closed] Use newer Certificate.serial_number in krainstance.py

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/496 Author: stlaz Title: #496: Use newer Certificate.serial_number in krainstance.py Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/496/head:pr496 git checkout pr496

[Freeipa-devel] [freeipa PR#495][closed] Fix ipa-server-upgrade

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/495 Author: stlaz Title: #495: Fix ipa-server-upgrade Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/495/head:pr495 git checkout pr495 -- Manage your subscription fo

[Freeipa-devel] [freeipa PR#495][+pushed] Fix ipa-server-upgrade

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/495 Title: #495: Fix ipa-server-upgrade Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#496][comment] Use newer Certificate.serial_number in krainstance.py

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/496 Title: #496: Use newer Certificate.serial_number in krainstance.py MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/8c2cd66269d7be976ae7fc990343ed8e9b5282a3 """

[Freeipa-devel] [freeipa PR#496][+pushed] Use newer Certificate.serial_number in krainstance.py

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/496 Title: #496: Use newer Certificate.serial_number in krainstance.py Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/

[Freeipa-devel] [freeipa PR#439][+postponed] [WIP] [Py3] testing both py2/py3 in travis

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/439 Title: #439: [WIP] [Py3] testing both py2/py3 in travis Label: +postponed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Con

[Freeipa-devel] [freeipa PR#460][+postponed] [Py3] ipa-server-install, ipa-server-upgrade fixes

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/460 Title: #460: [Py3] ipa-server-install, ipa-server-upgrade fixes Label: +postponed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/

[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ Is really needed to have this is make check? It makes build dependencies of wheel mandratory not optional ``` error: invalid command '

[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages

2017-02-23 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ Is really needed to have this is make check? It makes build dependencies of wheel mandratory not optional ``` error: invalid command '

[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages

2017-02-22 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ LGTM, please rebase and I will test it. """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281749499 --

[Freeipa-devel] [freeipa PR#495][comment] Fix ipa-server-upgrade

2017-02-22 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/495 Title: #495: Fix ipa-server-upgrade MartinBasti commented: """ Does this belong to any ticket which caused this regression? """ See the full comment at https://github.com/freeipa/freeipa/pull/495#issuecom

[Freeipa-devel] [freeipa PR#457][closed] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-22 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/457 Author: martbab Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/457/head:pr457 git checkou

[Freeipa-devel] [freeipa PR#457][+pushed] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-22 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/457 Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeip

[Freeipa-devel] [freeipa PR#457][comment] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-22 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/457 Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/af998c4d30175fb3ecc148e1b3a7aca03ef9239a https://fedorahos

[Freeipa-devel] [freeipa PR#457][+ack] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-22 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/457 Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.o

[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages

2017-02-22 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ Thank you. I see errors reported by pylint ``` * Module ipaserver.install.installutils ipaserver/install/installutils.py:1209: [

[Freeipa-devel] [freeipa PR#437][comment] FIPS: replica install check

2017-02-21 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/437 Title: #437: FIPS: replica install check MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/3372ad2766c0d182fa88c8bc28cf43477dc4cb3b https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#437][closed] FIPS: replica install check

2017-02-21 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/437 Author: tomaskrizek Title: #437: FIPS: replica install check Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/437/head:pr437 git checkout pr437 -- Manage your subs

[Freeipa-devel] [freeipa PR#437][+pushed] FIPS: replica install check

2017-02-21 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/437 Title: #437: FIPS: replica install check Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#481][closed] Minor typo fix in DNS install plugin

2017-02-21 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/481 Author: Akasurde Title: #481: Minor typo fix in DNS install plugin Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/481/head:pr481 git checkout pr481 -- Manage you

[Freeipa-devel] [freeipa PR#437][comment] FIPS: replica install check

2017-02-21 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/437 Title: #437: FIPS: replica install check MartinBasti commented: """ Needs rebase """ See the full comment at https://github.com/freeipa/freeipa/pull/437#issuecomment-281361284 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#481][+pushed] Minor typo fix in DNS install plugin

2017-02-21 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/481 Title: #481: Minor typo fix in DNS install plugin Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/C

[Freeipa-devel] [freeipa PR#481][comment] Minor typo fix in DNS install plugin

2017-02-21 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/481 Title: #481: Minor typo fix in DNS install plugin MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/cc446fb44870592f73af9c0dc2a35c5d37ce7a5c """ See the full comment

[Freeipa-devel] [freeipa PR#489][closed] Fix error in ca_cert_files validator

2017-02-21 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/489 Author: stlaz Title: #489: Fix error in ca_cert_files validator Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/489/head:pr489 git checkout pr489 -- Manage your s

[Freeipa-devel] [freeipa PR#489][comment] Fix error in ca_cert_files validator

2017-02-21 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/489 Title: #489: Fix error in ca_cert_files validator MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/0fffeabe0249d9c3c11e522fccf22ddeb1197b64 """ See the full comment

[Freeipa-devel] [freeipa PR#489][+pushed] Fix error in ca_cert_files validator

2017-02-21 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/489 Title: #489: Fix error in ca_cert_files validator Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/C

[Freeipa-devel] [freeipa PR#491][+pushed] Don't prepend option names with additional '--'

2017-02-21 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/491 Title: #491: Don't prepend option names with additional '--' Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/C

[Freeipa-devel] [freeipa PR#491][closed] Don't prepend option names with additional '--'

2017-02-21 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/491 Author: stlaz Title: #491: Don't prepend option names with additional '--' Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/491/head:pr491 git checkout pr491 -- Ma

[Freeipa-devel] [freeipa PR#491][comment] Don't prepend option names with additional '--'

2017-02-21 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/491 Title: #491: Don't prepend option names with additional '--' MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/9ac068ad04a2323192f9447986a3d1c5431f1e50 """

[Freeipa-devel] [freeipa PR#482][comment] Remove MD5 certificate fingerprints

2017-02-21 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/482 Title: #482: Remove MD5 certificate fingerprints MartinBasti commented: """ +1 for sha256 """ See the full comment at https://github.com/freeipa/freeipa/pull/482#issuecomment-281352849 -- Manage your subscription

<    2   3   4   5   6   7   8   9   10   >