Re: [Freeipa-devel] [PATCHES] 228-237 Confirmation of dialogs by keyboard, better password dialogs

2013-02-21 Thread Petr Vobornik
On 01/07/2013 12:53 PM, Petr Vobornik wrote: On 11/27/2012 04:50 PM, Endi Sukma Dewata wrote: On 11/20/2012 6:54 AM, Petr Vobornik wrote: New design page: http://www.freeipa.org/page/V3/WebUI_keyboard_confirmation Link to design page was added to tickets #3200 and #2910. In the ticket list

[Freeipa-devel] Web UI: ipa-3-1 and master are equal

2013-02-21 Thread Petr Vobornik
confirm_dialog a base class of revoke and restore certificate dialogs b238fc13ef98afb0bae4c479be1fc2c7fa94468d Avoid internal error when user is not Trust admin -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com

Re: [Freeipa-devel] [PATCH] 256-258 Web UI: removed build dependency errors

2013-02-21 Thread Petr Vobornik
On 02/19/2013 04:12 AM, Endi Sukma Dewata wrote: ACK. Pushed to master, ipa-3-1 -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 264-265 Web UI:Certificate pages

2013-02-22 Thread Petr Vobornik
. Therefore the search is not restricted to 'subject'. It should be replaced by https://fedorahosted.org/freeipa/ticket/191 in a future. https://fedorahosted.org/freeipa/ticket/3419 -- Petr Vobornik From 868040b866e6180f81fae2d8c7f50482e09824e4 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo

Re: [Freeipa-devel] [PATCH] 0007 Web UI: Realm Domains page

2013-02-27 Thread Petr Vobornik
to separate action in action list. I prefer the former. Latter might have issues with two modifications (delete and add) at the same time at two different places (facet and add dialog). -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel

Re: [Freeipa-devel] [PATCH] 0007 Web UI: Realm Domains page

2013-03-06 Thread Petr Vobornik
On 03/05/2013 05:52 PM, Ana Krivokapic wrote: On 02/27/2013 05:10 PM, Petr Vobornik wrote: On 02/27/2013 04:20 PM, Ana Krivokapic wrote: Add support for Realm Domains to web UI. https://fedorahosted.org/freeipa/ticket/3407 The patch looks good, but there is a issue we don't have

Re: [Freeipa-devel] [PATCH] 259 Combobox keyboard support

2013-03-06 Thread Petr Vobornik
On 03/02/2013 08:38 PM, Endi Sukma Dewata wrote: On 02/27/2013 06:54 AM, Petr Vobornik wrote: On 02/27/2013 01:50 AM, Endi Sukma Dewata wrote: Another minor thing, if the search box is in focus, you can use the Up/Down arrow to go to the list. However, from the list you cannot use the Up

Re: [Freeipa-devel] [PATCH] 260-262 Global trust configuration page

2013-03-06 Thread Petr Vobornik
that happens to have the same name. I agree. Martin is it feasible? -- Endi S. Dewata -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 263 Web UI: configurable SID blacklists

2013-03-06 Thread Petr Vobornik
On 03/04/2013 06:14 PM, Endi Sukma Dewata wrote: On 2/18/2013 10:37 AM, Petr Vobornik wrote: Added blacklists section, with ipantsidblacklistincoming and ipantsidblacklistoutgoing multivalued textbox fields, into trust details page. https://fedorahosted.org/freeipa/ticket/3289 ACK. Pushed

Re: [Freeipa-devel] [PATCH] 260-262 Global trust configuration page

2013-03-06 Thread Petr Vobornik
On 03/06/2013 02:05 PM, Martin Kosek wrote: On 03/06/2013 01:42 PM, Petr Vobornik wrote: On 03/02/2013 08:40 PM, Endi Sukma Dewata wrote: - Original Message - First two patches are bug fixes which are required for third patch. Depends on my patch #259 (Combobox keyboard support) 1

Re: [Freeipa-devel] [PATCH] 264-265 Web UI:Certificate pages

2013-03-06 Thread Petr Vobornik
Updated patch 264 attached. 265 was rebased. See comments below. On 03/06/2013 12:33 AM, Endi Sukma Dewata wrote: On 2/22/2013 10:43 AM, Petr Vobornik wrote: Note: static json files for testing and such will be updated soon (there were several patch which changes API. I rather want to do one

Re: [Freeipa-devel] [PATCH] 0007 Web UI: Realm Domains page

2013-03-07 Thread Petr Vobornik
On 03/06/2013 08:26 PM, Ana Krivokapic wrote: On 03/06/2013 10:40 AM, Petr Vobornik wrote: On 03/05/2013 05:52 PM, Ana Krivokapic wrote: On 02/27/2013 05:10 PM, Petr Vobornik wrote: On 02/27/2013 04:20 PM, Ana Krivokapic wrote: Add support for Realm Domains to web UI. https

Re: [Freeipa-devel] [PATCH] 255 Added Web UI support for service PAC type option: NONE

2013-03-07 Thread Petr Vobornik
On 02/14/2013 04:56 PM, Endi Sukma Dewata wrote: On 2/14/2013 6:30 AM, Petr Vobornik wrote: If they are mutually exclusive, they probably should be separated using radio buttons like this: PAC: ( ) None (o) Type: [x] MS-PAC [ ] PAD You missed one option

Re: [Freeipa-devel] [PATCH] 0007 Web UI: Realm Domains page

2013-03-07 Thread Petr Vobornik
On 03/07/2013 02:19 PM, Ana Krivokapic wrote: On 03/07/2013 12:41 PM, Petr Vobornik wrote: On 03/06/2013 08:26 PM, Ana Krivokapic wrote: On 03/06/2013 10:40 AM, Petr Vobornik wrote: On 03/05/2013 05:52 PM, Ana Krivokapic wrote: On 02/27/2013 05:10 PM, Petr Vobornik wrote: On 02/27/2013 04

Re: [Freeipa-devel] [PATCH] 0007 Web UI: Realm Domains page

2013-03-07 Thread Petr Vobornik
On 03/07/2013 05:32 PM, Petr Vobornik wrote: On 03/07/2013 02:19 PM, Ana Krivokapic wrote: On 03/07/2013 12:41 PM, Petr Vobornik wrote: On 03/06/2013 08:26 PM, Ana Krivokapic wrote: On 03/06/2013 10:40 AM, Petr Vobornik wrote: On 03/05/2013 05:52 PM, Ana Krivokapic wrote: On 02/27/2013 05

[Freeipa-devel] [PATCH] 266 Fixed Web UI build error caused by rhino changes in F19

2013-03-11 Thread Petr Vobornik
option. https://fedorahosted.org/freeipa/ticket/3501 -- Petr Vobornik From 792cd392ae2ec13c4d74afb9ef7f1262b9e06c1f Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Mon, 11 Mar 2013 14:15:46 +0100 Subject: [PATCH] Fixed Web UI build error caused by rhino changes in F19 rhino

[Freeipa-devel] [PATCH] 267 Filter groups by type (normal, posix, external)

2013-03-12 Thread Petr Vobornik
complexity. https://fedorahosted.org/freeipa/ticket/3483 -- Petr Vobornik From 586a14edd30d2754a69aa304a5bd4b2f645273c5 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Mon, 11 Mar 2013 12:37:29 +0100 Subject: [PATCH] Filter groups by type (normal, posix, external) Added option

Re: [Freeipa-devel] [PATCH] 260-262 Global trust configuration page

2013-03-12 Thread Petr Vobornik
On 03/06/2013 01:42 PM, Petr Vobornik wrote: On 03/02/2013 08:40 PM, Endi Sukma Dewata wrote: - Original Message - First two patches are bug fixes which are required for third patch. Depends on my patch #259 (Combobox keyboard support) 1) [PATCH] Fix dirty state update of editable

Re: [Freeipa-devel] [WIP] Web UI Refactoring plugins effort - current state

2013-03-14 Thread Petr Vobornik
by these patches (didn't check). Known problems: * dirty dialog is displayed twice On 03/05/2013 06:34 PM, Petr Vobornik wrote: Hello, Sending current state of $subj. It's main purpose is to get rough review and design comments. Attaching patches of work done. The effort is documented at: http

Re: [Freeipa-devel] [PATCH] 263 Web UI: configurable SID blacklists

2013-03-18 Thread Petr Vobornik
On 03/06/2013 01:25 PM, Petr Vobornik wrote: On 03/04/2013 06:14 PM, Endi Sukma Dewata wrote: On 2/18/2013 10:37 AM, Petr Vobornik wrote: Added blacklists section, with ipantsidblacklistincoming and ipantsidblacklistoutgoing multivalued textbox fields, into trust details page. https

Re: [Freeipa-devel] [PATCH] 260-262 Global trust configuration page

2013-03-18 Thread Petr Vobornik
On 03/06/2013 01:42 PM, Petr Vobornik wrote: On 03/02/2013 08:40 PM, Endi Sukma Dewata wrote: - Original Message - First two patches are bug fixes which are required for third patch. Depends on my patch #259 (Combobox keyboard support) 1) [PATCH] Fix dirty state update of editable

Re: [Freeipa-devel] [PATCH] 259 Combobox keyboard support

2013-03-18 Thread Petr Vobornik
On 03/06/2013 01:37 PM, Petr Vobornik wrote: On 03/02/2013 08:38 PM, Endi Sukma Dewata wrote: On 02/27/2013 06:54 AM, Petr Vobornik wrote: On 02/27/2013 01:50 AM, Endi Sukma Dewata wrote: Another minor thing, if the search box is in focus, you can use the Up/Down arrow to go to the list

[Freeipa-devel] [PATCH] 269 Run permission target switch action only for visible widgets

2013-03-21 Thread Petr Vobornik
even targets where it doesn't belong. Fixed by running target_mapping action only for visible targets. https://fedorahosted.org/freeipa/ticket/3527 -- Petr Vobornik From 96dd0606ed8708e66fd5ca52d977d23a8156eca2 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Thu, 21 Mar 2013

[Freeipa-devel] [PATCH] 270 Load extension.js after UI AMD modules.

2013-03-21 Thread Petr Vobornik
This patch is a fix for upcoming ipa-3-1 minor release. Loading of extension.js was removed with introduction of AMD modules. This patch returns the feature to avoid regressions. In 3.2 it will be handled differently (multiple plugins). -- Petr Vobornik From

Re: [Freeipa-devel] [PATCH] 267 Filter groups by type (normal, posix, external)

2013-03-21 Thread Petr Vobornik
On 03/21/2013 05:10 PM, Martin Kosek wrote: On 03/16/2013 03:32 AM, Endi Sukma Dewata wrote: On 3/12/2013 11:28 AM, Petr Vobornik wrote: Here's a patch for filtering groups by type. Design page: http://www.freeipa.org/page/V3/Filtering_groups_by_type The interface is: StrEnum('type

[Freeipa-devel] [PATCH] 271, 272 Added Web UI support for service PAC type option: NONE

2013-03-25 Thread Petr Vobornik
On 03/15/2013 11:47 PM, Endi Sukma Dewata wrote: On 3/7/2013 7:37 AM, Petr Vobornik wrote: Ideally it should be generic enough to combine any widgets. This might be a common scenario somewhere else: Something: ( ) Option 1 ( ) Option 2 (o) Other: [something else

Re: [Freeipa-devel] [WIP] Web UI Refactoring plugins effort - current state

2013-03-28 Thread Petr Vobornik
stuff for this mail I noticed several errors in DNS and automember plugin, will fix them. -- Petr Vobornik simpleuser.js Description: application/javascript From d6e45f4f4533dfb8e60205f060e0af87218d6b9b Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Thu, 28 Mar 2013 10:45

[Freeipa-devel] [PATCH] 273 Add ipakrbokasdelegate option to service and host Web UI pages

2013-03-29 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/3329 -- Petr Vobornik From 787927ba4099418af2993ec786b69bd446f48aba Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Fri, 29 Mar 2013 16:59:44 +0100 Subject: [PATCH] Add ipakrbokasdelegate option to service and host Web UI pages

Re: [Freeipa-devel] [PATCH] 271, 272 Added Web UI support for service PAC type option: NONE

2013-03-29 Thread Petr Vobornik
On 03/27/2013 04:42 PM, Endi Sukma Dewata wrote: On 3/26/2013 12:55 PM, Endi Sukma Dewata wrote: On 3/25/2013 6:46 AM, Petr Vobornik wrote: Reimplemented ^^ to match your proposal. Attaching as patches with new numbers (271,272) as they don't have much common with the original patch

Re: [Freeipa-devel] [PATCH] 269 Run permission target switch action only for visible widgets

2013-04-05 Thread Petr Vobornik
On 03/21/2013 05:19 PM, Ana Krivokapic wrote: On 03/21/2013 04:34 PM, Petr Vobornik wrote: Permission details page was incorrectly evaluated as dirty (update button enabled) right after load when permission type={subtree,filter} and some attrs are set. Can be reproduced by opening 'Modify

[Freeipa-devel] PATCH] 275 Fix regression in group type selection in group adder dialog

2013-04-05 Thread Petr Vobornik
Refactoring of radio widget (04325fbb4c64ee4aef6d8c9adf0ff95b8b653101) caused that value is no longer supplied to value_change handler. -- Petr Vobornik From 59f4bdada6d694c86cbb275316116f7541fc Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Fri, 5 Apr 2013 13:20:23

Re: [Freeipa-devel] [RFE] Remove source hosts from HBAC

2013-04-08 Thread Petr Vobornik
the warning. But in CLI we might because user didn't had to read help beforehand. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [RFE] Remove source hosts from HBAC

2013-04-08 Thread Petr Vobornik
On 04/08/2013 03:03 PM, Rob Crittenden wrote: Petr Vobornik wrote: On 04/05/2013 07:59 PM, Ana Krivokapic wrote: Hello list, I have been thinking about the possible implementation for a solution of ticket https://fedorahosted.org/freeipa/ticket/3528. There are several options: 1. Completely

Re: [Freeipa-devel] [PATCH] 267 Filter groups by type (normal, posix, external)

2013-04-09 Thread Petr Vobornik
On 04/04/2013 12:02 PM, Martin Kosek wrote: On 04/04/2013 11:48 AM, Tomas Babej wrote: On 03/22/2013 03:03 PM, Martin Kosek wrote: On 03/21/2013 06:10 PM, Petr Vobornik wrote: On 03/21/2013 05:10 PM, Martin Kosek wrote: On 03/16/2013 03:32 AM, Endi Sukma Dewata wrote: On 3/12/2013 11:28 AM

Re: [Freeipa-devel] [PATCH] 267 Filter groups by type (normal, posix, external)

2013-04-09 Thread Petr Vobornik
On 04/09/2013 05:06 PM, Martin Kosek wrote: On 04/09/2013 04:38 PM, Petr Vobornik wrote: On 04/04/2013 12:02 PM, Martin Kosek wrote: Thanks Tomas for your opinion, I can agree with that. To make it more in an actual design, this is API following this discussion that I would propose

Re: [Freeipa-devel] [PATCH] 260-262 Global trust configuration page

2013-04-10 Thread Petr Vobornik
On 03/19/2013 05:04 AM, Endi Sukma Dewata wrote: On 3/18/2013 6:30 AM, Petr Vobornik wrote: The static page and the code looks good, but do you have a live server that I could take a look at? https:///ipa/ui/#trusts=trustconfigipaserver=trustsnavigation=ipaserver Thanks. ACK

Re: [Freeipa-devel] PATCH] 275 Fix regression in group type selection in group adder dialog

2013-04-10 Thread Petr Vobornik
On 04/05/2013 02:50 PM, Ana Krivokapic wrote: On 04/05/2013 01:28 PM, Petr Vobornik wrote: Refactoring of radio widget (04325fbb4c64ee4aef6d8c9adf0ff95b8b653101) caused that value is no longer supplied to value_change handler. ACK. Pushed to master -- Petr Vobornik

[Freeipa-devel] Web UI refactoring effort ready for review

2013-04-22 Thread Petr Vobornik
, -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 402 Add userClass attribute for hosts

2013-04-23 Thread Petr Vobornik
Which raises UI questions: 1) Do we want to add the class attrs to user and host adder dialogs? (to allow automember to kick in) 2) Do we want to add the attrs to user and host details pages? (to keep CLI and UI in sync) -- Petr Vobornik ___ Freeipa

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-24 Thread Petr Vobornik
. 3. delete ./facets module Use ./reg an ./builder instead. Incorporate it into router to support standalone facets. Done, but not tested. I'll create plugin example to test it. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-24 Thread Petr Vobornik
On 04/24/2013 06:03 PM, Alexander Bokovoy wrote: On Wed, 24 Apr 2013, Petr Vobornik wrote: I've implemented the remaining work. Pushed to the private repo. Know problems remaining work -- 1. Change generation of plugin index to dynamical instead of rpm-post

Re: [Freeipa-devel] [PATCH 0052] Make gecos field editable in Web UI

2013-04-25 Thread Petr Vobornik
On 04/24/2013 03:07 PM, Tomas Babej wrote: Hi, This patch exposes user entry gecos field in Web UI. https://fedorahosted.org/freeipa/ticket/3569 Tomas ACK, pushed to master. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-26 Thread Petr Vobornik
much, it is just a nice to have (does not make sense to 'expand all' if everything is already expanded). Open a ticket. I wonder how many users is using this feature. Personally, I don't. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-26 Thread Petr Vobornik
/2013 12:51 PM, Petr Vobornik wrote: On 04/25/2013 06:37 PM, Ana Krivokapic wrote: Hi, While reviewing and testing the new UI changes, I have encountered the following issues. (Some of them may be unrelated to the webUI refactoring effort, but I will list them here just so we are aware of them

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-26 Thread Petr Vobornik
Another problem found: trustconfig had invalid spec which made the trust section quite unusable. Fixed and pushed to the private repo. I also took an opportunity and added missing parts of trust metadata for static testing. On 04/26/2013 04:32 PM, Petr Vobornik wrote: Hi, 1, 2 and 3a

[Freeipa-devel] [PATCH] 276 Fix: Certificate status is not visible in Service and Host page

2013-04-26 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/3593 -- Petr Vobornik From 661f1a6b7e5c295f99f0c144dc69fba444ffe6d2 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Fri, 26 Apr 2013 18:41:09 +0200 Subject: [PATCH] Fix: Certificate status is not visible in Service and Host page

Re: [Freeipa-devel] [PATCH] 276 Fix: Certificate status is not visible in Service and Host page

2013-04-30 Thread Petr Vobornik
On 04/29/2013 01:05 PM, Ana Krivokapic wrote: On 04/26/2013 06:43 PM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/3593 ACK Pushed to master. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-30 Thread Petr Vobornik
to not be much useful yet because it's search is limited only to one array, which is not enough To test the plugins put them into: /usr/share/ipa/ui/js/plugins/usermod /usr/share/ipa/ui/js/plugins/simpleuser On 04/26/2013 06:15 PM, Petr Vobornik wrote: Another problem found: trustconfig had invalid

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-03 Thread Petr Vobornik
On 05/03/2013 12:44 PM, Ana Krivokapic wrote: On 04/26/2013 12:51 PM, Petr Vobornik wrote: On 04/25/2013 06:37 PM, Ana Krivokapic wrote: 1) When in self service mode, you are now allowed to go to pages of related objects. If you go to e.g. User Groups for your user, there are Add/Delete

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-03 Thread Petr Vobornik
Update: * added ticket number to every commit, some commit messages improved * ~4 commits squashed * rebased on current master On 04/30/2013 07:19 PM, Petr Vobornik wrote: Update: * rebased on current master an force-pushed to private repo * fixed crash when IPA installed without CA * fixed

Re: [Freeipa-devel] [PATCH] Resolve SIDs in Web UI

2013-05-06 Thread Petr Vobornik
@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Resolve SIDs in Web UI

2013-05-06 Thread Petr Vobornik
that could further be removed, I haven't looked into greater detail. Please note that attached patch only covers parts in install/ui/src/freeipa, you'd still need to add plugin changes from ipalib/plugins/trust.py. -- Petr Vobornik diff --git a/install/ui/src/freeipa/association.js b/install/ui/src

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-06 Thread Petr Vobornik
that would warrant a NACK. As long as the API is well documented for plugin writers it should be sufficient. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0027 Prompt for nameserver IP address in dnszone-add

2013-05-13 Thread Petr Vobornik
there is no text_widget.is_enabled() method so `zone_w.input.prop('disabled')` can't be replaced. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0026 Do not display success message on failure in web UI

2013-05-13 Thread Petr Vobornik
touching these parts of code. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0027 Prompt for nameserver IP address in dnszone-add

2013-05-14 Thread Petr Vobornik
On 05/14/2013 01:36 PM, Ana Krivokapic wrote: On 05/14/2013 12:05 PM, Ana Krivokapic wrote: On 05/13/2013 02:50 PM, Petr Vobornik wrote: A nitpick for UI part which is not a blocker(nack) because we don't have any strict rules for following topic: We should avoid depending on widget's html

[Freeipa-devel] [PATCH] 413 Fix: HBAC Test tab is missing

2013-05-14 Thread Petr Vobornik
Fix for really stupid mistake with quite big impact... Caused by typo in metadata provider source path. No metadata - no HBAC test entity - no tab https://fedorahosted.org/freeipa/ticket/3627 -- Petr Vobornik From 5b1fc24ae1e28ce8a775fb7923cedfba397a210f Mon Sep 17 00:00:00 2001 From: Petr

[Freeipa-devel] [PATCH] 414-415 Move spec modifications from facet factories to pre_ops

2013-05-15 Thread Petr Vobornik
with the ones defined for the facets in these modules. The move simplifies module dependencies - there is no reason to have general facet module dependent on specialized facet modules. Pre_ops uniting makes the code simpler. https://fedorahosted.org/freeipa/ticket/3605 -- Petr Vobornik From

[Freeipa-devel] [PATCH] 416 Web UI: move ./_base/metadata_provider.js to ./metadata.js

2013-05-15 Thread Petr Vobornik
Metadata provider is IPA specific object, not a framework object, so it should not be in _base directory. https://fedorahosted.org/freeipa/ticket/3604 -- Petr Vobornik From 144e68a2a849c7b5fd176359c03142dbb27e4d24 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Tue, 14

Re: [Freeipa-devel] [PATCH] 0026 Do not display success message on failure in web UI

2013-05-16 Thread Petr Vobornik
On 05/15/2013 05:43 PM, Ana Krivokapic wrote: On 05/13/2013 04:51 PM, Petr Vobornik wrote: On 05/07/2013 05:16 PM, Ana Krivokapic wrote: https://fedorahosted.org/freeipa/ticket/3591 1) The change from on_success to on_error is causing problems when some command in a batch doesn't fail. Ie

Re: [Freeipa-devel] [PATCH] 414-415 Move spec modifications from facet factories to pre_ops

2013-05-16 Thread Petr Vobornik
On 05/15/2013 04:02 PM, Ana Krivokapic wrote: On 05/15/2013 12:09 PM, Petr Vobornik wrote: [PATCH] 414 Move spec modifications from facet factories to pre_ops --- Spec modifications in factories makes inheritance and extensibility

Re: [Freeipa-devel] [PATCH] 416 Web UI: move ./_base/metadata_provider.js to ./metadata.js

2013-05-17 Thread Petr Vobornik
On 05/15/2013 04:03 PM, Ana Krivokapic wrote: On 05/15/2013 12:19 PM, Petr Vobornik wrote: Metadata provider is IPA specific object, not a framework object, so it should not be in _base directory. https://fedorahosted.org/freeipa/ticket/3604 ACK -- Regards, Ana Krivokapic Pushed

Re: [Freeipa-devel] [PATCH] 414-415 Move spec modifications from facet factories to pre_ops

2013-05-17 Thread Petr Vobornik
On 05/16/2013 02:01 PM, Petr Vobornik wrote: On 05/15/2013 04:02 PM, Ana Krivokapic wrote: On 05/15/2013 12:09 PM, Petr Vobornik wrote: [PATCH] 414 Move spec modifications from facet factories to pre_ops --- Spec modifications

Re: [Freeipa-devel] [PATCH] 0026 Do not display success message on failure in web UI

2013-05-17 Thread Petr Vobornik
On 05/16/2013 04:26 PM, Ana Krivokapic wrote: On 05/16/2013 01:20 PM, Petr Vobornik wrote: On 05/15/2013 05:43 PM, Ana Krivokapic wrote: On 05/13/2013 04:51 PM, Petr Vobornik wrote: On 05/07/2013 05:16 PM, Ana Krivokapic wrote: https://fedorahosted.org/freeipa/ticket/3591 1) The change

[Freeipa-devel] [PATCH] 417 Regression fix: missing control buttons in nested search facets

2013-05-29 Thread Petr Vobornik
Automount maps, keys and dnsrecord search facet are missing control buttons (add, delete, refresh). Regression introduced by 6e90920233cc9a7c9feb040dea22cda837715c39 - 'Move spec modifications from facet factories to pre_ops'. https://fedorahosted.org/freeipa/ticket/3605 -- Petr Vobornik

[Freeipa-devel] [PATCH] 418 Make ssbrowser.html work in IE 10

2013-05-29 Thread Petr Vobornik
://fedorahosted.org/freeipa/ticket/3645 -- Petr Vobornik From af2c2fb00e0146f60ad31f17fba25be5e89120af Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Wed, 29 May 2013 13:06:11 +0200 Subject: [PATCH] Make ssbrowser.html work in IE 10 Manual configuration page for other browsers

Re: [Freeipa-devel] [PATCH] 417 Regression fix: missing control buttons in nested search facets

2013-06-03 Thread Petr Vobornik
On 05/29/2013 01:43 PM, Ana Krivokapic wrote: On 05/29/2013 10:38 AM, Petr Vobornik wrote: Automount maps, keys and dnsrecord search facet are missing control buttons (add, delete, refresh). Regression introduced by 6e90920233cc9a7c9feb040dea22cda837715c39 - 'Move spec modifications from facet

Re: [Freeipa-devel] [PATCH] 418 Make ssbrowser.html work in IE 10

2013-06-04 Thread Petr Vobornik
On 06/03/2013 06:18 PM, Ana Krivokapic wrote: On 05/29/2013 01:15 PM, Petr Vobornik wrote: Manual configuration page for other browsers (ssbrowser.html) doesn't work in IE 10 - error page is displayed. This patch is conditioning creation of Firefox configuration object so that configure.jar

Re: [Freeipa-devel] [RFE] Integration testing

2013-06-04 Thread Petr Vobornik
protocol: * python-paramiko Naturally, the new dependencies are not needed in a production environment. = External Impact = Cooperation with QE is underway. = Design author = [[User:pviktorin|Petr Viktorin]] -- Petr Vobornik ___ Freeipa-devel

Re: [Freeipa-devel] [RFE] Integration testing

2013-06-05 Thread Petr Vobornik
On 06/04/2013 07:19 PM, Petr Viktorin wrote: On 06/04/2013 06:15 PM, Petr Vobornik wrote: Hello, Some Qs: 1) does the configuration only mean: We have this topology, run all test which fits into it? Not quite, it means We have these machines, run tests whose topology can fit on them. IDK

[Freeipa-devel] [PATCH] 419 Fix regression: missing facet tab group labels

2013-06-05 Thread Petr Vobornik
Currently there is only empty space between facet tabs and facet title. It's a regression caused by recent refactoring. https://fedorahosted.org/freeipa/ticket/3688 -- Petr Vobornik From 7914c069d0271546673b6c8289479eb16789c621 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com

Re: [Freeipa-devel] [PATCH] 419 Fix regression: missing facet tab group labels

2013-06-05 Thread Petr Vobornik
On 06/05/2013 02:45 PM, Ana Krivokapic wrote: On 06/05/2013 01:07 PM, Petr Vobornik wrote: Currently there is only empty space between facet tabs and facet title. It's a regression caused by recent refactoring. https://fedorahosted.org/freeipa/ticket/3688 ACK Pushed to master, ipa-3-2

Re: [Freeipa-devel] [PATCH] 420 Regression fix: rule table with ext. member support doesn't offer any items

2013-06-13 Thread Petr Vobornik
On 06/13/2013 02:46 PM, Ana Krivokapic wrote: On 06/13/2013 12:30 PM, Petr Vobornik wrote: Rule tables with external member has more than one column and therefore exclude parameter for adder dialog is not array of strings but array of objects. normalize_values function can't work

Re: [Freeipa-devel] [PATCH] 0036 Fix displaying of success message

2013-06-13 Thread Petr Vobornik
On 06/13/2013 05:33 PM, Ana Krivokapic wrote: On 06/13/2013 05:18 PM, Petr Vobornik wrote: On 06/13/2013 04:16 PM, Ana Krivokapic wrote: Hello, Make sure that the success message in web UI is properly populated with actual number of items that were successfully added/removed. https

Re: [Freeipa-devel] [PATCH] 420 Regression fix: rule table with ext. member support doesn't offer any items

2013-06-13 Thread Petr Vobornik
On 06/13/2013 05:13 PM, Ana Krivokapic wrote: On 06/13/2013 03:24 PM, Petr Vobornik wrote: On 06/13/2013 02:46 PM, Ana Krivokapic wrote: On 06/13/2013 12:30 PM, Petr Vobornik wrote: Rule tables with external member has more than one column and therefore exclude parameter for adder dialog

[Freeipa-devel] [PATCH] 421 Fix default value selection in radio widget

2013-06-18 Thread Petr Vobornik
Fix default value selection in radio widget https://fedorahosted.org/freeipa/ticket/3718 -- Petr Vobornik From 9df5d05592e247b9d082377c0c309efbc5e1f74d Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Tue, 18 Jun 2013 18:11:04 +0200 Subject: [PATCH] Fix default value

Re: [Freeipa-devel] [PATCH] 412 Remove entitlement support

2013-06-19 Thread Petr Vobornik
ACK on Web UI part. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 421 Fix default value selection in radio widget

2013-06-24 Thread Petr Vobornik
On 06/20/2013 06:11 PM, Ana Krivokapic wrote: On 06/18/2013 07:28 PM, Petr Vobornik wrote: Fix default value selection in radio widget https://fedorahosted.org/freeipa/ticket/3718 The web UI now displays 'Forward policy' as 'Forward first' when no policy is active (e.g. in case of empty

Re: [Freeipa-devel] [PATCH] 421 Fix default value selection in radio widget

2013-06-24 Thread Petr Vobornik
On 06/24/2013 04:01 PM, Ana Krivokapic wrote: On 06/24/2013 12:42 PM, Petr Vobornik wrote: On 06/20/2013 06:11 PM, Ana Krivokapic wrote: On 06/18/2013 07:28 PM, Petr Vobornik wrote: Fix default value selection in radio widget https://fedorahosted.org/freeipa/ticket/3718 The web UI now

[Freeipa-devel] [PATCH] 425 Do not redirect to https in /ipa/ui on non-HTML files

2013-06-24 Thread Petr Vobornik
Those resources are needed by page which has to use http(browser config) prior to acceptance of CA cert. https://fedorahosted.org/freeipa/ticket/3748 -- Petr Vobornik From 892ab95f1fe6fe9c186f1bdc84f218fcb1e0c147 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Mon, 24 Jun

Re: [Freeipa-devel] [PATCH] 425 Do not redirect to https in /ipa/ui on non-HTML files

2013-06-25 Thread Petr Vobornik
On 06/25/2013 12:22 PM, Martin Kosek wrote: On 06/24/2013 07:00 PM, Tomas Babej wrote: On 06/24/2013 06:13 PM, Petr Vobornik wrote: Those resources are needed by page which has to use http(browser config) prior to acceptance of CA cert. https://fedorahosted.org/freeipa/ticket/3748

[Freeipa-devel] [PATCH] 426 Create Firefox configuration extension on CA-less install

2013-06-26 Thread Petr Vobornik
Create: * kerberosauth.xpi * krb.js even when --http_pkcs12 option is used. https://fedorahosted.org/freeipa/ticket/3747 -- Petr Vobornik From 8a0f26fd473c39be255592ddc8f42100ea466d2b Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Tue, 25 Jun 2013 16:53:24 +0200 Subject

[Freeipa-devel] [PATCH] 427 Disable checkboxes and radios for readonly attributes

2013-06-28 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/3764 -- Petr Vobornik From c7e435978e82c76483f71fb82fce1a3fabf016a7 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Fri, 28 Jun 2013 14:52:11 +0200 Subject: [PATCH] Disable checkboxes and radios for readonly attributes https

Re: [Freeipa-devel] [PATCH] 422-424 Web UI integration tests

2013-07-16 Thread Petr Vobornik
On 07/16/2013 12:58 PM, Ana Krivokapic wrote: On 07/16/2013 12:54 PM, Petr Vobornik wrote: On 07/16/2013 12:33 PM, Ana Krivokapic wrote: On 07/16/2013 10:52 AM, Petr Vobornik wrote: On 07/09/2013 05:37 PM, Ana Krivokapic wrote: On 06/21/2013 10:56 AM, Petr Vobornik wrote: Sending an initial

Re: [Freeipa-devel] [PATCH] 0045 Expose ipaRangeType in Web UI

2013-07-17 Thread Petr Vobornik
'ipasecondarybaserid' should be required and enabled only when 'ipabaserid' is set. Additionally, both should be required and enabled if adtrust_is_enabled (in UI: `IPA.trust_enabled`). -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel

[Freeipa-devel] [PATCH] 428 Hide delete button in multivalued widget if attr is not writable

2013-07-18 Thread Petr Vobornik
Hide delete button in multivalued widget if attr is not writable https://fedorahosted.org/freeipa/ticket/3799 -- Petr Vobornik From 0f133f0aa47f0bd1b6567c3adeb37e58e73df859 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Fri, 28 Jun 2013 16:14:45 +0200 Subject: [PATCH

[Freeipa-devel] [PATCH] 429 Make ssh_widget not-editable if attr is readonly

2013-07-18 Thread Petr Vobornik
Make ssh_widget not-editable if attr is readonly Depends on patch pvoborni-428. https://fedorahosted.org/freeipa/ticket/3800 -- Petr Vobornik From df1d96dcd9996d6849521f0e36cdd6e04e8d3b14 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Fri, 28 Jun 2013 16:50:52 +0200

[Freeipa-devel] [PATCH] 430 Break long words in notification area

2013-07-18 Thread Petr Vobornik
Long words (ie. service principal) breaks out of notification area. It doesn't look good. Patch adds word-wrap to break them to multiple pieces. Reproduction: modify a service in Web UI -- Petr Vobornik From cc8462c8166c51d3241f1a5efd261d0dc4d6e07b Mon Sep 17 00:00:00 2001 From: Petr Vobornik

[Freeipa-devel] [PATCH] 431-434 Web UI integration tests continuation

2013-07-18 Thread Petr Vobornik
by code from xmlrpc tests. To obtain ranges, this patch also adds method to execute FreeIPA command through Web UI. It uses Web UI instead of ipalib so it doesn't need to care about authentication on a test-runner machine. All: https://fedorahosted.org/freeipa/ticket/3744 -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 431-434 Web UI integration tests continuation

2013-07-18 Thread Petr Vobornik
On 07/18/2013 01:34 PM, Petr Vobornik wrote: [PATCH] 431 Web UI integration tests: Add trust tests [PATCH] 432 Web UI integration tests: Add ui_driver method descriptions [PATCH] 433 Web UI integration tests: Verify data after add and mod [PATCH] 434 Web UI integration tests: Compute range

[Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label

2013-07-19 Thread Petr Vobornik
Remove word 'field' from GECOS param label No other param/field has 'field' in a label. -- Petr Vobornik From a7f58da057c41c0902fde6b4f0c66d6ba5d5fdec Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Fri, 19 Jul 2013 13:35:17 +0200 Subject: [PATCH] Remove word 'field' from

Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label

2013-07-19 Thread Petr Vobornik
On 07/19/2013 02:20 PM, Jan Pazdziora wrote: On Fri, Jul 19, 2013 at 01:44:57PM +0200, Petr Vobornik wrote: Remove word 'field' from GECOS param label No other param/field has 'field' in a label. I'm not sure I'm in favour of the change. Calling it just GECOS does not make much sense because

Re: [Freeipa-devel] [PATCHES] 143-147 Improve performance with large groups

2013-07-19 Thread Petr Vobornik
On 07/19/2013 03:49 PM, Jan Cholasta wrote: On 19.7.2013 13:10, Petr Vobornik wrote: On 07/18/2013 05:29 PM, Jan Cholasta wrote: On 18.7.2013 17:26, Martin Kosek wrote: On 07/18/2013 05:22 PM, Jan Cholasta wrote: On 18.7.2013 17:07, Martin Kosek wrote: On 07/18/2013 04:53 PM, Jan Cholasta

Re: [Freeipa-devel] [PATCH] 428 Hide delete button in multivalued widget if attr is not writable

2013-07-19 Thread Petr Vobornik
On 07/18/2013 05:50 PM, James wrote: On Thu, 2013-07-18 at 12:11 +0200, Petr Vobornik wrote: Hide delete button in multivalued widget if attr is not writable Hey, Maybe it would be a good idea to set the disabled state of the button instead of removing it? That way it's obvious that some

Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label

2013-07-22 Thread Petr Vobornik
On 07/19/2013 11:19 PM, Dmitri Pal wrote: On 07/19/2013 09:26 AM, Jan Pazdziora wrote: On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote: Disclaimer: I have no strong feelings in this matter, it just looks weird to me, so I'm OK with not doing it if it's general consensus

Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label

2013-07-23 Thread Petr Vobornik
On 07/22/2013 05:33 PM, Ana Krivokapic wrote: On 07/22/2013 09:01 AM, Martin Kosek wrote: On 07/19/2013 11:19 PM, Dmitri Pal wrote: On 07/19/2013 09:26 AM, Jan Pazdziora wrote: On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote: Disclaimer: I have no strong feelings in this matter

Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label

2013-07-23 Thread Petr Vobornik
On 07/23/2013 09:02 AM, Martin Kosek wrote: On 07/23/2013 01:31 AM, Dmitri Pal wrote: On 07/22/2013 08:38 AM, Petr Vobornik wrote: On 07/19/2013 11:19 PM, Dmitri Pal wrote: On 07/19/2013 09:26 AM, Jan Pazdziora wrote: On Fri, Jul 19, 2013 at 03:17:49PM +0200, Petr Vobornik wrote: Disclaimer

Re: [Freeipa-devel] [PATCH] 436 Remove word 'field' from GECOS param label

2013-07-23 Thread Petr Vobornik
On 07/23/2013 01:12 PM, Ana Krivokapic wrote: On 07/23/2013 12:58 PM, Petr Vobornik wrote: On 07/22/2013 05:33 PM, Ana Krivokapic wrote: On 07/22/2013 09:01 AM, Martin Kosek wrote: On 07/19/2013 11:19 PM, Dmitri Pal wrote: On 07/19/2013 09:26 AM, Jan Pazdziora wrote: On Fri, Jul 19, 2013

Re: [Freeipa-devel] [PATCH] 430 Break long words in notification area

2013-07-23 Thread Petr Vobornik
On 07/22/2013 05:19 PM, Ana Krivokapic wrote: On 07/18/2013 12:58 PM, Petr Vobornik wrote: Long words (ie. service principal) breaks out of notification area. It doesn't look good. Patch adds word-wrap to break them to multiple pieces. Reproduction: modify a service in Web UI ACK Pushed

Re: [Freeipa-devel] [PATCH] 0047 Honor 'enabled' option for widgets

2013-07-23 Thread Petr Vobornik
On 07/22/2013 04:46 PM, Ana Krivokapic wrote: On 07/18/2013 09:47 AM, Petr Vobornik wrote: On 07/17/2013 09:18 PM, Ana Krivokapic wrote: Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3793. Hello, 1) IMO we should not create attribute which is just a negation

<    1   2   3   4   5   6   7   8   9   10   >