gkaihorodova's pull request #32: "Test for caacl-add-service" was opened
PR body:
"""
Test for caacl-add-service: incorrect error message when service does not exists
https://fedorahosted.org/freeipa/ticket/6171
"""
See the full pull-request at https://github.com/freeipa/freeipa/pull/32
... or p
mirielka's pull request #17: "Tests: Random issuer certificate can be added to
a service" label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/17
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/fre
mirielka's pull request #39: "Tests: Add missing attributes to
test_xmlrpc/test_trust tests" label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/39
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/
URL: https://github.com/freeipa/freeipa/pull/147
Author: gkaihorodova
Title: #147: Tests: Unaccessible variable self.attrs in Tracker
Action: opened
PR body:
"""
https://fedorahosted.org/freeipa/ticket/6125
"""
To pull the PR as Git branch:
git remote ad
URL: https://github.com/freeipa/freeipa/pull/147
Author: gkaihorodova
Title: #147: Tests: Unaccessible variable self.attrs in Tracker
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/147/head:pr147
git checkout
URL: https://github.com/freeipa/freeipa/pull/148
Author: gkaihorodova
Title: #148: Unaccessible variable self.attrs in Tracker
Action: opened
PR body:
"""
In tracker, 'self.attrs' variable is created and filled in track_create method.
Some objects are not created bu
URL: https://github.com/freeipa/freeipa/pull/148
Title: #148: Unaccessible variable self.attrs in Tracker
gkaihorodova commented:
"""
You're right, empty dict is more applicable here. I will close that one and
open new with suggested fix.
"""
See the
URL: https://github.com/freeipa/freeipa/pull/148
Author: gkaihorodova
Title: #148: Unaccessible variable self.attrs in Tracker
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/148/head:pr148
git checkout pr148
URL: https://github.com/freeipa/freeipa/pull/149
Author: gkaihorodova
Title: #149: Tests: Unaccessible variable self.attrs in Tracker
Action: opened
PR body:
"""
In tracker, 'self.attrs' variable is created and filled in track_create method.
Some objects are not
URL: https://github.com/freeipa/freeipa/pull/148
Author: gkaihorodova
Title: #148: Unaccessible variable self.attrs in Tracker
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/148/head:pr148
git checkout
URL: https://github.com/freeipa/freeipa/pull/181
Author: gkaihorodova
Title: #181: Tests : User Tracker creation of user with minimal values
Action: opened
PR body:
"""
Fix provide possibility to create user-add test with minimal values,
where uid is not specified, to provide
URL: https://github.com/freeipa/freeipa/pull/181
Author: gkaihorodova
Title: #181: Tests : User Tracker creation of user with minimal values
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/181/head:pr181
URL: https://github.com/freeipa/freeipa/pull/181
Author: gkaihorodova
Title: #181: Tests : User Tracker creation of user with minimal values
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/181/head:pr181
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
gkaihorodova commented:
"""
Yes, It's a valid point to add testcases for these changes . Will do. Thank
you.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/181
Author: gkaihorodova
Title: #181: Tests : User Tracker creation of user with minimal values
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/181/head:pr181
URL: https://github.com/freeipa/freeipa/pull/210
Author: gkaihorodova
Title: #210: Tests: Stage User Tracker implementation
Action: opened
PR body:
"""
Fix provide possibility of creation stage user with minimal values,
with uid not specified. Implementation is the same as f
URL: https://github.com/freeipa/freeipa/pull/210
Author: gkaihorodova
Title: #210: Tests: Stage User Tracker implementation
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/210/head:pr210
git checkout pr210
URL: https://github.com/freeipa/freeipa/pull/119
Title: #119: Tests: Providing trust tests with tree root domain
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/C
URL: https://github.com/freeipa/freeipa/pull/210
Author: gkaihorodova
Title: #210: Tests: Stage User Tracker implementation
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/210/head:pr210
git checkout pr210
URL: https://github.com/freeipa/freeipa/pull/210
Author: gkaihorodova
Title: #210: Tests: Stage User Tracker implementation
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/210/head:pr210
git checkout pr210
URL: https://github.com/freeipa/freeipa/pull/181
Author: gkaihorodova
Title: #181: Tests : User Tracker creation of user with minimal values
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/181/head:pr181
URL: https://github.com/freeipa/freeipa/pull/181
Author: gkaihorodova
Title: #181: Tests : User Tracker creation of user with minimal values
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/181/head:pr181
URL: https://github.com/freeipa/freeipa/pull/181
Author: gkaihorodova
Title: #181: Tests : User Tracker creation of user with minimal values
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/181/head:pr181
URL: https://github.com/freeipa/freeipa/pull/210
Author: gkaihorodova
Title: #210: Tests: Stage User Tracker implementation
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/210/head:pr210
git checkout pr210
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
gkaihorodova commented:
"""
will do, but before let me do small changes that was requested by @stlaz in
#210, to use str.format() instead of " %r "
URL: https://github.com/freeipa/freeipa/pull/210
Author: gkaihorodova
Title: #210: Tests: Stage User Tracker implementation
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/210/head:pr210
git checkout pr210
URL: https://github.com/freeipa/freeipa/pull/181
Author: gkaihorodova
Title: #181: Tests : User Tracker creation of user with minimal values
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/181/head:pr181
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
gkaihorodova commented:
"""
Yes, the intention was to have repr() of the given string , so I'll use ''{!r}
instead of '{}', and a
URL: https://github.com/freeipa/freeipa/pull/181
Author: gkaihorodova
Title: #181: Tests : User Tracker creation of user with minimal values
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/181/head:pr181
URL: https://github.com/freeipa/freeipa/pull/210
Author: gkaihorodova
Title: #210: Tests: Stage User Tracker implementation
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/210/head:pr210
git checkout pr210
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
gkaihorodova commented:
"""
Thank you for review!
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/181#issuecomment-27123664
URL: https://github.com/freeipa/freeipa/pull/386
Author: gkaihorodova
Title: #386: Tests: Add tree root domain role in legacy client tests
Action: opened
PR body:
"""
Legacy client tests inherits test cases from trust tests, that have
role for tree root domain. That role was mi
URL: https://github.com/freeipa/freeipa/pull/386
Author: gkaihorodova
Title: #386: Tests: Add tree root domain role in legacy client tests
Action: edited
Changed field: body
Original value:
"""
Legacy client tests inherits test cases from trust tests, that have
role for t
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
gkaihorodova commented:
"""
@mbasti-rh done. hope now it's fine
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/18
URL: https://github.com/freeipa/freeipa/pull/210
Author: gkaihorodova
Title: #210: Tests: Stage User Tracker implementation
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/210/head:pr210
git checkout pr210
URL: https://github.com/freeipa/freeipa/pull/181
Author: gkaihorodova
Title: #181: Tests : User Tracker creation of user with minimal values
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/181/head:pr181
URL: https://github.com/freeipa/freeipa/pull/448
Author: gkaihorodova
Title: #448: Tests: Basic coverage with tree root domain
Action: opened
PR body:
"""
Tests: Basic coverage with tree root domain
Extend existing legacy client tests to cover test cases with tree roo
URL: https://github.com/freeipa/freeipa/pull/448
Title: #448: Tests: Basic coverage with tree root domain
gkaihorodova commented:
"""
Can you be a little bit more specific about "triplication of the test cases ",
please.
Because, to be honest, I'm having hard
URL: https://github.com/freeipa/freeipa/pull/448
Title: #448: Tests: Basic coverage with tree root domain
gkaihorodova commented:
"""
Thank you for explanation and tips. I noticed it as well and I agree that it
(and not only that) worth refactoring. Yes, my PR is more or
URL: https://github.com/freeipa/freeipa/pull/448
Title: #448: Tests: Basic coverage with tree root domain
gkaihorodova commented:
"""
Yes, sure I'll work on these issues
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/448#iss
URL: https://github.com/freeipa/freeipa/pull/448
Author: gkaihorodova
Title: #448: Tests: Basic coverage with tree root domain
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/448/head:pr448
git checkout
URL: https://github.com/freeipa/freeipa/pull/448
Title: #448: Tests: Basic coverage with tree root domain
gkaihorodova commented:
"""
Bump for review
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/448#issuecomment-282664683
--
Manage you
URL: https://github.com/freeipa/freeipa/pull/448
Title: #448: Tests: Basic coverage with tree root domain
gkaihorodova commented:
"""
Thanks you for review. Let's hope for the best .
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/448#iss
43 matches
Mail list logo