[Freeipa-devel] [freeipa PR#53] Fix ScriptError to always return string from __str__ (+pushed)

2016-09-05 Thread mbasti-rh
mbasti-rh's pull request #53: "Fix ScriptError to always return string from __str__" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/53 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#53] Fix ScriptError to always return string from __str__ (closed)

2016-09-05 Thread mbasti-rh
mbasti-rh's pull request #53: "Fix ScriptError to always return string from __str__" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/53 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#57] Use RSA-OAEP instead of RSA PKCS#1 v1.5 (closed)

2016-09-05 Thread mbasti-rh
tiran's pull request #57: "Use RSA-OAEP instead of RSA PKCS#1 v1.5" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/57 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/57/head:pr57 git checkout

[Freeipa-devel] [freeipa PR#56] Use RSA-OAEP instead of RSA PKCS#1 v1.5 (comment)

2016-09-05 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/4ae4d0d6909e99892442a170288f0eee9610d1c2 ipa-4-4: https://fedorahosted.org/freeipa/changeset/71e7cb124d021f976eebb6e99fc012becf94a9b6 """ See the full

[Freeipa-devel] [freeipa PR#56] Use RSA-OAEP instead of RSA PKCS#1 v1.5 (+pushed)

2016-09-05 Thread mbasti-rh
tiran's pull request #56: "Use RSA-OAEP instead of RSA PKCS#1 v1.5" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/56 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#56] Use RSA-OAEP instead of RSA PKCS#1 v1.5 (closed)

2016-09-05 Thread mbasti-rh
tiran's pull request #56: "Use RSA-OAEP instead of RSA PKCS#1 v1.5" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/56 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/56/head:pr56 git checkout

[Freeipa-devel] [freeipa PR#54] cli: use full name when executing a command (comment)

2016-09-05 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/a3d178b86ddff9335228d99fe06e8fc89a00235a ipa-4-4: https://fedorahosted.org/freeipa/changeset/136a649a9e1da26e28b7151af061f8094b0f1d22 """ See the full

[Freeipa-devel] [freeipa PR#54] cli: use full name when executing a command (+pushed)

2016-09-05 Thread mbasti-rh
jcholast's pull request #54: "cli: use full name when executing a command" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/54 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#54] cli: use full name when executing a command (closed)

2016-09-05 Thread mbasti-rh
jcholast's pull request #54: "cli: use full name when executing a command" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/54 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/54/head:pr54 git

[Freeipa-devel] [freeipa PR#56] Use RSA-OAEP instead of RSA PKCS#1 v1.5 (+ack)

2016-09-05 Thread mbasti-rh
tiran's pull request #56: "Use RSA-OAEP instead of RSA PKCS#1 v1.5" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/56 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute

[Freeipa-devel] [freeipa PR#57] Use RSA-OAEP instead of RSA PKCS#1 v1.5 (+ack)

2016-09-05 Thread mbasti-rh
tiran's pull request #57: "Use RSA-OAEP instead of RSA PKCS#1 v1.5" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/57 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute

[Freeipa-devel] [freeipa PR#54] cli: use full name when executing a command (+ack)

2016-09-05 Thread mbasti-rh
jcholast's pull request #54: "cli: use full name when executing a command" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/54 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#58] Ip addr validation (opened)

2016-09-05 Thread mbasti-rh
mbasti-rh's pull request #58: "Ip addr validation" was opened PR body: """ """ See the full pull-request at https://github.com/freeipa/freeipa/pull/58 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/58/head:pr58 git checkout

[Freeipa-devel] [freeipa PR#55] Fix parse errors with link-local addresses (opened)

2016-09-05 Thread mbasti-rh
mbasti-rh's pull request #55: "Fix parse errors with link-local addresses" was opened PR body: """ Link-local addresses received from netifaces contains '%suffix' that causes parse error in IPNetwork class. We must remove %suffix before it us used in IPNetwork objects.

[Freeipa-devel] [freeipa PR#53] Fix ScriptError to always return string from __str__ (opened)

2016-09-05 Thread mbasti-rh
mbasti-rh's pull request #53: "Fix ScriptError to always return string from __str__" was opened PR body: """ Use super for proper handling of exceptions. msg property was added due compatibility with the current code. https://fedorahosted.org/freeipa/ticket/6294 """ See the full pull-request

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (+ack)

2016-09-05 Thread mbasti-rh
ofayans's pull request #52: "Removed incorrect check for returncode" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/52 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

2016-09-05 Thread mbasti-rh
mbasti-rh commented on a pull request """ ACK: Removed incorrect check for returncode NACK: Several fixes in replica_promotion tests -- missing explanation in commit messages why this change is needed, if changes are unrelated should be in multiple patches ACK: Cha

[Freeipa-devel] [freeipa PR#48] [4.4] Set zanata project-version fo 4.4 branch (opened)

2016-09-01 Thread mbasti-rh
mbasti-rh's pull request #48: "[4.4] Set zanata project-version fo 4.4 branch" was opened PR body: """ """ See the full pull-request at https://github.com/freeipa/freeipa/pull/48 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#42] Tests: Avoid skipping tests due to missing files (closed)

2016-09-01 Thread mbasti-rh
mirielka's pull request #42: "Tests: Avoid skipping tests due to missing files" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/42 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/42/head:pr42

[Freeipa-devel] [freeipa PR#42] Tests: Avoid skipping tests due to missing files (+pushed)

2016-09-01 Thread mbasti-rh
mirielka's pull request #42: "Tests: Avoid skipping tests due to missing files" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/42 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#34] dns: prompt for missing record parts in CLI (comment)

2016-09-01 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fix works for me partially, it fixes issues reported in ticket. Do you want to open new ticket for this or should it be part of this ticket? Expected: ``` [root@vm-058-080 ~]# ipa dnsrecord-add test. rec Please choose a type of DNS

[Freeipa-devel] [freeipa PR#45] custodia: force reconnect before retrieving CA certs from LDAP (closed)

2016-09-01 Thread mbasti-rh
jcholast's pull request #45: "custodia: force reconnect before retrieving CA certs from LDAP" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/45 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#45] custodia: force reconnect before retrieving CA certs from LDAP (comment)

2016-09-01 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/17ea4ae6b9007e121ae1ea7748643394fec84ad7 """ See the full comment at https://github.com/freeipa/freeipa/pull/45#issuecomment-244048121 -- Manage your subs

[Freeipa-devel] [freeipa PR#45] custodia: force reconnect before retrieving CA certs from LDAP (+pushed)

2016-09-01 Thread mbasti-rh
jcholast's pull request #45: "custodia: force reconnect before retrieving CA certs from LDAP" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/45 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#45] custodia: force reconnect before retrieving CA certs from LDAP (+ack)

2016-09-01 Thread mbasti-rh
jcholast's pull request #45: "custodia: force reconnect before retrieving CA certs from LDAP" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/45 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#42] Tests: Avoid skipping tests due to missing files (comment)

2016-08-31 Thread mbasti-rh
mbasti-rh commented on a pull request """ Probably instead of that magic, there could be: ``` self.testdir = os.path.abspath(os.path.dirname(__file__)) ``` It should always find the proper local directory And please in read_file, instead of plus sign, use os.path.join(self.tes

[Freeipa-devel] [freeipa PR#42] Tests: Avoid skipping tests due to missing files (comment)

2016-08-31 Thread mbasti-rh
mbasti-rh commented on a pull request """ I don't like this. Will we have if/elif for each possible location of where tests are executed. What changed? I'm sure those tests work in past. Why dir where test is executed was changed? """ See the full comment at http

[Freeipa-devel] [freeipa PR#41] Postpone enabling LDAPS in replica promotion (closed)

2016-08-31 Thread mbasti-rh
tomaskrizek's pull request #41: "Postpone enabling LDAPS in replica promotion" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/41 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/41/head:pr41

[Freeipa-devel] [freeipa PR#40] do not use trusted forest name to construct domain admin principal (comment)

2016-08-31 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/f32e0e4e522e09390f4295dd79f52d7a48877d3a """ See the full comment at https://github.com/freeipa/freeipa/pull/40#issuecomment-243758104 -- Manage your subs

[Freeipa-devel] [freeipa PR#40] do not use trusted forest name to construct domain admin principal (+pushed)

2016-08-31 Thread mbasti-rh
martbab's pull request #40: "do not use trusted forest name to construct domain admin principal" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/40 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#39] Tests: Add missing attributes to test_xmlrpc/test_trust tests (+pushed)

2016-08-31 Thread mbasti-rh
mirielka's pull request #39: "Tests: Add missing attributes to test_xmlrpc/test_trust tests" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/39 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#39] Tests: Add missing attributes to test_xmlrpc/test_trust tests (comment)

2016-08-31 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/60e88038c43c2ea2afc7e48f3e8dbd9bcfe955e8 """ See the full comment at https://github.com/freeipa/freeipa/pull/39#issuecomment-243757482 -- Manage your subs

[Freeipa-devel] [freeipa PR#39] Tests: Add missing attributes to test_xmlrpc/test_trust tests (closed)

2016-08-31 Thread mbasti-rh
mirielka's pull request #39: "Tests: Add missing attributes to test_xmlrpc/test_trust tests" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/39 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#17] Tests: Random issuer certificate can be added to a service (closed)

2016-08-31 Thread mbasti-rh
mirielka's pull request #17: "Tests: Random issuer certificate can be added to a service" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/17 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#17] Tests: Random issuer certificate can be added to a service (+pushed)

2016-08-31 Thread mbasti-rh
mirielka's pull request #17: "Tests: Random issuer certificate can be added to a service" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/17 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#38] Removed incorrect check for returncode (+rejected)

2016-08-30 Thread mbasti-rh
ofayans's pull request #38: "Removed incorrect check for returncode" label *rejected* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/38 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#38] Removed incorrect check for returncode (comment)

2016-08-30 Thread mbasti-rh
mbasti-rh commented on a pull request """ IPA code should be fixed not tests """ See the full comment at https://github.com/freeipa/freeipa/pull/38#issuecomment-243463585 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/

[Freeipa-devel] [freeipa PR#24] [master, ipa-4-3] Raise error when running ipa-adtrust-install with empty netbios--name (comment)

2016-08-30 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/2c7b7b3acc0a7131ea14cc43acb571150b585171 ipa-4-3: https://fedorahosted.org/freeipa/changeset/6064b122f995ca5e8f9bfcc72a8565d1280f8876 """ See the full

[Freeipa-devel] [freeipa PR#24] [master, ipa-4-3] Raise error when running ipa-adtrust-install with empty netbios--name (closed)

2016-08-30 Thread mbasti-rh
mirielka's pull request #24: "[master, ipa-4-3] Raise error when running ipa-adtrust-install with empty netbios--name" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/24 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa

[Freeipa-devel] [freeipa PR#24] [master, ipa-4-3] Raise error when running ipa-adtrust-install with empty netbios--name (+pushed)

2016-08-30 Thread mbasti-rh
mirielka's pull request #24: "[master, ipa-4-3] Raise error when running ipa-adtrust-install with empty netbios--name" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/24 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#20] cert: include CA name in cert command output (+pushed)

2016-08-30 Thread mbasti-rh
jcholast's pull request #20: "cert: include CA name in cert command output" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/20 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#20] cert: include CA name in cert command output (closed)

2016-08-30 Thread mbasti-rh
jcholast's pull request #20: "cert: include CA name in cert command output" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/20 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/20/head:pr20 git

[Freeipa-devel] [freeipa PR#20] cert: include CA name in cert command output (comment)

2016-08-30 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/117274ff047eb4148fd2624ae800f45e50a7e2cd """ See the full comment at https://github.com/freeipa/freeipa/pull/20#issuecomment-243401428 -- Manage your subs

[Freeipa-devel] [freeipa PR#20] cert: include CA name in cert command output (+ack)

2016-08-30 Thread mbasti-rh
jcholast's pull request #20: "cert: include CA name in cert command output" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/20 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#37] cert: add missing param values to cert-find output (+pushed)

2016-08-30 Thread mbasti-rh
jcholast's pull request #37: "cert: add missing param values to cert-find output" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/37 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#37] cert: add missing param values to cert-find output (comment)

2016-08-30 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/22d5f579bbd8bb452cf1bf620294ab6ade6e7c47 """ See the full comment at https://github.com/freeipa/freeipa/pull/37#issuecomment-243392998 -- Manage your subs

[Freeipa-devel] [freeipa PR#30] Print to debug output answer from CA (comment)

2016-08-30 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/5251cf5d14ffc178ead6e0af053d391f5b7a6782 """ See the full comment at https://github.com/freeipa/freeipa/pull/30#issuecomment-243375582 -- Manage your subs

[Freeipa-devel] [freeipa PR#30] Print to debug output answer from CA (closed)

2016-08-30 Thread mbasti-rh
mbasti-rh's pull request #30: "Print to debug output answer from CA" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/30 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/30/head:pr30 git checkout

[Freeipa-devel] [freeipa PR#30] Print to debug output answer from CA (+pushed)

2016-08-30 Thread mbasti-rh
mbasti-rh's pull request #30: "Print to debug output answer from CA" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/30 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#36] Fix tests for forward zones (comment)

2016-08-30 Thread mbasti-rh
mbasti-rh commented on a pull request """ master: eabe248957f75a1dd3b8d3d330740d929f9e42d9 Only one patch was pushed, there was error found in tooling """ See the full comment at https://github.com/freeipa/freeipa/pull/36#issuecomment-243374067 -- Manage you

[Freeipa-devel] [freeipa PR#36] Fix tests for forward zones (closed)

2016-08-30 Thread mbasti-rh
pspacek's pull request #36: "Fix tests for forward zones" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/36 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/36/head:pr36 git checkout pr36 --

[Freeipa-devel] [freeipa PR#36] Fix tests for forward zones (+pushed)

2016-08-30 Thread mbasti-rh
pspacek's pull request #36: "Fix tests for forward zones" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/36 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to

[Freeipa-devel] [freeipa PR#36] Fix tests for forward zones (comment)

2016-08-30 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/8f1ba05c26921fb787c3eb1bb846a13e06e424ff """ See the full comment at https://github.com/freeipa/freeipa/pull/36#issuecomment-243372212 -- Manage your subs

[Freeipa-devel] [freeipa PR#32] Test for caacl-add-service (+pushed)

2016-08-30 Thread mbasti-rh
gkaihorodova's pull request #32: "Test for caacl-add-service" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/32 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to

[Freeipa-devel] [freeipa PR#32] Test for caacl-add-service (comment)

2016-08-30 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/572bb55da4aedaae0cf529ab343484db06d89731 """ See the full comment at https://github.com/freeipa/freeipa/pull/32#issuecomment-243371317 -- Manage your subs

[Freeipa-devel] [freeipa PR#32] Test for caacl-add-service (closed)

2016-08-30 Thread mbasti-rh
gkaihorodova's pull request #32: "Test for caacl-add-service" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/32 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/32/head:pr32 git checkout pr32 --

[Freeipa-devel] [freeipa PR#34] dns: prompt for missing record parts in CLI (comment)

2016-08-30 Thread mbasti-rh
mbasti-rh commented on a pull request """ Can we move DNS record classes to ipalib/dnsrecords.py and use it in both client and server? IMO for server side code it should work just fine, not sure about client. """ See the full comment at https://github.com/freeip

[Freeipa-devel] [freeipa PR#20] cert: include CA name in cert command output (comment)

2016-08-29 Thread mbasti-rh
mbasti-rh commented on a pull request """ test_xmlrpc/test_cert_plugin.py F.F 2 same internal errors: ``` [Mon Aug 29 14:57:07.951307 2016] [wsgi:error] [pid 66778] ipa: ERROR: non-public: KeyError: ipapython.dn.DN('CN=SMIME CA,O=test industr

[Freeipa-devel] [freeipa PR#34] dns: prompt for missing record parts in CLI (comment)

2016-08-29 Thread mbasti-rh
mbasti-rh commented on a pull request """ I really don't like to move definitions how to split params from classes to single function ``` def split_rrparam(name, value): ``` It doesn't look safe for me or easy to understand and maintain. When I want to add new DNS type, I

[Freeipa-devel] [freeipa PR#26] Don't ignore --ignore-last-of-role for last CA (comment)

2016-08-29 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/f0487946cd760a97d92aac12d98cf8bb748576a2 """ See the full comment at https://github.com/freeipa/freeipa/pull/26#issuecomment-243102220 -- Manage your subs

[Freeipa-devel] [freeipa PR#26] Don't ignore --ignore-last-of-role for last CA (closed)

2016-08-29 Thread mbasti-rh
stlaz's pull request #26: "Don't ignore --ignore-last-of-role for last CA" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/26 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/26/head:pr26 git

[Freeipa-devel] [freeipa PR#26] Don't ignore --ignore-last-of-role for last CA (+pushed)

2016-08-29 Thread mbasti-rh
stlaz's pull request #26: "Don't ignore --ignore-last-of-role for last CA" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/26 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#14] Tests: Failing intree tests (+pushed)

2016-08-29 Thread mbasti-rh
mirielka's pull request #14: "Tests: Failing intree tests" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/14 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to

[Freeipa-devel] [freeipa PR#14] Tests: Failing intree tests (comment)

2016-08-29 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/3c32af55b646819fa8938d9a6efa6c3189525c37 https://fedorahosted.org/freeipa/changeset/774e4e479db637840cc2441778b5486d4c3b91d3 https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#14] Tests: Failing intree tests (closed)

2016-08-29 Thread mbasti-rh
mirielka's pull request #14: "Tests: Failing intree tests" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/14 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/14/head:pr14 git checkout pr14 --

[Freeipa-devel] [freeipa PR#14] Tests: Failing intree tests (+ack)

2016-08-29 Thread mbasti-rh
mirielka's pull request #14: "Tests: Failing intree tests" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/14 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to

[Freeipa-devel] [freeipa PR#30] Print to debug output answer from CA (opened)

2016-08-26 Thread mbasti-rh
mbasti-rh's pull request #30: "Print to debug output answer from CA" was opened PR body: """ CA request may fail due various erros, without debug output we cannot decide what is wrong. """ See the full pull-request at https://github.com/freeipa/freeipa/pull/30 ... or pull the PR as Git branch:

[Freeipa-devel] [freeipa PR#21] custodia: include known CA certs in the PKCS#12 file for Dogtag (closed)

2016-08-26 Thread mbasti-rh
jcholast's pull request #21: "custodia: include known CA certs in the PKCS#12 file for Dogtag" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/21 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#21] custodia: include known CA certs in the PKCS#12 file for Dogtag (comment)

2016-08-26 Thread mbasti-rh
mbasti-rh commented on a pull request """ Yes, I can reproduce it without this PR. ACK for this """ See the full comment at https://github.com/freeipa/freeipa/pull/21#issuecomment-242751300 -- Manage your subscription for the Freeipa-devel mailing list: https://w

[Freeipa-devel] [freeipa PR#21] custodia: include known CA certs in the PKCS#12 file for Dogtag (+ack)

2016-08-26 Thread mbasti-rh
jcholast's pull request #21: "custodia: include known CA certs in the PKCS#12 file for Dogtag" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/21 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#21] custodia: include known CA certs in the PKCS#12 file for Dogtag (comment)

2016-08-26 Thread mbasti-rh
mbasti-rh commented on a pull request """ I cannot connect to LDAPS even if only CA-less servers are installed """ See the full comment at https://github.com/freeipa/freeipa/pull/21#issuecomment-242746093 -- Manage your subscription for the Freeipa-devel mailin

[Freeipa-devel] [freeipa PR#28] Added a sleep interval after domainlevel raise in tests (+pushed)

2016-08-26 Thread mbasti-rh
ofayans's pull request #28: "Added a sleep interval after domainlevel raise in tests" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/28 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#28] Added a sleep interval after domainlevel raise in tests (comment)

2016-08-26 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/9dffe55e6582bca7b1a4b8ad3042c63c5ccde51a """ See the full comment at https://github.com/freeipa/freeipa/pull/28#issuecomment-242747200 -- Manage your subs

[Freeipa-devel] [freeipa PR#28] Added a sleep interval after domainlevel raise in tests (closed)

2016-08-26 Thread mbasti-rh
ofayans's pull request #28: "Added a sleep interval after domainlevel raise in tests" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/28 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#28] Added a sleep interval after domainlevel raise in tests (+ack)

2016-08-26 Thread mbasti-rh
ofayans's pull request #28: "Added a sleep interval after domainlevel raise in tests" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/28 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#28] Added a sleep interval after domainlevel raise in tests (comment)

2016-08-26 Thread mbasti-rh
mbasti-rh commented on a pull request """ Maybe comment next to sleep why the sleep is there, may not hurt """ See the full comment at https://github.com/freeipa/freeipa/pull/28#issuecomment-242727734 -- Manage your subscription for the Freeipa-devel mailin

[Freeipa-devel] [freeipa PR#21] custodia: include known CA certs in the PKCS#12 file for Dogtag (comment)

2016-08-26 Thread mbasti-rh
mbasti-rh commented on a pull request """ On replica: ``` [root@vm-058-017 ~]# ipa-ca-install Directory Manager (existing master) password: Run connection check to master Connection check OK Configuring certificate server (pki-tomcatd). Estimated time: 3 minutes 30 seconds [

[Freeipa-devel] [freeipa PR#23] Time-Based HBAC Policies (comment)

2016-08-25 Thread mbasti-rh
mbasti-rh commented on a pull request """ I wrote a few comments. The most serious issue I found was time rule permissions, we must carefully decide what to do now, otherwise it will hurt us in future. Would be nice to provide API tests too :) """ See the full

[Freeipa-devel] [freeipa PR#18] Fixed incorrect sequence of method calls in tasks.py (comment)

2016-08-25 Thread mbasti-rh
mbasti-rh commented on a pull request """ @ofayans This is just mirror repo of fedorahosted , we cannot merge commits here, it has no effect. """ See the full comment at https://github.com/freeipa/freeipa/pull/18#issuecomment-242359169 -- Manage your subscription

[Freeipa-devel] [freeipa PR#18] Fixed incorrect sequence of method calls in tasks.py (+pushed)

2016-08-25 Thread mbasti-rh
ofayans's pull request #18: "Fixed incorrect sequence of method calls in tasks.py" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/18 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#18] Fixed incorrect sequence of method calls in tasks.py (comment)

2016-08-25 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/fbc9179970ce30ba8c121a3d60b9550ef8f9c06c """ See the full comment at https://github.com/freeipa/freeipa/pull/18#issuecomment-242359000 -- Manage your subs

[Freeipa-devel] [freeipa PR#18] Fixed incorrect sequence of method calls in tasks.py (comment)

2016-08-25 Thread mbasti-rh
mbasti-rh commented on a pull request """ NACK ``` [Thu Aug 25 13:31:13.597940 2016] [wsgi:error] [pid 130658] Traceback (most recent call last): [Thu Aug 25 13:31:13.597945 2016] [wsgi:error] [pid 130658] File "/usr/lib/python2.7/site-packages/ipaserver/rpc

[Freeipa-devel] [freeipa PR#18] Fixed incorrect sequence of method calls in tasks.py (+ack)

2016-08-25 Thread mbasti-rh
ofayans's pull request #18: "Fixed incorrect sequence of method calls in tasks.py" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/18 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#16] Require httpd 2.4.6-31 with mod_proxy Unix socket support (comment)

2016-08-24 Thread mbasti-rh
mbasti-rh commented on a pull request """ I realized that we should use 2.4.7 in upstream specfile, to make porting of IPA easier """ See the full comment at https://github.com/freeipa/freeipa/pull/16#issuecomment-242108719 -- Manage your subscription for the Fre

[Freeipa-devel] [freeipa PR#16] Require httpd 2.4.6-31 with mod_proxy Unix socket support (comment)

2016-08-24 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/17bb9b9a9ba983020c66f4b83a5918be636ef3bd """ See the full comment at https://github.com/freeipa/freeipa/pull/16#issuecomment-242103959 -- Manage your subs

[Freeipa-devel] [freeipa PR#15] Secure permissions of Custodia server.keys (closed)

2016-08-24 Thread mbasti-rh
tiran's pull request #15: "Secure permissions of Custodia server.keys" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/15 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/15/head:pr15 git

[Freeipa-devel] [freeipa PR#15] Secure permissions of Custodia server.keys (+pushed)

2016-08-24 Thread mbasti-rh
tiran's pull request #15: "Secure permissions of Custodia server.keys" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/15 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#15] Secure permissions of Custodia server.keys (comment)

2016-08-24 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/d9ab0097e15618b0c614b3fdfa2ac4ea52b902c0 """ See the full comment at https://github.com/freeipa/freeipa/pull/15#issuecomment-242095453 -- Manage your subs

[Freeipa-devel] [freeipa PR#15] Secure permissions of Custodia server.keys (+ack)

2016-08-24 Thread mbasti-rh
tiran's pull request #15: "Secure permissions of Custodia server.keys" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/15 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#13] Handled empty hostname in server-del command (closed)

2016-08-24 Thread mbasti-rh
Akasurde's pull request #13: "Handled empty hostname in server-del command" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/13 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/13/head:pr13 git

[Freeipa-devel] [freeipa PR#13] Handled empty hostname in server-del command (+pushed)

2016-08-24 Thread mbasti-rh
Akasurde's pull request #13: "Handled empty hostname in server-del command" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/13 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#13] Handled empty hostname in server-del command (comment)

2016-08-24 Thread mbasti-rh
mbasti-rh commented on a pull request Fixed upstream master: https://fedorahosted.org/freeipa/changeset/95a594af4c99255ea4da27e609cf41b79ca7ed91 See the full comment at https://github.com/freeipa/freeipa/pull/13#issuecomment-242071162 -- Manage your subscription for the Freeipa-devel mailing

[Freeipa-devel] [freeipa PR#13] Handled empty hostname in server-del command (+ack)

2016-08-24 Thread mbasti-rh
Akasurde's pull request #13: "Handled empty hostname in server-del command" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/13 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#13] Handled empty hostname in server-del command (comment)

2016-08-23 Thread mbasti-rh
mbasti-rh commented on a pull request NACK, see inline comments See the full comment at https://github.com/freeipa/freeipa/pull/13#issuecomment-241742765 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA

[Freeipa-devel] [freeipa PR#11] Removed unwanted line break from RefererError Dialog message (+pushed)

2016-08-23 Thread mbasti-rh
Akasurde's pull request #11: "Removed unwanted line break from RefererError Dialog message" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/11 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#11] Removed unwanted line break from RefererError Dialog message (comment)

2016-08-23 Thread mbasti-rh
mbasti-rh commented on a pull request Fixed upstream master: https://fedorahosted.org/freeipa/changeset/d5a3f10a854f998087fe2c22fcbbbfdd2aba50ce See the full comment at https://github.com/freeipa/freeipa/pull/11#issuecomment-241702681 -- Manage your subscription for the Freeipa-devel mailing

[Freeipa-devel] [freeipa PR#12] Tests: Duplicate declaration on variables in ID views tests (closed)

2016-08-23 Thread mbasti-rh
mirielka's pull request #12: "Tests: Duplicate declaration on variables in ID views tests" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/12 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#12] Tests: Duplicate declaration on variables in ID views tests (+pushed)

2016-08-23 Thread mbasti-rh
mirielka's pull request #12: "Tests: Duplicate declaration on variables in ID views tests" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/12 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#12] Tests: Duplicate declaration on variables in ID views tests (comment)

2016-08-23 Thread mbasti-rh
mbasti-rh commented on a pull request Fixed upstream master: https://fedorahosted.org/freeipa/changeset/fef4b953099b7d22f257bf32b6aa5d422a2831e5 See the full comment at https://github.com/freeipa/freeipa/pull/12#issuecomment-241691499 -- Manage your subscription for the Freeipa-devel mailing

<    5   6   7   8   9   10