mirielka's pull request #39: "Tests: Add missing attributes to
test_xmlrpc/test_trust tests" label *pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/39
--
Manage your subscription for the Freeipa-devel mailing list:
mbasti-rh commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/60e88038c43c2ea2afc7e48f3e8dbd9bcfe955e8
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/39#issuecomment-243757482
--
Manage your subs
tomaskrizek's pull request #41: "Postpone enabling LDAPS in replica promotion"
was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/41
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/41/head:pr41
mbasti-rh commented on a pull request
"""
I don't like this. Will we have if/elif for each possible location of where
tests are executed. What changed? I'm sure those tests work in past. Why dir
where test is executed was changed?
"""
See the full comment at
http
mbasti-rh commented on a pull request
"""
Probably instead of that magic, there could be:
```
self.testdir = os.path.abspath(os.path.dirname(__file__))
```
It should always find the proper local directory
And please in read_file, instead of plus sign, use os.path.join(self.tes
mbasti-rh's pull request #78: "Fix Ip-addr validation" was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/78
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/78/head:pr78
git checkout pr78
From
mbasti-rh's pull request #78: "Fix Ip-addr validation" was opened
PR body:
"""
"""
See the full pull-request at https://github.com/freeipa/freeipa/pull/78
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/78/head:pr78
git
mbasti-rh's pull request #81: "Fix emptyzones dns upgrade" was opened
PR body:
"""
"""
See the full pull-request at https://github.com/freeipa/freeipa/pull/81
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/81/head:pr81
git
ofayans's pull request #52: "Removed incorrect check for returncode" was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/52
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/52/head:pr52
git checkout
mirielka's pull request #27: "[master, ipa-4-3] Tests: Fix integration sudo
tests setup and checks" label *pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/27
--
Manage your subscription for the Freeipa-devel mailing list:
mbasti-rh commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/7cac8392036bf6d6bbd74f5a781986dec21149d6
ipa-4-3:
https://fedorahosted.org/freeipa/changeset/6d04220dc3071782cf303b2e94e06da4ee26e512
ipa-4-4:
https://fedorahosted.org/fr
mirielka's pull request #27: "[master, ipa-4-3] Tests: Fix integration sudo
tests setup and checks" label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/27
--
Manage your subscription for the Freeipa-devel mailing list:
mirielka's pull request #27: "[master, ipa-4-3] Tests: Fix integration sudo
tests setup and checks" was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/27
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
mbasti-rh's pull request #82: "Fix regexp in user/group name" was opened
PR body:
"""
Regexp should not enforce lenght of string, we have different checks for
that. Secondly regexp with length specified produces an incorrect error
message.
https://fedorahosted.org/freeipa/ticket/5822
"""
See
mbasti-rh's pull request #81: "Fix emptyzones dns upgrade" was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/81
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/81/head:pr81
git checkout pr81
ofayans's pull request #52: "Removed incorrect check for returncode" label
*ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/52
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
mbasti-rh commented on a pull request
"""
**Removed incorrect check for returncode**
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/22b0e8a9eb9eb3d47131c6784d70dd409d5b889b
ipa-4-4:
https://fedorahosted.org/freeipa/changeset/e265853d055caf7e3d17316eee6e25aa26b
mbasti-rh commented on a pull request
"""
**Changed addressing to the client hosts to be replicas**
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/ac78d191ded6721cf1051413cdd6862c0362e66b
ipa-4-4:
https://fedorahosted.org/fr
mbasti-rh commented on a pull request
"""
**Several fixes in replica_promotion tests**
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/39c15ecdcdcbc2a0b651b0f89080789dd806e998
ipa-4-4:
https://fedorahosted.org/freeipa/changeset/cd6adafbf699da48ab877e77ac9c1cc1dd2
mbasti-rh commented on a pull request
"""
**Xfailed the tests due to a known bug with replica preparation**
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/1e484d010b653b8ac06425ca602ba5c9e950ed89
"""
See the full comment at
https://gith
ofayans's pull request #52: "Removed incorrect check for returncode" label
*pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/52
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
mbasti-rh commented on a pull request
"""
Please split this into 2 commits, it contains independent issues
* wrong path to IPA join
* extra attribute
It is not related to this PR, but for me it looks that this test is focused to
ipa-join command and I don't see how this is relat
mbasti-rh commented on a pull request
"""
I was thinking hard about it, if there should be SSSD restart, but I cannot
find any case where it is needed after server uninstall
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/86#issuecom
pvomacka's pull request #72: "WebUI: Add handling for HTTP error 404" label
*pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/72
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
mbasti-rh commented on a pull request
"""
Sorry guys, but ticket is in closed milestone you need a new one.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/83#issuecomment-247348762
--
Manage your subscription for the Freeipa-devel mailin
Akasurde's pull request #83: "Added a fix for setting Priority as required
field " label *ack* has been removed
See the full pull-request at https://github.com/freeipa/freeipa/pull/83
--
Manage your subscription for the Freeipa-devel mailing list:
mbasti-rh commented on a pull request
"""
Can wait until Lenka give us the reason?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/86#issuecomment-247344542
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redha
pvomacka's pull request #72: "WebUI: Add handling for HTTP error 404" was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/72
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/72/head:pr72
git checkout
mbasti-rh commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/b18a35145df92522ae990e020513d1a77e311493
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/72#issuecomment-247349710
--
Manage your subs
mbasti-rh commented on a pull request
"""
@Akasurde I said we need a *new* ticket for it. I opened one for you
https://fedorahosted.org/freeipa/ticket/6335
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/83#issuecomment-247530662
--
Manage you
URL: https://github.com/freeipa/freeipa/pull/98
Title: #98: Make server uninstaller exit with non-zero exit status during
failed validation
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to
URL: https://github.com/freeipa/freeipa/pull/121
Author: mbasti-rh
Title: #121: Pylint: enable unused-variable check
Action: opened
PR body:
"""
Modules with too many unused variables have check locally disabled
"""
To pull the PR as Git branch:
git remote ad
URL: https://github.com/freeipa/freeipa/pull/110
Title: #110: test_text: add test ipa.pot file for tests
mbasti-rh commented:
"""
Fixed upstream
ipa-4-4:
https://fedorahosted.org/freeipa/changeset/f4115f68eea4112957bb58c25f29c6f40d8172ef
master:
https://fedorahosted.org/fr
URL: https://github.com/freeipa/freeipa/pull/104
Author: martbab
Title: #104: Backport XMLRPC test fixes to ipa-4-3 branch
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/104/head:pr104
git checkout pr104
--
URL: https://github.com/freeipa/freeipa/pull/104
Title: #104: Backport XMLRPC test fixes to ipa-4-3 branch
mbasti-rh commented:
"""
Fixed upstream
ipa-4-3:
https://fedorahosted.org/freeipa/changeset/4b551743820f436807811415ab51d6ee238ee971
https://fedorahosted.org/fr
URL: https://github.com/freeipa/freeipa/pull/104
Title: #104: Backport XMLRPC test fixes to ipa-4-3 branch
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/98
Author: martbab
Title: #98: Make server uninstaller exit with non-zero exit status during
failed validation
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
URL: https://github.com/freeipa/freeipa/pull/98
Title: #98: Make server uninstaller exit with non-zero exit status during
failed validation
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/347f5ca0e145491d387f60f95b67ef5
URL: https://github.com/freeipa/freeipa/pull/111
Author: tomaskrizek
Title: #111: Prompt for forwarder in dnsforwardzone-add
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/111/head:pr111
git checkout pr111
--
URL: https://github.com/freeipa/freeipa/pull/111
Title: #111: Prompt for forwarder in dnsforwardzone-add
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/ef9c718e3a82fcbd5944cc993e2c9f3f1237f85c
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/111
Title: #111: Prompt for forwarder in dnsforwardzone-add
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/110
Author: mbasti-rh
Title: #110: test_text: add test ipa.pot file for tests
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/110/head:pr110
git checkout pr110
URL: https://github.com/freeipa/freeipa/pull/110
Title: #110: test_text: add test ipa.pot file for tests
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/121
Author: mbasti-rh
Title: #121: Pylint: enable unused-variable check
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/121/head:pr121
git checkout pr121
From
URL: https://github.com/freeipa/freeipa/pull/124
Title: #124: Fix: find OSCP certificate test
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/95aa9369cb2f84ab71fa84e254d0bb3af264e97e
"""
See the full comment at
https://g
URL: https://github.com/freeipa/freeipa/pull/124
Title: #124: Fix: find OSCP certificate test
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/124
Author: mbasti-rh
Title: #124: Fix: find OSCP certificate test
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/124/head:pr124
git checkout pr124
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/137
Title: #137: Test: disabled wrong client domain tests for domlevel 0
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/138
Title: #138: Fix ipa-cacert-manage man page
mbasti-rh commented:
"""
Is this written in IdM guide, if not IMO it would be nice to open doc bug in BZ
and add this info there as well
"""
See the full comment at
http
URL: https://github.com/freeipa/freeipa/pull/128
Title: #128: Properly handle LDAP socket closures in ipa-otpd
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/128
Author: npmccallum
Title: #128: Properly handle LDAP socket closures in ipa-otpd
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/128/head:pr128
git checkout pr128
URL: https://github.com/freeipa/freeipa/pull/135
Title: #135: Pylint: remove unused variables
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/135
Author: mbasti-rh
Title: #135: Pylint: remove unused variables
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/135/head:pr135
git checkout pr135
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/125
Author: tiran
Title: #125: Add iSecStore.span
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/125/head:pr125
git checkout pr125
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/125
Title: #125: Add iSecStore.span
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/135
Title: #135: Pylint: remove unused variables
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/d9375881460d63cdd696bb0705da0ac205db9870
https://fedorahosted.org/fr
URL: https://github.com/freeipa/freeipa/pull/115
Title: #115: Don't show traceback when ipa config file is not an absolute path
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/134
Title: #134: DNS URI support
mbasti-rh commented:
"""
NACK, please see inline comments
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/134#issuecomment-251916849
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/134
Title: #134: DNS URI support
mbasti-rh commented:
"""
I was able to add an invalid URI record
```
[root@vm-058-017 ~]# ipa dnsrecord-add test.zone. --uri-rec='0 0 trolo"lo'
Record name: test2
Record name: test2
URI r
URL: https://github.com/freeipa/freeipa/pull/132
Title: #132: Draft for a new setup.py (WIP)
mbasti-rh commented:
"""
This WIP works for me, I like that we get rid of setup.py.in files.
I'm looking forward to final version
Please fix PEP8 reported error and my inline co
URL: https://github.com/freeipa/freeipa/pull/108
Title: #108: Bump pki min version and add commentary about sub-CA revocation on
delete
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/131
Title: #131: Fixed script generating certs to address untrusted sub-ca
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/108
Title: #108: Bump pki min version and add commentary about sub-CA revocation on
delete
mbasti-rh commented:
"""
IMO for that there is 'Requires' statement. We don't need 10.3.5-6 during build
time and IIRC Honza is work
URL: https://github.com/freeipa/freeipa/pull/136
Author: mbasti-rh
Title: #136: [WIP] Fix KRA install tests
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/136/head:pr136
git checkout pr136
From
URL: https://github.com/freeipa/freeipa/pull/136
Author: mbasti-rh
Title: #136: Fix KRA install tests
Action: edited
Changed field: title
Original value:
"""
[WIP] Fix KRA install tests
"""
--
Manage your subscription for the Freeipa-devel mailing list:
URL: https://github.com/freeipa/freeipa/pull/125
Title: #125: Add iSecStore.span
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/139
Title: #139: WebUI: Vault Management
mbasti-rh commented:
"""
I'm not sure if this is done on purpose, but Vault section is shown there even
I have no KRA installed in topology, and I'm getting error
```
An error has occurred
URL: https://github.com/freeipa/freeipa/pull/142
Title: #142: CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper
(un)pickling
mbasti-rh commented:
"""
IMO here (__init__ of CheckedIPAddress) is missing self._net = addr._net it
may cause issues
```
if
URL: https://github.com/freeipa/freeipa/pull/133
Title: #133: Tests: print what was expected from exceptions and callables in
xmlrpc_tests
mbasti-rh commented:
"""
Please set proper patch author, otherwise LGTM
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/135
Author: mbasti-rh
Title: #135: Pylint: remove unused variables from install modules and scripts
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/135
URL: https://github.com/freeipa/freeipa/pull/135
Author: mbasti-rh
Title: #135: Pylint: remove unused variables from install modules and scripts
Action: opened
PR body:
"""
Would be nice to merge this patch before refactoring of installers starts
"""
To pull th
URL: https://github.com/freeipa/freeipa/pull/135
Author: mbasti-rh
Title: #135: Pylint: remove unused variables
Action: edited
Changed field: title
Original value:
"""
Pylint: remove unused variables from install modules and scripts
"""
--
Manage your subs
URL: https://github.com/freeipa/freeipa/pull/134
Title: #134: DNS URI support
mbasti-rh commented:
"""
jslint failed please fix it (you can leave pep8 as is, to be consistent with
current code)
"""
See the full comment at
https://github.com/freeipa/freeipa/p
URL: https://github.com/freeipa/freeipa/pull/135
Author: mbasti-rh
Title: #135: Pylint: remove unused variables from install modules and scripts
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/135
URL: https://github.com/freeipa/freeipa/pull/136
Author: mbasti-rh
Title: #136: [WIP] Fix KRA install tests
Action: opened
PR body:
"""
- in test_installation testsuite KRA related tests were duplicated, this PR
removes it
- in test_installation test suite with domain level 0,
URL: https://github.com/freeipa/freeipa/pull/122
Title: #122: Acceptance tests
mbasti-rh commented:
"""
Please see my inline comments, I would not bother with removing DNS tests from
suite because they are fast and should not affect CA/KRA
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/130
Author: ofayans
Title: #130: Added --ip-address paramenter to client installation
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/130/head:pr130
git checkout
URL: https://github.com/freeipa/freeipa/pull/130
Title: #130: Added --ip-address paramenter to client installation
mbasti-rh commented:
"""
I don't see any disagreement so I'm closing this PR
"""
See the full comment at
https://github.com/freeipa/freeipa/p
URL: https://github.com/freeipa/freeipa/pull/130
Title: #130: Added --ip-address paramenter to client installation
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/114
Title: #114: Raise errors from service.py:_ldap_mod() by default
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/c56256e2a29f076e6afa559225a66f58b0773eb5
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/114
Title: #114: Raise errors from service.py:_ldap_mod() by default
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/114
Author: pspacek
Title: #114: Raise errors from service.py:_ldap_mod() by default
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/114/head:pr114
git checkout pr114
URL: https://github.com/freeipa/freeipa/pull/129
Author: stlaz
Title: #129: Fix test_util.test_assert_deepequal test
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/129/head:pr129
git checkout pr129
--
Manage
URL: https://github.com/freeipa/freeipa/pull/129
Title: #129: Fix test_util.test_assert_deepequal test
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/d70d71846d6eb7d8e6a730965e54e737e7b49f15
ipa-4-4:
https://fedorahosted.org/fr
URL: https://github.com/freeipa/freeipa/pull/125
Title: #125: Add iSecStore.span
mbasti-rh commented:
"""
Please fix PEP8 error, otherwise LGTM
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/125#issuecomment-251371815
--
Manage your subs
URL: https://github.com/freeipa/freeipa/pull/142
Title: #142: CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper
(un)pickling
mbasti-rh commented:
"""
Works for me, I'm not pushing this yet if somebody wants to double check pickle
implementation
"&quo
URL: https://github.com/freeipa/freeipa/pull/134
Title: #134: DNS URI support
mbasti-rh commented:
"""
I'm so sorry, I didn't noticed earlier, but you forgot to bump API in VERSION
Otherwise LGTM and works for me
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/108
Title: #108: Bump pki min version and add commentary about sub-CA revocation on
delete
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/6b3f4984296f3caff8f29490eae3ed1dca64b8c3
https://f
URL: https://github.com/freeipa/freeipa/pull/108
Author: frasertweedale
Title: #108: Bump pki min version and add commentary about sub-CA revocation
on delete
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
URL: https://github.com/freeipa/freeipa/pull/108
Title: #108: Bump pki min version and add commentary about sub-CA revocation on
delete
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/123
Title: #123: Tests: Remove silent deleting and creating entries by tracker
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/74e52e86867372365d1d63561f7d1ff961b89ee0
"""
URL: https://github.com/freeipa/freeipa/pull/123
Title: #123: Tests: Remove silent deleting and creating entries by tracker
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/115
Author: tomaskrizek
Title: #115: Don't show traceback when ipa config file is not an absolute path
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/115/head:pr115
URL: https://github.com/freeipa/freeipa/pull/115
Title: #115: Don't show traceback when ipa config file is not an absolute path
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/d7a2dfddbc2dc9ae4cea7d65e56d61a6a4d2b928
https://fedorahos
URL: https://github.com/freeipa/freeipa/pull/139
Title: #139: WebUI: Vault Management
mbasti-rh commented:
"""
1)
I created shared vault, but I cannot see it in 'Shared Vaults', it is show only
in 'My Vaults'
i.e. it was created ad user vault according CLI
2)
'My Vau
URL: https://github.com/freeipa/freeipa/pull/139
Title: #139: WebUI: Vault Management
mbasti-rh commented:
"""
Yeah, and I forgot to write:
11)
There should be an information in webUI, that secrets can be added/retrieved to
vault only by using vault-archive and vault-re
URL: https://github.com/freeipa/freeipa/pull/147
Title: #147: Tests: Unaccessible variable self.attrs in Tracker
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/85
Author: pvomacka
Title: #85: WebUI: Change group name from 'normal' to 'Non-POSIX'
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/85/head:pr85
git checkout pr85
URL: https://github.com/freeipa/freeipa/pull/85
Title: #85: WebUI: Change group name from 'normal' to 'Non-POSIX'
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/0e6d6e403255649538224c409a0a279aaf9d5181
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/85
Title: #85: WebUI: Change group name from 'normal' to 'Non-POSIX'
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
101 - 200 of 999 matches
Mail list logo
