[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-21 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA pspacek commented: """ Works for me, server installation including DNSSEC worked fine. """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#317][+ack] Unify password generation across FreeIPA

2016-12-21 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#358][+ack] Use the tar Posix option for tarballs

2016-12-21 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/358 Title: #358: Use the tar Posix option for tarballs Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#358][comment] Use the tar Posix option for tarballs

2016-12-21 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/358 Title: #358: Use the tar Posix option for tarballs pspacek commented: """ Thanks, ACK! """ See the full comment at https://github.com/freeipa/freeipa/pull/358#issuecomment-268527273 -- Manage your subscription

[Freeipa-devel] [freeipa PR#358][comment] Use the tar Posix option for tarballs

2016-12-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/358 Title: #358: Use the tar Posix option for tarballs pspacek commented: """ CondACK if the message is corrected. """ See the full comment at https://github.com/freeipa/freeipa/pull/358#issuecomment-26845716

[Freeipa-devel] [freeipa PR#358][comment] Use the tar Posix option for tarballs

2016-12-20 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/358 Title: #358: Use the tar Posix option for tarballs pspacek commented: """ Please add a note *why* it is necessary. Something like "ustar format we used before could not handle files with > 65535" or so. This will help

[Freeipa-devel] [bind-dyndb-ldap PR#6][+ack] handle termination of syncrepl watcher thread

2016-12-20 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/6 Title: #6: handle termination of syncrepl watcher thread Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [bind-dyndb-ldap PR#6][comment] handle termination of syncrepl watcher thread

2016-12-20 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/6 Title: #6: handle termination of syncrepl watcher thread pspacek commented: """ We are almost there. Just minor changes will make it perfect :-) """ See the full comment at https://github.com/freeipa/bind-

[Freeipa-devel] [freeipa PR#279][comment] installer: Stop adding distro-specific NTP servers into ntp.conf

2016-12-19 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/279 Title: #279: installer: Stop adding distro-specific NTP servers into ntp.conf pspacek commented: """ ACK """ See the full comment at https://github.com/freeipa/freeipa/pull/279#issuecomment-267986862 -- Manage you

[Freeipa-devel] [freeipa PR#352][opened] Clarify meaning of --domain and --realm in installers

2016-12-19 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/352 Author: pspacek Title: #352: Clarify meaning of --domain and --realm in installers Action: opened PR body: """ Man pages need bigger overhaul. Take this as hot-fix for FAQ. https://fedorahosted.org/freeipa/ticket/6574 &quo

[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions

2016-12-18 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/347 Title: #347: Improvements in {get|set}_directive functions pspacek commented: """ Please see my in-line comments. """ See the full comment at https://github.com/freeipa/freeipa/pull/347#issuecomment-26789916

[Freeipa-devel] [freeipa PR#333][synchronized] Remove named-pkcs11 workarounds from DNSSEC tests.

2016-12-14 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/333 Author: pspacek Title: #333: Remove named-pkcs11 workarounds from DNSSEC tests. Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/333/head:pr333 git checkout

[Freeipa-devel] [freeipa PR#333][opened] Remove named-pkcs11 workarounds from DNSSEC tests.

2016-12-13 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/333 Author: pspacek Title: #333: Remove named-pkcs11 workarounds from DNSSEC tests. Action: opened PR body: """ As far as I can tell the tests are passing for some time in Jenkins so maybe a bug in some underlying component was fixe

[Freeipa-devel] [bind-dyndb-ldap PR#5][opened] Add GDB pretty-printers for plugin data structures to contrib.

2016-12-13 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/5 Author: pspacek Title: #5: Add GDB pretty-printers for plugin data structures to contrib. Action: opened PR body: """ These are convenience scripts I created over time to ease digging in bind-dyndb-ldap data structures

[Freeipa-devel] [freeipa PR#330][opened] Build: forbid builds in working directories containing white spaces

2016-12-13 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/330 Author: pspacek Title: #330: Build: forbid builds in working directories containing white spaces Action: opened PR body: """ Spaces are causing problems in libtool, makefiles, autoconf itself, gettextize framework etc. so th

[Freeipa-devel] [freeipa PR#272][synchronized] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-12 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Author: pspacek Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-12 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ I've found the root cause - incorrect order of operations in freeipa.spec.in. Now it should work. ""&quo

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-12 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA pspacek commented: """ Talk is cheap so here is the code! ~~~ import math import string import random class TokenGenerator(object): """Tunable tok

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-12 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA pspacek commented: """ The main problem here is that we are mixing two approaches together, i.e. entropy specification using bits + specification using character classes e

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA pspacek commented: """ @mbasti-rh You are missing the point and thus do not answer my question: The docstring does not tell anything about relation of 'entropy' and th

[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA

2016-12-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA pspacek commented: """ Guys, I'm confused. What exactly is the purpose of `TokenGenerator`? The docstring does not explain to me what is relation between argument

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ To be sure I re-built RPMs from this PR using `makerpms.sh` script. My findings are: - `/usr/bin/ipa-run-tests` is a symli

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ Relevant parts of SPEC file are here: https://github.com/freeipa/freeipa/pull/272/commits/684f4f5d4fbcfc62c555f7ef85

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ `make install` will install whatever is auto-detected during configure (or overriden by `$PYTHON` variable while ca

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ @martbab Can I do something in the build system to make your CI implementation easier? """ See the f

[Freeipa-devel] [freeipa PR#307][+ack] Lowered the version of gettext

2016-12-09 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/307 Title: #307: Lowered the version of gettext Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-08 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ I've synchronized `python-cryptography` and `python-gssapi` versions. Thank you for noticing. Let's see if CI tests pa

[Freeipa-devel] [freeipa PR#272][synchronized] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-08 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Author: pspacek Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull

[Freeipa-devel] [freeipa PR#307][comment] Lowered the version of gettext

2016-12-08 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/307 Title: #307: Lowered the version of gettext pspacek commented: """ @pvomacka Pavel, you did not remove the `po/Rules-quot` file. Adding it to `.gitignore` is not enough. NACK (sorry for messing with the label, too fat fingers) &q

[Freeipa-devel] [freeipa PR#307][-ack] Lowered the version of gettext

2016-12-08 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/307 Title: #307: Lowered the version of gettext Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#307][+ack] Lowered the version of gettext

2016-12-08 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/307 Title: #307: Lowered the version of gettext Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-08 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ I've implemented tiran's proposal and rebased the patchset. """ See the full comment at https://g

[Freeipa-devel] [freeipa PR#272][synchronized] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-08 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Author: pspacek Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-12-08 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ I'm fine with `make pylint PYTHON=python3` as long as you can agree on it :-) """ See the full comment at

[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2016-12-07 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code pspacek commented: """ @simo5 Please extend the design page with image description which explains each of the steps. There are numbers and letters in

[Freeipa-devel] [freeipa PR#279][comment] installer: Stop adding distro-specific NTP servers into ntp.conf

2016-12-05 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/279 Title: #279: installer: Stop adding distro-specific NTP servers into ntp.conf pspacek commented: """ NACK """ See the full comment at https://github.com/freeipa/freeipa/pull/279#issuecomment-26508409

[Freeipa-devel] [freeipa PR#309][+ack] ipa-replica-conncheck: fix race condition

2016-12-05 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/309 Title: #309: ipa-replica-conncheck: fix race condition Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#307][comment] Lowered the version of gettext

2016-12-05 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/307 Title: #307: Lowered the version of gettext pspacek commented: """ If the file `Rules-quot` is generated by `autoreconf -i`, please remove it completely and add it into `.gitignore`. """ See the full comment

[Freeipa-devel] [freeipa PR#306][+ack] Ignore backup~ files like config.h.in~

2016-12-05 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/306 Title: #306: Ignore backup~ files like config.h.in~ Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#304][+ack] Relax check for .git to support freeipa in submodules

2016-12-05 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/304 Title: #304: Relax check for .git to support freeipa in submodules Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [bind-dyndb-ldap PR#1][comment] Port bind-dyndb-ldap to BIND 9.11

2016-11-30 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/1 Title: #1: Port bind-dyndb-ldap to BIND 9.11 pspacek commented: """ Pushed to master: 2649ef1da1cbfc1203337665c4e589e1fe75f04b BIND 9.11: Remove #if blocks for older BIND versions. 8178f3cf856829c081a663a2e3f4d77ecc2db6b1

[Freeipa-devel] [bind-dyndb-ldap PR#1][closed] Port bind-dyndb-ldap to BIND 9.11

2016-11-30 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/1 Author: pspacek Title: #1: Port bind-dyndb-ldap to BIND 9.11 Action: closed To pull the PR as Git branch: git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap git fetch ghbind-dyndb-ldap pull/1/head:pr1 git checkout

[Freeipa-devel] [freeipa PR#284][+ack] ipautil: check for open ports on all resolved IPs

2016-11-30 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/284 Title: #284: ipautil: check for open ports on all resolved IPs Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#267][+ack] ipa-replica-conncheck: do not close listening ports until required

2016-11-30 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/267 Title: #267: ipa-replica-conncheck: do not close listening ports until required Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-11-30 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ @mbasti-rh @jcholast @tiran If you want I can replace the `--with-pytlint` option with `--enable-pylint` option (without

[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-11-30 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time pspacek commented: """ Fixed. Now `with_pylint` section contains nested section `with_python3`. """ See the full comment at https

[Freeipa-devel] [freeipa PR#272][synchronized] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-11-30 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Author: pspacek Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull

[Freeipa-devel] [freeipa PR#281][comment] Accept server host names resolvable only using /etc/hosts

2016-11-29 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/281 Title: #281: Accept server host names resolvable only using /etc/hosts pspacek commented: """ `--no-host-dns` disables all checks (theoretically) so it should be used only in special cases. Given it acts as kind of force sw

[Freeipa-devel] [freeipa PR#281][comment] Accept server host names resolvable only using /etc/hosts

2016-11-29 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/281 Title: #281: Accept server host names resolvable only using /etc/hosts pspacek commented: """ This entierly depens on configuration. Imagine following imaginary company setup: - public part of DNS tree is `example.com.` - priv

[Freeipa-devel] [freeipa PR#279][comment] installer: Stop adding distro-specific NTP servers into ntp.conf

2016-11-28 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/279 Title: #279: installer: Stop adding distro-specific NTP servers into ntp.conf pspacek commented: """ Have you tested the code? I would bet that it will remove everything except 127.127... from the list of servers. "&quo

[Freeipa-devel] [freeipa PR#279][comment] installer: Stop adding distro-specific NTP servers into ntp.conf

2016-11-28 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/279 Title: #279: installer: Stop adding distro-specific NTP servers into ntp.conf pspacek commented: """ NACK ``` Pylint is running, please wait ... * Module ipaserver.install.ntpinstance ipaserver/install/ntpinstance.py:23

[Freeipa-devel] [freeipa PR#281][opened] Accept server host names resolvable only using /etc/hosts

2016-11-28 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/281 Author: pspacek Title: #281: Accept server host names resolvable only using /etc/hosts Action: opened PR body: """ Apparently "files" implementation of hosts NSS database cannot deal with trailing period in hos

[Freeipa-devel] [freeipa PR#213][edited] Build system refactoring phase 3

2016-11-25 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Author: pspacek Title: #213: Build system refactoring phase 3 Action: edited Changed field: body Original value: """ This monster patch-set refactors most of build system and moves most of the logic from SPEC file

[Freeipa-devel] [freeipa PR#268][comment] Build system must regenerate file when template changes

2016-11-25 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/268 Title: #268: Build system must regenerate file when template changes pspacek commented: """ Oh, you are right, I was mixing `CONFIG_STATUS_DEPEDENCIES` and `AC_CONFIG_FILES`. Sorry! So please let me explain the problem with `

[Freeipa-devel] [freeipa PR#268][comment] Build system must regenerate file when template changes

2016-11-25 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/268 Title: #268: Build system must regenerate file when template changes pspacek commented: """ I already described problems with `AC_CONFIG_FILE` in https://github.com/freeipa/freeipa/pull/251#issuecomment-261470338 a week

[Freeipa-devel] [freeipa PR#273][opened] Build: workaround bug while calling parallel make from rpmbuild

2016-11-25 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/273 Author: pspacek Title: #273: Build: workaround bug while calling parallel make from rpmbuild Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6418 """ To pull the PR as Git branch: git remote ad

[Freeipa-devel] [freeipa PR#213][edited] Build system refactoring phase 3

2016-11-24 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/213 Author: pspacek Title: #213: Build system refactoring phase 3 Action: edited Changed field: body Original value: """ This monster patch-set refactors most of build system and moves most of the logic from SPEC file

[Freeipa-devel] [freeipa PR#272][synchronized] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-11-24 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Author: pspacek Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull

[Freeipa-devel] [freeipa PR#272][opened] Build: makerpms.sh generates Python 2 & 3 packages at the same time

2016-11-24 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/272 Author: pspacek Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time Action: opened PR body: """ Petr Viktorin recommended me to copy the whole build directory and run configure twice, wi

[Freeipa-devel] [freeipa PR#113][comment] ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri

2016-11-24 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/113 Title: #113: ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri pspacek commented: """ Honza will take care of this as part of ipalib cleanup for the Integration Improvements project. "&quo

[Freeipa-devel] [freeipa PR#268][synchronized] Build system must regenerate file when template changes

2016-11-24 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/268 Author: pspacek Title: #268: Build system must regenerate file when template changes Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/268/head:pr268 git

[Freeipa-devel] [freeipa PR#268][opened] Build system must regenerate file when template changes

2016-11-23 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/268 Author: pspacek Title: #268: Build system must regenerate file when template changes Action: opened PR body: """ Proper fix for https://fedorahosted.org/freeipa/ticket/6498. This PR obsoletes #251. """ To pull th

[Freeipa-devel] [freeipa PR#251][+rejected] Add rebuild rule for template files

2016-11-21 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/251 Title: #251: Add rebuild rule for template files Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#251][comment] Add rebuild rule for template files

2016-11-21 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/251 Title: #251: Add rebuild rule for template files pspacek commented: """ I'm going to provide a proper fix as agreed on meeting today. """ See the full comment at https://github.com/freeipa/freeipa/pull/251#issuecom

[Freeipa-devel] [freeipa PR#251][closed] Add rebuild rule for template files

2016-11-21 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/251 Author: tiran Title: #251: Add rebuild rule for template files Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/251/head:pr251 git checkout pr251 -- Manage your

[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system

2016-11-21 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system pspacek commented: """ @tiran You are right, I forgot to remove the `config.rpath` when `AM_GNU_GETTEXT_VERSION` macro was introduced. This version fix

[Freeipa-devel] [freeipa PR#260][opened] Build: fix path in ipa-ods-exporter.socket unit file

2016-11-21 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/260 Author: pspacek Title: #260: Build: fix path in ipa-ods-exporter.socket unit file Action: opened PR body: """ This fixes regression caused by incorrect daemons/dnssec/ipa-ods-exporter.socket.in path template intro

[Freeipa-devel] [bind-dyndb-ldap PR#1][comment] Port bind-dyndb-ldap to BIND 9.11

2016-11-18 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/1 Title: #1: Port bind-dyndb-ldap to BIND 9.11 pspacek commented: """ @stutiredboy There is probably a issue in path overriding logic. I will take care of this in separate PR because it works when you have BIND 9.11 instal

[Freeipa-devel] [bind-dyndb-ldap PR#1][+ack] Port bind-dyndb-ldap to BIND 9.11

2016-11-18 Thread pspacek
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/1 Title: #1: Port bind-dyndb-ldap to BIND 9.11 Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#253][comment] Add .eggs to Gitignore

2016-11-18 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/253 Title: #253: Add .eggs to Gitignore pspacek commented: """ I'm using this script to build IPA: ~~~ rm -rvf ~/rpmbuild/{BUILD,BUILDROOT,SPECS,SOURCES,RPMS,SRPMS} mkdir -pv ~/rpmbuild/{BUILD,BUILDROOT,SPECS,SOURCES,RPMS,SRPMS

[Freeipa-devel] [freeipa PR#251][comment] Add rebuild rule for template files

2016-11-17 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/251 Title: #251: Add rebuild rule for template files pspacek commented: """ NACK: - the variable is defined incorrectly, it should be in configure.ac (see Automake manual chapter [16 Rebuilding Makefiles](https://www.gnu.org/so

[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system

2016-11-17 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system pspacek commented: """ Good catch, fixed & rebased on top of current master. """ See the full comment at https://github.com/freeipa/freei

[Freeipa-devel] [freeipa PR#253][comment] Add .eggs to Gitignore

2016-11-17 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/253 Title: #253: Add .eggs to Gitignore pspacek commented: """ @tiran Please provide me a ticket number which is linked to the commits which caused creation of .eggs. Thanks. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#253][opened] Add .eggs to Gitignore

2016-11-17 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/253 Author: pspacek Title: #253: Add .eggs to Gitignore Action: opened PR body: """ These are result of new Python builds. """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeip

[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system

2016-11-16 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system pspacek commented: """ As far as I can tell all the nits mentioned *above* are addressed in the last version. Enjoy review :-) """

[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system

2016-11-16 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system pspacek commented: """ This is rebased and fixed version. It should work including linters. Missing things: - [x] use fresh gettext files generated by auto

[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system

2016-11-16 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system pspacek commented: """ As far as I can tell all the nits mentioned below are addressed in the last version. Enjoy review :-) """

[Freeipa-devel] [freeipa PR#246][+ack] Build: ignore rpmbuild for lint target

2016-11-16 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/246 Title: #246: Build: ignore rpmbuild for lint target Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#195][edited] Make ipaclient pip install-able

2016-11-16 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/195 Author: tiran Title: #195: Make ipaclient pip install-able Action: edited Changed field: body Original value: """ This makes ipaclient and dependencies pip install-able by adding install requirements to all `setup.py`. A new make target

[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system

2016-11-16 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system pspacek commented: """ This is rebased and fixed version. It should work including linters. Missing things: - [ ] use fresh gettext files generated by auto

[Freeipa-devel] [freeipa PR#236][+ack] Build phase 7: cleanup

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ ACKing on behalf of Lukas. """ See the full comment at https://github.com/freeipa/freeipa/pull/236#issuecomment-260776818 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ @lslebodn There is currently no plan to support distcheck: Python setuptools do not support VPATH builds as AFAIK it is impossible to do that without patching set

[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ Rebased. """ See the full comment at https://github.com/freeipa/freeipa/pull/236#issuecomment-260769221 -- Manage your subscription for the Fre

[Freeipa-devel] [freeipa PR#236][synchronized] Build phase 7: cleanup

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Author: pspacek Title: #236: Build phase 7: cleanup Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/236/head:pr236 git checkout pr236 From

[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ @lslebodn I've dropped the controversial patch which removes NULLs to allow you to send PR which adds it everywhere as you proposed. I'm going to wait till

[Freeipa-devel] [freeipa PR#236][synchronized] Build phase 7: cleanup

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Author: pspacek Title: #236: Build phase 7: cleanup Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/236/head:pr236 git checkout pr236 From

[Freeipa-devel] [freeipa PR#215][comment] Add script to setup krb5 NFS exports

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/215 Title: #215: Add script to setup krb5 NFS exports pspacek commented: """ It sounds to me that it could be an useful plugin for ipa-advise tool. This is the tool which is supposed to given advies like 'install this and that' and s

[Freeipa-devel] [freeipa PR#237][reopened] Update man page for ipa-adtrust-install by removing --no-msdcs option

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/237 Author: pspacek Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs option Action: reopened To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/237

[Freeipa-devel] [freeipa PR#237][comment] Update man page for ipa-adtrust-install by removing --no-msdcs option

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/237 Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs option pspacek commented: """ Given the code change went to ipa-4-4 branch, I would merge it to ipa-4-4 as well. It does not make sense to keep it only

[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup

2016-11-14 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ Hi Lukas. Given there is no technical justification to have it I'm going to remove these. Simple is better than complex. """ See the full comment at http

[Freeipa-devel] [freeipa PR#237][synchronized] Update man page for ipa-adtrust-install by removing --no-msdcs option

2016-11-14 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/237 Author: pspacek Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs option Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/237

[Freeipa-devel] [freeipa PR#237][comment] Update man page for ipa-adtrust-install by removing --no-msdcs option

2016-11-14 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/237 Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs option pspacek commented: """ Here you go. """ See the full comment at https://github.com/freeipa/freeipa/pull/237#issuecomment-26028076

[Freeipa-devel] [freeipa PR#237][opened] Update man page for ipa-adtrust-install by removing --no-msdcs option

2016-11-13 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/237 Author: pspacek Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs option Action: opened PR body: """ https://bugzilla.redhat.com/show_bug.cgi?id=1392778 """ To pull the PR as Git br

[Freeipa-devel] [freeipa PR#236][opened] Build phase 7: cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Author: pspacek Title: #236: Build phase 7: cleanup Action: opened PR body: """ Depends on PR #233. - Clean-up ancient leftovers and clean minor bugs here and there. - Support --enable-silent-rules and V=0 variable for make to

[Freeipa-devel] [freeipa PR#233][synchronized] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Author: pspacek Title: #233: Build phase 6: %install cleanup Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/233/head:pr233 git checkout pr233 From

[Freeipa-devel] [freeipa PR#233][comment] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup pspacek commented: """ I've fixed incorrect use of `-D` in `install` calls above. """ See the full comment at https://github.com/freeipa/freeipa/pull/233#issuecom

[Freeipa-devel] [freeipa PR#233][synchronized] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Author: pspacek Title: #233: Build phase 6: %install cleanup Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/233/head:pr233 git checkout pr233 From

[Freeipa-devel] [freeipa PR#233][comment] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup pspacek commented: """ @tiran Please re-review and set review status accordingly. Thanks! """ See the full comment at https://github.com/freeipa/freeipa/pull/233#iss

[Freeipa-devel] [freeipa PR#233][comment] Build phase 6: %install cleanup

2016-11-11 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup pspacek commented: """ This version fixes the fixable issues, i.e. everything mentioned above except changing file ownership. """ See the full comment at https://githu

  1   2   3   >