Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch

2010-09-20 Thread Pavel Zuna

On 09/17/2010 04:38 PM, Adam Young wrote:

moved images up
Adding an 'images' subdir was proliferating changes throughout the build
system
this seemed easier

Submitted as a separate patch to signify where wea re departing from
what is generated by theme-roller



Doesn't apply for me. Missing some image files and doesn't apply on 
jquery-ui.css.

I applied all your patches I could find before this one, but I can't find number 
28 on the list. Maybe that's the reason.


Pavel

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch

2010-09-20 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote:

 moved images up
   Adding an 'images' subdir was proliferating changes throughout the 
 build system
   this seemed easier
 
 Submitted as a separate patch to signify where wea re departing from 
 what is generated by theme-roller

admiyo-freeipa-0030-moved-images-up.patch

ACK with a few notes:
- If the number of images is getting large, it's better to use a separate
  folder for images.
- If the theme needs to be regenerated, the files need to be modified 
  rearranged again.
- To support customizable UI, the file needs to be modified  rearranged
  again.

--
Endi S. Dewata

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch

2010-09-20 Thread Adam Young

On 09/20/2010 12:14 PM, Endi Sukma Dewata wrote:

- Adam Youngayo...@redhat.com  wrote:

   

moved images up
   Adding an 'images' subdir was proliferating changes throughout the
build system
   this seemed easier

Submitted as a separate patch to signify where wea re departing from
what is generated by theme-roller
 

admiyo-freeipa-0030-moved-images-up.patch

ACK with a few notes:
- If the number of images is getting large, it's better to use a separate
   folder for images.
- If the theme needs to be regenerated, the files need to be modified
   rearranged again.
- To support customizable UI, the file needs to be modified  rearranged
   again.

--
Endi S. Dewata
   

Pushed to master.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch

2010-09-20 Thread Adam Young

On 09/20/2010 11:30 AM, Endi Sukma Dewata wrote:

- Adam Youngayo...@redhat.com  wrote:

   

On 09/20/2010 08:10 AM, Pavel Zuna wrote:
 

On 09/17/2010 04:38 PM, Adam Young wrote:
   

moved images up
Adding an 'images' subdir was proliferating changes throughout the
 

build
 

system
this seemed easier

Submitted as a separate patch to signify where wea re departing
 

from
 

what is generated by theme-roller

 

Doesn't apply for me. Missing some image files and doesn't apply on
   
 

jquery-ui.css.

I applied all your patches I could find before this one, but I can't
   
 

find number 28 on the list. Maybe that's the reason.

Pavel
   

admiyo-freeipa-0028-theme.patch
ACK.

--
Endi S. Dewata
   

Pushed to master

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel