Re: [Freeipa-devel] [PATCH] 0059: webui: make 'Actions' strings translatable

2016-06-21 Thread Martin Basti 



On 21.06.2016 13:09, Petr Vobornik wrote:

On 06/21/2016 12:34 PM, Martin Basti wrote:


On 20.06.2016 20:48, Pavel Vomacka wrote:

Hello,

please review attached patch.

--

Pavel^3 Vomacka




Functional ACK



Code ACK

Pushed to master: 13e0d2e4d1c0da055644d87f1b8a9465b2ef6dfa

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0059: webui: make 'Actions' strings translatable

2016-06-21 Thread Petr Vobornik 
On 06/21/2016 12:34 PM, Martin Basti wrote:
> 
> 
> On 20.06.2016 20:48, Pavel Vomacka wrote:
>> Hello,
>>
>> please review attached patch.
>>
>> -- 
>>
>> Pavel^3 Vomacka
>>
>>
>>
> Functional ACK
> 
> 

Code ACK
-- 
Petr Vobornik

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0059: webui: make 'Actions' strings translatable

2016-06-21 Thread Martin Basti 



On 20.06.2016 20:48, Pavel Vomacka wrote:

Hello,

please review attached patch.

--

Pavel^3 Vomacka




Functional ACK
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH] 0059: webui: make 'Actions' strings translatable

2016-06-20 Thread Pavel Vomacka 

Hello,

please review attached patch.

--

Pavel^3 Vomacka

From ff35b4ae33714783c42751f917e2c21fd390cbd7 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka 
Date: Mon, 20 Jun 2016 20:43:26 +0200
Subject: [PATCH] Make Actions string translatable

Remove hardcoded strings 'Actions ' and substitute them by strings from
translatable strings.
---
 install/ui/src/freeipa/facet.js  | 2 +-
 install/ui/src/freeipa/facets/HeaderMixin.js | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/install/ui/src/freeipa/facet.js b/install/ui/src/freeipa/facet.js
index cc51a1531d875882414c0392fabff2dbf4ce315a..4553c5c65e6c334ed451e9c2f1a89ddc455d71c3 100644
--- a/install/ui/src/freeipa/facet.js
+++ b/install/ui/src/freeipa/facet.js
@@ -1112,7 +1112,7 @@ exp.facet = IPA.facet = function(spec, no_init) {
 name: 'facet_actions',
 'class': 'dropdown facet-actions',
 right_aligned: true,
-toggle_text: 'Actions ',
+toggle_text: text.get('@i18n:actions.title') + ' ',
 toggle_class: 'btn btn-default',
 toggle_icon: 'fa fa-angle-down'
 });
diff --git a/install/ui/src/freeipa/facets/HeaderMixin.js b/install/ui/src/freeipa/facets/HeaderMixin.js
index 01273129106118fa7408b6ef217193424a678503..d5dbe924ad4117f3bd492abe3c15b4281b7c1594 100644
--- a/install/ui/src/freeipa/facets/HeaderMixin.js
+++ b/install/ui/src/freeipa/facets/HeaderMixin.js
@@ -9,10 +9,11 @@ define(['dojo/_base/declare',
 'dojo/dom-class',
 '../builder',
 '../facet',
+'../text',
 '../widgets/ActionDropdownWidget'
],
function(declare, lang, on, construct, dom_class,
-builder, mod_facet, ActionDropdownWidget) {
+builder, mod_facet, text, ActionDropdownWidget) {
 
 
 /**
@@ -247,7 +248,7 @@ var HeaderMixin = declare([], {
 name: 'facet_actions',
 'class': 'dropdown facet-actions',
 right_aligned: true,
-toggle_text: 'Actions ',
+toggle_text: text.get('@i18n:actions.title') + ' ',
 toggle_class: 'btn btn-default',
 toggle_icon: 'fa fa-angle-down'
 });
-- 
2.5.5

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code