Re: [Freeipa-devel] [PATCH] 428 Hide delete button in multivalued widget if attr is not writable

2013-07-29 Thread Ana Krivokapic
On 07/18/2013 12:11 PM, Petr Vobornik wrote: Hide delete button in multivalued widget if attr is not writable https://fedorahosted.org/freeipa/ticket/3799 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 428 Hide delete button in multivalued widget if attr is not writable

2013-07-19 Thread Petr Vobornik
On 07/18/2013 05:50 PM, James wrote: On Thu, 2013-07-18 at 12:11 +0200, Petr Vobornik wrote: Hide delete button in multivalued widget if attr is not writable Hey, Maybe it would be a good idea to set the disabled state of the button instead of removing it? That way it's obvious that some

Re: [Freeipa-devel] [PATCH] 428 Hide delete button in multivalued widget if attr is not writable

2013-07-19 Thread James
On Fri, 2013-07-19 at 17:59 +0200, Petr Vobornik wrote: Hello, Note: the button is actually in a form of a link I didn't notice this before. Sorry for the noise. James The approach you're proposing is often valid and a preferred one but I don't think it's the best approach for our

[Freeipa-devel] [PATCH] 428 Hide delete button in multivalued widget if attr is not writable

2013-07-18 Thread Petr Vobornik
Hide delete button in multivalued widget if attr is not writable https://fedorahosted.org/freeipa/ticket/3799 -- Petr Vobornik From 0f133f0aa47f0bd1b6567c3adeb37e58e73df859 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Fri, 28 Jun 2013 16:14:45 +0200 Subject: [PATCH]

Re: [Freeipa-devel] [PATCH] 428 Hide delete button in multivalued widget if attr is not writable

2013-07-18 Thread James
On Thu, 2013-07-18 at 12:11 +0200, Petr Vobornik wrote: Hide delete button in multivalued widget if attr is not writable Hey, Maybe it would be a good idea to set the disabled state of the button instead of removing it? That way it's obvious that some attrs can be deleted, and it won't cause