Re: [Freeipa-devel] [PATCH 0059] dbus: Create empty dbus.Array with specified signature

2015-08-14 Thread Martin Basti



On 08/10/2015 04:14 PM, David Kupka wrote:
I was installing freeipa-server earlier today and it failed with 
Unable to guess signature from empty list.
I was unable to reproduce it but there is now harm in explicitly 
specifying the signature of the empty list to prevent this issue.





ACK

Pushed to master: fe91c375d06b076c628e2e72cfdf48db5435

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0059] dbus: Create empty dbus.Array with specified signature

2015-08-10 Thread David Kupka
I was installing freeipa-server earlier today and it failed with Unable 
to guess signature from empty list.
I was unable to reproduce it but there is now harm in explicitly 
specifying the signature of the empty list to prevent this issue.


--
David Kupka
From bd77546fc5844645a0813b702aa2b5de718b6e0b Mon Sep 17 00:00:00 2001
From: David Kupka dku...@redhat.com
Date: Mon, 10 Aug 2015 15:46:03 +0200
Subject: [PATCH] dbus: Create empty dbus.Array with specified signature

Python DBus binding could fail to guess the type signature from empty list.
This issue was seen but we don't have a reproducer. There is no harm in making
sure that it will not happen.
---
 ipaserver/install/dogtaginstance.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ipaserver/install/dogtaginstance.py b/ipaserver/install/dogtaginstance.py
index 33f39f7930b4151200f2880d02a0bc2c152c0025..70f11ee09a6ac427322bb069b0851bc7c93fe04d 100644
--- a/ipaserver/install/dogtaginstance.py
+++ b/ipaserver/install/dogtaginstance.py
@@ -304,7 +304,8 @@ class DogtagInstance(service.Service):
 if not path:
 iface.add_known_ca(
 'dogtag-ipa-ca-renew-agent',
-paths.DOGTAG_IPA_CA_RENEW_AGENT_SUBMIT, [])
+paths.DOGTAG_IPA_CA_RENEW_AGENT_SUBMIT,
+dbus.Array([], dbus.Signature('s')))
 
 def __get_pin(self):
 try:
-- 
2.4.3

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code