Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-08 Thread Martin Kosek
On 04/03/2014 04:31 PM, Alexander Bokovoy wrote: On Wed, 02 Apr 2014, Martin Kosek wrote: On 04/01/2014 12:03 PM, Jan Pazdziora wrote: On Tue, Apr 01, 2014 at 10:05:39AM +0200, Tomas Babej wrote: Yes, that was the intention. Mistake on my part, I'll send updated patches. Updated patch

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-03 Thread Alexander Bokovoy
On Wed, 02 Apr 2014, Martin Kosek wrote: On 04/01/2014 12:03 PM, Jan Pazdziora wrote: On Tue, Apr 01, 2014 at 10:05:39AM +0200, Tomas Babej wrote: Yes, that was the intention. Mistake on my part, I'll send updated patches. Updated patch attached. Ack based on reading the code and

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-02 Thread Martin Kosek
On 04/01/2014 12:03 PM, Jan Pazdziora wrote: On Tue, Apr 01, 2014 at 10:05:39AM +0200, Tomas Babej wrote: Yes, that was the intention. Mistake on my part, I'll send updated patches. Updated patch attached. Ack based on reading the code and documentation for slapi_ch_free_string. Ok,

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-02 Thread Alexander Bokovoy
On Wed, 02 Apr 2014, Martin Kosek wrote: On 04/01/2014 12:03 PM, Jan Pazdziora wrote: On Tue, Apr 01, 2014 at 10:05:39AM +0200, Tomas Babej wrote: Yes, that was the intention. Mistake on my part, I'll send updated patches. Updated patch attached. Ack based on reading the code and

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-01 Thread Jan Pazdziora
On Thu, Mar 27, 2014 at 01:14:52PM +0100, Tomas Babej wrote: Hi, When cleaning the range_info struct, simple free of the struct is not enough, we have to free contents of char pointers in the struct as well. https://fedorahosted.org/freeipa/ticket/4276 [...] 1 file changed, 13

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-01 Thread Alexander Bokovoy
On Tue, 01 Apr 2014, Jan Pazdziora wrote: On Thu, Mar 27, 2014 at 01:14:52PM +0100, Tomas Babej wrote: Hi, When cleaning the range_info struct, simple free of the struct is not enough, we have to free contents of char pointers in the struct as well.

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-01 Thread Tomas Babej
On 04/01/2014 09:11 AM, Alexander Bokovoy wrote: On Tue, 01 Apr 2014, Jan Pazdziora wrote: On Thu, Mar 27, 2014 at 01:14:52PM +0100, Tomas Babej wrote: Hi, When cleaning the range_info struct, simple free of the struct is not enough, we have to free contents of char pointers in the struct

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-01 Thread Tomas Babej
On 04/01/2014 09:17 AM, Tomas Babej wrote: On 04/01/2014 09:11 AM, Alexander Bokovoy wrote: On Tue, 01 Apr 2014, Jan Pazdziora wrote: On Thu, Mar 27, 2014 at 01:14:52PM +0100, Tomas Babej wrote: Hi, When cleaning the range_info struct, simple free of the struct is not enough, we have to

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-01 Thread Jan Pazdziora
On Tue, Apr 01, 2014 at 10:05:39AM +0200, Tomas Babej wrote: Yes, that was the intention. Mistake on my part, I'll send updated patches. Updated patch attached. Ack based on reading the code and documentation for slapi_ch_free_string. -- Jan Pazdziora Principal Software Engineer,

[Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-03-27 Thread Tomas Babej
Hi, When cleaning the range_info struct, simple free of the struct is not enough, we have to free contents of char pointers in the struct as well. https://fedorahosted.org/freeipa/ticket/4276 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: