Re: [Freeipa-devel] [PATCH 40/40] ticket 1659 - invalid i18n string in dns.py

2011-08-18 Thread Alexander Bokovoy
On 18.08.2011 01:54, John Dennis wrote:
 dns.py at line 976 has an invalid i18n string and cannot be processed
 during message extraction causing message catalog generation to fail.
 
 The format parameters are trapped inside the i18n string. Also it's
 not necessary to promote the i18n string literal to unicode via the u
 prefix because the _() function returns unicode.
ACK


-- 
/ Alexander Bokovoy

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH 40/40] ticket 1659 - invalid i18n string in dns.py

2011-08-18 Thread Martin Kosek
On Thu, 2011-08-18 at 10:43 +0300, Alexander Bokovoy wrote:
 On 18.08.2011 01:54, John Dennis wrote:
  dns.py at line 976 has an invalid i18n string and cannot be processed
  during message extraction causing message catalog generation to fail.
  
  The format parameters are trapped inside the i18n string. Also it's
  not necessary to promote the i18n string literal to unicode via the u
  prefix because the _() function returns unicode.
 ACK
 
 

Pushed to master, ipa-2-1.

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH 40/40] ticket 1659 - invalid i18n string in dns.py

2011-08-17 Thread John Dennis
dns.py at line 976 has an invalid i18n string and cannot be processed
during message extraction causing message catalog generation to fail.

The format parameters are trapped inside the i18n string. Also it's
not necessary to promote the i18n string literal to unicode via the u
prefix because the _() function returns unicode.

--
John Dennis jden...@redhat.com

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
From b3be43ecbe98fce9de95bac0acc3c9493a3a8b59 Mon Sep 17 00:00:00 2001
From: John Dennis jden...@redhat.com
Date: Wed, 17 Aug 2011 18:51:38 -0400
Subject: [PATCH 40/40] ticket 1659 - invalid i18n string in dns.py
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

dns.py at line 976 has an invalid i18n string and cannot be processed
during message extraction causing message catalog generation to fail.

The format parameters are trapped inside the i18n string. Also it's
not necessary to promote the i18n string literal to unicode via the u
prefix because the _() function returns unicode.
---
 ipalib/plugins/dns.py |5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/ipalib/plugins/dns.py b/ipalib/plugins/dns.py
index 105678b..8ff3fc4 100644
--- a/ipalib/plugins/dns.py
+++ b/ipalib/plugins/dns.py
@@ -71,7 +71,7 @@ EXAMPLES:
 
A record: 1.2.3.4, 11.22.33.44
 
-   Delete A record '1.2.3.4'? Yes/No (default No): 
+   Delete A record '1.2.3.4'? Yes/No (default No):
Delete A record '11.22.33.44'? Yes/No (default No): y
  Record name: www
  A record: 1.2.3.4  (A record 11.22.33.44 has been deleted)
@@ -972,8 +972,7 @@ class dnsrecord_del(dnsrecord_mod_record):
 deleted_values = []
 for rec_value in dns_record[param.name]:
 user_del_value = self.Backend.textui.prompt_yesno(
-_(uDelete %s '%s'?
-%  (param.label, rec_value)), default=False)
+_(Delete %s '%s'?) % (param.label, rec_value), default=False)
 if user_del_value is True:
  deleted_values.append(rec_value)
 if deleted_values:
-- 
1.7.4.4

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel