URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
MartinBasti commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/fa7aaef1de2c97ac9d24925ca9adb25c7151055f
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
MartinBasti commented:
"""
@gkaihorodova you haven't pushed the changes to github repo
```
git push --force
```
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
gkaihorodova commented:
"""
@mbasti-rh done. hope now it's fine
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/181#issuecomment-272172666
--
Manage
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
mbasti-rh commented:
"""
This PR still needs rebase, it is not possible to apply patch without 3way
merge, please pull the latest master and do rebase, we merge only patches
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
gkaihorodova commented:
"""
Thank you for review!
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/181#issuecomment-271236642
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
stlaz commented:
"""
Thank you for the changes!
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/181#issuecomment-271222754
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
gkaihorodova commented:
"""
Yes, the intention was to have repr() of the given string , so I'll use ''{!r}
instead of '{}', and apply that change to #210 also. Thank you.
"""
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
stlaz commented:
"""
Seems fine + Travis is satisfied as well, ACK.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/181#issuecomment-270845790
--
Manage
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
stlaz commented:
"""
Seems fine + Travis is satisfied as well, ACK.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/181#issuecomment-270845790
--
Manage
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
mbasti-rh commented:
"""
Then, @stlaz must give final ACK
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/181#issuecomment-270692529
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
gkaihorodova commented:
"""
will do, but before let me do small changes that was requested by @stlaz in
#210, to use str.format() instead of " %r "
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
mbasti-rh commented:
"""
PR needs rebase
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/181#issuecomment-270594446
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
martbab commented:
"""
Bump for review.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/181#issuecomment-266416346
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
mirielka commented:
"""
Please check inline comments. Also suggestion for more test cases:
- try to create a user whose automatically generated uid would be too long (>32
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
apophys commented:
"""
I think in this case we can go with keyword arguments only. Most of the uses of
the tracker in the tests do it already. What I will need in the case of
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
mirielka commented:
"""
Having "None" default values for obligatory arguments does not seem to be a
good idea. If the method was called with default values, it would fail. It
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
gkaihorodova commented:
"""
Yes, It's a valid point to add testcases for these changes . Will do. Thank
you.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
mirielka commented:
"""
The same minimal values apply for stageuser-add command, can you please modify
the stageuser tracker as well? Also adding testcases for these changes
18 matches
Mail list logo
