[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/4842231074683ff68be50b147560f5383aa305b6 https://fedorahosted.org/freeipa/changeset/d40c376ccc1ec9292df0306134c7bfdfd096566e https://fedorahosted.org/freeipa/changeset/166257ec5b33dd2c95bbaf8463867c77fd6ef5db https://fedorahosted.org/freeipa/changeset/9ef5a7de781f2508c2925225533973417458d0ea https://fedorahosted.org/freeipa/changeset/8a7962585069d7b0ff7e8d87ce094f07c16b3cd4 https://fedorahosted.org/freeipa/changeset/4c133837d149352a68e1d6cbefbb28e4ae048755 """ See the full comment at https://github.com/freeipa/freeipa/pull/238#issuecomment-262267304 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system pspacek commented: """ @tiran You are right, I forgot to remove the `config.rpath` when `AM_GNU_GETTEXT_VERSION` macro was introduced. This version fixes this problem by removing `config.rpath` from Git. @lslebodn We can do this change in some later PR. I do not want to mix it with translation system changes. """ See the full comment at https://github.com/freeipa/freeipa/pull/238#issuecomment-261927883 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system lslebodn commented: """ >Your patch adds `config.rpath`. Is it necessary to include the file in source >control? certmonger and sssd use the file but don't have it in git. Following patch fixes this issue http://paste.fedoraproject.org/484212/47049414/ """ See the full comment at https://github.com/freeipa/freeipa/pull/238#issuecomment-261516489 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system tiran commented: """ Your patch adds ```config.rpath```. Is it necessary to include the file in source control? certmonger and sssd use the file but don't have it in git. """ See the full comment at https://github.com/freeipa/freeipa/pull/238#issuecomment-261504800 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system pspacek commented: """ Good catch, fixed & rebased on top of current master. """ See the full comment at https://github.com/freeipa/freeipa/pull/238#issuecomment-261467199 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system tiran commented: """ Build is failing: ``` Can't exec "autopoint": No such file or directory at /usr/share/autoconf/Autom4te/FileUtils.pm line 345. autoreconf: failed to run autopoint: No such file or directory autoreconf: autopoint is needed because this package uses Gettext ``` The command is provided by gettext-devel: ``` BuildRequires: gettext-devel ``` """ See the full comment at https://github.com/freeipa/freeipa/pull/238#issuecomment-261205116 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system pspacek commented: """ As far as I can tell all the nits mentioned *above* are addressed in the last version. Enjoy review :-) """ See the full comment at https://github.com/freeipa/freeipa/pull/238#issuecomment-261020281 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system pspacek commented: """ This is rebased and fixed version. It should work including linters. Missing things: - [x] use fresh gettext files generated by autoreconf """ See the full comment at https://github.com/freeipa/freeipa/pull/238#issuecomment-260936269 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system pspacek commented: """ As far as I can tell all the nits mentioned below are addressed in the last version. Enjoy review :-) """ See the full comment at https://github.com/freeipa/freeipa/pull/238#issuecomment-261020281 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system pspacek commented: """ This is rebased and fixed version. It should work including linters. Missing things: - [ ] use fresh gettext files generated by autoreconf """ See the full comment at https://github.com/freeipa/freeipa/pull/238#issuecomment-260936269 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system lslebodn commented: """ and also ``` Making install in po make[1]: Entering directory '/home/user/freeipa/po' make[1]: *** No rule to make target 'install'. Stop. make[1]: Leaving directory '/home/user/freeipa/po' make: *** [Makefile:595: install-recursive] Error 1 ``` """ See the full comment at https://github.com/freeipa/freeipa/pull/238#issuecomment-260662849 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system mbasti-rh commented: """ Lint failed ``` cd .; ./makeaci --validate ./makeaci: ipaserver/plugins/dogtag.py:244: ignoring ImportError: No module named backports_abc cd .; ./makeapi --validate ./makeapi: ipaserver/plugins/dogtag.py:244: ignoring ImportError: No module named backports_abc make -C ./po validate-src-strings make[1]: Entering directory '/freeipa/po' make[1]: Leaving directory '/freeipa/po' make[1]: *** No rule to make target 'validate-src-strings'. Stop. make: *** [polint] Error 2 Makefile:1098: recipe for target 'polint' failed ``` """ See the full comment at https://github.com/freeipa/freeipa/pull/238#issuecomment-260452692 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
