URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/b7d70baee73c64898de91e2fa59b3f9f417c8e01
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
I've found the root cause - incorrect order of operations in freeipa.spec.in.
Now it should work.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
martbab commented:
"""
Yep, running `ipa ping` on Fedora 25 confirms this:
```
# ipa ping
ipa: ERROR: AttributeError: 'str' object has no attribute 'decode'
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
martbab commented:
"""
I have re-built RPMs in the F25 image and found out that the /usr/bin/ipa
command has the following shebang:
```
#!/usr/bin/python3
```
so
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
To be sure I re-built RPMs from this PR using `makerpms.sh` script. My findings
are:
- `/usr/bin/ipa-run-tests` is a symlink to
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
@martbab Yes for this PR travis run tests under PY3, see tracebacks it is from
python3.5 site-packages
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
@martbab Yes for this PR travis run tests under PY3, see tracebacks it is from
python3.5 site-packages
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
Relevant parts of SPEC file are here:
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
`make install` will install whatever is auto-detected during configure (or
overriden by `$PYTHON` variable while calling `make install`).
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
martbab commented:
"""
Travis installs the built RPMs and then runs server install and outoftree test
suite. It does not use `make install`.
BTW does this mean
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
`make install` put `#!/usr/bin/python` into `ipa-run-tests` and it causes that
on F25 our tests are running by default under PY3
Probably
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
@martbab Can I do something in the build system to make your CI implementation
easier?
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
ACK, but travis runs tests under PY3 and should be, I tried locally and tests
works for me (ipa-run-tests is still py2 by default), so
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
ACK, but travis runs tests under PY3 and should be, I tried locally and tests
works for me (ipa-run-tests is still py2 by default), so
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
I've synchronized `python-cryptography` and `python-gssapi` versions. Thank you
for noticing. Let's see if CI tests pass or not.
"""
See the
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
tiran commented:
"""
* CI is failing: ```12-08 10:53 ipadocker.cli ERRORCommand echo Secret123 |
kinit admin && ipa ping failed (exit code 1)```. I have kicked
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
I've implemented tiran's proposal and rebased the patchset.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
I'm fine with `make pylint PYTHON=python3` as long as you can agree on it :-)
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
Ok if Petr agree we can go with your proposal
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
tiran commented:
"""
PS: I'd rather not run both linters in parallel. We use pylint in parallel
mode, which runs as many workers as CPU cores. ```make pylint```
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
tiran commented:
"""
It's easily possible with my proposal, just saying:
```make pylint PYTHON=python3```
```make pylint PYTHON=python2```
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
I had discussion with Petr, and currently we cannot run both pylints in build
system and it is not easy to add it there.
So we have to
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
Or we can run both pylints as far as we wants py2/3 compatible versions
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
But we build both 2/3 versions at once
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/272#issuecomment-265469455
--
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
tiran commented:
"""
It makes more sense to follow the principal *test what you build, build what
you test*.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
I would like rather explicit pylint version than autodetection
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
tiran commented:
"""
+1 for my trick
Since I disabled the import warnings for samba bindings in fef6f18aa, pylint is
passing under Python 3, too.
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
@mbasti-rh @jcholast @tiran
If you want I can replace the `--with-pytlint` option with `--enable-pylint`
option (without parameters) and use
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
Fixed. Now `with_pylint` section contains nested section `with_python3`.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
mbasti-rh commented:
"""
Shouldn't be there python3 in BuildRequires as well? At least with
python3-pylint we need python3 dependencies to be able do pylint3
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
tiran commented:
"""
AFAIK the build won't run pylint twice with the correct Python version. You
could replace the configure option for pylint and the pylint
31 matches
Mail list logo
