URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
MartinBasti commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/b3c41f21e51e5389d95b5486dcdfdc3f9a8b0424
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
MartinBasti commented:
"""
That test actually doesn't test output of command, IMO it should be
xmlrpc_test. But it can be done later, shouldn't block this PR
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
MartinBasti commented:
"""
That test actually doesn't test output of command, IMO it should be
xmlrpc_test. But it can be done later, shouldn't block this PR
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
MartinBasti commented:
"""
@Akasurde sorry for delay, we still miss test. Otherwise I'm fine with this
approach (when issue commented inline fixed)
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
Akasurde commented:
"""
@MartinBasti is there any action item pending on my side?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/394#issuecomment-277606801
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
MartinBasti commented:
"""
I would like to have `py3 str` <=> `py2 unicode`, `py3 bytes` <=> `py2 str`,
but framework is far away from this ideal state.
So I have no strong opinion, and once we will
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
HonzaCholasta commented:
"""
We are OK with the patch because fixing the root cause is out of the scope of
this PR.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
HonzaCholasta commented:
"""
@tiran, namespace keys are always ASCII. But feel free to open a ticket to
convert all remaining uses of `str` as text to `unicode`, changing it for one
random bit in
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
tiran commented:
"""
In Python 2 str is a Chimera with the head of a text object and the body of a
bytes object. It's just text if all text you got is ASCII. For clean polyglot
code it's highly
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
HonzaCholasta commented:
"""
The namespace keys *are* text (`str`) in both Python 2 and 3. The issue here is
that the RPC layer assumes that `str` is binary data, which the patch correctly
fixes by
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
tiran commented:
"""
Why should *Python 2 class names are str instances* prevent us from making the
namespace keys text? In Python 2 ASCII str and ASCII unicode are equivalent
dict keys (same hash,
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
tiran commented:
"""
Why should *Python 2 class names are str instances* prevent us from making the
namespace keys text? In Python 2 ASCII str and ASCII unicode are equivalent
dict keys (same hash,
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
Akasurde commented:
"""
@martbab Yes, I will write a test case for this scenario and attach here.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/394#issuecomment-273420038
--
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
martbab commented:
"""
@Akasurde are you OK with writing a simple regression test for this command as
a part of this PR?
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
HonzaCholasta commented:
"""
@mbasti-rh, no. Classes aren't named using unicode strings either.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/394#issuecomment-273395287
--
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
mbasti-rh commented:
"""
Shouldn't be namespaces named using unicode strings?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/394#issuecomment-273275568
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
rcritten commented:
"""
How about a test to prevent future regressions?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/394#issuecomment-272962038
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
martbab commented:
"""
Thanks the patch makes the command work. However, the namespace names are
returned as string, not unicode literals and thus the framework returns them as
base64-encoded values:
18 matches
Mail list logo
