[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-03-15 Thread tjaalton
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tjaalton commented: """ sorry, I just saw PR#600 which is a subset of this """ See the full comment at https://github.com/freeipa/freeipa/pull/494#issuecomment-286758047 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-03-15 Thread tjaalton
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tjaalton commented: """ +ack on the xmlrpc-c detection patch at least, I need that on Debian """ See the full comment at https://github.com/freeipa/freeipa/pull/494#issuecomment-286756541 -- Manage your

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build pvoborni commented: """ #364 was pushed. """ See the full comment at https://github.com/freeipa/freeipa/pull/494#issuecomment-281690828 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 01:52), Tomas Krizek wrote: >@lslebodn My bad, there was some leftover stuff that `git clean -dfx` didn't >clear for some reason. > >Nevertheless, this does work and

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 03:24), Christian Heimes wrote: >python-requests is a bad example because it suffers from the same issue as IPA. > >A better example is any other modern Python project

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 03:24), Christian Heimes wrote: >python-requests is a bad example because it suffers from the same issue as IPA. > >A better example is any other modern Python project

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tiran commented: """ python-requests is a bad example because it suffers from the same issue as IPA. A better example is any other modern Python project like cryptography. It runs tests with installed

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 03:04), Christian Heimes wrote: >You are aware that your example code checks the wrong code? It is testing >in-tree sources, not the actual sources that get packaged and

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tiran commented: """ You are aware that your example code checks the wrong code? It is testing in-tree sources, not the actual sources that get packaged and installed. """ See the full comment at

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 02:51), Christian Heimes wrote: >You assumption is incorrect. ```ipatests``` does not depend on >```ipaserver```,

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tiran commented: """ You assumption is incorrect. ```ipatests``` does not depend on ```ipaserver```, https://github.com/freeipa/freeipa/blob/master/ipatests/setup.py#L61 ``` install_requires=[

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 02:09), Christian Heimes wrote: >There are two reasons we decided on ```--without-ipatests```: > >* ```--with-tests``` / ```--without-tests``` is technically not correct.

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 02:23), Christian Heimes wrote: >tiran requested changes on this pull request. > >see comments > >> -CFLAGS="$bck_cflags" >- >-LIBPDB_NAME=""

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 02:16), Christian Heimes wrote: >NACK on 42fb9b1c > >* Either use ```--with-ipaplatform=redhat``` on CentOS >* Or implement a proper way to fill ipaplatfrom from

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tiran commented: """ NACK on 42fb9b1c * Either use ```--with-ipaplatform=redhat``` on CentOS * Or implement a proper way to fill ipaplatfrom from ```/etc/os-relase``` value ```ID_LIKE```,

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tiran commented: """ There are two reasons we decided on ```--without-ipatests```: * ```--with-tests``` / ```--without-tests``` is technically not correct. We still compile C tests. The flag is about the

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 01:43), Christian Heimes wrote: >NACK on aece4c3c > >We compromised on ```--without-ipatests``` with installation of ipatests >defaulting to true. The compromose was

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tomaskrizek commented: """ @lslebodn My bad, there was some leftover stuff that `git clean -dfx` didn't clear for some reason. Nevertheless, this does work and allows a client only, as well as installing

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tiran commented: """ NACK on aece4c3c We compromised on ```--without-ipatests``` with installation of ipatests defaulting to true. The compromose was already ACKed by @simo5 """ See the full comment at

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ BTW I tested client-only build on fedora24, fedora25, fedora rawhide, epel7, debian stable, debian testing, debian unstable """ See the full comment at

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 00:59), Tomas Krizek wrote: >I'm not able to run autoreconf, it fails with the following error: > >``` >configure.ac:447: error: required file

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tomaskrizek commented: """ I'm not able to run autoreconf, it fails with the following error: ``` configure.ac:447: error: required file 'init/tmpfilesd/Makefile.in' not found asn1/Makefile.am: installing