[Freeipa-devel] [freeipa PR#688][comment] Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

2017-04-26 Thread HonzaCholasta
  URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user 
searches

HonzaCholasta commented:
"""
master:

* 38276d3473ecf2a4cc5b5e2a107347f046625626 Update get_attr_filter in LDAPSearch 
to handle nsaccountlock user searches


ipa-4-5:

* dc4d60c9665408666ab3dfab7023a578c34d65a2 Update get_attr_filter in LDAPSearch 
to handle nsaccountlock user searches


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/688#issuecomment-297338734
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#688][comment] Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

2017-04-25 Thread redhatrises
  URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user 
searches

redhatrises commented:
"""
@HonzaCholasta I removed the change to `VERSION.m4`
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/688#issuecomment-297037487
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#688][comment] Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

2017-04-25 Thread HonzaCholasta
  URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user 
searches

HonzaCholasta commented:
"""
Actually, please remove the change in `VERSION.m4`, as it is not necessary and 
prevents the patch from applying cleanly on top of ipa-4-5.

Also please add the ticket link to commit messages.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/688#issuecomment-297025571
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#688][comment] Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

2017-04-25 Thread HonzaCholasta
  URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user 
searches

HonzaCholasta commented:
"""
Thanks!
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/688#issuecomment-297024230
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#688][comment] Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

2017-04-25 Thread redhatrises
  URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user 
searches

redhatrises commented:
"""
@HonzaCholasta done. https://pagure.io/freeipa/issue/6896
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/688#issuecomment-297023523
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#688][comment] Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

2017-04-25 Thread HonzaCholasta
  URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user 
searches

HonzaCholasta commented:
"""
I guess it should. Could you please file a ticket?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/688#issuecomment-296931927
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#688][comment] Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

2017-04-20 Thread redhatrises
  URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user 
searches

redhatrises commented:
"""
Should this also go into the 4.5 branch?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/688#issuecomment-295713837
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#688][comment] Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

2017-04-20 Thread redhatrises
  URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user 
searches

redhatrises commented:
"""
Bump for review
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/688#issuecomment-295713616
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#688][comment] Update get_attr_filter in LDAPSearch to handle nsaccountlock user searches

2017-04-06 Thread redhatrises
  URL: https://github.com/freeipa/freeipa/pull/688
Title: #688: Update get_attr_filter in LDAPSearch to handle nsaccountlock user 
searches

redhatrises commented:
"""
@HonzaCholasta ready for your review.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/688#issuecomment-292297176
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code