Re: [Freeipa-devel] PATCH: Improve on #2795 patches

2016-07-25 Thread Simo Sorce
On Wed, 2016-07-20 at 15:17 +0200, David Kupka wrote: > On 20/07/16 12:11, Simo Sorce wrote: > > Attached patch introduces a helper function and avoids the questionable > > replace+delete operations where possible (still employed in the > > entry_to_mods function). > > Compiles and I am about to

Re: [Freeipa-devel] PATCH: Improve on #2795 patches

2016-07-20 Thread David Kupka
On 20/07/16 12:11, Simo Sorce wrote: Attached patch introduces a helper function and avoids the questionable replace+delete operations where possible (still employed in the entry_to_mods function). Compiles and I am about to test it, but I'd like feedback on it if anyone wants to take a look.

[Freeipa-devel] PATCH: Improve on #2795 patches

2016-07-20 Thread Simo Sorce
Attached patch introduces a helper function and avoids the questionable replace+delete operations where possible (still employed in the entry_to_mods function). Compiles and I am about to test it, but I'd like feedback on it if anyone wants to take a look. Simo.From