Re: [Freeipa-devel] admiyo-0214-1-pwpolicy-priority
On 03/17/2011 10:01 PM, Endi Sukma Dewata wrote:
On 3/17/2011 7:04 PM, Adam Young wrote:
Some issues:
1. There's a jslint warning.
2. Try creating a new password policy, then edit and change the
priority. When you click Update the priority will get updated but the
field will become read only.
https://fedorahosted.org/freeipa/ticket/1103
3. Try changing another field, then click Update. It will fail saying:
invalid 'priority': priority must be a unique (priority already by
password policy).
https://fedorahosted.org/freeipa/ticket/1104
Issue #2 and #3 will only become a problem if we have a priority field
in the details page. If we change the patch to fix only the dialog box
and leave the details page without the priority field like before we
probably could postpone these bugs into 2.1.
This is bascially the same patch as the first one, but without the JSL
messages.
From 9d80badf2ae51132b8e9fca053767c40a3cebded Mon Sep 17 00:00:00 2001
From: Adam Young ayo...@redhat.com
Date: Thu, 17 Mar 2011 19:52:52 -0400
Subject: [PATCH] pwpolicy priority
Priority is now a required field in order to add a new password policy. Thus, not having the field present means we cannot create one.
https://fedorahosted.org/freeipa/ticket/1102
---
install/ui/policy.js |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/install/ui/policy.js b/install/ui/policy.js
index 8c954288350d1facf19c52eed92cee5ccb73ae54..bbbf58049ff0fadcf823e800152fc00cbf055e8b 100644
--- a/install/ui/policy.js
+++ b/install/ui/policy.js
@@ -621,7 +621,9 @@ IPA.entity_factories.pwpolicy = function() {
title: IPA.messages.objects.pwpolicy.add,
entity_name:'pwpolicy'
}).
-field(IPA.text_widget({name: 'cn', undo: false};
+field(IPA.text_widget({name: 'cn', undo: false})).
+field(IPA.text_widget({name: 'cospriority',
+ undo: false};
that.facet(
IPA.details_facet({name:'details'}).
@@ -635,7 +637,6 @@ IPA.entity_factories.pwpolicy = function() {
input({name:'krbpwdhistorylength'}).
input({name:'krbpwdmindiffchars'}).
input({name:'krbpwdminlength'})));
-
that.create_association_facets();
that.entity_init();
--
1.7.4
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] admiyo-0214-1-pwpolicy-priority
On 3/18/2011 8:57 AM, Adam Young wrote: On 03/17/2011 10:01 PM, Endi Sukma Dewata wrote: On 3/17/2011 7:04 PM, Adam Young wrote: Some issues: 1. There's a jslint warning. 2. Try creating a new password policy, then edit and change the priority. When you click Update the priority will get updated but the field will become read only. https://fedorahosted.org/freeipa/ticket/1103 3. Try changing another field, then click Update. It will fail saying: invalid 'priority': priority must be a unique (priority already by password policy). https://fedorahosted.org/freeipa/ticket/1104 Issue #2 and #3 will only become a problem if we have a priority field in the details page. If we change the patch to fix only the dialog box and leave the details page without the priority field like before we probably could postpone these bugs into 2.1. This is bascially the same patch as the first one, but without the JSL messages. ACK. The patch fixes ticket #1102 (adder dialog). We still need to add the priority field into the details page (will open a new ticket), but that can be done in 2.1 after fixing issue #2 and #3 above. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] admiyo-0214-1-pwpolicy-priority
On 03/18/2011 10:43 AM, Endi Sukma Dewata wrote: On 3/18/2011 8:57 AM, Adam Young wrote: On 03/17/2011 10:01 PM, Endi Sukma Dewata wrote: On 3/17/2011 7:04 PM, Adam Young wrote: Some issues: 1. There's a jslint warning. 2. Try creating a new password policy, then edit and change the priority. When you click Update the priority will get updated but the field will become read only. https://fedorahosted.org/freeipa/ticket/1103 3. Try changing another field, then click Update. It will fail saying: invalid 'priority': priority must be a unique (priority already by password policy). https://fedorahosted.org/freeipa/ticket/1104 Issue #2 and #3 will only become a problem if we have a priority field in the details page. If we change the patch to fix only the dialog box and leave the details page without the priority field like before we probably could postpone these bugs into 2.1. This is bascially the same patch as the first one, but without the JSL messages. ACK. The patch fixes ticket #1102 (adder dialog). We still need to add the priority field into the details page (will open a new ticket), but that can be done in 2.1 after fixing issue #2 and #3 above. Pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] admiyo-0214-1-pwpolicy-priority
From d8c6d615a87a9f8d06260ad06d4caec6ddd55526 Mon Sep 17 00:00:00 2001
From: Adam Young ayo...@redhat.com
Date: Thu, 17 Mar 2011 19:52:52 -0400
Subject: [PATCH] pwpolicy priority
Priority is now a required field in order to add a new password policy. Thus, not having the field present means we cannot create one.
https://fedorahosted.org/freeipa/ticket/1102
---
install/ui/policy.js |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/install/ui/policy.js b/install/ui/policy.js
index 8c954288350d1facf19c52eed92cee5ccb73ae54..a3345fe89fcf2dce0d2661cec8b520614883d12a 100644
--- a/install/ui/policy.js
+++ b/install/ui/policy.js
@@ -621,7 +621,9 @@ IPA.entity_factories.pwpolicy = function() {
title: IPA.messages.objects.pwpolicy.add,
entity_name:'pwpolicy'
}).
-field(IPA.text_widget({name: 'cn', undo: false};
+field(IPA.text_widget({name: 'cn', undo: false})).
+field(IPA.text_widget({name: 'cospriority', undo: false}))
+));
that.facet(
IPA.details_facet({name:'details'}).
@@ -634,8 +636,8 @@ IPA.entity_factories.pwpolicy = function() {
input({name:'krbminpwdlife'}).
input({name:'krbpwdhistorylength'}).
input({name:'krbpwdmindiffchars'}).
-input({name:'krbpwdminlength'})));
-
+input({name:'krbpwdminlength'}).
+input({name:'cospriority'})));
that.create_association_facets();
that.entity_init();
--
1.7.4
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] admiyo-0214-1-pwpolicy-priority
On 3/17/2011 7:04 PM, Adam Young wrote: Some issues: 1. There's a jslint warning. 2. Try creating a new password policy, then edit and change the priority. When you click Update the priority will get updated but the field will become read only. https://fedorahosted.org/freeipa/ticket/1103 3. Try changing another field, then click Update. It will fail saying: invalid 'priority': priority must be a unique (priority already by password policy). https://fedorahosted.org/freeipa/ticket/1104 Issue #2 and #3 will only become a problem if we have a priority field in the details page. If we change the patch to fix only the dialog box and leave the details page without the priority field like before we probably could postpone these bugs into 2.1. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
