Re: [Freeipa-devel] [PATCH] 030 Extending facet's mechanism of gathering changes

2011-11-07 Thread Petr Vobornik
On 11/04/2011 06:22 PM, Endi Sukma Dewata wrote: Rebased, ACK, and pushed to master. Some comments below. On 11/4/2011 7:21 AM, Petr Vobornik wrote: Perhaps the save_as_update_info() later can be merged with get_update_info() too because both are essentially generating update_info for dirty

Re: [Freeipa-devel] [PATCH] 030 Extending facet's mechanism of gathering changes

2011-11-04 Thread Endi Sukma Dewata
Rebased, ACK, and pushed to master. Some comments below. On 11/4/2011 7:21 AM, Petr Vobornik wrote: I'm considering command builder more as an utility class, than proper builder. If it would gather more functionality it would be better to changed it that way. I think in general a utility

Re: [Freeipa-devel] [PATCH] 030 Extending facet's mechanism of gathering changes

2011-11-03 Thread Endi Sukma Dewata
On 11/3/2011 7:35 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/2041 I'm not sure if update_info and other new classes should be in details.js. It's probably ok now, but in the future we might want to move them somewhere else. How about creating command.js and move all