Re: [Freeipa-devel] [PATCH] fix API.txt

2011-01-21 Thread Simo Sorce 
On Fri, 21 Jan 2011 15:14:52 -0500
Rob Crittenden rcrit...@redhat.com wrote:

 A couple of recent patches missed changes to API.txt. I pushed the 
 attached under the 1-liner rule.
 
 rob

This begs the question: how were they tested?
why both the submitter and the reviewer didn't see the build failing ?

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] fix API.txt

2011-01-21 Thread Jakub Hrozek 

On 01/21/2011 09:14 PM, Rob Crittenden wrote:

+option: Flag('del_all', autofill=True, default=False, label=Gettext('Delete 
all associated records', domain='ipa', localedir=None))


I think you accidentally generated API.txt while still having my Nacked 
DNS patch in tree.


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] fix API.txt

2011-01-21 Thread Jakub Hrozek 

On 01/21/2011 09:48 PM, Simo Sorce wrote:

On Fri, 21 Jan 2011 15:14:52 -0500
Rob Crittendenrcrit...@redhat.com  wrote:


A couple of recent patches missed changes to API.txt. I pushed the
attached under the 1-liner rule.

rob


This begs the question: how were they tested?
why both the submitter and the reviewer didn't see the build failing ?

Simo.



This is weird - my recent DNS plugin patch should have broken the API 
(it adds a new parameter --del-all) but I'm able to run make rpms just 
fine even without Rob's API additions. Also running ./makeapi --validate 
is OK.


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel