Re: [Freeipa-devel] [PATCH 0039] ipa-kdb: common function to get key encodings/salt types

2015-06-29 Thread Martin Basti

On 15/06/15 18:38, Martin Babinsky wrote:

On 05/28/2015 02:55 PM, Simo Sorce wrote:

On Thu, 2015-05-28 at 14:43 +0200, Martin Babinsky wrote:

A small improvement upon simo's fix for
https://fedorahosted.org/freeipa/ticket/4914

--
Martin^3 Babinsky


LGTM.

Simo.



Anyone else to review this patch? It also incidentally fixes a 
recently reported resource leak.



ACK

--
Martin Basti

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0039] ipa-kdb: common function to get key encodings/salt types

2015-06-29 Thread Petr Vobornik

On 06/29/2015 04:20 PM, Martin Basti wrote:

On 15/06/15 18:38, Martin Babinsky wrote:

On 05/28/2015 02:55 PM, Simo Sorce wrote:

On Thu, 2015-05-28 at 14:43 +0200, Martin Babinsky wrote:

A small improvement upon simo's fix for
https://fedorahosted.org/freeipa/ticket/4914

--
Martin^3 Babinsky


LGTM.

Simo.



Anyone else to review this patch? It also incidentally fixes a
recently reported resource leak.


ACK



Pushed to master: 4d7b630992da3d0c646b27268a85e6e8c30eebfe
--
Petr Vobornik

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0039] ipa-kdb: common function to get key encodings/salt types

2015-06-15 Thread Martin Babinsky

On 05/28/2015 02:55 PM, Simo Sorce wrote:

On Thu, 2015-05-28 at 14:43 +0200, Martin Babinsky wrote:

A small improvement upon simo's fix for
https://fedorahosted.org/freeipa/ticket/4914

--
Martin^3 Babinsky


LGTM.

Simo.



Anyone else to review this patch? It also incidentally fixes a recently 
reported resource leak.


--
Martin^3 Babinsky

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0039] ipa-kdb: common function to get key encodings/salt types

2015-05-28 Thread Simo Sorce
On Thu, 2015-05-28 at 14:43 +0200, Martin Babinsky wrote:
 A small improvement upon simo's fix for 
 https://fedorahosted.org/freeipa/ticket/4914
 
 --
 Martin^3 Babinsky

LGTM.

Simo.

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code