Re: [Freeipa-devel] [PATCH 0079] Change shebang to absolute path in ipa-client-automount
On Wednesday 24 of July 2013 13:06:19 Martin Kosek wrote: On 07/24/2013 12:39 PM, Tomas Babej wrote: Hi, this fixes the https://fedorahosted.org/freeipa/ticket/3811 Tomas Shouldn't we also add '-E' parameter like we do with in other install tools' shebang? Martin I added the flag. Please note that there is inconsistency in usage of the user-defined Python variables. About half of the scripts use the -E parameter. Even if we restrict ourselves to the 'install' tools, there are exceptions, like ipa-adtrust-install. TomasFrom 85b40faab00523bdde51729f0be8a1842279fa4d Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Tue, 23 Jul 2013 17:11:59 +0200 Subject: [PATCH] Change shebang to absolute path in ipa-client-automount https://fedorahosted.org/freeipa/ticket/3811 --- ipa-client/ipa-install/ipa-client-automount | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipa-client/ipa-install/ipa-client-automount b/ipa-client/ipa-install/ipa-client-automount index 346b474fef12ad814eedae5cc98380709eac38ff..2ce31dcb9605941fa8734caad7ed5ba9b5ce1e01 100755 --- a/ipa-client/ipa-install/ipa-client-automount +++ b/ipa-client/ipa-install/ipa-client-automount @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/python -E # # Authors: # Rob Crittenden rcrit...@redhat.com -- 1.8.3.1 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0079] Change shebang to absolute path in ipa-client-automount
On 07/25/2013 03:24 PM, Tomas Babej wrote: On Wednesday 24 of July 2013 13:06:19 Martin Kosek wrote: On 07/24/2013 12:39 PM, Tomas Babej wrote: Hi, this fixes the https://fedorahosted.org/freeipa/ticket/3811 Tomas Shouldn't we also add '-E' parameter like we do with in other install tools' shebang? Martin I added the flag. Please note that there is inconsistency in usage of the user-defined Python variables. About half of the scripts use the -E parameter. Even if we restrict ourselves to the 'install' tools, there are exceptions, like ipa-adtrust-install. Right, we fill fix those too if the need arises. Tomas ACK. Pushed to master, ipa-3-2. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0079] Change shebang to absolute path in ipa-client-automount
On Wed, Jul 24, 2013 at 12:39:07PM +0200, Tomas Babej wrote: Hi, this fixes the https://fedorahosted.org/freeipa/ticket/3811 Tomas From ed9014c9db13247dbf062af58f21ea583c476300 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Tue, 23 Jul 2013 17:11:59 +0200 Subject: [PATCH] Change shebang to absolute path in ipa-client-automount https://fedorahosted.org/freeipa/ticket/3811 --- ipa-client/ipa-install/ipa-client-automount | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipa-client/ipa-install/ipa-client-automount b/ipa-client/ipa-install/ipa-client-automount index 346b474fef12ad814eedae5cc98380709eac38ff..8328976adb4d8949bdd400ff9d764b31dd85e5c3 100755 --- a/ipa-client/ipa-install/ipa-client-automount +++ b/ipa-client/ipa-install/ipa-client-automount Running git grep shows install/tools/ipa-compliance:#!/usr/bin/env python -- shouldn't it be changed as well? -- Jan Pazdziora | adelton at #ipa*, #brno Principal Software Engineer, Identity Management Engineering, Red Hat ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0079] Change shebang to absolute path in ipa-client-automount
On 07/24/2013 12:43 PM, Jan Pazdziora wrote: On Wed, Jul 24, 2013 at 12:39:07PM +0200, Tomas Babej wrote: Hi, this fixes the https://fedorahosted.org/freeipa/ticket/3811 Tomas From ed9014c9db13247dbf062af58f21ea583c476300 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Tue, 23 Jul 2013 17:11:59 +0200 Subject: [PATCH] Change shebang to absolute path in ipa-client-automount https://fedorahosted.org/freeipa/ticket/3811 --- ipa-client/ipa-install/ipa-client-automount | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipa-client/ipa-install/ipa-client-automount b/ipa-client/ipa-install/ipa-client-automount index 346b474fef12ad814eedae5cc98380709eac38ff..8328976adb4d8949bdd400ff9d764b31dd85e5c3 100755 --- a/ipa-client/ipa-install/ipa-client-automount +++ b/ipa-client/ipa-install/ipa-client-automount Running git grep shows install/tools/ipa-compliance:#!/usr/bin/env python -- shouldn't it be changed as well? That tool was removed recently. Update your repo :) -- Petr³ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0079] Change shebang to absolute path in ipa-client-automount
On Wednesday 24 of July 2013 12:43:49 Jan Pazdziora wrote: On Wed, Jul 24, 2013 at 12:39:07PM +0200, Tomas Babej wrote: Hi, this fixes the https://fedorahosted.org/freeipa/ticket/3811 Tomas From ed9014c9db13247dbf062af58f21ea583c476300 Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com Date: Tue, 23 Jul 2013 17:11:59 +0200 Subject: [PATCH] Change shebang to absolute path in ipa-client-automount https://fedorahosted.org/freeipa/ticket/3811 --- ipa-client/ipa-install/ipa-client-automount | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipa-client/ipa-install/ipa-client-automount b/ipa-client/ipa-install/ipa-client-automount index 346b474fef12ad814eedae5cc98380709eac38ff..8328976adb4d8949bdd400ff9d764b31dd85e5c3 100755 --- a/ipa-client/ipa-install/ipa-client-automount +++ b/ipa-client/ipa-install/ipa-client-automount Running git grep shows install/tools/ipa-compliance:#!/usr/bin/env python -- shouldn't it be changed as well? It seems that you don't have updated repository. [tbabej@thinkpad7 freeipa]$ git grep /usr/bin/env ipa-client/ipa-install/ipa-client-automount:#!/usr/bin/env python The ipa-compliance script has been removed recently. It is no longer in either master or ipa-3-2 branch. See Martin's commit 77ae4da70632e17b6be09e9ad71fc353b3bad96e. Tomas ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0079] Change shebang to absolute path in ipa-client-automount
On 07/24/2013 12:39 PM, Tomas Babej wrote: Hi, this fixes the https://fedorahosted.org/freeipa/ticket/3811 Tomas Shouldn't we also add '-E' parameter like we do with in other install tools' shebang? Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0079] Change shebang to absolute path in ipa-client-automount
On Wed, Jul 24, 2013 at 12:52:31PM +0200, Petr Viktorin wrote: That tool was removed recently. Update your repo :) Ah, I had some uncommitted change so git pull did not do what I meant it to do (and I ignored the warning it gave me). Sorry about the noise. -- Jan Pazdziora | adelton at #ipa*, #brno Principal Software Engineer, Identity Management Engineering, Red Hat ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
