Re: [Freeipa-devel] [PATCH 0298-0302] Implement handling of inactive master zones
On 22.9.2014 15:10, Tomas Hozza wrote: On 09/19/2014 03:46 PM, Petr Spacek wrote: Hello, This patch set fixes https://fedorahosted.org/bind-dyndb-ldap/ticket/127 https://bugzilla.redhat.com/show_bug.cgi?id=1138317 Please review it ASAP, it targets IPA 4.1/Fedora 21. Tomas and Martin, please communicate who is going to review what:-) Thank you for your time! The code seems to be fine. ACK. Thank you for review! I'm branching v5 at this point (before the push). In other words v5 branch will not contain this patch set and master branch will contain the patch set. Pushed to master (to-be-v6): 23f2ddb317ab46419ea83725f458caae1b432fb5 27a911cae9de911938d90c94c61cecd494136fc1 3dd95594e664b7b59a9f8c1d15cb1280eebeb3e7 169f5e5f2a551253bc489edf109eab71a8331c3f 5ef943a39cfdfbadeb2a41cc3efd707caeca36bd -- Petr^2 Spacek ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0298-0302] Implement handling of inactive master zones
On 19/09/14 15:46, Petr Spacek wrote: Hello, This patch set fixes https://fedorahosted.org/bind-dyndb-ldap/ticket/127 https://bugzilla.redhat.com/show_bug.cgi?id=1138317 Please review it ASAP, it targets IPA 4.1/Fedora 21. Tomas and Martin, please communicate who is going to review what :-) Thank you for your time! functional ACK, but wait for Tomas' ACK as well. my tests: * disable zone * enable zone * add record to disabled zone * delete record from disabled zone * add record to enabled zone * delete record from enabled zone * disable DNSSEC, enabled zone * enable DNSSEC, enabled zone * disable DNSSEC, disabled zone * enable DNSSEC, disabled zone * add disabled zone * delete disabled zone * add disabled zone with dnssec * delete disabled zone with dnssec * add zone * delete zone * disable zone without valid NS record * enable zone without valid NS record * Enable zone, Enable DNSSEC, Disable DNSSEC, disable zone, Enable DNSSEC in Disabled zone, Enable zone * freeIPA DNS tests * some random tests -- Martin Basti ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0298-0302] Implement handling of inactive master zones
On 09/22/2014 02:01 PM, Martin Basti wrote: On 19/09/14 15:46, Petr Spacek wrote: Hello, This patch set fixes https://fedorahosted.org/bind-dyndb-ldap/ticket/127 https://bugzilla.redhat.com/show_bug.cgi?id=1138317 Please review it ASAP, it targets IPA 4.1/Fedora 21. Tomas and Martin, please communicate who is going to review what :-) Thank you for your time! functional ACK, but wait for Tomas' ACK as well. my tests: * disable zone * enable zone * add record to disabled zone * delete record from disabled zone * add record to enabled zone * delete record from enabled zone * disable DNSSEC, enabled zone * enable DNSSEC, enabled zone * disable DNSSEC, disabled zone * enable DNSSEC, disabled zone * add disabled zone * delete disabled zone * add disabled zone with dnssec * delete disabled zone with dnssec * add zone * delete zone * disable zone without valid NS record * enable zone without valid NS record * Enable zone, Enable DNSSEC, Disable DNSSEC, disable zone, Enable DNSSEC in Disabled zone, Enable zone * freeIPA DNS tests * some random tests Could you ideally send a patch with these? Integration tests aren't very hard to write -- see ipatests/test_integration/test_service_permissions.py -- Petr³ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 0298-0302] Implement handling of inactive master zones
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/19/2014 03:46 PM, Petr Spacek wrote: Hello, This patch set fixes https://fedorahosted.org/bind-dyndb-ldap/ticket/127 https://bugzilla.redhat.com/show_bug.cgi?id=1138317 Please review it ASAP, it targets IPA 4.1/Fedora 21. Tomas and Martin, please communicate who is going to review what :-) Thank you for your time! The code seems to be fine. ACK. Regards, - -- Tomas Hozza Software Engineer - EMEA ENG Developer Experience PGP: 1D9F3C2D Red Hat Inc. http://cz.redhat.com -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQEcBAEBAgAGBQJUIB/eAAoJEMWIetUdnzwtTdUH/iJX0CY5c5inZVXqOv+5Tt+V pcAwe/vlh6/3qJbZaA2sUc+i3M9dNhM2v2TPAugzfF1ZDGKwCjn8T+7XROsit/17 67XfZDhw/3Q4wsmsxR24YUXG5Q7TlX9NdlvFOUtsbeGfKdQKxsZB+cResv5dz6O8 p/gyNvvKJOE8nbJ33yE5A2tUocdgJHDcgsgCKWiYP3pOleJuKHYK0uyQZmAxxOJ+ q09KTBoEUg7fOI+ekReCzUysdDzOJSc+6zpJQ8LbK/g8Fa5Pg/+q9zBKVN5xng9l 4TCvVzz8kkVp8ArNAl4nE5eLVaYksT4xUWmf2RMzbtxOzJ+gmrYmce4mHRR6zcM= =ViAQ -END PGP SIGNATURE- ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
