Re: [Freeipa-devel] [PATCH 3] Adding CLI Enable/Disable Operations for SudoRules

2010-12-08 Thread JR Aquino
This patch address's the CLI Operations needed to toggle enable / disable
on the SudoRules.

I will need to work with Nalin to adjust the Compat Plugin so that
'disabled' rules are ignored for Compat translation.

On 12/8/10 7:39 AM, Endi Sukma Dewata edew...@redhat.com wrote:

On 12/7/2010 6:25 PM, JR Aquino wrote:
 This patch Addresses items:
   1. The UI needs a rule status with values active  inactive. The CLI
doesn't have this attribute. HBAC has ipaenabledflag attribute which can
be managed using hbac-enable/disable operations.
   2. The UI needs a user category for the Who section. The CLI
doesn't have this attribute. HBAC has usercategory attribute which can
be managed using hbac-add/mod operations.
   3. The UI needs a host category for the Access this host section.
The CLI doesn't have this attribute. HBAC has hostcategory attribute
which can be managed using hbac-add/mod operations.

Hi JR, thanks for the patch. I have tested it, items #2 and #3 work.
However, for item #1 it's still missing the sudorule-enable/disable
operations which are needed to set the ipaenabledflag.

This patch itself is fine, so I pushed it to master. You could submit
the enable/disable operations in a separate patch. Thanks!

-- 
Endi S. Dewata



freeipa-jraquino-0003-Enable-Disable-SudoRule.patch
Description: freeipa-jraquino-0003-Enable-Disable-SudoRule.patch
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 3] Adding CLI Enable/Disable Operations for SudoRules

2010-12-08 Thread Endi Sukma Dewata

On 12/8/2010 10:03 AM, JR Aquino wrote:

This patch address's the CLI Operations needed to toggle enable / disable
on the SudoRules.


Thanks for such a quick response!
ACK and pushed to master.

--
Endi S. Dewata

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel