Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-03-21 Thread Petr Viktorin
On 03/20/2012 10:08 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/16/2012 12:55 PM, Petr Viktorin wrote: On 03/15/2012 08:55 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2227 (Unable to add certain sudo commands to groups). What an interesting

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-03-20 Thread Petr Viktorin
On 03/16/2012 12:55 PM, Petr Viktorin wrote: On 03/15/2012 08:55 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2227 (Unable to add certain sudo commands to groups). What an interesting bug to get :) One problem with our CSV splitting is that it's not

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-03-16 Thread Petr Viktorin
On 03/15/2012 08:55 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2227 (Unable to add certain sudo commands to groups). What an interesting bug to get :) One problem with our CSV splitting is that it's not idempotent (baskslashes are eaten when there

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-03-15 Thread Rob Crittenden
Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2227 (Unable to add certain sudo commands to groups). What an interesting bug to get :) One problem with our CSV splitting is that it's not idempotent (baskslashes are eaten when there are escaped commas), but when we forward a call

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once (updated)

2012-03-02 Thread Petr Viktorin
On 02/29/2012 07:13 PM, Petr Vobornik wrote: On 02/27/2012 02:01 PM, Petr Viktorin wrote: It seems I didn't communicate the problem and my solution clearly enough, so let me try again. (Also, I learned from the discussions!) Currently, both the client and the server parse CSV options. The

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once (updated)

2012-02-29 Thread Petr Vobornik
On 02/27/2012 02:01 PM, Petr Viktorin wrote: It seems I didn't communicate the problem and my solution clearly enough, so let me try again. (Also, I learned from the discussions!) Currently, both the client and the server parse CSV options. The client does *not* re-encode the CSV before

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-24 Thread Petr Viktorin
On 02/23/2012 04:08 PM, Jan Cholasta wrote: Can't you just re-escape the values before forwarding the call? That would be a fairly straightforward fix and it would remove the need for all the _forwarded_call hackery. All right, I'll do that once we decide on how to escape. Self-NACK for the

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-24 Thread Petr Viktorin
On 02/24/2012 11:09 AM, Petr Viktorin wrote: On 02/23/2012 04:08 PM, Jan Cholasta wrote: Can't you just re-escape the values before forwarding the call? That would be a fairly straightforward fix and it would remove the need for all the _forwarded_call hackery. All right, I'll do that

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-24 Thread Martin Kosek
On Fri, 2012-02-24 at 11:09 +0100, Petr Viktorin wrote: ... You need four backslashes for a literal backslash, three to escape a comma. I think 2.1 clients are already broken, and the backwards incompatibility would only affect workarounds. Yes, but CSV values without escaping works. And

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-24 Thread Petr Vobornik
On 02/24/2012 11:09 AM, Petr Viktorin wrote: As far as I can see the Web UI is tied to the server version, so changing the JSON communication shouldn't be a problem? Anyway, since the JSON code for this is scattered across the codebase, we need to introduce a common JS function first, and only

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-24 Thread Petr Viktorin
On 02/24/2012 12:09 PM, Martin Kosek wrote: On Fri, 2012-02-24 at 11:09 +0100, Petr Viktorin wrote: ... You need four backslashes for a literal backslash, three to escape a comma. I think 2.1 clients are already broken, and the backwards incompatibility would only affect workarounds. Yes,

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-24 Thread Rob Crittenden
Petr Viktorin wrote: On 02/24/2012 12:09 PM, Martin Kosek wrote: On Fri, 2012-02-24 at 11:09 +0100, Petr Viktorin wrote: ... You need four backslashes for a literal backslash, three to escape a comma. I think 2.1 clients are already broken, and the backwards incompatibility would only affect

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-24 Thread Petr Viktorin
On 02/24/2012 03:08 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/24/2012 12:09 PM, Martin Kosek wrote: On Fri, 2012-02-24 at 11:09 +0100, Petr Viktorin wrote: ... Old clients *already send* plain arrays; but the server currently errorneously parses each part again. Maybe a better

[Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-23 Thread Petr Viktorin
https://fedorahosted.org/freeipa/ticket/2227 (Unable to add certain sudo commands to groups). What an interesting bug to get :) One problem with our CSV splitting is that it's not idempotent (baskslashes are eaten when there are escaped commas), but when we forward a call it gets done on

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-23 Thread Jan Cholasta
On 23.2.2012 15:29, Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2227 (Unable to add certain sudo commands to groups). What an interesting bug to get :) One problem with our CSV splitting is that it's not idempotent (baskslashes are eaten when there are escaped commas), but

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-02-23 Thread Martin Kosek
On Thu, 2012-02-23 at 16:08 +0100, Jan Cholasta wrote: On 23.2.2012 15:29, Petr Viktorin wrote: ... If we only keep one of those, the fix for #2227 should be quite easy. If not (backwards compatibility), we need to document this properly, test all the corner cases, and fix the UI to handle