Re: [Freeipa-devel] [PATCH] 0130 -- create missing idranges in trust-fetch-domains

2014-01-15 Thread Alexander Bokovoy
On Tue, 14 Jan 2014, Sumit Bose wrote: On Tue, Jan 14, 2014 at 04:03:06PM +0200, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Martin Kosek wrote: On 01/14/2014 01:27 PM, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Martin Kosek wrote: On 01/14/2014 01:02 PM, Alexander Bokovoy wrote: Hi,

Re: [Freeipa-devel] [PATCH] 0130 -- create missing idranges in trust-fetch-domains

2014-01-15 Thread Sumit Bose
On Wed, Jan 15, 2014 at 02:14:08PM +0200, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Sumit Bose wrote: On Tue, Jan 14, 2014 at 04:03:06PM +0200, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Martin Kosek wrote: On 01/14/2014 01:27 PM, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Martin

Re: [Freeipa-devel] [PATCH] 0130 -- create missing idranges in trust-fetch-domains

2014-01-15 Thread Martin Kosek
On 01/15/2014 02:54 PM, Sumit Bose wrote: On Wed, Jan 15, 2014 at 02:14:08PM +0200, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Sumit Bose wrote: On Tue, Jan 14, 2014 at 04:03:06PM +0200, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Martin Kosek wrote: On 01/14/2014 01:27 PM, Alexander

Re: [Freeipa-devel] [PATCH] 0130 -- create missing idranges in trust-fetch-domains

2014-01-15 Thread Alexander Bokovoy
On Wed, 15 Jan 2014, Martin Kosek wrote: On 01/15/2014 02:54 PM, Sumit Bose wrote: On Wed, Jan 15, 2014 at 02:14:08PM +0200, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Sumit Bose wrote: On Tue, Jan 14, 2014 at 04:03:06PM +0200, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Martin Kosek

Re: [Freeipa-devel] [PATCH] 0130 -- create missing idranges in trust-fetch-domains

2014-01-15 Thread Martin Kosek
On 01/15/2014 03:10 PM, Alexander Bokovoy wrote: On Wed, 15 Jan 2014, Martin Kosek wrote: On 01/15/2014 02:54 PM, Sumit Bose wrote: On Wed, Jan 15, 2014 at 02:14:08PM +0200, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Sumit Bose wrote: On Tue, Jan 14, 2014 at 04:03:06PM +0200, Alexander

Re: [Freeipa-devel] [PATCH] 0130 -- create missing idranges in trust-fetch-domains

2014-01-15 Thread Alexander Bokovoy
On Wed, 15 Jan 2014, Martin Kosek wrote: On 01/15/2014 03:10 PM, Alexander Bokovoy wrote: On Wed, 15 Jan 2014, Martin Kosek wrote: On 01/15/2014 02:54 PM, Sumit Bose wrote: On Wed, Jan 15, 2014 at 02:14:08PM +0200, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Sumit Bose wrote: On Tue, Jan

Re: [Freeipa-devel] [PATCH] 0130 -- create missing idranges in trust-fetch-domains

2014-01-15 Thread Alexander Bokovoy
On Wed, 15 Jan 2014, Alexander Bokovoy wrote: new version attached. Thanks. I can give functional ACK. All my checks are working as expected, idranges are added if needed and 'ipa: ERROR: no such entry' is displayed if the forest name is invalid. Btw I think you can add

Re: [Freeipa-devel] [PATCH] 0130 -- create missing idranges in trust-fetch-domains

2014-01-15 Thread Martin Kosek
On 01/15/2014 03:43 PM, Alexander Bokovoy wrote: On Wed, 15 Jan 2014, Alexander Bokovoy wrote: new version attached. Thanks. I can give functional ACK. All my checks are working as expected, idranges are added if needed and 'ipa: ERROR: no such entry' is displayed if the forest name is

[Freeipa-devel] [PATCH] 0130 -- create missing idranges in trust-fetch-domains

2014-01-14 Thread Alexander Bokovoy
Hi, attached patch implements missing idranges when new child domains discovered through 'ipa trust-fetch-domains'. This functionality existed in 'ipa trust-add' but was not exposed in the 'ipa trust-fetch-domains'. Additionally, error message is shown in case trust name is incorrect.

Re: [Freeipa-devel] [PATCH] 0130 -- create missing idranges in trust-fetch-domains

2014-01-14 Thread Martin Kosek
On 01/14/2014 01:02 PM, Alexander Bokovoy wrote: Hi, attached patch implements missing idranges when new child domains discovered through 'ipa trust-fetch-domains'. This functionality existed in 'ipa trust-add' but was not exposed in the 'ipa trust-fetch-domains'. Additionally, error

Re: [Freeipa-devel] [PATCH] 0130 -- create missing idranges in trust-fetch-domains

2014-01-14 Thread Alexander Bokovoy
On Tue, 14 Jan 2014, Martin Kosek wrote: On 01/14/2014 01:02 PM, Alexander Bokovoy wrote: Hi, attached patch implements missing idranges when new child domains discovered through 'ipa trust-fetch-domains'. This functionality existed in 'ipa trust-add' but was not exposed in the 'ipa

Re: [Freeipa-devel] [PATCH] 0130 -- create missing idranges in trust-fetch-domains

2014-01-14 Thread Martin Kosek
On 01/14/2014 01:27 PM, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Martin Kosek wrote: On 01/14/2014 01:02 PM, Alexander Bokovoy wrote: Hi, attached patch implements missing idranges when new child domains discovered through 'ipa trust-fetch-domains'. This functionality existed in 'ipa

Re: [Freeipa-devel] [PATCH] 0130 -- create missing idranges in trust-fetch-domains

2014-01-14 Thread Alexander Bokovoy
On Tue, 14 Jan 2014, Martin Kosek wrote: On 01/14/2014 01:27 PM, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Martin Kosek wrote: On 01/14/2014 01:02 PM, Alexander Bokovoy wrote: Hi, attached patch implements missing idranges when new child domains discovered through 'ipa

Re: [Freeipa-devel] [PATCH] 0130 -- create missing idranges in trust-fetch-domains

2014-01-14 Thread Sumit Bose
On Tue, Jan 14, 2014 at 04:03:06PM +0200, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Martin Kosek wrote: On 01/14/2014 01:27 PM, Alexander Bokovoy wrote: On Tue, 14 Jan 2014, Martin Kosek wrote: On 01/14/2014 01:02 PM, Alexander Bokovoy wrote: Hi, attached patch implements missing