Re: [Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-06-01 Thread Adam Young
https://fedorahosted.org/freeipa/ticket/204 Comments for what was fixed are in the patch. Here's what I didn't change: 4. Clicking 'Back to List' when viewing a map brings you back to list of locations. Is this still intentional? Perhaps the label should be changed to 'Back to

Re: [Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-06-01 Thread Adam Young
On 06/01/2011 07:05 PM, Endi Sukma Dewata wrote: On 6/1/2011 10:09 AM, Adam Young wrote: 11. The option values for automount map adder dialog could be simplified to direct and indirect. The values used are what is appended to the command's method. Had to leave them as is to keep that

Re: [Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-05-31 Thread Adam Young
On 05/28/2011 08:54 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel JSL lint cleanup From 7fba335cf391dab621102da43c3a1eae7cfdb74e Mon Sep 17 00:00:00 2001 From:

Re: [Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-05-31 Thread Adam Young
I thought I had posted my work for indirect maps as a different patch, but it appears not. This patch merged in delete key and indirect maps. On 05/31/2011 10:00 AM, Adam Young wrote: On 05/31/2011 09:57 AM, Adam Young wrote: On 05/28/2011 08:54 PM, Adam Young wrote:

Re: [Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-05-31 Thread Adam Young
On 05/31/2011 10:00 AM, Adam Young wrote: On 05/31/2011 09:57 AM, Adam Young wrote: On 05/28/2011 08:54 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel JSL lint

Re: [Freeipa-devel] [PATCH] 0229-automount-delete-key

2011-05-31 Thread Endi Sukma Dewata
On 5/31/2011 11:59 AM, Adam Young wrote: Some issues: 1. The labels for mount and parentmap fields in automount map are missing. 2. The mount and parentmap fields in automount map adder dialog shows undo button. This can be fixed by adding undo: false parameter. 3. The Delete button