Re: [Freeipa-devel] [PATCH] 0267-dnsrecord-mod-ui

2011-07-13 Thread Endi Sukma Dewata
On 7/12/2011 4:47 PM, Adam Young wrote: Some issues: 1. In DNS record adder dialog, the data field is required but it's not checked before submit. There is no param_info for this field, so the required flag may need to be specified explicitly in the field declaration. 2. Adding/deleting

Re: [Freeipa-devel] [PATCH] 0267-dnsrecord-mod-ui

2011-07-13 Thread Endi Sukma Dewata
On 7/13/2011 4:03 PM, Adam Young wrote: 3. I cannot try this due to issue #2, but in CLI when the last data is removed using -mod the record itself will be deleted. The record has to be re-added before it can be modified again. A user might encounter this issue if he removes all existing data,

Re: [Freeipa-devel] [PATCH] 0267-dnsrecord-mod-ui

2011-07-11 Thread Adam Young
On 07/08/2011 08:33 PM, Adam Young wrote: Please do not push this yet. Is is merely posted to get an early code review. In order for this patch to be fully functional, it needs the dnsrecord_mod patch for the server to be pushed first. Additionally, it uses many string literals that need

[Freeipa-devel] [PATCH] 0267-dnsrecord-mod-ui

2011-07-08 Thread Adam Young
Please do not push this yet. Is is merely posted to get an early code review. In order for this patch to be fully functional, it needs the dnsrecord_mod patch for the server to be pushed first. Additionally, it uses many string literals that need to be put into the messages file for