Re: [Freeipa-devel] [PATCH] 059 Use unicode parameters in the host plugin

2011-02-18 Thread Rob Crittenden
Jakub Hrozek wrote: On Thu, Feb 17, 2011 at 11:30:03AM +0100, Jan Zelený wrote: Better, thanks. I'd also like to change the code which is using this function, so the conversion doesn't take place twice. I think it's safe. The documentation on unicode() says: --- More precisely, if object is a

Re: [Freeipa-devel] [PATCH] 059 Use unicode parameters in the host plugin

2011-02-17 Thread Jakub Hrozek
On Thu, Feb 17, 2011 at 11:30:03AM +0100, Jan Zelený wrote: > Better, thanks. I'd also like to change the code which is using this function, > so the conversion doesn't take place twice. I think it's safe. The documentation on unicode() says: --- More precisely, if object is a Unicode string or

Re: [Freeipa-devel] [PATCH] 059 Use unicode parameters in the host plugin

2011-02-17 Thread Jan Zelený
Jakub Hrozek wrote: > On Thu, Feb 17, 2011 at 11:06:35AM +0100, Jan Zelený wrote: > > Jan Zelený wrote: > > > Jakub Hrozek wrote: > > > > While reviewing Rob's latest patch I found out that we didn't convert > > > > to unicode on couple of places in the host plugin. > > > > > > ack > > > > On

Re: [Freeipa-devel] [PATCH] 059 Use unicode parameters in the host plugin

2011-02-17 Thread Jakub Hrozek
On Thu, Feb 17, 2011 at 11:06:35AM +0100, Jan Zelený wrote: > Jan Zelený wrote: > > Jakub Hrozek wrote: > > > While reviewing Rob's latest patch I found out that we didn't convert to > > > unicode on couple of places in the host plugin. > > > > ack > > On a second thoughts - maybe the _get_unic

Re: [Freeipa-devel] [PATCH] 059 Use unicode parameters in the host plugin

2011-02-17 Thread Jan Zelený
Jan Zelený wrote: > Jakub Hrozek wrote: > > While reviewing Rob's latest patch I found out that we didn't convert to > > unicode on couple of places in the host plugin. > > ack On a second thoughts - maybe the _get_unicode_reverse_zone isn't necessary at all - is it possible to do this change

Re: [Freeipa-devel] [PATCH] 059 Use unicode parameters in the host plugin

2011-02-17 Thread Jan Zelený
Jakub Hrozek wrote: > While reviewing Rob's latest patch I found out that we didn't convert to > unicode on couple of places in the host plugin. ack Jan ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/fr

[Freeipa-devel] [PATCH] 059 Use unicode parameters in the host plugin

2011-02-16 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 While reviewing Rob's latest patch I found out that we didn't convert to unicode on couple of places in the host plugin. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iE