Jan Cholasta wrote:
Dne 15.11.2011 20:10, Rob Crittenden napsal(a):
Jan Cholasta wrote:
Dne 9.11.2011 11:59, Alexander Bokovoy napsal(a):
On Wed, 09 Nov 2011, Jan Cholasta wrote:
would't suffer from a facelift - currently it is messy, hard to read
code, with bits nobody ever used or uses
Dne 15.11.2011 20:10, Rob Crittenden napsal(a):
Jan Cholasta wrote:
Dne 9.11.2011 11:59, Alexander Bokovoy napsal(a):
On Wed, 09 Nov 2011, Jan Cholasta wrote:
would't suffer from a facelift - currently it is messy, hard to read
code, with bits nobody ever used or uses anymore, some of the
Dne 3.11.2011 12:43, Alexander Bokovoy napsal(a):
On Thu, 03 Nov 2011, Jan Cholasta wrote:
The problem with the API class is that it creates all the plugin
instances every time. Both mine and your patch don't change that,
they deal only with finalization, which is the easier part of the
lazy
On Wed, 09 Nov 2011, Jan Cholasta wrote:
would't suffer from a facelift - currently it is messy, hard to read
code, with bits nobody ever used or uses anymore, some of the
docstrings and comments aren't correct, etc.)
A review of API class is a good idea. However, I think it is currently
Dne 9.11.2011 11:59, Alexander Bokovoy napsal(a):
On Wed, 09 Nov 2011, Jan Cholasta wrote:
would't suffer from a facelift - currently it is messy, hard to read
code, with bits nobody ever used or uses anymore, some of the
docstrings and comments aren't correct, etc.)
A review of API class is a
On Wed, 2011-11-02 at 18:38 +0200, Alexander Bokovoy wrote:
(actual patch attached!)
On Wed, 02 Nov 2011, Alexander Bokovoy wrote:
On Wed, 02 Nov 2011, Jan Cholasta wrote:
Callable instances are a consequence of the above --
Command.__call__() does use properties that are changed due
On Thu, 03 Nov 2011, Martin Kosek wrote:
Good, this indeed addresses all my previous concerns but one :-)
$ ./makeapi
Writing API to API.txt
Traceback (most recent call last):
File ./makeapi, line 392, in module
sys.exit(main())
File ./makeapi, line 376, in main
rval |=
Dne 2.11.2011 17:38, Alexander Bokovoy napsal(a):
(actual patch attached!)
On Wed, 02 Nov 2011, Alexander Bokovoy wrote:
On Wed, 02 Nov 2011, Jan Cholasta wrote:
Callable instances are a consequence of the above --
Command.__call__() does use properties that are changed due to
finalize()
On Thu, 03 Nov 2011, Jan Cholasta wrote:
The problem with the API class is that it creates all the plugin
instances every time. Both mine and your patch don't change that,
they deal only with finalization, which is the easier part of the
lazy initialization problem. Additionally, in your patch
On Mon, 31 Oct 2011, Jan Cholasta wrote:
Dne 31.10.2011 13:19, Alexander Bokovoy napsal(a):
On Mon, 31 Oct 2011, Jan Cholasta wrote:
Added finalization for __call__ and the check for CLI. Patch attached.
ACK from my side but see below.
+def __getattribute__(self, name):
+if not
On Wed, 2011-11-02 at 12:42 +0200, Alexander Bokovoy wrote:
On Mon, 31 Oct 2011, Jan Cholasta wrote:
Dne 31.10.2011 13:19, Alexander Bokovoy napsal(a):
On Mon, 31 Oct 2011, Jan Cholasta wrote:
Added finalization for __call__ and the check for CLI. Patch attached.
ACK from my side but see
On Wed, 02 Nov 2011, Martin Kosek wrote:
Hmm, this looks impressive! It would brings us considerably faster CLI
calls.
And again, I would feel much safer if we do these optimizations only
for CLI and let server do all the initialization right on start.
Well, that could be done in
Dne 2.11.2011 11:42, Alexander Bokovoy napsal(a):
On Mon, 31 Oct 2011, Jan Cholasta wrote:
Dne 31.10.2011 13:19, Alexander Bokovoy napsal(a):
On Mon, 31 Oct 2011, Jan Cholasta wrote:
Added finalization for __call__ and the check for CLI. Patch attached.
ACK from my side but see below.
+
On Wed, 02 Nov 2011, Jan Cholasta wrote:
I see a number of problems with the patch:
* Only Command subclasses are finalized (that might be the reason
why it is so fast)
* You assume that the first operation on a plugin instance is a
call on the args/options/params namespaces, but there
Dne 2.11.2011 16:11, Alexander Bokovoy napsal(a):
On Wed, 02 Nov 2011, Jan Cholasta wrote:
I see a number of problems with the patch:
* Only Command subclasses are finalized (that might be the reason
why it is so fast)
* You assume that the first operation on a plugin instance is a
call
On Wed, 02 Nov 2011, Jan Cholasta wrote:
Callable instances are a consequence of the above --
Command.__call__() does use properties that are changed due to
finalize() being run. In fact, there are so many places in FreeIPA
where we simply expect that foo.args/params/output_params/output is
(actual patch attached!)
On Wed, 02 Nov 2011, Alexander Bokovoy wrote:
On Wed, 02 Nov 2011, Jan Cholasta wrote:
Callable instances are a consequence of the above --
Command.__call__() does use properties that are changed due to
finalize() being run. In fact, there are so many places in
Dne 26.10.2011 16:50, Jan Cholasta napsal(a):
Dne 26.10.2011 16:39, Martin Kosek napsal(a):
On Wed, 2011-10-26 at 15:52 +0200, Jan Cholasta wrote:
Dne 26.10.2011 15:41, Martin Kosek napsal(a):
On Wed, 2011-10-26 at 11:39 +0200, Jan Cholasta wrote:
Dne 25.10.2011 22:30, Rob Crittenden
On Mon, 31 Oct 2011, Jan Cholasta wrote:
Added finalization for __call__ and the check for CLI. Patch attached.
ACK from my side but see below.
+def __getattribute__(self, name):
+if not name.startswith('_Plugin__') and not
name.startswith('_ReadOnly__') and name !=
On Mon, 2011-10-31 at 14:19 +0200, Alexander Bokovoy wrote:
On Mon, 31 Oct 2011, Jan Cholasta wrote:
Added finalization for __call__ and the check for CLI. Patch attached.
ACK from my side but see below.
+def __getattribute__(self, name):
+if not name.startswith('_Plugin__')
On Mon, 31 Oct 2011, Simo Sorce wrote:
On Mon, 2011-10-31 at 14:19 +0200, Alexander Bokovoy wrote:
On Mon, 31 Oct 2011, Jan Cholasta wrote:
Added finalization for __call__ and the check for CLI. Patch attached.
ACK from my side but see below.
+def __getattribute__(self, name):
Dne 31.10.2011 13:19, Alexander Bokovoy napsal(a):
On Mon, 31 Oct 2011, Jan Cholasta wrote:
Added finalization for __call__ and the check for CLI. Patch attached.
ACK from my side but see below.
+def __getattribute__(self, name):
+if not name.startswith('_Plugin__') and not
On Wed, 2011-10-26 at 11:39 +0200, Jan Cholasta wrote:
Dne 25.10.2011 22:30, Rob Crittenden napsal(a):
Ondrej Hamada wrote:
On 10/25/2011 04:01 PM, Martin Kosek wrote:
On Tue, 2011-10-25 at 15:29 +0200, Ondrej Hamada wrote:
https://fedorahosted.org/freeipa/ticket/1336
Lazy
On Wed, 2011-10-26 at 15:52 +0200, Jan Cholasta wrote:
Dne 26.10.2011 15:41, Martin Kosek napsal(a):
On Wed, 2011-10-26 at 11:39 +0200, Jan Cholasta wrote:
Dne 25.10.2011 22:30, Rob Crittenden napsal(a):
Ondrej Hamada wrote:
On 10/25/2011 04:01 PM, Martin Kosek wrote:
On Tue, 2011-10-25
https://fedorahosted.org/freeipa/ticket/1336
Lazy initialization of ipalib plugins is used under all contexts, not
only when context = cli. Every loaded plugin is pre-finalized - a flag
is set, which means, that the plugin needs to be finalized. Then every
call of plugin's __gettattr__ checks
On Tue, 2011-10-25 at 15:29 +0200, Ondrej Hamada wrote:
https://fedorahosted.org/freeipa/ticket/1336
Lazy initialization of ipalib plugins is used under all contexts, not
only when context = cli. Every loaded plugin is pre-finalized - a flag
is set, which means, that the plugin needs to be
On 10/25/2011 04:01 PM, Martin Kosek wrote:
On Tue, 2011-10-25 at 15:29 +0200, Ondrej Hamada wrote:
https://fedorahosted.org/freeipa/ticket/1336
Lazy initialization of ipalib plugins is used under all contexts, not
only when context = cli. Every loaded plugin is pre-finalized - a flag
is set,
Ondrej Hamada wrote:
On 10/25/2011 04:01 PM, Martin Kosek wrote:
On Tue, 2011-10-25 at 15:29 +0200, Ondrej Hamada wrote:
https://fedorahosted.org/freeipa/ticket/1336
Lazy initialization of ipalib plugins is used under all contexts, not
only when context = cli. Every loaded plugin is
28 matches
Mail list logo
